Bug#121335: Please add the Toshiby keybounce fix
On Mon, Oct 28, 2002 at 01:01:43PM +0100, Michel D?nzer wrote:
>
> I doubt that very much as it happens with all kinds of keyboards on Macs
> but doesn't happen in Mac OS.
Well as I said earlier, it's not difficult to convince me.
For ADB keyboards, you just have to enable dump_adb_input in
macintosh/adb.c and recompile your kernel. If the output shows
that you do get the release from the hardware but not the kernel
then the issue is settled and we can find out what's going wrong.
If you suspect that the problem is further down in the system,
then you could also simply add printks to the relevant interrupt
handler (easy to find as they usually call adb_input) to see if
you're getting notified or not. If you don't get an interrupt,
then you won't get any release events.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Bug#121335: Please add the Toshiby keybounce fix
On Mon, Oct 28, 2002 at 01:01:43PM +0100, Michel D?nzer wrote:
>
> I doubt that very much as it happens with all kinds of keyboards on Macs
> but doesn't happen in Mac OS.
Well as I said earlier, it's not difficult to convince me.
For ADB keyboards, you just have to enable dump_adb_input in
macintosh/adb.c and recompile your kernel. If the output shows
that you do get the release from the hardware but not the kernel
then the issue is settled and we can find out what's going wrong.
If you suspect that the problem is further down in the system,
then you could also simply add printks to the relevant interrupt
handler (easy to find as they usually call adb_input) to see if
you're getting notified or not. If you don't get an interrupt,
then you won't get any release events.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#121335: Please add the Toshiby keybounce fix
On Mon, Oct 28, 2002 at 01:01:43PM +0100, Michel Dänzer wrote: > > Well I don't see anything in there that shows that this is a kernel > > bug. What it does show is that some people are seeing this on the > > console. This means that it probably is a hardware problem. > > I doubt that very much as it happens with all kinds of keyboards on Macs > but doesn't happen in Mac OS. Michel, It is a waste of your time to try and deal with Herbert Xu on this issue. I suggest you approach Ben Herrenschmidt and/or LKML and get it fixed in the upstream kernel if possible. There is, of course, always the possibility that even if the Linux kernel guys agree with you and XFree86, that Herbert will tear the patch out in Debian kernel patches, but since he doesn't package the PowerPC kernel-image packages, at least the problem will be solved for Debian's PowerMac users. Also, if Herbert does this we can always ask him to respect upstream, and package the "Xu version" separately, as he recently acknowledged was the correct thing to do with his fork of ash. -- G. Branden Robinson| One man's "magic" is another man's Debian GNU/Linux | engineering. "Supernatural" is a [EMAIL PROTECTED] | null word. http://people.debian.org/~branden/ | -- Robert Heinlein pgp0aut1pe3hh.pgp Description: PGP signature
Bug#121335: Please add the Toshiby keybounce fix
On Mon, Oct 28, 2002 at 01:01:43PM +0100, Michel Dänzer wrote: > > Well I don't see anything in there that shows that this is a kernel > > bug. What it does show is that some people are seeing this on the > > console. This means that it probably is a hardware problem. > > I doubt that very much as it happens with all kinds of keyboards on Macs > but doesn't happen in Mac OS. Michel, It is a waste of your time to try and deal with Herbert Xu on this issue. I suggest you approach Ben Herrenschmidt and/or LKML and get it fixed in the upstream kernel if possible. There is, of course, always the possibility that even if the Linux kernel guys agree with you and XFree86, that Herbert will tear the patch out in Debian kernel patches, but since he doesn't package the PowerPC kernel-image packages, at least the problem will be solved for Debian's PowerMac users. Also, if Herbert does this we can always ask him to respect upstream, and package the "Xu version" separately, as he recently acknowledged was the correct thing to do with his fork of ash. -- G. Branden Robinson| One man's "magic" is another man's Debian GNU/Linux | engineering. "Supernatural" is a [EMAIL PROTECTED] | null word. http://people.debian.org/~branden/ | -- Robert Heinlein msg04434/pgp0.pgp Description: PGP signature
Bug#121335: Please add the Toshiby keybounce fix
On Mon, 2002-10-28 at 12:50, Herbert Xu wrote: > On Mon, Oct 28, 2002 at 12:42:17PM +0100, Michel D?nzer wrote: > > > > See this thread: > > > > http://lists.debian.org/debian-powerpc/2002/debian-powerpc-200210/msg00260.html > > Well I don't see anything in there that shows that this is a kernel > bug. What it does show is that some people are seeing this on the > console. This means that it probably is a hardware problem. I doubt that very much as it happens with all kinds of keyboards on Macs but doesn't happen in Mac OS. -- Earthling Michel Dänzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast
Bug#121335: Please add the Toshiby keybounce fix
On Mon, Oct 28, 2002 at 12:42:17PM +0100, Michel D?nzer wrote:
>
> See this thread:
>
> http://lists.debian.org/debian-powerpc/2002/debian-powerpc-200210/msg00260.html
Well I don't see anything in there that shows that this is a kernel
bug. What it does show is that some people are seeing this on the
console. This means that it probably is a hardware problem.
Unfortunately this is not something that can be worked around in
software since it is easy to filter out spurious events, but it
is impossible to manufacture missing events.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Bug#121335: Please add the Toshiby keybounce fix
On Mon, 2002-10-28 at 08:36, Herbert Xu wrote: > On Mon, Oct 28, 2002 at 03:00:40AM +0100, Michel D?nzer wrote: > > > > Herbert, I think I've seen a kernel patch for #121335, and #156563 has > > definitely been nailed down to the kernel input layer. > > If you mean the patch in the bug log, then it's not going to be included > since it just filters out the duplicate events which is something that > should be done in the X server. AFAIK XFree86 upstream disagrees, though I think the best would be to do it in both, so it's fixed for the user if either has the fix. > As to #156563, please show me the evidence that it is a kernel bug since > it's not in the bug logs. See this thread: http://lists.debian.org/debian-powerpc/2002/debian-powerpc-200210/msg00260.html -- Earthling Michel Dänzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast
Bug#121335: Please add the Toshiby keybounce fix
On Mon, 2002-10-28 at 12:50, Herbert Xu wrote: > On Mon, Oct 28, 2002 at 12:42:17PM +0100, Michel D?nzer wrote: > > > > See this thread: > > > > http://lists.debian.org/debian-powerpc/2002/debian-powerpc-200210/msg00260.html > > Well I don't see anything in there that shows that this is a kernel > bug. What it does show is that some people are seeing this on the > console. This means that it probably is a hardware problem. I doubt that very much as it happens with all kinds of keyboards on Macs but doesn't happen in Mac OS. -- Earthling Michel Dänzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#121335: Please add the Toshiby keybounce fix
On Mon, Oct 28, 2002 at 12:42:17PM +0100, Michel D?nzer wrote:
>
> See this thread:
>
> http://lists.debian.org/debian-powerpc/2002/debian-powerpc-200210/msg00260.html
Well I don't see anything in there that shows that this is a kernel
bug. What it does show is that some people are seeing this on the
console. This means that it probably is a hardware problem.
Unfortunately this is not something that can be worked around in
software since it is easy to filter out spurious events, but it
is impossible to manufacture missing events.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#121335: Please add the Toshiby keybounce fix
On Mon, 2002-10-28 at 08:36, Herbert Xu wrote: > On Mon, Oct 28, 2002 at 03:00:40AM +0100, Michel D?nzer wrote: > > > > Herbert, I think I've seen a kernel patch for #121335, and #156563 has > > definitely been nailed down to the kernel input layer. > > If you mean the patch in the bug log, then it's not going to be included > since it just filters out the duplicate events which is something that > should be done in the X server. AFAIK XFree86 upstream disagrees, though I think the best would be to do it in both, so it's fixed for the user if either has the fix. > As to #156563, please show me the evidence that it is a kernel bug since > it's not in the bug logs. See this thread: http://lists.debian.org/debian-powerpc/2002/debian-powerpc-200210/msg00260.html -- Earthling Michel Dänzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#121335: Please add the Toshiby keybounce fix
On Sat, Oct 26, 2002 at 09:27:27AM +0200, Debian User wrote: > this is the patch for the current 2.4.20-pre11 kernel. Please apply. FYI, Herbert is categorically refusing to apply this patch. Also, I believe the company is known as "Toshiba", not "Toshiby". -- G. Branden Robinson|The basic test of freedom is Debian GNU/Linux |perhaps less in what we are free to [EMAIL PROTECTED] |do than in what we are free not to http://people.debian.org/~branden/ |do. -- Eric Hoffer pgps1UW64V0wq.pgp Description: PGP signature
Bug#121335: Processed: Re: Bug#121335: Please add the Toshiby keybounce fix
On Mon, Oct 28, 2002 at 12:16:18PM +1100, Herbert Xu wrote: > PS Please cc [EMAIL PROTECTED] when you do this as > otherwise I don't get the message. If you check out the headers of the message in question, you'll see that I attempted to, but mistyped the address. -- G. Branden Robinson|Religion is regarded by the common Debian GNU/Linux |people as true, by the wise as [EMAIL PROTECTED] |false, and by the rulers as useful. http://people.debian.org/~branden/ |-- Lucius Annaeus Seneca pgpUaDZaOlwOZ.pgp Description: PGP signature
Bug#121335: Please add the Toshiby keybounce fix
On Sat, Oct 26, 2002 at 09:27:27AM +0200, Debian User wrote: > this is the patch for the current 2.4.20-pre11 kernel. Please apply. FYI, Herbert is categorically refusing to apply this patch. Also, I believe the company is known as "Toshiba", not "Toshiby". -- G. Branden Robinson|The basic test of freedom is Debian GNU/Linux |perhaps less in what we are free to [EMAIL PROTECTED] |do than in what we are free not to http://people.debian.org/~branden/ |do. -- Eric Hoffer msg04419/pgp0.pgp Description: PGP signature
Processed: Re: Processed: Re: Bug#121335: Please add the Toshiby keybounce fix
Processing commands for [EMAIL PROTECTED]: > reassign 121335 xserver-xfree86 Bug#121335: kernel: keybounce on Toshiba Tecra 9000 Bug#142569: kernel: keybounce when system is under load Bug#156563: kernel: key release on Mac USB keyboard not detected by X server Bug reassigned from package `kernel' to `xserver-xfree86'. > quit Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database)
Bug#121335: Processed: Re: Bug#121335: Please add the Toshiby keybounce fix
On Mon, Oct 28, 2002 at 12:16:18PM +1100, Herbert Xu wrote: > PS Please cc [EMAIL PROTECTED] when you do this as > otherwise I don't get the message. If you check out the headers of the message in question, you'll see that I attempted to, but mistyped the address. -- G. Branden Robinson|Religion is regarded by the common Debian GNU/Linux |people as true, by the wise as [EMAIL PROTECTED] |false, and by the rulers as useful. http://people.debian.org/~branden/ |-- Lucius Annaeus Seneca msg04416/pgp0.pgp Description: PGP signature
Processed: Re: Bug#121335: Please add the Toshiby keybounce fix
Processing commands for [EMAIL PROTECTED]: > reassign 121335 kernel Bug#121335: kernel: keybounce on Toshiba Tecra 9000 Bug#142569: kernel: keybounce when system is under load Bug#156563: kernel: key release on Mac USB keyboard not detected by X server Bug reassigned from package `xserver-xfree86' to `kernel'. > thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database)
Processed: Re: Processed: Re: Bug#121335: Please add the Toshiby keybounce fix
Processing commands for [EMAIL PROTECTED]: > reassign 121335 xserver-xfree86 Bug#121335: kernel: keybounce on Toshiba Tecra 9000 Bug#142569: kernel: keybounce when system is under load Bug#156563: kernel: key release on Mac USB keyboard not detected by X server Bug reassigned from package `kernel' to `xserver-xfree86'. > quit Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Processed: Re: Bug#121335: Please add the Toshiby keybounce fix
Processing commands for [EMAIL PROTECTED]: > reassign 121335 kernel Bug#121335: kernel: keybounce on Toshiba Tecra 9000 Bug#142569: kernel: keybounce when system is under load Bug#156563: kernel: key release on Mac USB keyboard not detected by X server Bug reassigned from package `xserver-xfree86' to `kernel'. > thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#121335: Please add the Toshiby keybounce fix
Hi,
this is the patch for the current 2.4.20-pre11 kernel. Please apply.
--- drivers/char/keyboard.c.original2002-10-25 21:19:03.0 +0200
+++ drivers/char/keyboard.c 2002-10-25 21:24:20.0 +0200
@@ -97,6 +97,9 @@
void compute_shiftstate(void);
+static unsigned char prev_scancode;
+static unsigned char next_scancode;
+
typedef void (*k_hand)(unsigned char value, char up_flag);
typedef void (k_handfn)(unsigned char value, char up_flag);
@@ -213,7 +216,19 @@
}
kbd = kbd_table + fg_console;
if ((raw_mode = (kbd->kbdmode == VC_RAW))) {
- put_queue(scancode | up_flag);
+ /* put_queue(scancode | up_flag); */
+ /* The following 'if' is a workaround for hardware
+ * which sometimes send the key release event twice
+ */
+ unsigned char next_scancode = scancode|up_flag;
+ if (up_flag && next_scancode==prev_scancode) {
+/* unexpected 2nd release event */
+ } else {
+ prev_scancode=next_scancode;
+ put_queue(next_scancode);
+ }
+
+
/* we do not return yet, because we want to maintain
the key_down array, so that we have the correct
values when finishing RAW mode or when changing VT's */
Bug#121335: Please add the Toshiby keybounce fix
Hi,
this is the patch for the current 2.4.20-pre11 kernel. Please apply.
--- drivers/char/keyboard.c.original2002-10-25 21:19:03.0 +0200
+++ drivers/char/keyboard.c 2002-10-25 21:24:20.0 +0200
@@ -97,6 +97,9 @@
void compute_shiftstate(void);
+static unsigned char prev_scancode;
+static unsigned char next_scancode;
+
typedef void (*k_hand)(unsigned char value, char up_flag);
typedef void (k_handfn)(unsigned char value, char up_flag);
@@ -213,7 +216,19 @@
}
kbd = kbd_table + fg_console;
if ((raw_mode = (kbd->kbdmode == VC_RAW))) {
- put_queue(scancode | up_flag);
+ /* put_queue(scancode | up_flag); */
+ /* The following 'if' is a workaround for hardware
+ * which sometimes send the key release event twice
+ */
+ unsigned char next_scancode = scancode|up_flag;
+ if (up_flag && next_scancode==prev_scancode) {
+/* unexpected 2nd release event */
+ } else {
+ prev_scancode=next_scancode;
+ put_queue(next_scancode);
+ }
+
+
/* we do not return yet, because we want to maintain
the key_down array, so that we have the correct
values when finishing RAW mode or when changing VT's */
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
