Bug#239341: xdm: extraneous TCP port introduced in upstream
tag 239341 + upstream patch thanks On Wed, Mar 24, 2004 at 10:05:46AM -0500, Jeff King wrote: Package: xdm Version: 4.3.0-7 Severity: normal Followup-For: Bug #239341 Hmm. The TCP port opening was introduced in xc/programs/xdm/socket.c, revision 3.11, when they removed the lines: if (request_port == 0) return; which also got backported to 4_3_0_2. See here: http://cvsweb.xfree86.org/cvsweb/xc/programs/xdm/socket.c#rev3.10.4.1 The xdmcp listening socket code was ripped out of CreateWellKnownSockets(), and my guess is that the check for request_port == 0 went accidentally. I don't see why you would want a randomly-selected chooser socket if you're not going to listen for the well-known UDP requests. I'm not familiar enough with this code to actually submit a patch. Can somebody with more clue check this out? Or maybe this should just be forwarded upstream. Thanks a lot for tracking this down! Your diagnosis and solution look correct to me. I'll apply a patch. -- G. Branden Robinson| Debian GNU/Linux | Ignorantia judicis est calamitas [EMAIL PROTECTED] | innocentis. http://people.debian.org/~branden/ | signature.asc Description: Digital signature
Processed: Re: Bug#239341: xdm: extraneous TCP port introduced in upstream
Processing commands for [EMAIL PROTECTED]: tag 239341 + upstream patch Bug#239341: xdm: unknown purpose tcp port open There were no tags set. Tags added: upstream, patch thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database)
Bug#239341: xdm: extraneous TCP port introduced in upstream
Package: xdm Version: 4.3.0-7 Severity: normal Followup-For: Bug #239341 Hmm. The TCP port opening was introduced in xc/programs/xdm/socket.c, revision 3.11, when they removed the lines: if (request_port == 0) return; which also got backported to 4_3_0_2. See here: http://cvsweb.xfree86.org/cvsweb/xc/programs/xdm/socket.c#rev3.10.4.1 The xdmcp listening socket code was ripped out of CreateWellKnownSockets(), and my guess is that the check for request_port == 0 went accidentally. I don't see why you would want a randomly-selected chooser socket if you're not going to listen for the well-known UDP requests. I'm not familiar enough with this code to actually submit a patch. Can somebody with more clue check this out? Or maybe this should just be forwarded upstream.
