Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities
tags 242216 - patch reassign 242216 xserver-xorg kthxbye On Thu, Apr 8, 2004 at 11:29:46 +0400, Nikita V. Youshchenko wrote: Could you please explain what you mean? Sure. ... I am referring to the large case statement at line 990 of xserver-xfree86.config.in[1]. The Simple) and Medium) cases have no auto-answer logic. Your patch should not be applied until they do. I'm not sure I understand why auto_answer logic is needed there, but anyway the attached patch is probably what you wish. Hi, is this bug still a problem for you with the current xserver-xorg package configuration? Hi. Unfortunately, too many time has passed since I reported that bug. I'm currently completely out of context. I've tried to check the current situation - but I even can't find what is modern equivalent of old xserver-xfree86.config file. Probably this bug should be just closed. Nikita pgpiRfhZSh5mt.pgp Description: PGP signature
Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities
tags 242216 - patch reassign 242216 xserver-xorg kthxbye On Thu, Apr 8, 2004 at 11:29:46 +0400, Nikita V. Youshchenko wrote: Could you please explain what you mean? Sure. ... I am referring to the large case statement at line 990 of xserver-xfree86.config.in[1]. The Simple) and Medium) cases have no auto-answer logic. Your patch should not be applied until they do. I'm not sure I understand why auto_answer logic is needed there, but anyway the attached patch is probably what you wish. Hi, is this bug still a problem for you with the current xserver-xorg package configuration? Cheers, Julien -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Re: Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities
Processing commands for [EMAIL PROTECTED]: tags 242216 - patch Bug#242216: xserver-xfree86: [debconf] monitor selection method defaults to advanced in too many siutations Tags were: patch Tags removed: patch reassign 242216 xserver-xorg Bug#242216: xserver-xfree86: [debconf] monitor selection method defaults to advanced in too many siutations Bug reassigned from package `xserver-xfree86' to `xserver-xorg'. kthxbye Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities
On Tue, Apr 06, 2004 at 02:14:03PM +0400, Nikita V. Youshchenko wrote: Your patch is incomplete; there is no auto_answer counterpart for the Simple and Medium monitor selection methods. Could you please explain what you mean? Sure. I've looked at the code of auto_answer, and I fail to find what else is needed to change default displayed answer. auto_answer routine seems do put it's fourth argiment to debconf database using db_set. So in current code it puts Advanced there, in my patch it will put $DEFAULT there instead. I fail to understand why this is not enough. Nothing else is needed to change the default displayed answer, but you need to be able to handle the later consequences. I am referring to the large case statement at line 990 of xserver-xfree86.config.in[1]. The Simple) and Medium) cases have no auto-answer logic. Your patch should not be applied until they do. [1] svn cat svn://necrotic.deadbeast.net/xfree86/trunk/debian/xserver-xfree86.config.in -- G. Branden Robinson|Religion consists in a set of Debian GNU/Linux |things which the average man thinks [EMAIL PROTECTED] |he believes and wishes he was http://people.debian.org/~branden/ |certain of. -- Mark Twain signature.asc Description: Digital signature
Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities
tag 242216 + patch thanks Could you please explain what you mean? Sure. ... I am referring to the large case statement at line 990 of xserver-xfree86.config.in[1]. The Simple) and Medium) cases have no auto-answer logic. Your patch should not be applied until they do. I'm not sure I understand why auto_answer logic is needed there, but anyway the attached patch is probably what you wish. Index: xserver-xfree86.config.in === --- xserver-xfree86.config.in (revision 1225) +++ xserver-xfree86.config.in (working copy) @@ -978,19 +978,19 @@ MONITOR_IS_LCD=$RET if [ $RET = true ]; then db_subst xserver-xfree86/config/monitor/selection-method choices Medium, Advanced - db_subst xserver-xfree86/config/monitor/selection-method default Medium + DEFAULT=Medium else # not an LCD db_subst xserver-xfree86/config/monitor/selection-method choices Simple, Medium, Advanced - db_subst xserver-xfree86/config/monitor/selection-method default Simple + DEFAULT=Simple fi -auto_answer db_input $(priority_ceil $PRIORITY) xserver-xfree86/config/monitor/selection-method Advanced +db_subst xserver-xfree86/config/monitor/selection-method default $DEFAULT +auto_answer db_input $(priority_ceil $PRIORITY) xserver-xfree86/config/monitor/selection-method $DEFAULT db_get xserver-xfree86/config/monitor/selection-method case $RET in Simple) -db_input $(priority_ceil $PRIORITY) xserver-xfree86/config/monitor/screen-size || debug_report_status db_input $(priority_ceil $PRIORITY) xserver-xfree86/config/monitor/screen-size $? -db_go +auto_answer db_input $(priority_ceil $PRIORITY) xserver-xfree86/config/monitor/screen-size 15 inches (380 mm) db_get xserver-xfree86/config/monitor/screen-size case $RET in 'Up to 14 inches (355 mm)') @@ -1016,8 +1016,7 @@ esac ;; Medium) -db_input $(priority_ceil $PRIORITY) xserver-xfree86/config/monitor/mode-list || debug_report_status db_input $(priority_ceil $PRIORITY) xserver-xfree86/config/monitor/mode-list $? -db_go +auto_answer db_input $(priority_ceil $PRIORITY) xserver-xfree86/config/monitor/mode-list 1024x768 @ 75Hz db_get xserver-xfree86/config/monitor/mode-list case $RET in 640x480 @ 60Hz)
Processed: Re: Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities
Processing commands for [EMAIL PROTECTED]: tag 242216 + patch Bug#242216: xserver-xfree86: config script could use different defaults for monitor selection method at different debconf question priorities There were no tags set. Tags added: patch thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database)
Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities
tag 242216 - patch severity 242216 wishlist retitle 242216 xserver-xfree86: config script could use different defaults for monitor selection method at different debconf question priorities thanks On Mon, Apr 05, 2004 at 04:17:26PM +0400, Nikita V. Youshchenko wrote: xserver-xfree86.config contains the following code: [...] Thus default answer for xserver-xfree86/config/monitor/selection-method is Simple or Medium (which is good for non-technical users), but if debconf actually asks the question, the default shown answer is hardcoded to Advanced. Since users tend to accept all defaults they see (even after a help screen was shown describing what the selections mean), too often they select this default and are faced with questions about frequences they can't understand. And even can't go back at that point. So it seems better to show a silly-safe choise by default. I.e. the same as is set in the case when question is not asked. Your patch is incomplete; there is no auto_answer counterpart for the Simple and Medium monitor selection methods. If you were to supply those as well, your patch would be ripe for evaluation. -- G. Branden Robinson| The Bible is probably the most Debian GNU/Linux | genocidal book ever written. [EMAIL PROTECTED] | -- Noam Chomsky http://people.debian.org/~branden/ | signature.asc Description: Digital signature
Processed: Re: Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities
Processing commands for [EMAIL PROTECTED]: tag 242216 - patch Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities Tags were: patch Tags removed: patch severity 242216 wishlist Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities Severity set to `wishlist'. retitle 242216 xserver-xfree86: config script could use different defaults for monitor selection method at different debconf question priorities Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities Changed Bug title. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database)
Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities
Your patch is incomplete; there is no auto_answer counterpart for the Simple and Medium monitor selection methods. Could you please explain what you mean? I've looked at the code of auto_answer, and I fail to find what else is needed to change default displayed answer. auto_answer routine seems do put it's fourth argiment to debconf database using db_set. So in current code it puts Advanced there, in my patch it will put $DEFAULT there instead. I fail to understand why this is not enough.
Bug#242216: xserver-xfree86.config hardcodes different defaults for display selection method on different priorities
Package: xserver-xfree86 Version: 4.3.0-7 Severity: normal Tags: patch xserver-xfree86.config contains the following code: ... if [ $RET = true ]; then db_subst xserver-xfree86/config/monitor/selection-method choices Medium, Advanced db_subst xserver-xfree86/config/monitor/selection-method default Medium else # not an LCD db_subst xserver-xfree86/config/monitor/selection-method choices Simple, Medium, Advanced db_subst xserver-xfree86/config/monitor/selection-method default Simple fi auto_answer db_input $(priority_ceil $PRIORITY) xserver-xfree86/config/monitor/selection-method Advanced ... Thus default answer for xserver-xfree86/config/monitor/selection-method is Simple or Medium (which is good for non-technical users), but if debconf actually asks the question, the default shown answer is hardcoded to Advanced. Since users tend to accept all defaults they see (even after a help screen was shown describing what the selections mean), too often they select this default and are faced with questions about frequences they can't understand. And even can't go back at that point. So it seems better to show a silly-safe choise by default. I.e. the same as is set in the case when question is not asked. --- xserver-xfree86.config.orig 2004-04-05 16:02:07.0 +0400 +++ xserver-xfree86.config 2004-04-05 16:06:21.0 +0400 @@ -1568,13 +1568,14 @@ MONITOR_IS_LCD=$RET if [ $RET = true ]; then db_subst xserver-xfree86/config/monitor/selection-method choices Medium, Advanced - db_subst xserver-xfree86/config/monitor/selection-method default Medium + DEFAULT=Medium else # not an LCD db_subst xserver-xfree86/config/monitor/selection-method choices Simple, Medium, Advanced - db_subst xserver-xfree86/config/monitor/selection-method default Simple + DEFAULT=Simple fi -auto_answer db_input $(priority_ceil $PRIORITY) xserver-xfree86/config/monitor/selection-method Advanced +db_subst xserver-xfree86/config/monitor/selection-method default $DEFAULT +auto_answer db_input $(priority_ceil $PRIORITY) xserver-xfree86/config/monitor/selection-method $DEFAULT db_get xserver-xfree86/config/monitor/selection-method case $RET in
