Bug#252585: Xsession.options parsing fragile

2010-11-09 Thread Julien Viard de Galbert
Hello Marc,

It's been 3 more years and the issue is still there...

But the parsing does not (or no longer) use grep so your proposed regex
will not fit...

For information the parsing is done by the following script:
# read OPTIONFILE
OPTIONS=$(cat $OPTIONFILE) || true

has_option() {
  if [ ${OPTIONS#*
$1} != $OPTIONS ]; then
return 0
  else
return 1
  fi
}

So one can add a new line just after $1 and before the closing bracket }
to match exact option and remove the conflicting prefix but that would
mean the rest of the line is no longer ignored (I don't know maybe some
people were adding comments to the end of the line).
And also it doesn't allow for neither leading or ending spaces.

Maybe a good solution would be to document in Xsession(5) in the
customizing section that option name should not contain any other option
name as prefix.

What do you think ?

-- 
Julien Viard de Galbertjul...@vdg.blogsite.org
http://silicone.homelinux.org/   jul...@silicone.homelinux.org



-- 
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101109144025.ga28...@vdg.blogsite.org



Bug#252585: Xsession.options parsing fragile

2007-02-26 Thread Marc Haber
reassign  #252585 x11-common
reopen #252585
found #252585 7.1.0-12
thanks

On Mon, Feb 26, 2007 at 08:24:49PM +0100, Brice Goglin wrote:
 Closing this bug since I didn't get any reply from the submitter after
 my ping a month ago. If anybody ever reproduces this problem, feel free
 to reopen.

I must have missed the ping. I can still reproduce the issue despite
havin gmigrated to x.org long ago.

Greetings
Marc

-- 
-
Marc Haber | I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things.Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]