Bug#365292: xbase-clients: xmore crashes immediately

[Eugene Konev]

Again, some code not properly ifdef'ed for building without xprint. Fix
attached.

# HG changeset patch
# User [EMAIL PROTECTED]
# Node ID cc07826ef0d862516a72a8dbe0403f0d420c5c77
# Parent  973ecd7376218cdaa4298cfc4dda3267046e1ef3
merge

diff -r 973ecd737621 -r cc07826ef0d8 
app/xbase-clients/xmore-X11R7.0-1.0.1/xmore.c
--- a/app/xbase-clients/xmore-X11R7.0-1.0.1/xmore.c Sun Apr 30 13:40:29 
2006 +0800
+++ b/app/xbase-clients/xmore-X11R7.0-1.0.1/xmore.c Sun Apr 30 13:40:40 
2006 +0800
@@ -150,7 +150,9 @@ static void
 static void
 printshellDestroyXtProc(Widget w, XtPointer client_data, XtPointer callData)
 {
+#ifdef USE_XPRINT
 XawPrintDialogClosePrinterConnection(printdialog, False);
+#endif
 }
 
 #ifdef USE_XPRINT
@@ -302,7 +304,12 @@ int main( int argc, char *argv[] )
 #endif
   
   n = 0;
-  XtSetArg(args[n], XtNfromHoriz,   printbutton);n++;
+#ifdef USE_XPRINT
+  XtSetArg(args[n], XtNfromHoriz,   printbutton);
+#else
+  XtSetArg(args[n], XtNfromHoriz,   NULL);
+#endif
+  n++;
   XtSetArg(args[n], XtNfromVert,text);   n++;
   XtSetArg(args[n], XtNlabel,   "Quit");  n++;
   quitbutton = XtCreateManagedWidget("quit", commandWidgetClass, form, args, 
n);

Bug#365292: xbase-clients: xmore crashes immediately

[Justin Pryzby]

On Sat, Apr 29, 2006 at 11:03:57AM +0200, Michel D?nzer wrote:
> On Fri, 2006-04-28 at 20:49 -0400, Justin Pryzby wrote:
> > Package: xbase-clients
> > Version: 1:7.0.0-5
> > Severity: normal
> > 
> > $ xmore /dev/null 
> > Segmentation fault
> 
> Please run it in gdb and provide a backtrace.
#0  0xb7ea39be in CvtEdgeTypeToString () from /usr/lib/libXaw.so.7
#1  0xb7ea39c9 in CvtEdgeTypeToString () from /usr/lib/libXaw.so.7
#2  0xb7ea3b8e in CvtEdgeTypeToString () from /usr/lib/libXaw.so.7
#3  0xb7ea4412 in CvtEdgeTypeToString () from /usr/lib/libXaw.so.7
#4  0xb7e41449 in XtGetClassExtension () from /usr/lib/libXt.so.6
#5  0xb7e41468 in XtGetClassExtension () from /usr/lib/libXt.so.6
#6  0xb7e42757 in XtRealizeWidget () from /usr/lib/libXt.so.6
#7  0x08048b03 in main (argc=2, argv=0xbfe04954)
at ../xmore-X11R7.0-1.0.1/xmore.c:314
app = (XtAppContext) 0x804d878
form = (Widget) 0x8059aa0
printbutton = 
quitbutton = 
args = {{name = 0x804911b "fromHoriz", value = -1075820404}, {
name = 0x8049125 "fromVert", value = 134605248}, {
name = 0x804a4ed "label", value = 134517038}, {name = 0x804a42a "height", 
value = 300}, {name = 0x80490f6 "scrollHorizontal", value = 2}, {
name = 0x8049107 "scrollVertical", value = 2}, {
name = 0x804ab22 "fontSet", value = 134587712}, {
name = 0x8048bb0 "U\211?\203?\030\211]??O", value = 0}}

Bug#365292: xbase-clients: xmore crashes immediately

[Michel Dänzer]

On Fri, 2006-04-28 at 20:49 -0400, Justin Pryzby wrote:
> Package: xbase-clients
> Version: 1:7.0.0-5
> Severity: normal
> 
> $ xmore /dev/null 
> Segmentation fault

Please run it in gdb and provide a backtrace.


-- 
Earthling Michel Dänzer  | Debian (powerpc), X and DRI developer
Libre software enthusiast|   http://svcs.affero.net/rm.php?r=daenzer

Bug#365292: xbase-clients: xmore crashes immediately

[Justin Pryzby]

Package: xbase-clients
Version: 1:7.0.0-5
Severity: normal

$ xmore /dev/null 
Segmentation fault

valgrind has tons of warnings.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]