Bug#405782: [xserver-xorg] "dpkg-reconfigure xserver-xorg" stuck

2007-01-06 Thread Boris Dores
On Sat, Jan 06, 2007 at 06:04:54PM (GMT+0100), Brice Goglin wrote:
> Ok great, thanks. I have reproduced the problem with a chroot and a
> locally-nfs-mounted /tmp. The problem is caused by /usr/bin/dexconf not
> closing a redirection before exiting. File descriptor 4 was kept open,
> pointing to /tmp/dexconf-tmp-/DRI. Adding exec 4<&- solves the
> problem. Patch attached.

  I confirm. Works fine now.
  Thanks a lot.

-- 
Boris Dorès



Bug#405782: [xserver-xorg] "dpkg-reconfigure xserver-xorg" stuck

2007-01-06 Thread Brice Goglin
reassign 405782 x11-common
tag 405782 + patch
thanks





>   Then, in the resulting file, we can see at some point a
> /tmp/dexconf-tmp-27788/.nfs0001403c0317, which disappears immediately.
>
>   If I'm not mistaken, it happens on a NFS share when we delete a file
> which is still open, doesn't it ? That seems to be a lead (at least I
> hope).
>   

Ok great, thanks. I have reproduced the problem with a chroot and a
locally-nfs-mounted /tmp. The problem is caused by /usr/bin/dexconf not
closing a redirection before exiting. File descriptor 4 was kept open,
pointing to /tmp/dexconf-tmp-/DRI. Adding exec 4<&- solves the
problem. Patch attached.

Brice

---
 debian/local/dexconf |3 +++
 1 file changed, 3 insertions(+)

Index: xorg-7.1.0/debian/local/dexconf
===
--- xorg-7.1.0.orig/debian/local/dexconf	2007-01-06 17:50:41.0 +0100
+++ xorg-7.1.0/debian/local/dexconf	2007-01-06 17:53:11.0 +0100
@@ -414,6 +414,9 @@
 EndSection
 SECTION
 
+# Close file descriptor 4 before we delete temporary files
+exec 4<&-
+
 # Tell debconf to stop listening to us.
 db_stop
 


Bug#405782: [xserver-xorg] "dpkg-reconfigure xserver-xorg" stuck

2007-01-06 Thread Brice Goglin
I forgot to patch the trap, new patch attached (it includes the previous
one).

Brice

---
 debian/local/dexconf |4 
 1 file changed, 4 insertions(+)

Index: xorg-7.1.0/debian/local/dexconf
===
--- xorg-7.1.0.orig/debian/local/dexconf	2007-01-06 17:50:41.0 +0100
+++ xorg-7.1.0/debian/local/dexconf	2007-01-06 18:11:21.0 +0100
@@ -117,6 +117,7 @@
 trap 'if [ -e "$DEXCONFTMPDIR/backup" ] && [ -n "$XF86CONFIG" ]; then \
 cat "$DEXCONFTMPDIR/backup" >"$XF86CONFIG"; \
   fi; \
+  exec 4<&-; \
   rm -rf "$DEXCONFTMPDIR"; \
   bomb "received signal; aborting"' HUP INT QUIT TERM
 
@@ -414,6 +415,9 @@
 EndSection
 SECTION
 
+# Close file descriptor 4 before we delete temporary files
+exec 4<&-
+
 # Tell debconf to stop listening to us.
 db_stop
 


Processed: Bug#405782: [xserver-xorg] "dpkg-reconfigure xserver-xorg" stuck

2007-01-06 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

> reassign 405782 x11-common
Bug#405782: [xserver-xorg] "dpkg-reconfigure xserver-xorg" stuck
Bug reassigned from package `xserver-xorg' to `x11-common'.

> tag 405782 + patch
Bug#405782: [xserver-xorg] "dpkg-reconfigure xserver-xorg" stuck
Tags were: moreinfo unreproducible
Tags added: patch

> thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Processed: Bug#405782: [xserver-xorg] "dpkg-reconfigure xserver-xorg" stuck

2007-01-06 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

> tags 405782 + unreproducible moreinfo
Bug#405782: [xserver-xorg] "dpkg-reconfigure xserver-xorg" stuck
There were no tags set.
Tags added: unreproducible, moreinfo

> severity 405782 normal
Bug#405782: [xserver-xorg] "dpkg-reconfigure xserver-xorg" stuck
Severity set to `normal' from `grave'

> thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#405782: [xserver-xorg] "dpkg-reconfigure xserver-xorg" stuck

2007-01-06 Thread Boris Dores
Package: xserver-xorg
Version: 1:7.1.0-9
Severity: grave

  Hi everyone,

  It would seem that "dpkg-reconfigure xserver-xorg" never succeeds to
update /etc/X11/xorg.conf any more.

  At the end of the questions part, the following is displayed on the
console :

xserver-xorg postinst warning: overwriting possibly-customised configuration
   file; backup in /etc/X11/xorg.conf.20070106082628
rm: cannot remove directory `/tmp/dexconf-tmp-6475': Directory not empty.
xserver-xorg postinst warning: error while preparing new Xorg X server
   configuration file in /etc/X11/xorg.conf.dpkg-new; not attempting to
   update existing configuration

  However, /tmp/dexconf-tmp-* is always empty (afterwards at
least), and manually running dexconf generates a perfectly working
/etc/X11/xorg.conf (even though it displays the same "Directory not
empty" warning).

  I tried the same procedure on 4 newly installed hosts (debootstrap of
etch to a nfsroot), and again after manually running dexconf, it always
fails.

  Thanks.
  Best regards.

-- 
Boris Dorès