Bug#452913: Bug#437066: xserver-xorg-video-intel: refuses 1366x768 because detects 1024x768 panel size
Looks like my previous patch to bug #437066 was the real cause of bug
#452913.
The new patch (attached) copies values of bios_mode to fixed_mode,
instead of overwriting the latter.
--
Sergey Yanovich
diff --git a/src/i830_lvds.c b/src/i830_lvds.c
index a3a56f7..76e55f7 100644
--- a/src/i830_lvds.c
+++ b/src/i830_lvds.c
@@ -926,6 +926,16 @@ i830_lvds_init(ScrnInfoPtr pScrn)
bios_mode = i830_bios_get_panel_mode(pScrn, dev_priv-panel_wants_dither);
if (bios_mode != NULL) {
if (dev_priv-panel_fixed_mode != NULL) {
+ /* Fixup for a 1366x768 panel with the horizontal trimmed
+ * down to 1024 for text mode.
+ */
+ if (!xf86ModesEqual(dev_priv-panel_fixed_mode, bios_mode)
+ bios_mode-HDisplay == 1366)
+ {
+ memcpy(dev_priv-panel_fixed_mode-Clock,
+ bios_mode-Clock, sizeof(int)*12);
+ }
+
/* Fixup for a 1280x768 panel with the horizontal trimmed
* down to 1024 for text mode.
*/
Bug#437066: xserver-xorg-video-intel: refuses 1366x768 because detects 1024x768 panel size
Hello Brice,
After debian/unstable bumped xorg version, I was not able to use the
old v1.7.2 driver any longer.
I have had to engineer a brute hack, but it seems to be in the spirit
of driver (there is one already).
The patch that gives me 1366x768 back is attached.
Cheers,
--
Sergey
diff --git a/src/i830_lvds.c b/src/i830_lvds.c
index 18e5c2b..54a4838 100644
--- a/src/i830_lvds.c
+++ b/src/i830_lvds.c
@@ -563,6 +563,17 @@ i830_lvds_init(ScrnInfoPtr pScrn)
bios_mode = i830_bios_get_panel_mode(pScrn, dev_priv-panel_wants_dither);
if (bios_mode != NULL) {
if (dev_priv-panel_fixed_mode != NULL) {
+ /* Fixup for a 1366x768 panel with the horizontal trimmed
+ * down to 1024 for text mode.
+ */
+ if (!xf86ModesEqual(dev_priv-panel_fixed_mode, bios_mode)
+ bios_mode-HDisplay == 1366)
+ {
+ xfree(dev_priv-panel_fixed_mode-name);
+ xfree(dev_priv-panel_fixed_mode);
+ dev_priv-panel_fixed_mode = xf86DuplicateMode(bios_mode);
+ }
+
/* Fixup for a 1280x768 panel with the horizontal trimmed
* down to 1024 for text mode.
*/
Bug#437066: xserver-xorg-video-intel: refuses 1366x768 because detects 1024x768 panel size
forwarded 437066 https://bugs.freedesktop.org/show_bug.cgi?id=11932 thank you Sergey Yanovich wrote: Brice Goglin wrote: The upstream developer thinks the panel size detection needs to be fixed. But, in order to look at it, he needs your Xorg.0.log after adding Option ModeDebug yes to the device section. Could you send this log when using the git snapshot that you built this morning? No problem. And xorg.conf for reference. Bug forwarded at the URL above, feel free to add any comment there if you think it could help. Thanks, Brice -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Re: Bug#437066: xserver-xorg-video-intel: refuses 1366x768 because detects 1024x768 panel size
Processing commands for [EMAIL PROTECTED]: forwarded 437066 https://bugs.freedesktop.org/show_bug.cgi?id=11932 Bug#437066: xserver-xorg-video-intel: refuses 1366x768 because detects 1024x768 panel size Noted your statement that Bug has been forwarded to https://bugs.freedesktop.org/show_bug.cgi?id=11932. thank you Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#437066: xserver-xorg-video-intel: refuses 1366x768 because detects 1024x768 panel size
Sergey Yanovich wrote: Brice Goglin wrote: Once this is done, we'll know how bad the panel size dimension is detected and we'll have enough information to forward this bug upstream. Please find enclosed Xorg.0.log with video-intel at git20070810+your patch. (WW) i830_lvds_mode_valid: Using panel dimensions 1024x768 Thanks a lot for testing this so fast. The driver does not detect the right panel size (or the hardware does not expose it correctly). I will forward this problem upstream, either to fix the driver detection or to request an Option PanelSize to override the detection. Since this is a different bug than the original submitter of #420840, I have cloned it into a new bug report (#437066). I am keeping #420840 for its original submitter. Please only use the new #437066 when replying about the panel size being wrongly detected. Thanks, Brice -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
