Bug#484225: compiz-core: compiz-manager wrapper script modifies special ENV environment variable

2008-07-14 Thread Alexander E. Patrakov
The original patch attached to http://bugs.debian.org/484225 contains bashisms 
of the form export VARIABLE=VALUE. Please fix them instead of applying the 
patch blindly.

-- 
Alexander E. Patrakov



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#484225: compiz-core: compiz-manager wrapper script modifies special ENV environment variable

2008-07-14 Thread Julien Cristau
On Mon, Jul 14, 2008 at 18:45:47 +0600, Alexander E. Patrakov wrote:

 The original patch attached to http://bugs.debian.org/484225 contains
 bashisms of the form export VARIABLE=VALUE. Please fix them instead
 of applying the patch blindly.
 
Those aren't bashisms.  Please give a reference (or, really, don't
bother because you won't find one) instead of complaining blindly.

Cheers,
Julien



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#484225: compiz-core: compiz-manager wrapper script modifies special ENV environment variable

2008-07-14 Thread Alexander E. Patrakov
Julien Cristau wrote:
 On Mon, Jul 14, 2008 at 18:45:47 +0600, Alexander E. Patrakov wrote:
  The original patch attached to http://bugs.debian.org/484225 contains
  bashisms of the form export VARIABLE=VALUE. Please fix them instead
  of applying the patch blindly.

 Those aren't bashisms.  Please give a reference (or, really, don't
 bother because you won't find one) instead of complaining blindly.

Oops, sorry. I am after http://lists.boost.org/boost-build/2004/07/6890.php, 
which refers to Solaris. 
http://www.opengroup.org/onlinepubs/009695399/utilities/export.html does 
permit this syntax.

-- 
Alexander E. Patrakov



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#484225: compiz-core: compiz-manager wrapper script modifies special ENV environment variable

2008-07-14 Thread sean finney
On Monday 14 July 2008 03:42:29 pm Alexander E. Patrakov wrote:
  On Mon, Jul 14, 2008 at 18:45:47 +0600, Alexander E. Patrakov wrote:
   The original patch attached to http://bugs.debian.org/484225 contains
   bashisms of the form export VARIABLE=VALUE. Please fix them instead
   of applying the patch blindly.

 Oops, sorry. I am after
 http://lists.boost.org/boost-build/2004/07/6890.php, which refers to
 Solaris.
 http://www.opengroup.org/onlinepubs/009695399/utilities/export.html does
 permit this syntax.

and jftr please don't assume that we blindly apply patches sent to the bts. 

thanks,
sean


signature.asc
Description: This is a digitally signed message part.


Bug#484225: compiz-core: compiz-manager wrapper script modifies special ENV environment variable

2008-06-02 Thread Debian User
Package: compiz-core
Version: 1:0.7.4-0ubuntu7
Severity: important
Tags: patch


The Compiz Manager wrapper script (installed at /usr/bin/compiz)
modifies the ENV environment variable, which interferes with
interactive POSIX shells (/bin/sh).

For more details on the standard meaning of the ENV environment
variable, see the POSIX specifications at:
http://www.opengroup.org/onlinepubs/95399/basedefs/xbd_chap08.html

http://www.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_05_03

http://www.opengroup.org/onlinepubs/009695399/utilities/sh.html#tag_04_128_08

-- System Information:
Debian Release: lenny/sid
  APT prefers hardy-updates
  APT policy: (500, 'hardy-updates'), (500, 'hardy-security'), (500, 
'hardy-proposed'), (500, 'hardy-backports'), (500, 'hardy')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-17-generic (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages compiz-core depends on:
ii  libc6   2.7-10ubuntu3GNU C Library: Shared libraries
ii  libgl1-mesa-glx [li 7.0.3~rc2-1ubuntu3   A free implementation of the OpenG
ii  libice6 2:1.0.4-1X11 Inter-Client Exchange library
ii  libsm6  2:1.0.3-1X11 Session Management library
ii  libstartup-notifica 0.9-1library for program launch feedbac
ii  libx11-62:1.1.3-1ubuntu2 X11 client-side library
ii  libx11-xcb1 2:1.1.3-1ubuntu2 Xlib/XCB interface library
ii  libxcb1 1.1-1ubuntu1 X C Binding
ii  libxcomposite1  1:0.4.0-1X11 Composite extension library
ii  libxcursor1 1:1.1.9-1X cursor management library
ii  libxdamage1 1:1.1.1-3X11 damaged region extension libra
ii  libxext62:1.0.3-2build1  X11 miscellaneous extension librar
ii  libxfixes3  1:4.0.3-2X11 miscellaneous 'fixes' extensio
ii  libxinerama12:1.0.2-1build1  X11 Xinerama extension library
ii  libxml2 2.6.31.dfsg-2ubuntu1 GNOME XML library
ii  libxrandr2  2:1.2.2-1X11 RandR extension library
ii  libxslt1.1  1.1.22-1ubuntu1  XSLT processing library - runtime 
ii  mesa-utils  7.0.3~rc2-1ubuntu3   Miscellaneous Mesa GL utilities

Versions of packages compiz-core recommends:
ii  compiz-plugins  1:0.7.4-0ubuntu7 OpenGL window and compositing mana

-- no debconf information
Index: compiz-0.7.4/debian/compiz-manager
===
--- compiz-0.7.4.orig/debian/compiz-manager 2008-06-03 00:13:52.0 
-0400
+++ compiz-0.7.4/debian/compiz-manager  2008-06-03 00:15:06.0 -0400
@@ -63,7 +63,6 @@
 
 COMPIZ_OPTIONS=--ignore-desktop-hints --replace
 COMPIZ_PLUGINS=
-ENV=
 
 # Use emerald by default if it exist
 USE_EMERALD=yes
@@ -286,27 +285,23 @@
 build_env()
 {
if check_nvidia; then
-   ENV=__GL_YIELD=NOTHING 
+   export __GL_YIELD=NOTHING
fi
if [ $INDIRECT = yes ]; then
-   ENV=$ENV LIBGL_ALWAYS_INDIRECT=1 
+   export LIBGL_ALWAYS_INDIRECT=1
fi
if check_xgl; then
if [ -f ${LIBGL_NVIDIA} ]; then
-   ENV=$ENV LD_PRELOAD=${LIBGL_NVIDIA}
+   export LD_PRELOAD=${LD_PRELOAD:+${LD_PRELOAD} 
}${LIBGL_NVIDIA}
verbose Enabling Xgl with nVidia drivers...\n
fi
if [ -f ${LIBGL_FGLRX} ]; then
-   ENV=$ENV LD_PRELOAD=${LIBGL_FGLRX}
+   export LD_PRELOAD=${LD_PRELOAD:+${LD_PRELOAD} 
}${LIBGL_FGLRX}
verbose Enabling Xgl with fglrx ATi drivers...\n
fi
fi
 
-   ENV=$ENV FROM_WRAPPER=yes
-
-   if [ -n $ENV ]; then
-   export $ENV
-   fi
+   export FROM_WRAPPER=yes
 }
 
 build_args()