Bug#529830: git bisecting

2009-06-05 Thread Adrian Knoth
On Fri, Jun 05, 2009 at 12:53:48PM +0200, Michel Dänzer wrote:

> > a...@chopin:~/xdriver/xserver-xorg-video-ati$ git bisect bad
> > 421085949e195596000e37ea6693489db7c075b5 is first bad commit
> > commit 421085949e195596000e37ea6693489db7c075b5
> > Author: Alex Deucher 
> > Date:   Wed Apr 29 12:38:15 2009 -0400
> > 
> > radeon: fix several dpms issues
> > 
> > - atom dpms was unblanking for standby/suspend
> > - return if r600+ in radeon_crtc_modeset_ioctl()
> > - remove seprate standby/suspend handling in legacy
> >   crtc dpms.  we turn the outputs off, so turn the
> >   crtcs off too.
> > - disable the crtcs in legacy crtc dpms
> > - move radeon_crtc_modeset_ioctl() calls to radeon_crtc_dpms()
> >   so they will get called for both atom and legacy paths
> > 
> > Should fix bug 21321
> 
> When the problem happens, can you still ping the machine over the
> network?

Unfortunately not, so I cannot attach a debugger.


But it looks like that suspend/resume works if you switch from X to vt
before suspending. At least I was able to resume multiple times in a row
(let's say 8/8 good)

HTH

-- 
mail: a...@thur.de  http://adi.thur.de  PGP/GPG: key via keyserver



--
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#529830: git bisecting

2009-06-05 Thread Michel Dänzer
On Wed, 2009-06-03 at 20:34 +0200, Adrian Knoth wrote:
> 
> a...@chopin:~/xdriver/xserver-xorg-video-ati$ git bisect bad
> 421085949e195596000e37ea6693489db7c075b5 is first bad commit
> commit 421085949e195596000e37ea6693489db7c075b5
> Author: Alex Deucher 
> Date:   Wed Apr 29 12:38:15 2009 -0400
> 
> radeon: fix several dpms issues
> 
> - atom dpms was unblanking for standby/suspend
> - return if r600+ in radeon_crtc_modeset_ioctl()
> - remove seprate standby/suspend handling in legacy
>   crtc dpms.  we turn the outputs off, so turn the
>   crtcs off too.
> - disable the crtcs in legacy crtc dpms
> - move radeon_crtc_modeset_ioctl() calls to radeon_crtc_dpms()
>   so they will get called for both atom and legacy paths
> 
> Should fix bug 21321

When the problem happens, can you still ping the machine over the
network? Can you log in remotely, attach gdb to the X server process and
get a backtrace?


-- 
Earthling Michel Dänzer   |http://www.vmware.com
Libre software enthusiast |  Debian, X and DRI developer



--
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#529830: git bisecting

2009-06-03 Thread Adrian Knoth
On Wed, Jun 03, 2009 at 07:11:23PM +0200, I wrote:

> IOW: It takes some time for testing, and in the meantime, the accused

Ok, new information:

a...@chopin:~/xdriver/xserver-xorg-video-ati$ git bisect bad
421085949e195596000e37ea6693489db7c075b5 is first bad commit
commit 421085949e195596000e37ea6693489db7c075b5
Author: Alex Deucher 
Date:   Wed Apr 29 12:38:15 2009 -0400

radeon: fix several dpms issues

- atom dpms was unblanking for standby/suspend
- return if r600+ in radeon_crtc_modeset_ioctl()
- remove seprate standby/suspend handling in legacy
  crtc dpms.  we turn the outputs off, so turn the
  crtcs off too.
- disable the crtcs in legacy crtc dpms
- move radeon_crtc_modeset_ioctl() calls to radeon_crtc_dpms()
  so they will get called for both atom and legacy paths

Should fix bug 21321

:04 04 3ba7b4adeb22e435c61ecde68abb661e1122b028
f0ef8b23385d8c93a85c2552a3ba6d4a606367b0 M  src

a...@chopin:~/xdriver/xserver-xorg-video-ati$ git bisect log
git bisect start
# bad: [9ac2b8b802923eac33301424e8f00571c765cb82] Prepare changelog for upload
git bisect bad 9ac2b8b802923eac33301424e8f00571c765cb82
# good: [efa0fc15c2c99dea89f3b212f1667d49592c36b9] Prepare changelog for upload
git bisect good efa0fc15c2c99dea89f3b212f1667d49592c36b9
# good: [fbb04716e4c28347c9e627f3cc78b4420e9abfa0] AVIVO: better fix for cursor 
flickering/corruption issues
git bisect good fbb04716e4c28347c9e627f3cc78b4420e9abfa0
# good: [fbb04716e4c28347c9e627f3cc78b4420e9abfa0] AVIVO: better fix for cursor 
flickering/corruption issues
git bisect good fbb04716e4c28347c9e627f3cc78b4420e9abfa0
# bad: [cd03bc17ccb30f1598af61c455b623c14ea42e6b] r3xx-r5xx: switch to 1/12 
subpixel precision
git bisect bad cd03bc17ccb30f1598af61c455b623c14ea42e6b
# bad: [b6cd47ec007af2022af180f537a7ba01244b2c88] AVIVO: fix cursor corruption 
bands for real
git bisect bad b6cd47ec007af2022af180f537a7ba01244b2c88
# bad: [0e49efbe8c271c26cec4dfca063c73755dc2d25f] r2xx-r4xx: fix typo in last 
i2c fix and clarify hw i2c pin sel
git bisect bad 0e49efbe8c271c26cec4dfca063c73755dc2d25f
# bad: [421085949e195596000e37ea6693489db7c075b5] radeon: fix several dpms 
issues
git bisect bad 421085949e195596000e37ea6693489db7c075b5


At least this one now looks more related to my card. ;)


HTH

-- 
mail: a...@thur.de  http://adi.thur.de  PGP/GPG: key via keyserver

Acht Uhr? Morgens? Wach? Duschen? Das war kein Admin. (Jonas Luster in dasr)



-- 
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#529830: git bisecting

2009-06-03 Thread Adrian Knoth
On Tue, Jun 02, 2009 at 06:54:44PM +0200, I wrote:

> > > It's a HP nx6325 laptop with ATI xpress 200M (RS482).
> > Any chance you could use git bisect to track down what changes in the
> > radeon driver caused the problem?
> 
> a...@chopin:~/xserver-xorg-video-ati$ git bisect good
> b6cd47ec007af2022af180f537a7ba01244b2c88 is first bad commit
> commit b6cd47ec007af2022af180f537a7ba01244b2c88
> Author: Alex Deucher 
> Date:   Fri May 8 12:21:33 2009 -0400
> 
> AVIVO: fix cursor corruption bands for real
> 
> Don't have to leave both cursors enabled, just have to use
> the same mode for both cursors whether or not they are enabled.
> 
> :04 04 9434b74a8329bf6cd6c076fe512a333834641e99 
> e2bfdc6168042c7a1a6ef14b60ded5c6655fda77 M  src

The "git bisect good" was probably too early. I'm still getting freezes,
so it's easy to say when a revision is "bad", but even five successful
resumes in a row are not enough to call it "good".

IOW: It takes some time for testing, and in the meantime, the accused
commit mentioned above isn't probably the culprit.


Sorry for not testing it enough in the first place.


-- 
mail: a...@thur.de  http://adi.thur.de  PGP/GPG: key via keyserver



-- 
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#529830: git bisecting

2009-06-03 Thread Alex Deucher
On Tue, Jun 2, 2009 at 12:54 PM, Adrian Knoth  
wrote:
> On Mon, Jun 01, 2009 at 10:04:34AM -0400, Alex Deucher wrote:
>
>> > It's a HP nx6325 laptop with ATI xpress 200M (RS482).
>> Any chance you could use git bisect to track down what changes in the
>> radeon driver caused the problem?
>
> a...@chopin:~/xserver-xorg-video-ati$ git bisect good
> b6cd47ec007af2022af180f537a7ba01244b2c88 is first bad commit
> commit b6cd47ec007af2022af180f537a7ba01244b2c88
> Author: Alex Deucher 
> Date:   Fri May 8 12:21:33 2009 -0400
>
>    AVIVO: fix cursor corruption bands for real
>
>    Don't have to leave both cursors enabled, just have to use
>    the same mode for both cursors whether or not they are enabled.
>
> :04 04 9434b74a8329bf6cd6c076fe512a333834641e99 
> e2bfdc6168042c7a1a6ef14b60ded5c6655fda77 M      src
>
>

weird.  This shouldn't affect your card at all.

> a...@chopin:~/xserver-xorg-video-ati$ git bisect log
> git bisect start
> # bad: [9ac2b8b802923eac33301424e8f00571c765cb82] Prepare changelog for
> # upload
> git bisect bad 9ac2b8b802923eac33301424e8f00571c765cb82
> # good: [efa0fc15c2c99dea89f3b212f1667d49592c36b9] Prepare changelog for
> # upload
> git bisect good efa0fc15c2c99dea89f3b212f1667d49592c36b9
> # good: [fbb04716e4c28347c9e627f3cc78b4420e9abfa0] AVIVO: better fix for
> # cursor flickering/corruption issues
> git bisect good fbb04716e4c28347c9e627f3cc78b4420e9abfa0
> # good: [fbb04716e4c28347c9e627f3cc78b4420e9abfa0] AVIVO: better fix for
> # cursor flickering/corruption issues
> git bisect good fbb04716e4c28347c9e627f3cc78b4420e9abfa0
> # bad: [cd03bc17ccb30f1598af61c455b623c14ea42e6b] r3xx-r5xx: switch to
> # 1/12 subpixel precision
> git bisect bad cd03bc17ccb30f1598af61c455b623c14ea42e6b
> # bad: [b6cd47ec007af2022af180f537a7ba01244b2c88] AVIVO: fix cursor
> # corruption bands for real
> git bisect bad b6cd47ec007af2022af180f537a7ba01244b2c88
> # good: [0e49efbe8c271c26cec4dfca063c73755dc2d25f] r2xx-r4xx: fix typo
> # in last i2c fix and clarify hw i2c pin sel
> git bisect good 0e49efbe8c271c26cec4dfca063c73755dc2d25f
> # good: [0e49efbe8c271c26cec4dfca063c73755dc2d25f] r2xx-r4xx: fix typo
> # in last i2c fix and clarify hw i2c pin sel
> git bisect good 0e49efbe8c271c26cec4dfca063c73755dc2d25f
> # good: [cb8081a8e70b3354037f8ca99380288fe2eb9828] AVIVO: move cusor
> # offscreen when disabling
> git bisect good cb8081a8e70b3354037f8ca99380288fe2eb9828
>
>
>> Also, have you made any changes to your suspend/resume scripts (i.e.,
>> added or removed vbetool post options)?
>
> No.
>
>> Also is it just suspend to ram or suspend to disk or both?
>
> I can only speak for suspend to ram, since my swap partition is too
> small for suspend to disk.
>
>
> HTH.
>
> BTW: Do you think that's the same bug?
>
>   https://bugs.freedesktop.org/show_bug.cgi?id=16537

Maybe; it's hard to say.  Seems like it used to work for you recently.
 Suspend/resume is problematic on a lot of cards probably not the same
issue in all cases.

Alex



--
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#529830: git bisecting

2009-06-02 Thread Adrian Knoth
On Mon, Jun 01, 2009 at 10:04:34AM -0400, Alex Deucher wrote:

> > It's a HP nx6325 laptop with ATI xpress 200M (RS482).
> Any chance you could use git bisect to track down what changes in the
> radeon driver caused the problem?

a...@chopin:~/xserver-xorg-video-ati$ git bisect good
b6cd47ec007af2022af180f537a7ba01244b2c88 is first bad commit
commit b6cd47ec007af2022af180f537a7ba01244b2c88
Author: Alex Deucher 
Date:   Fri May 8 12:21:33 2009 -0400

AVIVO: fix cursor corruption bands for real

Don't have to leave both cursors enabled, just have to use
the same mode for both cursors whether or not they are enabled.

:04 04 9434b74a8329bf6cd6c076fe512a333834641e99 
e2bfdc6168042c7a1a6ef14b60ded5c6655fda77 M  src


a...@chopin:~/xserver-xorg-video-ati$ git bisect log
git bisect start
# bad: [9ac2b8b802923eac33301424e8f00571c765cb82] Prepare changelog for
# upload
git bisect bad 9ac2b8b802923eac33301424e8f00571c765cb82
# good: [efa0fc15c2c99dea89f3b212f1667d49592c36b9] Prepare changelog for
# upload
git bisect good efa0fc15c2c99dea89f3b212f1667d49592c36b9
# good: [fbb04716e4c28347c9e627f3cc78b4420e9abfa0] AVIVO: better fix for
# cursor flickering/corruption issues
git bisect good fbb04716e4c28347c9e627f3cc78b4420e9abfa0
# good: [fbb04716e4c28347c9e627f3cc78b4420e9abfa0] AVIVO: better fix for
# cursor flickering/corruption issues
git bisect good fbb04716e4c28347c9e627f3cc78b4420e9abfa0
# bad: [cd03bc17ccb30f1598af61c455b623c14ea42e6b] r3xx-r5xx: switch to
# 1/12 subpixel precision
git bisect bad cd03bc17ccb30f1598af61c455b623c14ea42e6b
# bad: [b6cd47ec007af2022af180f537a7ba01244b2c88] AVIVO: fix cursor
# corruption bands for real
git bisect bad b6cd47ec007af2022af180f537a7ba01244b2c88
# good: [0e49efbe8c271c26cec4dfca063c73755dc2d25f] r2xx-r4xx: fix typo
# in last i2c fix and clarify hw i2c pin sel
git bisect good 0e49efbe8c271c26cec4dfca063c73755dc2d25f
# good: [0e49efbe8c271c26cec4dfca063c73755dc2d25f] r2xx-r4xx: fix typo
# in last i2c fix and clarify hw i2c pin sel
git bisect good 0e49efbe8c271c26cec4dfca063c73755dc2d25f
# good: [cb8081a8e70b3354037f8ca99380288fe2eb9828] AVIVO: move cusor
# offscreen when disabling
git bisect good cb8081a8e70b3354037f8ca99380288fe2eb9828


> Also, have you made any changes to your suspend/resume scripts (i.e.,
> added or removed vbetool post options)? 

No.

> Also is it just suspend to ram or suspend to disk or both?

I can only speak for suspend to ram, since my swap partition is too
small for suspend to disk.


HTH.

BTW: Do you think that's the same bug?

   https://bugs.freedesktop.org/show_bug.cgi?id=16537


-- 
mail: a...@thur.de  http://adi.thur.de  PGP/GPG: key via keyserver



-- 
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org