Bug#675407: xserver-xorg-video-openchrome: openchrome relink against new xserver results in null pointer dereference
Hi,
the proposed patch does not work since the dereference already happens a
few lines before the located position in ViaDoubleCheckCLE266Revision().
I moved the initialization before the call and can confirm it is working.
Best regards,
Leon Winter--- a/src/via_driver.c2011-12-09 19:02:43.0 +0100
+++ b/src/via_driver.c2012-06-04 09:22:13.492691241 +0200
@@ -996,6 +996,11 @@
#endif
}
+hwp = VGAHWPTR(pScrn);
+
+/* Needed with X 1.12 */
+vgaHWSetStdFuncs(hwp);
+
if (pVia-Chipset == VIA_CLE266)
ViaDoubleCheckCLE266Revision(pScrn);
@@ -1011,8 +1016,6 @@
struct pci_device *vgaDevice = viaPciDeviceVga();
#endif
-hwp = VGAHWPTR(pScrn);
-
switch (pVia-Chipset) {
case VIA_CLE266:
#ifdef XSERVER_LIBPCIACCESS
Bug#675407: xserver-xorg-video-openchrome: openchrome relink against new xserver results in null pointer dereference
On Fri, Jun 01, 2012 at 02:40:04AM +0200, Cyril Brulebois wrote: Sebastian Reichel s...@debian.org (31/05/2012): Hi, It's not enough to rebuild openchrome against the new X-Server, since the new X-Server does not run vgaHWSetStdFuncs(hwp) anymore: http://cgit.freedesktop.org/xorg/xserver/commit/?id=4bd6579188e718654c35f95623fd4772f9e0ef06 Please update the driver to support the X-Server's ABI change. Hello, can you please test the attached patch? Seems like upstream's svn (no comment) has no fix at the moment. This might be because upstream switched to git :) and I didn't have time to update to package to track the git version yet. I hope I can find some time soon. -- Julien Viard de Galbertjul...@vdg.blogsite.org http://silicone.homelinux.org/ jul...@silicone.homelinux.org GPG Key ID: D00E52B6 Published on: hkp://keys.gnupg.net Key Fingerprint: E312 A31D BEC3 74CC C49E 6D69 8B30 6538 D00E 52B6 signature.asc Description: Digital signature
Bug#675407: xserver-xorg-video-openchrome: openchrome relink against new xserver results in null pointer dereference
Package: xserver-xorg-video-openchrome Version: 1:0.2.904+svn1050-1+b1 Severity: grave Tags: upstream Justification: renders package unusable Hi, It's not enough to rebuild openchrome against the new X-Server, since the new X-Server does not run vgaHWSetStdFuncs(hwp) anymore: http://cgit.freedesktop.org/xorg/xserver/commit/?id=4bd6579188e718654c35f95623fd4772f9e0ef06 Please update the driver to support the X-Server's ABI change. -- Sebastian -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120531214102.25809.82908.reportbug@earth.universe
Bug#675407: xserver-xorg-video-openchrome: openchrome relink against new xserver results in null pointer dereference
Sebastian Reichel s...@debian.org (31/05/2012):
Hi,
It's not enough to rebuild openchrome against the new X-Server,
since the new X-Server does not run vgaHWSetStdFuncs(hwp) anymore:
http://cgit.freedesktop.org/xorg/xserver/commit/?id=4bd6579188e718654c35f95623fd4772f9e0ef06
Please update the driver to support the X-Server's ABI change.
Hello,
can you please test the attached patch? Seems like upstream's svn (no
comment) has no fix at the moment.
Should be as easy as: debcheckout, git am, debuild -b, sudo debi
Mraw,
KiBi.
From 7e67d5a88475ada5be7573243c33b51f2b3bf186 Mon Sep 17 00:00:00 2001
From: Cyril Brulebois k...@debian.org
Date: Fri, 1 Jun 2012 00:38:19 +
Subject: [PATCH] Fix for X 1.12: Introduce a driver-side vgaHWSetStdFuncs()
call.
Mimick other drivers, and call vgaHWSetStdFuncs() unconditionally.
Signed-off-by: Cyril Brulebois k...@debian.org
---
src/via_driver.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/src/via_driver.c b/src/via_driver.c
index 62d8fb1..ed379c9 100644
--- a/src/via_driver.c
+++ b/src/via_driver.c
@@ -1013,6 +1013,9 @@ VIAPreInit(ScrnInfoPtr pScrn, int flags)
hwp = VGAHWPTR(pScrn);
+/* Needed with X 1.12 */
+vgaHWSetStdFuncs(hwp);
+
switch (pVia-Chipset) {
case VIA_CLE266:
#ifdef XSERVER_LIBPCIACCESS
--
1.7.10
signature.asc
Description: Digital signature
