Bug#749120: [PATCH libFS] include X11/Xmd.h in fs_transport

2015-07-26 Thread Alan Coopersmith

On 07/26/15 11:16 AM, Julien Cristau wrote:

Xtrans defines BytesReadable_t as int or long depending on whether
LONG64 is defined.  So on a 64bit build it would be int when building
FSConnServ.c, but long for fs_transport.c.  To fix this inconsistency,
make fs_transport.c include X11/Xmd.h.

Debian bug#749120

Reported-by: Michael Tautschnig m...@debian.org
Signed-off-by: Julien Cristau jcris...@debian.org
---
  src/fs_transport.c | 1 +
  1 file changed, 1 insertion(+)

I'm not sure if this should be fixed in xtrans instead...


Yeah - I think we should add the #include X11/Xmd.h to Xtrans.h, not
force every consumer to add it before including Xtrans.h.

--
-Alan Coopersmith-  alan.coopersm...@oracle.com
 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


--
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/55b52dab.6090...@oracle.com



Bug#749120: [PATCH libFS] include X11/Xmd.h in fs_transport

2015-07-26 Thread Julien Cristau
Xtrans defines BytesReadable_t as int or long depending on whether
LONG64 is defined.  So on a 64bit build it would be int when building
FSConnServ.c, but long for fs_transport.c.  To fix this inconsistency,
make fs_transport.c include X11/Xmd.h.

Debian bug#749120

Reported-by: Michael Tautschnig m...@debian.org
Signed-off-by: Julien Cristau jcris...@debian.org
---
 src/fs_transport.c | 1 +
 1 file changed, 1 insertion(+)

I'm not sure if this should be fixed in xtrans instead...

diff --git a/src/fs_transport.c b/src/fs_transport.c
index a924f91..347bd43 100644
--- a/src/fs_transport.c
+++ b/src/fs_transport.c
@@ -28,4 +28,5 @@
 #endif
 
 #include config.h /* Need to know which transport types to support */
+#include X11/Xmd.h
 #include X11/Xtrans/transport.c
-- 
2.1.4


-- 
To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/1437934619-21475-1-git-send-email-jcris...@debian.org