Bug#759518: x11-common: Print the real name of the executable instead of x-session-manager
On Wed, 12 Aug 2015 14:17:16 +0200 Julien Cristau jcris...@debian.org wrote: On Wed, Aug 12, 2015 at 13:54:19 +0200, Laurent Bigonville wrote: Package: x11-common Followup-For: Bug #759518 Hi, Yet another version of this patch. I guess it makes more sense to use the full path of the alternative if we are testing that it exits just the line before. FWIW I'm not convinced that this is a bug, nor something we need to change. Testing for the existence of an executable with the full path and then relying on the PATH looks like a bug to me. Printing the name of the executable might be indeed seen as something cosmetic, that's true. I don't think that adding the call to realpath is making the code more difficult to read though. Cheers, Laurent Bigonville
Bug#759518: x11-common: Print the real name of the executable instead of x-session-manager
On Wed, Aug 12, 2015 at 13:54:19 +0200, Laurent Bigonville wrote: Package: x11-common Followup-For: Bug #759518 Hi, Yet another version of this patch. I guess it makes more sense to use the full path of the alternative if we are testing that it exits just the line before. FWIW I'm not convinced that this is a bug, nor something we need to change. Cheers, Julien signature.asc Description: Digital signature
Bug#759518: x11-common: Print the real name of the executable instead of x-session-manager
Package: x11-common Followup-For: Bug #759518 Hi, Yet another version of this patch. I guess it makes more sense to use the full path of the alternative if we are testing that it exits just the line before. Cheers, Laurent Bigonville -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.0.0-2-amd64 (SMP w/8 CPU cores) Locale: LANG=fr_BE.utf8, LC_CTYPE=fr_BE.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages x11-common depends on: ii debconf [debconf-2.0] 1.5.57 ii lsb-base 4.1+Debian13+nmu1 x11-common recommends no packages. x11-common suggests no packages. -- debconf information excluded diff -Nru xorg-7.7+9/debian/local/Xsession.d/50x11-common_determine-startup xorg-7.7+9bigon1/debian/local/Xsession.d/50x11-common_determine-startup --- xorg-7.7+9/debian/local/Xsession.d/50x11-common_determine-startup 2013-09-26 01:24:29.0 +0200 +++ xorg-7.7+9bigon1/debian/local/Xsession.d/50x11-common_determine-startup 2015-08-12 13:09:31.0 +0200 @@ -26,11 +26,11 @@ # default session manager, window manager, and terminal emulator. if [ -z $STARTUP ]; then if [ -x /usr/bin/x-session-manager ]; then -STARTUP=x-session-manager +STARTUP=$(readlink -e /usr/bin/x-session-manager) elif [ -x /usr/bin/x-window-manager ]; then -STARTUP=x-window-manager +STARTUP=$(readlink -e /usr/bin/x-window-manager) elif [ -x /usr/bin/x-terminal-emulator ]; then -STARTUP=x-terminal-emulator +STARTUP=$(readlink -e /usr/bin/x-terminal-emulator) fi fi
Bug#759518: x11-common: Print the real name of the executable instead of x-session-manager
tag 759518 + patch thanks Hi, Is a patch like this acceptable? Cheers, Laurent Bigonvillediff -Nru xorg-7.7+7/debian/local/Xsession.d/50x11-common_determine-startup xorg-7.7+7bigon1/debian/local/Xsession.d/50x11-common_determine-startup --- xorg-7.7+7/debian/local/Xsession.d/50x11-common_determine-startup 2013-09-26 01:24:29.0 +0200 +++ xorg-7.7+7bigon1/debian/local/Xsession.d/50x11-common_determine-startup 2014-09-23 21:17:27.0 +0200 @@ -26,11 +26,11 @@ # default session manager, window manager, and terminal emulator. if [ -z $STARTUP ]; then if [ -x /usr/bin/x-session-manager ]; then -STARTUP=x-session-manager +STARTUP=$(basename $(readlink /etc/alternatives/x-session-manager) 2/dev/null) elif [ -x /usr/bin/x-window-manager ]; then -STARTUP=x-window-manager +STARTUP=$(basename $(readlink /etc/alternatives/x-window-manager) 2/dev/null) elif [ -x /usr/bin/x-terminal-emulator ]; then -STARTUP=x-terminal-emulator +STARTUP=$(basename $(readlink /etc/alternatives/x-terminal-emulator) 2/dev/null) fi fi
Bug#759518: x11-common: Print the real name of the executable instead of x-session-manager
Le Tue, 23 Sep 2014 21:25:53 +0200, Laurent Bigonville bi...@debian.org a écrit : tag 759518 + patch thanks Hi, Is a patch like this acceptable? Cheers, Laurent Bigonville Bahh wrong copy/paste I guess we should use /usr/bin instead of /etc/alternatives/ I guess diff -Nru xorg-7.7+7/debian/local/Xsession.d/50x11-common_determine-startup xorg-7.7+7bigon1/debian/local/Xsession.d/50x11-common_determine-startup --- xorg-7.7+7/debian/local/Xsession.d/50x11-common_determine-startup 2013-09-26 01:24:29.0 +0200 +++ xorg-7.7+7bigon1/debian/local/Xsession.d/50x11-common_determine-startup 2014-09-23 21:17:27.0 +0200 @@ -26,11 +26,11 @@ # default session manager, window manager, and terminal emulator. if [ -z $STARTUP ]; then if [ -x /usr/bin/x-session-manager ]; then -STARTUP=x-session-manager +STARTUP=$(basename $(readlink -e /usr/bin/x-session-manager) 2/dev/null) elif [ -x /usr/bin/x-window-manager ]; then -STARTUP=x-window-manager +STARTUP=$(basename $(readlink -e /usr/bin/x-window-manager) 2/dev/null) elif [ -x /usr/bin/x-terminal-emulator ]; then -STARTUP=x-terminal-emulator +STARTUP=$(basename $(readlink -e /usr/bin/x-terminal-emulator) 2/dev/null) fi fi
Bug#759518: x11-common: Print the real name of the executable instead of x-session-manager
affects 759518 + apport thanks Hi, Apparently this could actually affects apport (/usr/bin/apport-bug) that actually try to determine the type of session the user is running by grepping the process list. Cheers, Laurent Bigonville -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140923002154.01a72...@fornost.bigon.be
Bug#759518: x11-common: Print the real name of the executable instead of x-session-manager
Package: x11-common Version: 1:7.7+7 Severity: wishlist Hi, Currently, when starting a session, x-session-manager (the alternative symlink) is shown in the process list instead of the real name of the executable. I guess the symlink should be followed. Cheers, Laurent Bigonville -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.14-2-amd64 (SMP w/8 CPU cores) Locale: LANG=fr_BE.utf8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages x11-common depends on: ii debconf [debconf-2.0] 1.5.53 ii lsb-base 4.1+Debian13 x11-common recommends no packages. x11-common suggests no packages. -- debconf information: x11-common/xwrapper/allowed_users: Console Users Only x11-common/xwrapper/actual_allowed_users: console -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20140827231323.8722.31082.report...@fornost.bigon.be
