[jira] [Commented] (DELTASPIKE-165) Exception handlers: support handling unexpected exceptions
[
https://issues.apache.org/jira/browse/DELTASPIKE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255488#comment-13255488
]
Gerhard Petracek commented on DELTASPIKE-165:
-
please add new use-cases to
https://cwiki.apache.org/confluence/display/DeltaSpike/Exception+Control+Drafts
Exception handlers: support handling unexpected exceptions
--
Key: DELTASPIKE-165
URL: https://issues.apache.org/jira/browse/DELTASPIKE-165
Project: DeltaSpike
Issue Type: Improvement
Components: ExceptionControl-Module
Reporter: Ivo Maixner
Assignee: Gerhard Petracek
Provide a way to handle exceptions not handled by any other handler.
Currently, a handler like this:
public void unexpectedException(@Handles CaughtExceptionThrowable event) {
if (!event.isMarkedHandled()) {
log.error(Unexpected exception, event.getException());
messages.error(new BundleKey(MESSAGE_BUNDLE, unexpected.exception));
}
}
gets in the way when there are other handlers which respond to non-root-cause
exceptions.
Some ideas:
- an UnhandledException event fired as a last chance to handle it before
re-throwing it as unhandled
- a third traversal type - after BREADTH_FIRST and DEPTH_FIRST
See https://community.jboss.org/thread/198408
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-159) unit and integration tests for @ExceptionHandler
[ https://issues.apache.org/jira/browse/DELTASPIKE-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254462#comment-13254462 ] Gerhard Petracek commented on DELTASPIKE-159: - imo it doesn't make sense to resolve an issue which is ~40% done and to create a new one with the same content. unit and integration tests for @ExceptionHandler Key: DELTASPIKE-159 URL: https://issues.apache.org/jira/browse/DELTASPIKE-159 Project: DeltaSpike Issue Type: Sub-task Components: Core, ExceptionControl-Module, Tests Reporter: Gerhard Petracek Assignee: Jason Porter Fix For: 0.2-incubating -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-151) Provide lookup method with Map result
[ https://issues.apache.org/jira/browse/DELTASPIKE-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248647#comment-13248647 ] Gerhard Petracek commented on DELTASPIKE-151: - that sounds like a feature which is very specific to camel - imo we need a discussion on the mailing list before we add it. Provide lookup method with Map result - Key: DELTASPIKE-151 URL: https://issues.apache.org/jira/browse/DELTASPIKE-151 Project: DeltaSpike Issue Type: Improvement Components: Core Affects Versions: 0.2-incubating Reporter: Łukasz Dywicki Assignee: Gerhard Petracek Attachments: DELTASPIKE-151.diff Currently BeanProvider do not support lookups with Map result. In my case I create a adapter from Camel registry object to CDI bean registry. Camel uses different kind of lookups when needed: - by name (when type is unknown) - by type (for one instance) - by name and type - by type, with names Second operation is used to collect for example all instances of given type (all Endpoint, Tracer implementations registered). Names are then used to get returned instances in correct places. Camel is container agnostic so we cannot rely on CDI features in all places. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-145) autom. check of license header in test files
[ https://issues.apache.org/jira/browse/DELTASPIKE-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245852#comment-13245852 ] Gerhard Petracek commented on DELTASPIKE-145: - as a first step i created https://builds.apache.org/view/A-F/view/DeltaSpike/job/DeltaSpike%20RAT-Check/ autom. check of license header in test files Key: DELTASPIKE-145 URL: https://issues.apache.org/jira/browse/DELTASPIKE-145 Project: DeltaSpike Issue Type: Bug Components: Tests Affects Versions: 0.1-incubating Reporter: Gerhard Petracek Assignee: Mark Struberg Priority: Critical Fix For: 0.2-incubating recently lincoln committed 2 very trivial test files with the wrong license header (looks like a wrong template in his ide). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-130) Remove custom ProjectStageProducer logic
[ https://issues.apache.org/jira/browse/DELTASPIKE-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239924#comment-13239924 ] Gerhard Petracek commented on DELTASPIKE-130: - the original need was different, however, as you see it would even allow what you have in mind. please create a new jira issue, if you have a concrete use-case which isn't possible with the current approach. otherwise we can re-visit it as soon as it is needed. Remove custom ProjectStageProducer logic Key: DELTASPIKE-130 URL: https://issues.apache.org/jira/browse/DELTASPIKE-130 Project: DeltaSpike Issue Type: Improvement Components: Core Affects Versions: 0.1-incubating Reporter: Jason Porter Assignee: Gerhard Petracek Priority: Minor Fix For: 0.2-incubating Right now we have the ability to register a custom ProjectStageProducer which then overrides the default one in DeltaSpike. I don't think this is really necessary and our default ProjectStageProducer should be able to pick up any custom stages and use them accordingly. The extra configuration is cool, but I think at the end of the day it's not necessary. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-62) Discuss security module
[ https://issues.apache.org/jira/browse/DELTASPIKE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238925#comment-13238925 ] Gerhard Petracek commented on DELTASPIKE-62: i think it fits to part 3 of https://cwiki.apache.org/confluence/display/DeltaSpike/Security+Module+Drafts Discuss security module --- Key: DELTASPIKE-62 URL: https://issues.apache.org/jira/browse/DELTASPIKE-62 Project: DeltaSpike Issue Type: Sub-task Components: Security-Module Affects Versions: 0.1-incubating Reporter: Dan Allen Assignee: Shane Bryzak Fix For: 0.2-incubating Application security can be extremely confusing and frustrating, especially for Java EE developers. Yet, it's an absolute requirement for nearly every application. An integration with a strong security framework is desperately needed. DeltaSpike could offer a module that makes security very approachable and integrate well with CDI and other Java EE technologies. Apache Shiro [1] appears to be an ideal candidate. The goals for the project seem to align perfectly with this need, as Les explains in this article [2]. Apache Shiro has many things going for it that make it a good match for DeltaSpike: * a top level Apache project * actively developed * mature (nearly a decade) * pluggable extensible (the key for CDI integration) * works in web, ejb *and* java se environments * supports all aspects of security (authentication, authorization, permissions, certificates, ciphers) * easy to use * subjective bonus: has a cool name and logo It seems like Shiro could really use some CDI integration to make it even simpler. (Several integrations have already been explored [3]). We can start with some producers and then build on the declarative functionality that has previously been explored in Seam. [1] http://shiro.apache.org/index.html [2] http://www.infoq.com/articles/apache-shiro [3] http://shiro.apache.org/integration.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-114) @ConfigProperty based on ConfigResolver
[
https://issues.apache.org/jira/browse/DELTASPIKE-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224739#comment-13224739
]
Gerhard Petracek commented on DELTASPIKE-114:
-
optional support for:
@ConfigProperty(name = pool_size, eager = true, converter =
StringToIntegerConverter.class)
public @interface PoolSize
{
}
@Inject
@PoolSize
private int configuredPoolSize;
eager should be true by default - the configured value gets converted during
bootstrapping (if the value has an invalid format the bootstrapping process
fails).
if eager is false, the configured value will be converted directly before the
injection (e.g. for values stored in dynamic config-sources).
@ConfigProperty based on ConfigResolver
---
Key: DELTASPIKE-114
URL: https://issues.apache.org/jira/browse/DELTASPIKE-114
Project: DeltaSpike
Issue Type: New Feature
Components: Core
Affects Versions: 0.1-incubating
Reporter: gonzalad
Assignee: Gerhard Petracek
Fix For: 0.2-incubating
@Produces
public MyBean produceMyBean(@ConfigProperty(propertyA) String propertyA,
@ConfigProperty(propertyB) String propertyB)
//...
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-109) weekly ci builds for different versions of owb and weld
[ https://issues.apache.org/jira/browse/DELTASPIKE-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13220133#comment-13220133 ] Gerhard Petracek commented on DELTASPIKE-109: - weekly builds added for: DeltaSpike with OWB 1.1.1 DeltaSpike with OWB 1.1.2 DeltaSpike with OWB 1.1.3 DeltaSpike with Weld 1.1.3 DeltaSpike with Weld 1.1.3.SP1 DeltaSpike with Weld 1.1.4 DeltaSpike with Weld 1.1.5 DeltaSpike with Weld 1.1.5.AS71 weekly ci builds for different versions of owb and weld --- Key: DELTASPIKE-109 URL: https://issues.apache.org/jira/browse/DELTASPIKE-109 Project: DeltaSpike Issue Type: Task Affects Versions: 0.1-incubating Reporter: Gerhard Petracek Assignee: Gerhard Petracek Fix For: 0.2-incubating to detect issues early we need ci builds for more versions than just the default versions in our build config -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-109) weekly ci builds for different versions of owb and weld
[ https://issues.apache.org/jira/browse/DELTASPIKE-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13220135#comment-13220135 ] Gerhard Petracek commented on DELTASPIKE-109: - daily builds for the current snapshots: DeltaSpike with OWB 1.1.4-SNAPSHOT DeltaSpike with Weld 1.1.6-SNAPSHOT DeltaSpike with Weld 2.0.0-SNAPSHOT weekly ci builds for different versions of owb and weld --- Key: DELTASPIKE-109 URL: https://issues.apache.org/jira/browse/DELTASPIKE-109 Project: DeltaSpike Issue Type: Task Affects Versions: 0.1-incubating Reporter: Gerhard Petracek Assignee: Gerhard Petracek Fix For: 0.2-incubating to detect issues early we need ci builds for more versions than just the default versions in our build config -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-70) @Secured
[ https://issues.apache.org/jira/browse/DELTASPIKE-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201899#comment-13201899 ] Gerhard Petracek commented on DELTASPIKE-70: i pushed a first draft to https://github.com/os890/DS_Discuss/tree/DS70 - as soon as we found the issue with arquillian and the v0.1 release is done, i'll push it. @Secured Key: DELTASPIKE-70 URL: https://issues.apache.org/jira/browse/DELTASPIKE-70 Project: DeltaSpike Issue Type: New Feature Components: Security-Module Affects Versions: 0.1-incubating Reporter: Gerhard Petracek Assignee: Gerhard Petracek Fix For: 0.2-incubating we agreed on implementing it based on DELTASPIKE-69 (see http://s.apache.org/jT ) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-64) review and discuss @Secured
[
https://issues.apache.org/jira/browse/DELTASPIKE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196833#comment-13196833
]
Gerhard Petracek commented on DELTASPIKE-64:
small addition (if we agree on the basic concept):
i would suggest to change the parameter (of
AccessDecisionVoter#checkPermission) to a context (e.g. the
AccessDecisionVoterContext itself) which provides access to the current
InvocationContext and which allows to add the violations in an easier manner.
review and discuss @Secured
---
Key: DELTASPIKE-64
URL: https://issues.apache.org/jira/browse/DELTASPIKE-64
Project: DeltaSpike
Issue Type: Sub-task
Components: Security-Module
Affects Versions: 0.1
Reporter: Gerhard Petracek
Assignee: Gerhard Petracek
Fix For: 0.2
this feature is listed at
https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking and
part of myfaces codi-core.
@Secured is a simple cdi interceptor annotation which allows to filter method
calls to cdi beans based on custom rules.
it's possible to specify 1-n custom implementations of AccessDecisionVoter.
those voters get invoked before the call is forwarded to the target method (a
voter is a cdi bean which gets resolved by its concrete type). an
implementation of AccessDecisionVoter can access the InvocationContext to get
further details about the target method to trigger the corresponding
evaluation. as a result voters return a set of violations
(SecurityViolation). if there is no violation, the target-method gets
executed. if there is at least one violation, an AccessDeniedException will
be thrown.
in addition an AccessDecisionVoterContext is needed to detect if there is an
ongoing security check (e.g. it's possible to use it in a custom scope to
avoid that a security check postpones the expiration).
(in myfaces codi it's also used to secure views via view-configs, however, we
will exclude this part for now.)
users can use those simple and generic apis to implement their own access
control and it will get used by other deltaspike modules automatically (if
they use the security-api).
(in an AccessDecisionVoter it's possible to integrate 3rd party
security-frameworks.)
usage of @Secured:
//...
@Secured({MyAccessDecisionVoter1.class, MyAccessDecisionVoter2.class})
public class SecuredBean
{
//...
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-24) Deactivatable
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190671#comment-13190671 ] Gerhard Petracek commented on DELTASPIKE-24: 3rd party extensions can use it already by loading all ClassDeactivator implementations. currently they just can't use the helper which is used by deltaspike itself. Deactivatable - Key: DELTASPIKE-24 URL: https://issues.apache.org/jira/browse/DELTASPIKE-24 Project: DeltaSpike Issue Type: New Feature Components: Core Reporter: Gerhard Petracek Assignee: Mark Struberg Fix For: 0.1 original feature: https://issues.apache.org/jira/browse/EXTCDI-66 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-56) Add BeanManagerProvider.getRequiredBeanManager() method
[ https://issues.apache.org/jira/browse/DELTASPIKE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190799#comment-13190799 ] Gerhard Petracek commented on DELTASPIKE-56: +1 ! for moving this discussion to the mailing list. Add BeanManagerProvider.getRequiredBeanManager() method --- Key: DELTASPIKE-56 URL: https://issues.apache.org/jira/browse/DELTASPIKE-56 Project: DeltaSpike Issue Type: Improvement Components: Core Reporter: Christian Kaltepoth Assignee: Gerhard Petracek Priority: Minor Attachments: DELTASPIKE-56.patch While reviewing the implementation of BeanManagerProvider I saw that getBeanManager() may return null in some rare circumstances. Unfortunately this forces everyone calling this method to check the result for null. I think most code calling the method absolutely requires the BeanManager and cannot proceed without it. Therefore it would be nice to have some alternative getBeanManager() method that doesn't return null if the BeanManager is not available but instead throws a meaningful runtime exception. That's what Solder does per default. Calling Solder's BeanManagerLocator.getBeanManager() without a BeanManager being available will result in a BeanManagerUnavailableException. The attached patch adds a method getRequiredBeanManager() to the BeanManagerProvider implementing this behavior. I'm not sure if this minor thing should be discussed on the mailing list. If you think this should be discussed, please let me know, then I'll start a topic on deltaspike-dev. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-53) annotation literals for std. cdi annotations
[ https://issues.apache.org/jira/browse/DELTASPIKE-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190166#comment-13190166 ] Gerhard Petracek commented on DELTASPIKE-53: i added further literals and now we have: - AlternativeLiteral - AnyLiteral - ApplicationScopedLiteral - ConversationScopedLiteral - DefaultLiteral - DependentScopeLiteral - ModelLiteral - NamedLiteral - NewLiteral - RequestedScopeLiteral - SessionScopeLiteral - SpecializesLiteral - TypedLiteral annotation literals for std. cdi annotations Key: DELTASPIKE-53 URL: https://issues.apache.org/jira/browse/DELTASPIKE-53 Project: DeltaSpike Issue Type: New Feature Components: Core Reporter: Gerhard Petracek Assignee: Gerhard Petracek -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-45) AnnotatedTypeBuilder
[ https://issues.apache.org/jira/browse/DELTASPIKE-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190178#comment-13190178 ] Gerhard Petracek commented on DELTASPIKE-45: AnnotationRedefiner removed based on http://s.apache.org/vAB AnnotatedTypeBuilder Key: DELTASPIKE-45 URL: https://issues.apache.org/jira/browse/DELTASPIKE-45 Project: DeltaSpike Issue Type: New Feature Components: Core Reporter: Jason Porter Assignee: Jason Porter Fix For: 0.1 Attachments: DELTASPIKE-45_reduced_visibility.git.patch, DELTASPIKE-45_reduced_visibility.patch we agreed on it - see http://s.apache.org/VuD -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-45) AnnotatedTypeBuilder
[ https://issues.apache.org/jira/browse/DELTASPIKE-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188301#comment-13188301 ] Gerhard Petracek commented on DELTASPIKE-45: i haven't committed it because we usually don't just commit something and start a discussion afterwards. but i could have just pushed my local branch to an external repo and merge it as usual after we agreed on it and before pushing it to our central repo. i guess it was just automatism. AnnotatedTypeBuilder Key: DELTASPIKE-45 URL: https://issues.apache.org/jira/browse/DELTASPIKE-45 Project: DeltaSpike Issue Type: New Feature Components: Core Reporter: Jason Porter Assignee: Jason Porter Fix For: 0.1 Attachments: DELTASPIKE-45_reduced_visibility.git.patch, DELTASPIKE-45_reduced_visibility.patch we agreed on it - see http://s.apache.org/VuD -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-35) Create testing structure
[ https://issues.apache.org/jira/browse/DELTASPIKE-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13185551#comment-13185551 ] Gerhard Petracek commented on DELTASPIKE-35: imo we can close it and mark opens a new issue for the new approach (autom. copy of tests to the integration-test module to execute the tests in different containers to ensure that the cdi integration won't cause an issue and to avoid cp of tests) Create testing structure Key: DELTASPIKE-35 URL: https://issues.apache.org/jira/browse/DELTASPIKE-35 Project: DeltaSpike Issue Type: Task Components: Core Affects Versions: 0.1-SNAPSHOT Reporter: Jason Porter Assignee: Jason Porter Fix For: 0.1-SNAPSHOT -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-41) add java-se cdi-example
[ https://issues.apache.org/jira/browse/DELTASPIKE-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182390#comment-13182390 ] Gerhard Petracek commented on DELTASPIKE-41: BeanProvider example finished add java-se cdi-example --- Key: DELTASPIKE-41 URL: https://issues.apache.org/jira/browse/DELTASPIKE-41 Project: DeltaSpike Issue Type: Task Reporter: Gerhard Petracek Assignee: Gerhard Petracek -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-18) unit and integration tests for BeanManagerProvider
[ https://issues.apache.org/jira/browse/DELTASPIKE-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13182388#comment-13182388 ] Gerhard Petracek commented on DELTASPIKE-18: integration test finished unit and integration tests for BeanManagerProvider -- Key: DELTASPIKE-18 URL: https://issues.apache.org/jira/browse/DELTASPIKE-18 Project: DeltaSpike Issue Type: Sub-task Components: Core Reporter: Gerhard Petracek Assignee: Mark Struberg we need tests for: - after a container is bootstrapped, BeanManagerProvider.getInstance().getBeanManager() has to return a bm - usage in shared lib scenarios - shutdown of a container - cleanup has to be successful -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-21) ProjectStage
[ https://issues.apache.org/jira/browse/DELTASPIKE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13178243#comment-13178243 ] Gerhard Petracek commented on DELTASPIKE-21: ProjectStageProducer imported ProjectStage Key: DELTASPIKE-21 URL: https://issues.apache.org/jira/browse/DELTASPIKE-21 Project: DeltaSpike Issue Type: New Feature Components: Core Reporter: Gerhard Petracek Assignee: Mark Struberg Fix For: 0.1-SNAPSHOT original feature: https://issues.apache.org/jira/browse/EXTCDI-9 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-40) add project name as prefix to artifact-ids
[ https://issues.apache.org/jira/browse/DELTASPIKE-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13177985#comment-13177985 ] Gerhard Petracek commented on DELTASPIKE-40: it's very important to have a prefix. otherwise you could get name clashes if other libs don't care about it as well and have e.g. a jar with the name core-api. furthermore, you would have to open a jar file to see to which lib it belongs. add project name as prefix to artifact-ids -- Key: DELTASPIKE-40 URL: https://issues.apache.org/jira/browse/DELTASPIKE-40 Project: DeltaSpike Issue Type: Task Components: Core Reporter: Gerhard Petracek Assignee: Gerhard Petracek -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-36) review and discuss ConfiguredValueResolver
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176957#comment-13176957 ] Gerhard Petracek commented on DELTASPIKE-36: https://git-wip-us.apache.org/repos/asf?p=incubator-deltaspike.git;a=commit;h=fb0131106481f0b9a8fdc13b9879a5482219c736 https://git-wip-us.apache.org/repos/asf?p=incubator-deltaspike.git;a=commit;h=81170a8b0e72eb7d3a45ace61b0443503bce9333 ... is a completely new and simple but flexible implementation which illustrates an easier but very pluggable approach which allows different config-sources as well as re-ordering existing config-sources. review and discuss ConfiguredValueResolver -- Key: DELTASPIKE-36 URL: https://issues.apache.org/jira/browse/DELTASPIKE-36 Project: DeltaSpike Issue Type: Sub-task Components: Core Reporter: Gerhard Petracek Assignee: Gerhard Petracek for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container. an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-36) config-service
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176342#comment-13176342 ] Gerhard Petracek commented on DELTASPIKE-36: in myfaces codi it's handled via: ConfiguredValueResolver, ConfiguredValueDescriptor and internally it uses the Aggregatable api to support multiple values. a ConfiguredValueResolver can be configured via the std. spi mechanism provided by java1.6+. (with @InvocationOrder it's possible to define an order) config-service -- Key: DELTASPIKE-36 URL: https://issues.apache.org/jira/browse/DELTASPIKE-36 Project: DeltaSpike Issue Type: New Feature Components: Core Reporter: Gerhard Petracek Assignee: Gerhard Petracek for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container. an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-36) review and discuss ConfiguredValueResolver
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176347#comment-13176347 ] Gerhard Petracek commented on DELTASPIKE-36: we could think about using the config approach used by owb. instead of using Deactivatable and @InvocationOrder for 1-n implementations of ConfiguredValueResolver, there would be only one implementation which has to be configured via a properties file and with configuration.ordinal a custom config can overrule the default impl. advantage: + there is only one active impl of the service + no need to aggregate the result of multiple service implementations disadvantage: - the default impl. can't be re-used easily if a custom impl. is only responsible for some but not all configured values or a custom impl. allows to overrule the default config-source if there are configured values in a custom config-source - configuration.ordinal isn't type-safe - configuration.ordinal is an additional mechanism (@InvocationOrder is also used for ordering other artifacts like phase-listeners,...) review and discuss ConfiguredValueResolver -- Key: DELTASPIKE-36 URL: https://issues.apache.org/jira/browse/DELTASPIKE-36 Project: DeltaSpike Issue Type: Task Components: Core Reporter: Gerhard Petracek Assignee: Gerhard Petracek for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container. an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-36) review and discuss ConfiguredValueResolver
[
https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176350#comment-13176350
]
Gerhard Petracek commented on DELTASPIKE-36:
if we agree on a manual implementation, we can fix the first disadvantage.
e.g .
public class CustomConfiguredValueResolver implements ConfiguredValueResolver
{
@Delegate //gets injected manually as soon as it is needed during the
bootstrapping process of the cdi container
private ConfiguredValueResolver defaultConfiguredValueResolver;
//...
}
- a custom implementation can delegate to the default implementation without
knowing it
review and discuss ConfiguredValueResolver
--
Key: DELTASPIKE-36
URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
Project: DeltaSpike
Issue Type: Task
Components: Core
Reporter: Gerhard Petracek
Assignee: Gerhard Petracek
for several features we need a pluggable config-service which has to be
independent of cdi because it's needed e.g. during the bootstrapping process
of a cdi container.
an implementation is aware of a config source like property-files or xml
files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-20) move util methods to CdiUtils
[ https://issues.apache.org/jira/browse/DELTASPIKE-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175348#comment-13175348 ] Gerhard Petracek commented on DELTASPIKE-20: if you provide a name, type,... and there is no cdi bean for it the behaviour is different. optionalBeanAllowed == false cdiBeanFound == false - throw an exception optionalBeanAllowed == true cdiBeanFound == false - return null the alternative would be to return null and every caller has to do the exception part (if a cdi bean isn't optional) - we will see different exceptions for the same reason. move util methods to CdiUtils - Key: DELTASPIKE-20 URL: https://issues.apache.org/jira/browse/DELTASPIKE-20 Project: DeltaSpike Issue Type: Sub-task Components: Core Reporter: Gerhard Petracek Assignee: Mark Struberg public T T getContextualReference(ClassT type, boolean optionalBeanAllowed, Annotation... qualifiers) public T T getContextualReference(String name, boolean optionalBeanAllowed, ClassT targetType) public T T getContextualReference(BeanT bean, boolean optionalBeanAllowed, ClassT targetType) public T ListT getContextualReferences(ClassT type, boolean optionalBeanAllowed, Annotation... qualifiers) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-1) initial jira setup
[ https://issues.apache.org/jira/browse/DELTASPIKE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13167953#comment-13167953 ] Gerhard Petracek commented on DELTASPIKE-1: --- notifications: Administration - Notification Schemes - DeltaSpike Scheme created (copy of _Default Notification Scheme_) - click on the scheme - Add notification - select events (issue created - issue moved) and select Single Email Address select the project - notifications - actions - use a different scheme - select the new scheme issue types: select the project - issue types - actions - use a different scheme - Apache Default Issue Type Scheme thx to gmcdonald initial jira setup -- Key: DELTASPIKE-1 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1 Project: DeltaSpike Issue Type: Task Reporter: Gerhard Petracek Assignee: Gerhard Petracek - issue types - workflow - roles -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
