[Java DB - testing] Error nightly trunk (rev 1798290)

2017-06-10 Thread ingemar . aberg
Java DB testing and reporting infrastructure.

Error nightly trunk (rev 1798290)

There were execution errors and/or timeouts.
There were at least 29 failures.



[jira] [Commented] (DERBY-6938) Obtain cardinality estimates and true estimates for base tables as well as for intermediate results for queries involving multiple joins.

2017-06-10 Thread Bryan Pendleton (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045796#comment-16045796
 ] 

Bryan Pendleton commented on DERBY-6938:


I'm not certain I understand the question. I suspect we may have to study the 
code, and perform some experiments, to determine the answer.

But we can start by looking at these resources, in addition to the 
documentation you mentioned:
*  https://wiki.apache.org/db-derby/LanguageOptimize
*  http://db.apache.org/derby/papers/optimizer.html

I looked at the explain.txt that you attached, but I'm not certain I am 
following your analysis.

I wonder if you might be able to annotate the explain.txt with your own 
comments, and point directly at the section of the explain output that is of 
particular interest to you, so that I can better understand the question you 
are asking.

Note that it is entirely possible that Derby's query optimizer is not as 
sophisticated as you think it may be. That is one of the reasons that this 
testing is so important: we need to understand where Derby's query optimizer is 
not considering all the information that is available to it when it makes its 
decisions.


>  Obtain cardinality estimates and true estimates for base tables as well as 
> for intermediate results for queries involving multiple joins. 
> ---
>
> Key: DERBY-6938
> URL: https://issues.apache.org/jira/browse/DERBY-6938
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
> Attachments: explain.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[Java DB - testing] Failure continuous trunk (rev 1798340)

2017-06-10 Thread ingemar . aberg
Java DB testing and reporting infrastructure.

Failure continuous trunk (rev 1798340)

There were 16 failures.



[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045717#comment-16045717
 ] 

Bryan Pendleton commented on DERBY-6935:


Thanks again for catching this. Can you re-check the latest commit and make 
sure it has the right tests? Then I think we can re-resolve this issue.

> Test Coverage for added features.
> -
>
> Key: DERBY-6935
> URL: https://issues.apache.org/jira/browse/DERBY-6935
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
> Attachments: moreCycleTests.diff, simpleTests_2.diff, simpleTests.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045716#comment-16045716
 ] 

ASF subversion and git services commented on DERBY-6935:


Commit 1798340 from [~bryanpendleton] in branch 'code/trunk'
[ https://svn.apache.org/r1798340 ]

DERBY-6935: Test coverage for added features

This patch was contributed by Harshvardhan Gupta (harshvardhan145 at gmail dot 
com)

The patch adds additional test cases for the new CYCLE-related features
of the identity column support.

> Test Coverage for added features.
> -
>
> Key: DERBY-6935
> URL: https://issues.apache.org/jira/browse/DERBY-6935
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
> Attachments: moreCycleTests.diff, simpleTests_2.diff, simpleTests.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Harshvardhan Gupta (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045702#comment-16045702
 ] 

Harshvardhan Gupta commented on DERBY-6935:
---

Bryan, Yes the 'moreCycleTests.diff' contains the missing tests, I had not 
synced from remote before adding more tests to IdentitySequenceTests.java, 
maybe that could have caused problems with the usual patch command.

> Test Coverage for added features.
> -
>
> Key: DERBY-6935
> URL: https://issues.apache.org/jira/browse/DERBY-6935
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
> Attachments: moreCycleTests.diff, simpleTests_2.diff, simpleTests.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (DERBY-6938) Obtain cardinality estimates and true estimates for base tables as well as for intermediate results for queries involving multiple joins.

2017-06-10 Thread Harshvardhan Gupta (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harshvardhan Gupta updated DERBY-6938:
--
Attachment: explain.txt

Hi Bryan,

I am attaching the explain plan of one of the queries from the dataset. I have 
doubts with regard to the scans performed for INFO_TYPE and TITLE tables and 
optimizer's estimated row count for those scans.

How in general is the estimated row count for scans as part of joins 
determined? 

I went through the link below but they do not cover the case when a join is 
specified 
http://db.apache.org/derby/docs/10.13/tuning/ctunstats849203.html


>  Obtain cardinality estimates and true estimates for base tables as well as 
> for intermediate results for queries involving multiple joins. 
> ---
>
> Key: DERBY-6938
> URL: https://issues.apache.org/jira/browse/DERBY-6938
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
> Attachments: explain.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Reopened] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Pendleton reopened DERBY-6935:


> Test Coverage for added features.
> -
>
> Key: DERBY-6935
> URL: https://issues.apache.org/jira/browse/DERBY-6935
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
> Attachments: moreCycleTests.diff, simpleTests_2.diff, simpleTests.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Pendleton updated DERBY-6935:
---
Attachment: moreCycleTests.diff

OK, I think I see what I did wrong with the 'patch' command before.

Vardhan, does the attached 'moreCycleTests.diff' look like the correct set of 
missing tests to you?

> Test Coverage for added features.
> -
>
> Key: DERBY-6935
> URL: https://issues.apache.org/jira/browse/DERBY-6935
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
> Attachments: moreCycleTests.diff, simpleTests_2.diff, simpleTests.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (DERBY-6936) Documentation for changes made as part of DERBY-6904

2017-06-10 Thread Bryan Pendleton (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Pendleton updated DERBY-6936:
---
Attachment: rrefsqlj81859.html
rrefsqlj37836.html
rrefsistabs22441.html
docs.diff

Attached are my proposed changes to the documentation, and the 3 resulting 
manual pages in HTML format.

Please proofread and let me know if you see any errors or have additional 
improvements you think we should make.

> Documentation for changes made as part of DERBY-6904
> 
>
> Key: DERBY-6936
> URL: https://issues.apache.org/jira/browse/DERBY-6936
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Bryan Pendleton
>Priority: Minor
> Attachments: docs.diff, rrefsistabs22441.html, rrefsqlj37836.html, 
> rrefsqlj81859.html
>
>
> Here are the changes I believe we need for this task:
> 1) For DERBY-6904, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsqlj81859.html to document the 
> syntax and behavior of using ALTER TABLE to change the CYCLE option for a 
> generated column.
> 2) For DERBY-6905, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsistabs22441.html to document 
> the new AUTOINCREMENTCYCLE column that appears in SYSCOLUMNS
> 3) For DERBY-6906, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsqlj37836.html to document 
> that a generated column spec can now explicitly state NO CYCLE
> I believe these are all the documentation changes that are necessary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (DERBY-6936) Documentation for changes made as part of DERBY-6904

2017-06-10 Thread Bryan Pendleton (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Pendleton reassigned DERBY-6936:
--

Assignee: Bryan Pendleton  (was: Harshvardhan Gupta)

> Documentation for changes made as part of DERBY-6904
> 
>
> Key: DERBY-6936
> URL: https://issues.apache.org/jira/browse/DERBY-6936
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Bryan Pendleton
>Priority: Minor
>
> Here are the changes I believe we need for this task:
> 1) For DERBY-6904, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsqlj81859.html to document the 
> syntax and behavior of using ALTER TABLE to change the CYCLE option for a 
> generated column.
> 2) For DERBY-6905, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsistabs22441.html to document 
> the new AUTOINCREMENTCYCLE column that appears in SYSCOLUMNS
> 3) For DERBY-6906, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsqlj37836.html to document 
> that a generated column spec can now explicitly state NO CYCLE
> I believe these are all the documentation changes that are necessary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045567#comment-16045567
 ] 

Bryan Pendleton commented on DERBY-6935:


I see now that I missed some of your tests when working with 
simpleTests_2.diff. I think the patch command must have skipped that file 
because I already had the DERBY-6904 changes to IdentitySequenceTests.java 
applied, and I did not notice.

I'm sorry!

Yes, please re-submit a new patch with the tests that I missed from 
simpleTests_2.

> Test Coverage for added features.
> -
>
> Key: DERBY-6935
> URL: https://issues.apache.org/jira/browse/DERBY-6935
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
> Attachments: simpleTests_2.diff, simpleTests.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045566#comment-16045566
 ] 

Bryan Pendleton commented on DERBY-6935:


Did we add tests covering the behavior of SYSCOLUMNS.AUTOINCREMENTCYCLE for a 
non-generated column?

If not, perhaps you could include a couple of such tests?


> Test Coverage for added features.
> -
>
> Key: DERBY-6935
> URL: https://issues.apache.org/jira/browse/DERBY-6935
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
> Attachments: simpleTests_2.diff, simpleTests.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045558#comment-16045558
 ] 

Bryan Pendleton commented on DERBY-6935:


OK, let me look more closely; I probably fumbled the "patch" command while 
working with the diffs.

Or, best: can you please attach a new diff to this issue that contains only the 
missing changes to IdentitySequenceTests.java?

Thanks!

> Test Coverage for added features.
> -
>
> Key: DERBY-6935
> URL: https://issues.apache.org/jira/browse/DERBY-6935
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
> Attachments: simpleTests_2.diff, simpleTests.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Harshvardhan Gupta (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045556#comment-16045556
 ] 

Harshvardhan Gupta commented on DERBY-6935:
---

No, the recent changes to IdentitySequenceTests.java do not seem to be included 
in 1797283.

> Test Coverage for added features.
> -
>
> Key: DERBY-6935
> URL: https://issues.apache.org/jira/browse/DERBY-6935
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
> Attachments: simpleTests_2.diff, simpleTests.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DERBY-6936) Documentation for changes made as part of DERBY-6904

2017-06-10 Thread Harshvardhan Gupta (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045554#comment-16045554
 ] 

Harshvardhan Gupta commented on DERBY-6936:
---

Sure Bryan, please go ahead with the changes.

> Documentation for changes made as part of DERBY-6904
> 
>
> Key: DERBY-6936
> URL: https://issues.apache.org/jira/browse/DERBY-6936
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
>
> Here are the changes I believe we need for this task:
> 1) For DERBY-6904, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsqlj81859.html to document the 
> syntax and behavior of using ALTER TABLE to change the CYCLE option for a 
> generated column.
> 2) For DERBY-6905, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsistabs22441.html to document 
> the new AUTOINCREMENTCYCLE column that appears in SYSCOLUMNS
> 3) For DERBY-6906, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsqlj37836.html to document 
> that a generated column spec can now explicitly state NO CYCLE
> I believe these are all the documentation changes that are necessary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045553#comment-16045553
 ] 

Bryan Pendleton commented on DERBY-6935:


Yes, I believe those were committed as part of Commit 1797283 for DERBY-6904.

Can you 'svn up' your sandbox and confirm whether or not you see those tests in 
the current head revision from Subversion?

> Test Coverage for added features.
> -
>
> Key: DERBY-6935
> URL: https://issues.apache.org/jira/browse/DERBY-6935
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
> Attachments: simpleTests_2.diff, simpleTests.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Harshvardhan Gupta (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045551#comment-16045551
 ] 

Harshvardhan Gupta commented on DERBY-6935:
---

Hi Bryan,

I added some catalog tests too in IdentitySequenceTests.java which are not 
included in this commit but included in the patch I attached earlier.

Thanks

> Test Coverage for added features.
> -
>
> Key: DERBY-6935
> URL: https://issues.apache.org/jira/browse/DERBY-6935
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
> Attachments: simpleTests_2.diff, simpleTests.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DERBY-6936) Documentation for changes made as part of DERBY-6904

2017-06-10 Thread Bryan Pendleton (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045546#comment-16045546
 ] 

Bryan Pendleton commented on DERBY-6936:


Hi Vardhan, are you already working on this task? If not, I thought I would 
assign it to myself, and draft the documentation changes, and then you could 
review them and let me know if you see any mistakes or omissions? Thanks!

> Documentation for changes made as part of DERBY-6904
> 
>
> Key: DERBY-6936
> URL: https://issues.apache.org/jira/browse/DERBY-6936
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
>
> Here are the changes I believe we need for this task:
> 1) For DERBY-6904, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsqlj81859.html to document the 
> syntax and behavior of using ALTER TABLE to change the CYCLE option for a 
> generated column.
> 2) For DERBY-6905, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsistabs22441.html to document 
> the new AUTOINCREMENTCYCLE column that appears in SYSCOLUMNS
> 3) For DERBY-6906, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsqlj37836.html to document 
> that a generated column spec can now explicitly state NO CYCLE
> I believe these are all the documentation changes that are necessary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (DERBY-6936) Documentation for changes made as part of DERBY-6904

2017-06-10 Thread Bryan Pendleton (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Pendleton updated DERBY-6936:
---
Description: 
Here are the changes I believe we need for this task:

1) For DERBY-6904, we need to update 
https://db.apache.org/derby/docs/10.13/ref/rrefsqlj81859.html to document the 
syntax and behavior of using ALTER TABLE to change the CYCLE option for a 
generated column.

2) For DERBY-6905, we need to update 
https://db.apache.org/derby/docs/10.13/ref/rrefsistabs22441.html to document 
the new AUTOINCREMENTCYCLE column that appears in SYSCOLUMNS

3) For DERBY-6906, we need to update 
https://db.apache.org/derby/docs/10.13/ref/rrefsqlj37836.html to document that 
a generated column spec can now explicitly state NO CYCLE

I believe these are all the documentation changes that are necessary.

> Documentation for changes made as part of DERBY-6904
> 
>
> Key: DERBY-6936
> URL: https://issues.apache.org/jira/browse/DERBY-6936
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
>
> Here are the changes I believe we need for this task:
> 1) For DERBY-6904, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsqlj81859.html to document the 
> syntax and behavior of using ALTER TABLE to change the CYCLE option for a 
> generated column.
> 2) For DERBY-6905, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsistabs22441.html to document 
> the new AUTOINCREMENTCYCLE column that appears in SYSCOLUMNS
> 3) For DERBY-6906, we need to update 
> https://db.apache.org/derby/docs/10.13/ref/rrefsqlj37836.html to document 
> that a generated column spec can now explicitly state NO CYCLE
> I believe these are all the documentation changes that are necessary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (DERBY-6903) ALTER TABLE ALTER COLUMN resets CYCLE option of IDENTITY column

2017-06-10 Thread Bryan Pendleton (JIRA)

[ 
https://issues.apache.org/jira/browse/DERBY-6903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045543#comment-16045543
 ] 

Bryan Pendleton commented on DERBY-6903:


We've completed all our planned work for this item.

> ALTER TABLE ALTER COLUMN resets CYCLE option of IDENTITY column
> ---
>
> Key: DERBY-6903
> URL: https://issues.apache.org/jira/browse/DERBY-6903
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Affects Versions: 10.13.1.0
>Reporter: Bryan Pendleton
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
>
> Using ALTER TABLE with the SET INCREMENT BY or SET RESTART WITH
> options to make a change to a GENERATED ... BY IDENTITY column resets the 
> CYCLE option of that column to "off".
> Some test cases demonstrating this behavior were added as part of
> the DERBY-6852 change revision 1756287
> The problem occurs when the ALTER TABLE code drops and recreates
> the underlying SEQUENCE object, and does not preserve the CYCLE
> option of the underlying SEQUENCE object.
> I believe the correct behavior would be for the ALTER TABLE code
> to read the current CYCLE option of the underlying SEQUENCE object
> first, and then create the new SEQUENCE object with the same value
> for the CYCLE option.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (DERBY-6903) ALTER TABLE ALTER COLUMN resets CYCLE option of IDENTITY column

2017-06-10 Thread Bryan Pendleton (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-6903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Pendleton resolved DERBY-6903.

   Resolution: Fixed
Fix Version/s: 10.14.0.0

> ALTER TABLE ALTER COLUMN resets CYCLE option of IDENTITY column
> ---
>
> Key: DERBY-6903
> URL: https://issues.apache.org/jira/browse/DERBY-6903
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Affects Versions: 10.13.1.0
>Reporter: Bryan Pendleton
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
>
> Using ALTER TABLE with the SET INCREMENT BY or SET RESTART WITH
> options to make a change to a GENERATED ... BY IDENTITY column resets the 
> CYCLE option of that column to "off".
> Some test cases demonstrating this behavior were added as part of
> the DERBY-6852 change revision 1756287
> The problem occurs when the ALTER TABLE code drops and recreates
> the underlying SEQUENCE object, and does not preserve the CYCLE
> option of the underlying SEQUENCE object.
> I believe the correct behavior would be for the ALTER TABLE code
> to read the current CYCLE option of the underlying SEQUENCE object
> first, and then create the new SEQUENCE object with the same value
> for the CYCLE option.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (DERBY-6905) Enhance SYS.SYSCOLUMNS to report the CYCLE value for an IDENTITY column

2017-06-10 Thread Bryan Pendleton (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-6905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Pendleton resolved DERBY-6905.

   Resolution: Fixed
Fix Version/s: 10.14.0.0

We've completed all our planned work for this item

> Enhance SYS.SYSCOLUMNS to report the CYCLE value for an IDENTITY column
> ---
>
> Key: DERBY-6905
> URL: https://issues.apache.org/jira/browse/DERBY-6905
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Affects Versions: 10.13.1.0
>Reporter: Bryan Pendleton
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
>
> DERBY-6542 changed IDENTITY columns to build upon the underlying
> SEQUENCE objects. SEQUENCE objects can have a CYCLE option
> set for them, and as of DERBY-6852, the CYCLE option controls the
> behavior of the IDENTITY column that uses that SEQUENCE.
> It would be nice if SYS.SYSCOLUMNS would report the CYCLE option
> that is in effect for a IDENTITY column in that column's row in SYSCOLUMNS.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Pendleton resolved DERBY-6935.

   Resolution: Fixed
Fix Version/s: 10.14.0.0

We've completed all our planned work for this item.

> Test Coverage for added features.
> -
>
> Key: DERBY-6935
> URL: https://issues.apache.org/jira/browse/DERBY-6935
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Reporter: Harshvardhan Gupta
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
> Attachments: simpleTests_2.diff, simpleTests.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (DERBY-6906) Allow a GENERATED column to explicitly specify NO CYCLE

2017-06-10 Thread Bryan Pendleton (JIRA)

 [ 
https://issues.apache.org/jira/browse/DERBY-6906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Pendleton resolved DERBY-6906.

   Resolution: Fixed
Fix Version/s: 10.14.0.0

We've completed all our planned work for this item.

> Allow a GENERATED column to explicitly specify NO CYCLE
> ---
>
> Key: DERBY-6906
> URL: https://issues.apache.org/jira/browse/DERBY-6906
> Project: Derby
>  Issue Type: Sub-task
>  Components: SQL
>Affects Versions: 10.13.1.0
>Reporter: Bryan Pendleton
>Assignee: Harshvardhan Gupta
>Priority: Minor
> Fix For: 10.14.0.0
>
>
> DERBY-6852 added the ability for a GENERATED IDENTITY column
> to specify that it should have CYCLE behavior, utilizing the underlying
> CYCLE behavior of the SEQUENCE object.
> A column which does not wish to have CYCLE behavior is specified
> by omitting the the CYCLE keyword.
> It would be nice to allow a GENERATED IDENTITY column to
> explicitly specify that it should have NO CYCLE behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)