[Java DB - testing] Error continuous trunk (rev 1819103)

2017-12-22 Thread ingemar . aberg 
Java DB testing and reporting infrastructure.

Error continuous trunk (rev 1819103)

There were execution errors and/or timeouts.

[jira] [Commented] (DERBY-6945) Re-package Derby as a collection of jigsaw modules

2017-12-22 Thread Rick Hillegas (JIRA) 

[ 
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302156#comment-16302156
 ] 

Rick Hillegas commented on DERBY-6945:
--

Mostly it is localization resources which cause the test failure. Those are 
easy to fix. There is also an easily fixed overlap between derbyrun.jar and 
derbytools.jar:

{noformat}
org/apache/derby/iapi/tools straddles more than one jar file:
/Users/rhillegas/derby/mainline/trunk/jars/sane/derbyrun.jar
run.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derbytools.jar  
ToolUtils.class
{noformat}

However, there is a serious overlap between derby.jar and derbyclient.jar. The 
org.apache.derby.jdbc package contains client and engine classes which appear 
in the public api, namely, the jdbc drivers and the DataSources. Here are 
various ways to untangle this overlap:

1) Combine derby.jar and derbyclient.jar (and maybe derbyshared.jar) into a 
single big jar file. This will preserve the public api but it will bloat up the 
engine and client footprints.

2) Move org.apache.derby.jdbc out of both derby.jar and derbyclient.jar into 
derbyshared.jar. Again, this will preserve the public api. But it will create 
circular dependencies among these jar files.

3) Alter the public api by moving either the client org.apache.derby.jdbc or 
the engine org.apache.derby.jdbc into a separate package. This will maintain 
the current jar file boundaries. However, the imports of many applications will 
need to be re-adjusted and the applications will no longer run on Derby 10.15 
and earlier versions of Derby.

I would like to hear other people's opinions about how to untangle this mess.

Thanks.

> Re-package Derby as a collection of jigsaw modules
> --
>
> Key: DERBY-6945
> URL: https://issues.apache.org/jira/browse/DERBY-6945
> Project: Derby
>  Issue Type: Improvement
>Affects Versions: 10.13.1.2
>Reporter: Rick Hillegas
> Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff, 
> derby-6945-02-ab-newDerbySharedJar.diff, 
> derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff, 
> jdeps.out.tar
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider 
> re-packaging Derby as a set of jigsaw modules. This would result in a 
> different set of release artifacts. This might be a good opportunity to 
> address the Tomcat artifactory issues raised by issue DERBY-6944.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DERBY-6945) Re-package Derby as a collection of jigsaw modules

2017-12-22 Thread Rick Hillegas (JIRA) 

[ 
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302147#comment-16302147
 ] 

Rick Hillegas commented on DERBY-6945:
--

Here is the output from running the new regression test:

{noformat}
1) 
test_jarContents(org.apache.derbyTesting.functionTests.tests.lang.VetJigsawTest)junit.framework.AssertionFailedError:
 Jar files overlap!
org/apache/derby/iapi/tools straddles more than one jar file:
/Users/rhillegas/derby/mainline/trunk/jars/sane/derbyrun.jar
run.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derbytools.jar  
ToolUtils.class

org/apache/derby/jdbc straddles more than one jar file:
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
AutoloadedDriver$1.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
AutoloadedDriver.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
BasicEmbeddedConnectionPoolDataSource40.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
BasicEmbeddedDataSource40$1.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
BasicEmbeddedDataSource40$2.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
BasicEmbeddedDataSource40.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
BasicEmbeddedXADataSource40.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   Driver42.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbedPooledConnection$1.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbedPooledConnection.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbedXAConnection.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbedXAResource$1.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbedXAResource$2.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbedXAResource$3.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbedXAResource$4.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbedXAResource.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbeddedConnectionPoolDataSource.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbeddedConnectionPoolDataSource40.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbeddedConnectionPoolDataSourceInterface.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbeddedDataSource.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbeddedDataSource40.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbeddedDataSourceInterface.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbeddedDriver.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbeddedXADataSource.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbeddedXADataSource40.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
EmbeddedXADataSourceInterface.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
InternalDriver$1.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
InternalDriver$2.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
InternalDriver$3.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
InternalDriver$4.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
InternalDriver$5.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
InternalDriver$DaemonThreadFactory.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
InternalDriver$LoginCallable.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
InternalDriver.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   JDBC.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
ReferenceableDataSource.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
ResourceAdapterImpl$1.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
ResourceAdapterImpl.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
XAStatementControl.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
XATransactionState$1.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
XATransactionState$CancelXATransactionTask.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
XATransactionState$CleanupOrCancelMonitor.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derby.jar   
XATransactionState.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derbyclient.jar 
BasicClientConnectionPoolDataSource40.class
/Users/rhillegas/derby/mainline/trunk/jars/sane/derbyclient.jar

[jira] [Commented] (DERBY-6945) Re-package Derby as a collection of jigsaw modules

2017-12-22 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302146#comment-16302146
 ] 

ASF subversion and git services commented on DERBY-6945:


Commit 1819103 from [~rhillegas] in branch 'code/trunk'
[ https://svn.apache.org/r1819103 ]

DERBY-6945: Check in new regression test to verify that packages do not 
straddle jar files; commit derby-6945-03-aa-partitionTest.diff.

> Re-package Derby as a collection of jigsaw modules
> --
>
> Key: DERBY-6945
> URL: https://issues.apache.org/jira/browse/DERBY-6945
> Project: Derby
>  Issue Type: Improvement
>Affects Versions: 10.13.1.2
>Reporter: Rick Hillegas
> Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff, 
> derby-6945-02-ab-newDerbySharedJar.diff, 
> derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff, 
> jdeps.out.tar
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider 
> re-packaging Derby as a set of jigsaw modules. This would result in a 
> different set of release artifacts. This might be a good opportunity to 
> address the Tomcat artifactory issues raised by issue DERBY-6944.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (DERBY-6945) Re-package Derby as a collection of jigsaw modules

2017-12-22 Thread Rick Hillegas (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rick Hillegas updated DERBY-6945:
-
Attachment: derby-6945-03-aa-partitionTest.diff

> Re-package Derby as a collection of jigsaw modules
> --
>
> Key: DERBY-6945
> URL: https://issues.apache.org/jira/browse/DERBY-6945
> Project: Derby
>  Issue Type: Improvement
>Affects Versions: 10.13.1.2
>Reporter: Rick Hillegas
> Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff, 
> derby-6945-02-ab-newDerbySharedJar.diff, 
> derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff, 
> jdeps.out.tar
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider 
> re-packaging Derby as a set of jigsaw modules. This would result in a 
> different set of release artifacts. This might be a good opportunity to 
> address the Tomcat artifactory issues raised by issue DERBY-6944.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DERBY-6945) Re-package Derby as a collection of jigsaw modules

2017-12-22 Thread Rick Hillegas (JIRA) 

[ 
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302144#comment-16302144
 ] 

Rick Hillegas commented on DERBY-6945:
--

Attaching derby-6945-03-aa-partitionTest.diff. This patch adds a new regression 
test which verifies that packages do not straddle jar files. Right now the test 
is not wired into into its corresponding suite. That is because there are 
packages which straddle jar files.

Touches the following files:

-

A   
java/testing/org/apache/derbyTesting/functionTests/tests/lang/ZipFileTableFunction.java
A   
java/testing/org/apache/derbyTesting/functionTests/tests/lang/EnumeratorTableFunction.java
A   
java/testing/org/apache/derbyTesting/functionTests/tests/lang/VetJigsawTest.java

New test.

-

M   
java/build/org/apache/derbyBuild/lastgoodjarcontents/insane.derby.jar.lastcontents
M   
java/build/org/apache/derbyBuild/lastgoodjarcontents/insane.derbyTesting.jar.lastcontents
M   
java/build/org/apache/derbyBuild/lastgoodjarcontents/insane.derbyclient.jar.lastcontents
M   
java/build/org/apache/derbyBuild/lastgoodjarcontents/insane.derbynet.jar.lastcontents
M   
java/build/org/apache/derbyBuild/lastgoodjarcontents/insane.derbytools.jar.lastcontents
M   
java/build/org/apache/derbyBuild/lastgoodjarcontents/sane.derby.jar.lastcontents
M   
java/build/org/apache/derbyBuild/lastgoodjarcontents/sane.derbyTesting.jar.lastcontents
M   
java/build/org/apache/derbyBuild/lastgoodjarcontents/sane.derbyclient.jar.lastcontents
M   
java/build/org/apache/derbyBuild/lastgoodjarcontents/sane.derbynet.jar.lastcontents
M   
java/build/org/apache/derbyBuild/lastgoodjarcontents/sane.derbytools.jar.lastcontents

Jardriftcheck adjustments to account for the new test class.


> Re-package Derby as a collection of jigsaw modules
> --
>
> Key: DERBY-6945
> URL: https://issues.apache.org/jira/browse/DERBY-6945
> Project: Derby
>  Issue Type: Improvement
>Affects Versions: 10.13.1.2
>Reporter: Rick Hillegas
> Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff, 
> derby-6945-02-ab-newDerbySharedJar.diff, 
> derby-6945-02-ac-newDerbySharedJar.diff, jdeps.out.tar
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider 
> re-packaging Derby as a set of jigsaw modules. This would result in a 
> different set of release artifacts. This might be a good opportunity to 
> address the Tomcat artifactory issues raised by issue DERBY-6944.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Jenkins build is still unstable: Derby-JaCoCo #277

2017-12-22 Thread Apache Jenkins Server 
See