[jira] Commented: (DERBY-761) The reserved words list in the reference manual doesn't look uptodate
[ http://issues.apache.org/jira/browse/DERBY-761?page=comments#action_12365160 ] Satheesh Bandaram commented on DERBY-761: - I have reviewed the changes... I think this patch is ready to be committed. > The reserved words list in the reference manual doesn't look uptodate > - > > Key: DERBY-761 > URL: http://issues.apache.org/jira/browse/DERBY-761 > Project: Derby > Type: Bug > Components: Documentation > Reporter: Mamta A. Satoor > Attachments: derby761-2.diff, derby761-3.diff, derby761.diff, > rrefkeywords29722.html > > I looked at the 10.1 reference manual's reserved word list and noticed > keywords like BINARY, COALESCE missing from the list. Haven't checked the > list thoroughly to see what else might be missing but it would be good to fix > this for 10.2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-761) The reserved words list in the reference manual doesn't look uptodate
[ http://issues.apache.org/jira/browse/DERBY-761?page=comments#action_12365145 ] Mamta A. Satoor commented on DERBY-761: --- Satheesh, your list looks correct except for _DEFAULT. It should really be DEFAULT which is the reserved keyword. > The reserved words list in the reference manual doesn't look uptodate > - > > Key: DERBY-761 > URL: http://issues.apache.org/jira/browse/DERBY-761 > Project: Derby > Type: Bug > Components: Documentation > Reporter: Mamta A. Satoor > Attachments: derby761-2.diff, derby761.diff, rrefkeywords29722.html > > I looked at the 10.1 reference manual's reserved word list and noticed > keywords like BINARY, COALESCE missing from the list. Haven't checked the > list thoroughly to see what else might be missing but it would be good to fix > this for 10.2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-761) The reserved words list in the reference manual doesn't look uptodate
Mamta A. Satoor (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-761?page=comments#action_12365110 ] Mamta A. Satoor commented on DERBY-761: --- I am glad you are looking at the list too. I was surprised to see D and T in the TOKEN reserved words list. Here is what I see in sqlgrammar.jj But I don't see them in the reservedKeyword() so I guess D and T are not reserved words. Thanks for catching it. Eric, please take those off from your changes. I haven't looked at this closely, but note that "TS" is in the same category as "D" and "T". They're for timestamp, date, and time, respectively. So whatever happens to "D" and "T" should probably (I assume, having not investigated further) also occur for "TS". I.e. if you're going to remove "D" and "T", it seems (to me) that you should probably remove "TS", as well...? Army
[jira] Commented: (DERBY-761) The reserved words list in the reference manual doesn't look uptodate
[ http://issues.apache.org/jira/browse/DERBY-761?page=comments#action_12365115 ] Satheesh Bandaram commented on DERBY-761: - Here is the correct list... My previous list had GET_CURRENT_CONNECTION, it should have been GETCURRENTCONNECTION. ADD ALL ALLOCATE ALTER AND ANY ARE AS ASC ASSERTION AT AUTHORIZATION AVG BEGIN BETWEEN BIGINT BIT BOTH BY CASCADE CASCADED CASE CAST CHAR CHARACTER CHECK CLOSE COLLATE COLLATION COLUMN COMMIT CONNECT CONNECTION CONSTRAINT CONSTRAINTS CONTINUE CONVERT CORRESPONDING CREATE CURRENT CURRENT_DATE CURRENT_TIME CURRENT_TIMESTAMP CURRENT_USER CURSOR DEALLOCATE DEC DECIMAL DECLARE _DEFAULT DEFERRABLE DEFERRED DELETE DESC DESCRIBE DIAGNOSTICS DISCONNECT DISTINCT DOUBLE DROP ELSE END END-EXEC ESCAPE EXCEPT EXCEPTION EXEC EXECUTE EXISTS EXTERNAL FALSE FETCH FIRST FLOAT FOR FOREIGN FOUND FROM FULL FUNCTION GET GETCURRENTCONNECTION GLOBAL GO GOTO GRANT GROUP HAVING HOUR IDENTITY IMMEDIATE IN INDICATOR INITIALLY INNER INOUT INPUT INSENSITIVE INSERT INT INTEGER INTERSECT INTO IS ISOLATION JOIN KEY LAST LEFT LIKE LOWER MATCH MAX MIN MINUTE NATIONAL NATURAL NCHAR NVARCHAR NEXT NO NOT NULL NULLIF NUMERIC OF ON ONLY OPEN OPTION OR ORDER OUT OUTER OUTPUT OVERLAPS PAD PARTIAL PREPARE PRESERVE PRIMARY PRIOR PRIVILEGES PROCEDURE PUBLIC READ REAL REFERENCES RELATIVE RESTRICT REVOKE RIGHT ROLLBACK ROWS SCHEMA SCROLL SECOND SELECT SESSION_USER SET SMALLINT SOME SPACE SQL SQLCODE SQLERROR SQLSTATE SUBSTRING SUM SYSTEM_USER TABLE TEMPORARY TIMEZONE_HOUR TIMEZONE_MINUTE TO TRANSACTION TRANSLATE TRANSLATION TRUE UNION UNIQUE UNKNOWN UPDATE UPPER USER USING VALUES VARCHAR VARYING VIEW WHENEVER WHERE WITH WORK WRITE YEAR BOOLEAN CALL EXPLAIN LTRIM RTRIM SUBSTR XML XMLPARSE XMLSERIALIZE XMLEXISTS > The reserved words list in the reference manual doesn't look uptodate > - > > Key: DERBY-761 > URL: http://issues.apache.org/jira/browse/DERBY-761 > Project: Derby > Type: Bug > Components: Documentation > Reporter: Mamta A. Satoor > Attachments: derby761.diff, rrefkeywords29722.html > > I looked at the 10.1 reference manual's reserved word list and noticed > keywords like BINARY, COALESCE missing from the list. Haven't checked the > list thoroughly to see what else might be missing but it would be good to fix > this for 10.2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-761) The reserved words list in the reference manual doesn't look uptodate
[
http://issues.apache.org/jira/browse/DERBY-761?page=comments#action_12365110 ]
Mamta A. Satoor commented on DERBY-761:
---
I am glad you are looking at the list too. I was surprised to see D and T in
the TOKEN reserved words list. Here is what I see in sqlgrammar.jj
/*
This list should contain only and all SQL92 keywords that are reserved.
Reserved keywords can be used as identifiers in the language only
as delimited identifiers.
*/
/* NOTE - If you add a keyword, then you must add it to reservedKeyword()
*or nonReservedKeyword() as well!
*/
TOKEN [IGNORE_CASE] :
{ /* SQL92 reserved Keywords */
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| <_DEFAULT: "default">
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
}
/*
The next lists should contain non-SQL92 keywords, and should
specify whether their keywords are reserved or non-reserved.
If they are non-reserved, they need to be added to the identifier()
rule.
NOTE: XML, XMLPARSE, XMLSERIALIZE, and XMLEXISTS are considered reserved
words to comply with the SQL/XML (2003) standard, section 5.1.
*/
/* NOTE - If you add a keyword, then you must add it to reservedKeyword()
*or nonReservedKeyword() as well!
*/
TOKEN [IGNORE_CASE] :
{ /* Additional JSQL reserved keywords -- non-SQL92 reserved Keywords */
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
}
But I don't see them in the reservedKeyword() so I guess D and T are not
reserved words. Thanks for catching it. Eric, please take those off from your
changes.
> The reserved words list in the reference manual doesn't look uptodate
> -
>
> Key: DERBY-761
> URL: http://issues.apache.org/jira/browse/DERBY-761
> Project: Derby
> Type: Bug
> Components: Documentation
> Reporter: Mamta A. Satoor
> Attachments: derby761.diff, rrefkeywords29722.html
>
> I looked at the 10.1 reference manual's reserved word list and noticed
> keywords like BINARY, COALESCE missing from the list. Haven't checked the
> list thoroughly to see what else might be missing but it would be good to fix
> this for 10.2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-761) The reserved words list in the reference manual doesn't look uptodate
[ http://issues.apache.org/jira/browse/DERBY-761?page=comments#action_12365109 ] Satheesh Bandaram commented on DERBY-761: - Mamta, is D as a reserved word? This is the list of reserved words I see in 10.2. ADD ALL ALLOCATE ALTER AND ANY ARE AS ASC ASSERTION AT AUTHORIZATION AVG BEGIN BETWEEN BIT BOTH BY CASCADE CASCADED CASE CAST CHAR CHARACTER CHECK CLOSE COLLATE COLLATION COLUMN COMMIT CONNECT CONNECTION CONSTRAINT CONSTRAINTS CONTINUE CONVERT CORRESPONDING CREATE CURRENT CURRENT_DATE CURRENT_TIME CURRENT_TIMESTAMP CURRENT_USER CURSOR DEALLOCATE DEC DECIMAL DECLARE _DEFAULT DEFERRABLE DEFERRED DELETE DESC DESCRIBE DIAGNOSTICS DISCONNECT DISTINCT DOUBLE DROP ELSE END ENDEXEC ESCAPE EXCEPT EXCEPTION EXEC EXECUTE EXISTS EXTERNAL FALSE FETCH FIRST FLOAT FOR FOREIGN FOUND FROM FULL FUNCTION GET GET_CURRENT_CONNECTION GLOBAL GO GOTO GRANT GROUP HAVING HOUR IDENTITY IMMEDIATE IN INDICATOR INITIALLY INNER INOUT INPUT INSENSITIVE INSERT INT INTEGER INTERSECT INTO IS ISOLATION JOIN KEY LAST LEFT LIKE LOWER MATCH MAX MIN MINUTE NATIONAL NATURAL NCHAR NVARCHAR NEXT NO NOT NULL NULLIF NUMERIC OF ON ONLY OPEN OPTION OR ORDER OUT OUTER OUTPUT OVERLAPS PAD PARTIAL PREPARE PRESERVE PRIMARY PRIOR PRIVILEGES PROCEDURE PUBLIC READ REAL REFERENCES RELATIVE RESTRICT REVOKE RIGHT ROLLBACK ROWS SCHEMA SCROLL SECOND SELECT SESSION_USER SET SMALLINT SOME SPACE SQL SQLCODE SQLERROR SQLSTATE SUBSTRING SUM SYSTEM_USER TABLE TEMPORARY TIMEZONE_HOUR TIMEZONE_MINUTE TO TRANSACTION TRANSLATE TRANSLATION TRUE UNION UNIQUE UNKNOWN UPDATE UPPER USER USING VALUES VARCHAR VARYING VIEW WHENEVER WHERE WITH WORK WRITE YEAR BOOLEAN CALL EXPLAIN LONGINT LTRIM RTRIM SUBSTR XML XMLPARSE XMLSERIALIZE XMLEXISTS > The reserved words list in the reference manual doesn't look uptodate > - > > Key: DERBY-761 > URL: http://issues.apache.org/jira/browse/DERBY-761 > Project: Derby > Type: Bug > Components: Documentation > Reporter: Mamta A. Satoor > Attachments: derby761.diff, rrefkeywords29722.html > > I looked at the 10.1 reference manual's reserved word list and noticed > keywords like BINARY, COALESCE missing from the list. Haven't checked the > list thoroughly to see what else might be missing but it would be good to fix > this for 10.2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-761) The reserved words list in the reference manual doesn't look uptodate
[ http://issues.apache.org/jira/browse/DERBY-761?page=comments#action_12365102 ] Mamta A. Satoor commented on DERBY-761: --- I looked at sqlgrammar.jj and found following set of keywords that are missing from the docs 1)BINARY 2)CHARACTER_LENGTH 3)COALESCE 4)D 5)_DEFAULT 6)LOWER 7)MODULE 8)T 9)TS 10)VALUE 11)VARBINARY Following should be removed from the reserved keywords list from the doc 1)INOUT 2)NVARCHAR 3)OUT 4)TRAILING > The reserved words list in the reference manual doesn't look uptodate > - > > Key: DERBY-761 > URL: http://issues.apache.org/jira/browse/DERBY-761 > Project: Derby > Type: Bug > Components: Documentation > Reporter: Mamta A. Satoor > > I looked at the 10.1 reference manual's reserved word list and noticed > keywords like BINARY, COALESCE missing from the list. Haven't checked the > list thoroughly to see what else might be missing but it would be good to fix > this for 10.2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-761) The reserved words list in the reference manual doesn't look uptodate
[ http://issues.apache.org/jira/browse/DERBY-761?page=comments#action_12365094 ] Eric Radzinski commented on DERBY-761: -- If somebody can provide a complete list of reserved words, I'll update the reference guide. > The reserved words list in the reference manual doesn't look uptodate > - > > Key: DERBY-761 > URL: http://issues.apache.org/jira/browse/DERBY-761 > Project: Derby > Type: Bug > Components: Documentation > Reporter: Mamta A. Satoor > > I looked at the 10.1 reference manual's reserved word list and noticed > keywords like BINARY, COALESCE missing from the list. Haven't checked the > list thoroughly to see what else might be missing but it would be good to fix > this for 10.2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
