Re: [jira] Commented: (DERBY-891) derby_tests.policy file contains references to csinfo and db2j - should get cleaned up

[Daniel John Debrunner]

Daniel John Debrunner wrote:

> Hmmm, very strange. I would have thought that in remote mode the server
> needed accept permission on the real hostname, not just on 127.0.0.1 or
> localhost which is all that would be left after this patch.

I think I'm also confused between 'listen' and 'accept' permission. The
test policy file does not have listen permission, but the docs say
listen is only applicable for locahost.

If a machine has two network addresses and I only want the derby server
to be accessible remotely through one of those addresses, is that
defined by an 'accept' or 'listen' permission, or some combination of
the two.

Guess I need to look at the java doc more and what the network server uses.


Dan.

Re: [jira] Commented: (DERBY-891) derby_tests.policy file contains references to csinfo and db2j - should get cleaned up

[Daniel John Debrunner]

Myrna van Lunteren wrote:

> On 2/2/06, *Daniel John Debrunner* <[EMAIL PROTECTED]
> > wrote:
> 
> Possibly the best way forward is to limit this patch to the DERBY-891's
> description, renaming properties. Then clean up the granted socket
> permissions in a separate jira item. Keeping distinct issues separated
> is always good.
> 
>  
> Fair enough, I should've kept it straight. I'll fix up the policy file
> to have just the name changes, run derbyall with classes, sane, and
> insane jars (pointless to try the remote server stuff) and - probably
> tomorrow - submit a new patch.

If submit the patch before the test runs I will look at committing it.
If the difference to the previous patch is not deleting that permission
then the existing test runs are sufficient.

Thanks,
Dan.

Re: [jira] Commented: (DERBY-891) derby_tests.policy file contains references to csinfo and db2j - should get cleaned up

[Myrna van Lunteren]

On 2/2/06, Daniel John Debrunner <[EMAIL PROTECTED]> wrote:
Possibly the best way forward is to limit this patch to the DERBY-891'sdescription, renaming properties. Then clean up the granted socket
permissions in a separate jira item. Keeping distinct issues separatedis always good.
 
Fair enough, I should've kept it straight. I'll fix up the policy file to have just the name changes, run derbyall with classes, sane, and insane jars (pointless to try the remote server stuff) and - probably tomorrow - submit a new patch.

 
Myrna 

Re: [jira] Commented: (DERBY-891) derby_tests.policy file contains references to csinfo and db2j - should get cleaned up

[Daniel John Debrunner]

Myrna van Lunteren wrote:

> I had run derbyall (as I reported) with sane jars (and classes). All passed.
>  
> For derbynet.jar, used only on the server machine, the permissions need
> to be granted to the client machine. For derbyclient.jar, used only on
> the client machine, the permissions need to be granted to the server
> machine.

The derbynet.jar is also (can be) used on the client to perform ping's
etc. That's why the connect permission (I thought) was needed for the
server machine. Though it could be currently no tests are using that in
remote mode.

> At least, that seemed to work and it made sense to me.
> (Just for checks, I made sure the remote server testing works with the
> server started with sane and insane jars and this policy file. I need
> more changes in the tests in a follow-up patch to fully test the remote
> server stuff - that will be with DERBY-871; which is on hold waiting for
> this one).

Hmmm, very strange. I would have thought that in remote mode the server
needed accept permission on the real hostname, not just on 127.0.0.1 or
localhost which is all that would be left after this patch.

I think the policy file could do with further cleanup, separate to the
this patch, related to the socket permissions. It is probably possible
to remove the localhost and 127.0.0.1 related permissions and rely only
on the permissions granted through derbyTesting.{server,client}host names.

Possibly the best way forward is to limit this patch to the DERBY-891's
description, renaming properties. Then clean up the granted socket
permissions in a separate jira item. Keeping distinct issues separated
is always good.

Thanks,
Dan.

Re: [jira] Commented: (DERBY-891) derby_tests.policy file contains references to csinfo and db2j - should get cleaned up

[Myrna van Lunteren]

I had run derbyall (as I reported) with sane jars (and classes). All passed.
 
For derbynet.jar, used only on the server machine, the permissions need to be granted to the client machine. For derbyclient.jar, used only on the client machine, the permissions need to be granted to the server machine. 

 
At least, that seemed to work and it made sense to me.
 
(Just for checks, I made sure the remote server testing works with the server started with sane and insane jars and this policy file. I need more changes in the tests in a follow-up patch to fully test the remote server stuff - that will be with DERBY-871; which is on hold waiting for this one).

 
Myrna
 
 
 
 
 
 

[jira] Commented: (DERBY-891) derby_tests.policy file contains references to csinfo and db2j - should get cleaned up

[Kathey Marsden (JIRA)]

[ 
http://issues.apache.org/jira/browse/DERBY-891?page=comments#action_12364936 ] 

Kathey Marsden commented on DERBY-891:
--

I only ran with the classes

> derby_tests.policy file contains references to csinfo and db2j - should get 
> cleaned up
> --
>
>  Key: DERBY-891
>  URL: http://issues.apache.org/jira/browse/DERBY-891
>  Project: Derby
> Type: Bug
>   Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Trivial
>  Attachments: DERBY-891_013106.diff, DERBY-891_013106.stat
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should 
> get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should 
> get double-checked.
> The csinfo references are used in jvm.java. There referenced in the 
> testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath 
>  change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
>  change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
>  the comment said : // Only required due to a BUG.
>  Need to figure out which 'BUG' that is and document better
>  change to derby.codedir
> csinfo.trustedhost
>  change to derby.clienthost
>  document: - specifies the clients ip address/hostName. 
> csinfo.serverhost 
>  change to derby.serverhost
>  document: -Host name or ip where network server is started.
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (DERBY-891) derby_tests.policy file contains references to csinfo and db2j - should get cleaned up

[Daniel John Debrunner (JIRA)]

[ 
http://issues.apache.org/jira/browse/DERBY-891?page=comments#action_12364932 ] 

Daniel John Debrunner commented on DERBY-891:
-

Myrna and/or Kathey did you run the tests with jars or classes or both? On any 
major policy file change I found it was best to run both combinations and in 
some cases all four (sane/insane  combined with jar/classes).

The only change I question is the removal of this permission from derbynet.jar

-  permission java.net.SocketPermission "${csinfo.serverhost}", 
"accept,connect";

I would have thought that was needed for remote testing, maybe the intention 
was to add it back in a separate patch?



> derby_tests.policy file contains references to csinfo and db2j - should get 
> cleaned up
> --
>
>  Key: DERBY-891
>  URL: http://issues.apache.org/jira/browse/DERBY-891
>  Project: Derby
> Type: Bug
>   Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Trivial
>  Attachments: DERBY-891_013106.diff, DERBY-891_013106.stat
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should 
> get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should 
> get double-checked.
> The csinfo references are used in jvm.java. There referenced in the 
> testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath 
>  change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
>  change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
>  the comment said : // Only required due to a BUG.
>  Need to figure out which 'BUG' that is and document better
>  change to derby.codedir
> csinfo.trustedhost
>  change to derby.clienthost
>  document: - specifies the clients ip address/hostName. 
> csinfo.serverhost 
>  change to derby.serverhost
>  document: -Host name or ip where network server is started.
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (DERBY-891) derby_tests.policy file contains references to csinfo and db2j - should get cleaned up

[Kathey Marsden (JIRA)]

[ 
http://issues.apache.org/jira/browse/DERBY-891?page=comments#action_12364930 ] 

Kathey Marsden commented on DERBY-891:
--

I applied this patch and ran derbyall and it it passed, but I was not entirely 
sure about the  permissions changes at this late hour.  If another committer 
could take a look at the policy file changes and commit this I'd appreciate it 
as I will be out tomorrow.




> derby_tests.policy file contains references to csinfo and db2j - should get 
> cleaned up
> --
>
>  Key: DERBY-891
>  URL: http://issues.apache.org/jira/browse/DERBY-891
>  Project: Derby
> Type: Bug
>   Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Trivial
>  Attachments: DERBY-891_013106.diff, DERBY-891_013106.stat
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should 
> get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should 
> get double-checked.
> The csinfo references are used in jvm.java. There referenced in the 
> testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath 
>  change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
>  change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
>  the comment said : // Only required due to a BUG.
>  Need to figure out which 'BUG' that is and document better
>  change to derby.codedir
> csinfo.trustedhost
>  change to derby.clienthost
>  document: - specifies the clients ip address/hostName. 
> csinfo.serverhost 
>  change to derby.serverhost
>  document: -Host name or ip where network server is started.
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (DERBY-891) derby_tests.policy file contains references to csinfo and db2j - should get cleaned up

[Kathey Marsden (JIRA)]

[ 
http://issues.apache.org/jira/browse/DERBY-891?page=comments#action_12364896 ] 

Kathey Marsden commented on DERBY-891:
--

Thanks myrna. I will look at committing this patch.

> derby_tests.policy file contains references to csinfo and db2j - should get 
> cleaned up
> --
>
>  Key: DERBY-891
>  URL: http://issues.apache.org/jira/browse/DERBY-891
>  Project: Derby
> Type: Bug
>   Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Trivial
>  Attachments: DERBY-891_013106.diff, DERBY-891_013106.stat
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should 
> get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should 
> get double-checked.
> The csinfo references are used in jvm.java. There referenced in the 
> testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath 
>  change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
>  change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
>  the comment said : // Only required due to a BUG.
>  Need to figure out which 'BUG' that is and document better
>  change to derby.codedir
> csinfo.trustedhost
>  change to derby.clienthost
>  document: - specifies the clients ip address/hostName. 
> csinfo.serverhost 
>  change to derby.serverhost
>  document: -Host name or ip where network server is started.
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (DERBY-891) derby_tests.policy file contains references to csinfo and db2j - should get cleaned up

[Daniel John Debrunner (JIRA)]

[ 
http://issues.apache.org/jira/browse/DERBY-891?page=comments#action_12364491 ] 

Daniel John Debrunner commented on DERBY-891:
-

The db2j. references are required, it's the prefix of some properties used by 
some test code, unit tests in the store I believe.

The bug for csinfo.codedir, is DERBY-622, it's referenced in the policy file 
where csinfo.codedir is used.

It's fine to change the name of these properties, but I personally don't see 
any real need to do so. These are properties for the testing harness, not for 
the Derby engine or network server. If they are changed they should be changed 
to a name space related to derbyTesting, and not 'derby.'.  So possible names 
are:

derbyTesting,codejar
derbyTesting.codeclasses

etc.



> derby_tests.policy file contains references to csinfo and db2j - should get 
> cleaned up
> --
>
>  Key: DERBY-891
>  URL: http://issues.apache.org/jira/browse/DERBY-891
>  Project: Derby
> Type: Bug
>   Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Minor

>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should 
> get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should 
> get double-checked.
> The csinfo references are used in jvm.java. There referenced in the 
> testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath 
>  change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
>  change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
>  the comment said : // Only required due to a BUG.
>  Need to figure out which 'BUG' that is and document better
>  change to derby.codedir
> csinfo.trustedhost
>  change to derby.clienthost
>  document: - specifies the clients ip address/hostName. 
> csinfo.serverhost 
>  change to derby.serverhost
>  document: -Host name or ip where network server is started.
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira