[jira] Updated: (DERBY-1521) Upgrade test needs to be enhanced to test grant revoke
[ http://issues.apache.org/jira/browse/DERBY-1521?page=all ] Rick Hillegas updated DERBY-1521: - Urgency: Urgent (was: Normal) Bumping the urgency of this issue. > Upgrade test needs to be enhanced to test grant revoke > -- > > Key: DERBY-1521 > URL: http://issues.apache.org/jira/browse/DERBY-1521 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.2.1.0 >Reporter: Mamta A. Satoor > Assigned To: Deepa Remesh > Fix For: 10.2.1.0 > > Attachments: d1521-patch1-v1.diff, d1521-patch1-v1.status, > d1521-patch2-draft.diff, d1521-patch2-v1.diff, d1521-patch2-v1.status > > > Grant Revoke is one of the features targeted for 10.2 Release. The upgrade > test should be modified to test this feature with various upgrade scenarios > to make sure everything works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1521) Upgrade test needs to be enhanced to test grant revoke
[ http://issues.apache.org/jira/browse/DERBY-1521?page=all ] Deepa Remesh updated DERBY-1521: Derby Info: (was: [Patch Available]) > Upgrade test needs to be enhanced to test grant revoke > -- > > Key: DERBY-1521 > URL: http://issues.apache.org/jira/browse/DERBY-1521 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.2.0.0 >Reporter: Mamta A. Satoor > Assigned To: Deepa Remesh > Fix For: 10.2.0.0 > > Attachments: d1521-patch1-v1.diff, d1521-patch1-v1.status, > d1521-patch2-draft.diff, d1521-patch2-v1.diff, d1521-patch2-v1.status > > > Grant Revoke is one of the features targeted for 10.2 Release. The upgrade > test should be modified to test this feature with various upgrade scenarios > to make sure everything works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1521) Upgrade test needs to be enhanced to test grant revoke
[ http://issues.apache.org/jira/browse/DERBY-1521?page=all ] Deepa Remesh updated DERBY-1521: Attachment: d1521-patch2-v1.diff d1521-patch2-v1.status Attaching patch 'd1521-patch2-v1.diff' which is same as the draft patch 'd1521-patch2-draft.diff'. Only difference is the new patch is based on later svn revision. With this patch, upgrade test passes as DERBY-1608 has been fixed by Satheesh. Please review/commit this patch. Thanks. > Upgrade test needs to be enhanced to test grant revoke > -- > > Key: DERBY-1521 > URL: http://issues.apache.org/jira/browse/DERBY-1521 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.2.0.0 >Reporter: Mamta A. Satoor > Assigned To: Deepa Remesh > Fix For: 10.2.0.0 > > Attachments: d1521-patch1-v1.diff, d1521-patch1-v1.status, > d1521-patch2-draft.diff, d1521-patch2-v1.diff, d1521-patch2-v1.status > > > Grant Revoke is one of the features targeted for 10.2 Release. The upgrade > test should be modified to test this feature with various upgrade scenarios > to make sure everything works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1521) Upgrade test needs to be enhanced to test grant revoke
[ http://issues.apache.org/jira/browse/DERBY-1521?page=all ] Deepa Remesh updated DERBY-1521: Derby Info: [Patch Available] Patch 'd1521-patch2-draft.diff ' available for review > Upgrade test needs to be enhanced to test grant revoke > -- > > Key: DERBY-1521 > URL: http://issues.apache.org/jira/browse/DERBY-1521 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.2.0.0 >Reporter: Mamta A. Satoor > Assigned To: Deepa Remesh > Fix For: 10.2.0.0 > > Attachments: d1521-patch1-v1.diff, d1521-patch1-v1.status, > d1521-patch2-draft.diff > > > Grant Revoke is one of the features targeted for 10.2 Release. The upgrade > test should be modified to test this feature with various upgrade scenarios > to make sure everything works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1521) Upgrade test needs to be enhanced to test grant revoke
[ http://issues.apache.org/jira/browse/DERBY-1521?page=all ] Deepa Remesh updated DERBY-1521: Attachment: d1521-patch2-draft.diff Attaching a draft patch 'd1521-patch2-draft.diff' which sets "derby.database.sqlAuthorization" for an upgraded database and tests that grant/revoke is available. This patch is not for commit as the upgrade test currently fails because of DERBY-1544/DERBY-1608. Meantime, I am just posting this patch to get feedback. Tests are based on following understanding: 1) Grant/revoke feature is supported only if derby.database.sqlAuthorization is set to true 2) Grant/revoke feature available in 10.2 and higher versions 3) Related to upgrade, * grant/revoke feature is supported in following cases: a) hard upgrade to 10.2 or higher versions b) soft upgrade to versions higher than 10.2 * grant/revoke feature is not supported in following cases: c) soft upgrade to 10.2 I have not covered 3b) in the current patch. Please provide feedback. Thanks. > Upgrade test needs to be enhanced to test grant revoke > -- > > Key: DERBY-1521 > URL: http://issues.apache.org/jira/browse/DERBY-1521 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.2.0.0 >Reporter: Mamta A. Satoor > Assigned To: Deepa Remesh > Fix For: 10.2.0.0 > > Attachments: d1521-patch1-v1.diff, d1521-patch1-v1.status, > d1521-patch2-draft.diff > > > Grant Revoke is one of the features targeted for 10.2 Release. The upgrade > test should be modified to test this feature with various upgrade scenarios > to make sure everything works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1521) Upgrade test needs to be enhanced to test grant revoke
[ http://issues.apache.org/jira/browse/DERBY-1521?page=all ] Rick Hillegas updated DERBY-1521: - Urgency: Normal > Upgrade test needs to be enhanced to test grant revoke > -- > > Key: DERBY-1521 > URL: http://issues.apache.org/jira/browse/DERBY-1521 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.2.0.0 >Reporter: Mamta A. Satoor > Assigned To: Deepa Remesh > Fix For: 10.2.0.0 > > Attachments: d1521-patch1-v1.diff, d1521-patch1-v1.status > > > Grant Revoke is one of the features targeted for 10.2 Release. The upgrade > test should be modified to test this feature with various upgrade scenarios > to make sure everything works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1521) Upgrade test needs to be enhanced to test grant revoke
[ http://issues.apache.org/jira/browse/DERBY-1521?page=all ] Daniel John Debrunner updated DERBY-1521: - Derby Info: (was: [Patch Available]) Patch Committed revision 425846. Two issues to be addressed though: 1) The code that calls testGrantRevokeNotSupported() is a little confusing: +case PH_SOFT_UPGRADE: +case PH_POST_SOFT_UPGRADE: +case PH_HARD_UPGRADE: + if(grantRevokeNotSupported) + passed = testGrantRevokeNotSupported(s, phase); + It would be good if this code continued to test correctly once this class supports the next generation of upgrade. So i think testGrantRevokeNotSupported would be always called, and pass in grantRevokeNotSupported, then check the sql state for the exception based upon grantRevokeNotSupported and the phase. 2) Should REVOKE be tested in the testGrantRevokeNotSupported()? (given the name of the method and we want to ensure REVOKE fails as well) > Upgrade test needs to be enhanced to test grant revoke > -- > > Key: DERBY-1521 > URL: http://issues.apache.org/jira/browse/DERBY-1521 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.2.0.0 >Reporter: Mamta A. Satoor > Assigned To: Deepa Remesh > Fix For: 10.2.0.0 > > Attachments: d1521-patch1-v1.diff, d1521-patch1-v1.status > > > Grant Revoke is one of the features targeted for 10.2 Release. The upgrade > test should be modified to test this feature with various upgrade scenarios > to make sure everything works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1521) Upgrade test needs to be enhanced to test grant revoke
[ http://issues.apache.org/jira/browse/DERBY-1521?page=all ] Deepa Remesh updated DERBY-1521: Derby Info: [Patch Available] > Upgrade test needs to be enhanced to test grant revoke > -- > > Key: DERBY-1521 > URL: http://issues.apache.org/jira/browse/DERBY-1521 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.2.0.0 >Reporter: Mamta A. Satoor > Assigned To: Deepa Remesh > Fix For: 10.2.0.0 > > Attachments: d1521-patch1-v1.diff, d1521-patch1-v1.status > > > Grant Revoke is one of the features targeted for 10.2 Release. The upgrade > test should be modified to test this feature with various upgrade scenarios > to make sure everything works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1521) Upgrade test needs to be enhanced to test grant revoke
[ http://issues.apache.org/jira/browse/DERBY-1521?page=all ] Deepa Remesh updated DERBY-1521: Attachment: d1521-patch1-v1.diff d1521-patch1-v1.status Attaching a patch 'd1521-patch1-v1.diff' which modifies UpgradeTester to test the grant/revoke feature. This is a preliminary patch which tests the default upgrade behaviour: In upgrades from versions earlier than 10.2, * grant/revoke feature is not available in soft upgrade * grant/revoke feature is not available in full upgrade (by default). This feature will be available after full upgrade only if "derby.database.sqlAuthorization" is true. The patch adds a method to UpgradeTester to test grant/revoke feature. This method currently checks that grant/revoke feature is not supported by issuing a grant command. I think we need to add more checks to this method. With this patch, I ran the upgrade test with sane classes and jars. This patch modifies only upgrade test. Please review/commit this patch if okay. As I mentioned before, this is a preliminary patch. More changes planned in subsequent patch(es): * Test upgrade with derby.database.sqlAuthorization set * Add more checks to see grant/revoke feature not supported. - grant/revoke not available on existing databases if derby.database.sqlAuthorization was not set to true during upgrade. * Add basic tests to test grant/revoke feature works when upgraded with derby.database.sqlAuthorization set to true - grant/revoke works on the upgraded database - owner of system schemas is changed from pseudo user 'DBA' to the authorizationID of the user invoking upgrade - check contents of new system tables related to grant/revoke - check that all tables and views will be owned by the database owner after upgrade. - check if it is better to add few basic tests to UpgradeTester or cover the testing by calling an existing grant/revoke test Do we need to cover anything else in the testing? > Upgrade test needs to be enhanced to test grant revoke > -- > > Key: DERBY-1521 > URL: http://issues.apache.org/jira/browse/DERBY-1521 > Project: Derby > Issue Type: Improvement > Components: Test >Affects Versions: 10.2.0.0 >Reporter: Mamta A. Satoor > Assigned To: Deepa Remesh > Fix For: 10.2.0.0 > > Attachments: d1521-patch1-v1.diff, d1521-patch1-v1.status > > > Grant Revoke is one of the features targeted for 10.2 Release. The upgrade > test should be modified to test this feature with various upgrade scenarios > to make sure everything works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
