[jira] Updated: (DERBY-2342) convert importExport.java to junit
[ https://issues.apache.org/jira/browse/DERBY-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew McIntyre updated DERBY-2342: --- Attachment: derby-2342-v1.stat stat file for v1 patch > convert importExport.java to junit > -- > > Key: DERBY-2342 > URL: https://issues.apache.org/jira/browse/DERBY-2342 > Project: Derby > Issue Type: Improvement > Components: Tools >Affects Versions: 10.3.0.0 >Reporter: Andrew McIntyre > Assigned To: Andrew McIntyre > Fix For: 10.3.0.0 > > Attachments: derby-2342-v1.diff, derby-2342-v1.stat > > > Convert org.apache.derbyTesting.functionTests.tests.tools.importExport to > junit. New test is called ImportExportTest. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2342) convert importExport.java to junit
[ https://issues.apache.org/jira/browse/DERBY-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew McIntyre updated DERBY-2342: --- Attachment: derby-2342-v1.diff Patch that converts importExport.java to junit. > convert importExport.java to junit > -- > > Key: DERBY-2342 > URL: https://issues.apache.org/jira/browse/DERBY-2342 > Project: Derby > Issue Type: Improvement > Components: Tools >Affects Versions: 10.3.0.0 >Reporter: Andrew McIntyre > Assigned To: Andrew McIntyre > Fix For: 10.3.0.0 > > Attachments: derby-2342-v1.diff, derby-2342-v1.stat > > > Convert org.apache.derbyTesting.functionTests.tests.tools.importExport to > junit. New test is called ImportExportTest. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2342) convert importExport.java to junit
[ https://issues.apache.org/jira/browse/DERBY-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew McIntyre updated DERBY-2342: --- Attachment: derby-2342-v2.diff Attaching a second version of this patch which changes assertFilesEqual(String, String) to assertEquals(File,File) and moves it to BaseTestCase and reuses assertEquals for InputStreams instead of implementing something similar again. > convert importExport.java to junit > -- > > Key: DERBY-2342 > URL: https://issues.apache.org/jira/browse/DERBY-2342 > Project: Derby > Issue Type: Improvement > Components: Tools >Affects Versions: 10.3.0.0 >Reporter: Andrew McIntyre > Assigned To: Andrew McIntyre > Fix For: 10.3.0.0 > > Attachments: derby-2342-v1.diff, derby-2342-v1.stat, > derby-2342-v2.diff > > > Convert org.apache.derbyTesting.functionTests.tests.tools.importExport to > junit. New test is called ImportExportTest. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2342) convert importExport.java to junit
[ https://issues.apache.org/jira/browse/DERBY-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew McIntyre updated DERBY-2342: --- Attachment: derby-2342-v3.diff Thanks very much for the review, Suresh! Attaching a patch which incorporates most of your suggestions. I've used SupportFilesSetup.getReadWrite() to get the Files to pass to assertEquals(File,File). For the other cases where the directory is hardcoded, we need to pass a String to the import or export procedure. I could get a File or URL with getReadWrite or getReadWriteURL, but then I'd either have to get the String representation of the File or URL and do some manipulation of that String to get it into the format that the import/export procedures are expecting. I'm not sure that it is worth the trouble to do that when the location of the support file directories is unlikely to change. Patch is still not quite ready to commit, though, as I'm seeing some failures on jdk16 in client mode. > convert importExport.java to junit > -- > > Key: DERBY-2342 > URL: https://issues.apache.org/jira/browse/DERBY-2342 > Project: Derby > Issue Type: Improvement > Components: Tools >Affects Versions: 10.3.0.0 >Reporter: Andrew McIntyre > Assigned To: Andrew McIntyre > Fix For: 10.3.0.0 > > Attachments: derby-2342-v1.diff, derby-2342-v1.stat, > derby-2342-v2.diff, derby-2342-v3.diff > > > Convert org.apache.derbyTesting.functionTests.tests.tools.importExport to > junit. New test is called ImportExportTest. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2342) convert importExport.java to junit
[ https://issues.apache.org/jira/browse/DERBY-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew McIntyre updated DERBY-2342: --- Attachment: derby-2342-v4.diff Attaching an updated version of this patch which passes on jdk16 as well. > convert importExport.java to junit > -- > > Key: DERBY-2342 > URL: https://issues.apache.org/jira/browse/DERBY-2342 > Project: Derby > Issue Type: Improvement > Components: Tools >Affects Versions: 10.3.0.0 >Reporter: Andrew McIntyre > Assigned To: Andrew McIntyre > Fix For: 10.3.0.0 > > Attachments: derby-2342-v1.diff, derby-2342-v1.stat, > derby-2342-v2.diff, derby-2342-v3.diff, derby-2342-v4.diff > > > Convert org.apache.derbyTesting.functionTests.tests.tools.importExport to > junit. New test is called ImportExportTest. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2342) convert importExport.java to junit
[ https://issues.apache.org/jira/browse/DERBY-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew McIntyre updated DERBY-2342: --- Attachment: (was: derby-2342-v4.diff) > convert importExport.java to junit > -- > > Key: DERBY-2342 > URL: https://issues.apache.org/jira/browse/DERBY-2342 > Project: Derby > Issue Type: Improvement > Components: Tools >Affects Versions: 10.3.0.0 >Reporter: Andrew McIntyre > Assigned To: Andrew McIntyre > Fix For: 10.3.0.0 > > Attachments: derby-2342-v1.diff, derby-2342-v1.stat, > derby-2342-v2.diff, derby-2342-v3.diff, derby-2342-v4.diff > > > Convert org.apache.derbyTesting.functionTests.tests.tools.importExport to > junit. New test is called ImportExportTest. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2342) convert importExport.java to junit
[ https://issues.apache.org/jira/browse/DERBY-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew McIntyre updated DERBY-2342: --- Attachment: derby-2342-v4.diff Attaching an updated patch for this issue which passes on jdk16 as well. > convert importExport.java to junit > -- > > Key: DERBY-2342 > URL: https://issues.apache.org/jira/browse/DERBY-2342 > Project: Derby > Issue Type: Improvement > Components: Tools >Affects Versions: 10.3.0.0 >Reporter: Andrew McIntyre > Assigned To: Andrew McIntyre > Fix For: 10.3.0.0 > > Attachments: derby-2342-v1.diff, derby-2342-v1.stat, > derby-2342-v2.diff, derby-2342-v3.diff, derby-2342-v4.diff > > > Convert org.apache.derbyTesting.functionTests.tests.tools.importExport to > junit. New test is called ImportExportTest. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2342) convert importExport.java to junit
[ https://issues.apache.org/jira/browse/DERBY-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew McIntyre updated DERBY-2342: --- Attachment: derby-2342-v5.diff Attaching another updated patch, this catches the test up to the changes made by Suresh for DERBY-378. > convert importExport.java to junit > -- > > Key: DERBY-2342 > URL: https://issues.apache.org/jira/browse/DERBY-2342 > Project: Derby > Issue Type: Improvement > Components: Tools >Affects Versions: 10.3.0.0 >Reporter: Andrew McIntyre > Assigned To: Andrew McIntyre > Fix For: 10.3.0.0 > > Attachments: derby-2342-v1.diff, derby-2342-v1.stat, > derby-2342-v2.diff, derby-2342-v3.diff, derby-2342-v4.diff, derby-2342-v5.diff > > > Convert org.apache.derbyTesting.functionTests.tests.tools.importExport to > junit. New test is called ImportExportTest. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
