[jira] Updated: (DERBY-2760) Clean-up issues for UTF8Util.java
[ https://issues.apache.org/jira/browse/DERBY-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-2760: --- Attachment: derby-2760-2a-inner_class.diff 'derby-2760-2a-inner_class.diff' changes UTF8Util to use an inner class and also adds a test to verify the basic behavior of the skip-methods. Patch ready for review. > Clean-up issues for UTF8Util.java > - > > Key: DERBY-2760 > URL: https://issues.apache.org/jira/browse/DERBY-2760 > Project: Derby > Issue Type: Improvement > Components: JDBC >Affects Versions: 10.3.1.4 >Reporter: Knut Anders Hatlen >Priority: Trivial > Fix For: 10.4.0.0 > > Attachments: derby-2760-1a-remove_unused_method.diff, > derby-2760-2a-inner_class.diff > > > In DERBY-2646, some improvements to org.apache.derby.iapi.util.UTF8Util were > suggested: > - remove unused private method isDerbyEOFMarker(), or possibly rewrite it > to fit into skipInternal() > - skipInternal() should return an instance of a private inner class instead > of an array -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2760) Clean-up issues for UTF8Util.java
[ https://issues.apache.org/jira/browse/DERBY-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-2760: --- Derby Info: [Patch Available] Fix Version/s: 10.4.0.0 Assignee: Kristian Waagan > Clean-up issues for UTF8Util.java > - > > Key: DERBY-2760 > URL: https://issues.apache.org/jira/browse/DERBY-2760 > Project: Derby > Issue Type: Improvement > Components: JDBC >Affects Versions: 10.3.1.4 >Reporter: Knut Anders Hatlen >Assignee: Kristian Waagan >Priority: Trivial > Fix For: 10.4.0.0 > > Attachments: derby-2760-1a-remove_unused_method.diff, > derby-2760-2a-inner_class.diff > > > In DERBY-2646, some improvements to org.apache.derby.iapi.util.UTF8Util were > suggested: > - remove unused private method isDerbyEOFMarker(), or possibly rewrite it > to fit into skipInternal() > - skipInternal() should return an instance of a private inner class instead > of an array -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2760) Clean-up issues for UTF8Util.java
[ https://issues.apache.org/jira/browse/DERBY-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-2760: --- Attachment: derby-2760-2b-inner_class.diff '' addresses the comments from Dag, and deprecates revision 2a: - I added a comment (in the class JavaDoc) explaining that the "large" streams are just large enough to pass buffer boundaries. - I did not add JavaDoc on all public methods, as the names are pretty explanatory. Comments can be added in another patch if wanted. - I commented the "encoded length bytes" in the class JavaDoc a bit better. - Fixed typo. Test coverage is pretty good, but all error situations for the decoding routine are not exercised. I hope to add this in a later patch. This requires some "hand coded" invalid UTF-8 sequences. In addition I added a sanity test and fixed the incorrect package name in the license header. thanks, > Clean-up issues for UTF8Util.java > - > > Key: DERBY-2760 > URL: https://issues.apache.org/jira/browse/DERBY-2760 > Project: Derby > Issue Type: Improvement > Components: JDBC >Affects Versions: 10.3.1.4 >Reporter: Knut Anders Hatlen >Assignee: Kristian Waagan >Priority: Trivial > Fix For: 10.4.0.0 > > Attachments: derby-2760-1a-remove_unused_method.diff, > derby-2760-2a-inner_class.diff, derby-2760-2b-inner_class.diff > > > In DERBY-2646, some improvements to org.apache.derby.iapi.util.UTF8Util were > suggested: > - remove unused private method isDerbyEOFMarker(), or possibly rewrite it > to fit into skipInternal() > - skipInternal() should return an instance of a private inner class instead > of an array -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2760) Clean-up issues for UTF8Util.java
[ https://issues.apache.org/jira/browse/DERBY-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-2760: --- Derby Info: (was: [Patch Available]) Committed 'derby-2760-2b-inner_class.diff' to trunk with revision 605531. suites.All and derbyall ran successfully. Clearing patch available flag, but keeping issue open for a little while longer in hope to get in the last tests (see earlier comment). > Clean-up issues for UTF8Util.java > - > > Key: DERBY-2760 > URL: https://issues.apache.org/jira/browse/DERBY-2760 > Project: Derby > Issue Type: Improvement > Components: JDBC >Affects Versions: 10.3.1.4 >Reporter: Knut Anders Hatlen >Assignee: Kristian Waagan >Priority: Trivial > Fix For: 10.4.0.0 > > Attachments: derby-2760-1a-remove_unused_method.diff, > derby-2760-2a-inner_class.diff, derby-2760-2b-inner_class.diff > > > In DERBY-2646, some improvements to org.apache.derby.iapi.util.UTF8Util were > suggested: > - remove unused private method isDerbyEOFMarker(), or possibly rewrite it > to fit into skipInternal() > - skipInternal() should return an instance of a private inner class instead > of an array -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2760) Clean-up issues for UTF8Util.java
[ https://issues.apache.org/jira/browse/DERBY-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-2760: --- Derby Info: [Patch Available] > Clean-up issues for UTF8Util.java > - > > Key: DERBY-2760 > URL: https://issues.apache.org/jira/browse/DERBY-2760 > Project: Derby > Issue Type: Improvement > Components: JDBC >Affects Versions: 10.3.1.4 >Reporter: Knut Anders Hatlen >Assignee: Kristian Waagan >Priority: Trivial > Fix For: 10.4.0.0 > > Attachments: derby-2760-1a-remove_unused_method.diff, > derby-2760-2a-inner_class.diff, derby-2760-2b-inner_class.diff, > derby-2760-3a-extra_tests.diff > > > In DERBY-2646, some improvements to org.apache.derby.iapi.util.UTF8Util were > suggested: > - remove unused private method isDerbyEOFMarker(), or possibly rewrite it > to fit into skipInternal() > - skipInternal() should return an instance of a private inner class instead > of an array -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2760) Clean-up issues for UTF8Util.java
[ https://issues.apache.org/jira/browse/DERBY-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-2760: --- Attachment: derby-2760-3a-extra_tests.diff 'derby-2760-3a-extra_tests.diff' adds a few more tests for UTF8Util. Of special interest is that using UTF8Util to skip characters from an invalid byte sequence with UTF-8 encoding will/might succeed, depending on the encoding error and the character boundaries. See the test 'testSkippingInvalidEncodingWorks' for an example. I do not know if this will ever be a problem, because I assume the data has been verified at an earlier stage. If this is not the case, several problems can arise, such as incorrect positioning and a false positive for incorrect encoding (if you end up inside a correctly encoded multi byte character after skipping). Patch ready for review. > Clean-up issues for UTF8Util.java > - > > Key: DERBY-2760 > URL: https://issues.apache.org/jira/browse/DERBY-2760 > Project: Derby > Issue Type: Improvement > Components: JDBC >Affects Versions: 10.3.1.4 >Reporter: Knut Anders Hatlen >Assignee: Kristian Waagan >Priority: Trivial > Fix For: 10.4.0.0 > > Attachments: derby-2760-1a-remove_unused_method.diff, > derby-2760-2a-inner_class.diff, derby-2760-2b-inner_class.diff, > derby-2760-3a-extra_tests.diff > > > In DERBY-2646, some improvements to org.apache.derby.iapi.util.UTF8Util were > suggested: > - remove unused private method isDerbyEOFMarker(), or possibly rewrite it > to fit into skipInternal() > - skipInternal() should return an instance of a private inner class instead > of an array -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2760) Clean-up issues for UTF8Util.java
[ https://issues.apache.org/jira/browse/DERBY-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-2760: --- Derby Info: (was: [Patch Available]) Committed 'derby-2760-3a-extra_tests.diff' to trunk with revision 616786. > Clean-up issues for UTF8Util.java > - > > Key: DERBY-2760 > URL: https://issues.apache.org/jira/browse/DERBY-2760 > Project: Derby > Issue Type: Improvement > Components: JDBC >Affects Versions: 10.3.1.4 >Reporter: Knut Anders Hatlen >Assignee: Kristian Waagan >Priority: Trivial > Fix For: 10.4.0.0 > > Attachments: derby-2760-1a-remove_unused_method.diff, > derby-2760-2a-inner_class.diff, derby-2760-2b-inner_class.diff, > derby-2760-3a-extra_tests.diff > > > In DERBY-2646, some improvements to org.apache.derby.iapi.util.UTF8Util were > suggested: > - remove unused private method isDerbyEOFMarker(), or possibly rewrite it > to fit into skipInternal() > - skipInternal() should return an instance of a private inner class instead > of an array -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2760) Clean-up issues for UTF8Util.java
[ https://issues.apache.org/jira/browse/DERBY-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-2760: --- Attachment: derby-2760-1a-remove_unused_method.diff 'derby-2760-1a-remove_unused_method.diff' removes the unused method 'isDerbyEOFMarker'. It didn't contain anything important, so I decided to just remove it at once. However, it should still be considered if a new method should be written to make skipInternal cleaner. Committed 'derby-2760-1a-remove_unused_method.diff' to trunk with revision 544463. > Clean-up issues for UTF8Util.java > - > > Key: DERBY-2760 > URL: https://issues.apache.org/jira/browse/DERBY-2760 > Project: Derby > Issue Type: Improvement > Components: JDBC >Affects Versions: 10.3.0.0 >Reporter: Knut Anders Hatlen >Priority: Trivial > Attachments: derby-2760-1a-remove_unused_method.diff > > > In DERBY-2646, some improvements to org.apache.derby.iapi.util.UTF8Util were > suggested: > - remove unused private method isDerbyEOFMarker(), or possibly rewrite it > to fit into skipInternal() > - skipInternal() should return an instance of a private inner class instead > of an array -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
