[Bug 558841] Re: bluetooth devices menu item not working in bluetooth indicator
Cody's above patch for gtk+ (#16) fixes the reported bug. He mentioned that he is going to rework it to make it more acceptable to upstream and then, if I understand correctly, include it in a gtk+ SRU. -- bluetooth devices menu item not working in bluetooth indicator https://bugs.launchpad.net/bugs/558841 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497897] Re: Support Application Indicators
Unassigned myself as I didn't get to this in time for Lucid and my responsibilities are now different. ** Changed in: epiphany-browser (Ubuntu) Assignee: Travis B. Hartwell (nafai) = (unassigned) -- Support Application Indicators https://bugs.launchpad.net/bugs/497897 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 533775] Re: No icon for volume or typing break after upgrade to lucid
I can reproduce the situation the bug reporter describes (indicator applet removed from panel in Karmic, gnome typing monitor enabled, and then upgrade to Lucid, no icon shown. The failback is working in so much that a status icon is shown because there is no indicator applet, but an incorrect icon is shown. Will continue to investigate the cause and a potential fix. ** Changed in: gnome-control-center (Ubuntu) Status: New = Confirmed -- No icon for volume or typing break after upgrade to lucid https://bugs.launchpad.net/bugs/533775 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 548891] Re: keyboard input broken at gnome login prompt after package updates
I've looked into it a bit, but could not reproduce under this configuration: VMware Player version 3.0.1 build-227600 Host is 64-bit Lucid system up to date as of today Guest is 64-bit Lucid system up to date as of today Tried both with and without VMware Tools installed. VMware Tools version 8.1.4-227600 downloaded today. No keyboard issues at all in the gdm login screen. I note however that this is using a Ubuntu host, whereas from reading the original report and previous comments, it seems the problem is exhibited on OS X and Windows hosts. I don't have access to either OS X or Windows, so someone else will have to test. -- keyboard input broken at gnome login prompt after package updates https://bugs.launchpad.net/bugs/548891 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gdm in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497853] Re: Support application indicators
To address Martin's concerns, I discussed with mpt what the appropriate user interaction here should be. I did the following: - I reverted the cancel menu item back to using GTK_STOCK_CANCEL so it will be translated and then did some additional work to remove the icon from being displayed. - Since the application indicator does not give any more information than the dialog does, I removed the change of the menu item from cancel - close. Instead, when the burn is finished, the application indicator is hidden and the dialog is shown if hidden. When the dialog is destroyed, the application indicator is also destroyed. Hopefully this has both made the interaction simpler and also removed the string translation issue. Thanks for the feedback Martin. ** Patch added: App Indicators patch addressing Martin's concerns. http://launchpadlibrarian.net/40110067/app-indicators-take-4.patch -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to brasero in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497853] Re: Support application indicators
** Changed in: brasero (Ubuntu Lucid) Status: Incomplete = In Progress ** Changed in: brasero (Ubuntu Lucid) Assignee: Travis B. Hartwell (nafai) = Martin Pitt (pitti) -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to brasero in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497853] Re: Support application indicators
Change to proper state, per seb128. ** Changed in: brasero (Ubuntu Lucid) Status: Fix Committed = In Progress ** Changed in: brasero (Ubuntu Lucid) Assignee: Ken VanDine (ken-vandine) = Travis B. Hartwell (nafai) -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to brasero in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497853] Re: Support application indicators
This patch fixes a bug found by Ken by changing the cancel menu item to close to emulate the behavior of the old GtkStatusIcon. It also removes the icons from the menu items to make the menu formatting look correct. ** Patch added: Updated patch to add support for app indicators http://launchpadlibrarian.net/39933276/app-indicators-take-3.patch -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to brasero in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497853] Re: Support application indicators
Ready for re-review. Note that this change is as invasive as the change to vino, bug #497883, and perhaps should first be vetted upstream as Martin suggested for vino. ** Changed in: brasero (Ubuntu Lucid) Assignee: Travis B. Hartwell (nafai) = Canonical Desktop Team (canonical-desktop-team) -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to brasero in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497897] Re: Support Application Indicators
** Changed in: epiphany-browser (Ubuntu) Assignee: (unassigned) = Travis B. Hartwell (nafai) -- Support Application Indicators https://bugs.launchpad.net/bugs/497897 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497857] Re: Support application indicators
Thank you for your work there, some comment:
GtkStatusIcon *icon;
-
Why the blank line change?
These were probably all unintentional, I have since found a parameter
with git diff that allows me to ignore whitespace changes when
creating diffs that I will use. They partly came from calling M-x
delete-trailing-whitespace in Emacs, which possibly removed whitespace
that was there in the original code. I'll make sure there are no
extraneous lines in future patches.
+#ifdef HAVE_APP_INDICATOR
+const char TYPING_MONITOR_ACTIVE_ICON[] = bar-green;
+const char TYPING_MONITOR_ATTENTION_ICON[] = bar-red;
you can use #define TYPING_MONITOR_ACTIVE_ICON bar-green rather, that's
what GNOME does usually
Good hint, thanks.
+static gint get_time_left (DrWright *drwright);
this change seems to be code cleaning
I did this so I didn't copy and paste code between the two methods
that needed this functionality between the old update_tooltip () and
the new update_menu_text () functionality.
+update_app_indicator (DrWright *dr)
+current_status = app_indicator_get_status (dr-indicator);
+if (new_status != current_status) {
no need to get the current status and compare to the new one in this function,
could can just call set_status on the new one, if there is no status change
that will just do nothing
Good to know, I noticed you asking this question earlier, I'll remove
the extraneous check.
+#ifndef HAVE_APP_INDICATOR
gtk_status_icon_set_from_pixbuf (dr-icon,
dr-composite_bar);
+#endif
} else {
+#ifndef HAVE_APP_INDICATOR
gtk_status_icon_set_from_pixbuf (dr-icon,
dr-neutral_bar);
+#endif
no need to have 2 ifndef there, you can as well use one since there no action
to do in either case
Oh duh. :)
stop_blinking (dr);
+
the new line adding there doesn't seem required
+const gchar normal_msg_template[] = Take a break now (next in %dm);
+const gchar less_than_one_msg_template[] = Take a break now (next in
less than one minute);
why do you use strings different than the upstream ones? the upstream labels
indicate that the indication is the time before next break where you state
take a break now, did you change how the software works? aren't just menu
indications about the next break? in that's the case where should the user
take a break now when looking when is the next one?
This was from a suggestion from mpt. Previously, the information on
how much time left was indicated via a tooltip, which application
indicators don't support.
To quote from an e-mail from mpt:
-- quote --
For the typing break in particular, I suggest including the time in the
Take a Break item, like this:
..
| Take a Break Now (next in 7m) |
||
| Settings… |
| About Typing Break |
''
--- end quote ---
The reason we shortened the text there is the previous strings were
really long and would have made the menu strangely long. I tried not
to change the way the software works, just the way in which the
current information is conveyed. Would be it be clearer if the time
left was an insensitive menu item alone at the very top of the menu?
is ngettext() required there is the singular and plurial forms have no change?
Probably not, I bet I could just use the _N() macro.
+get_time_left (DrWright *dr)
+{
+gint elapsed_time, min;
the min variable seems not required there, you can as well use return directly
the value
Good catch, I'll fix that.
init_tray_icon (dr);
-
g_timeout_add_seconds (12,
the blank line change is not required
As noted above, whoops.
--
Support application indicators
https://bugs.launchpad.net/bugs/497857
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in ubuntu.
--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497857] Re: Support application indicators
Attached is an updated patch: 1) following recommendations from Sebastien above 2) updating the configure.ac with the latest suggestions from Ken ** Patch added: Patch for app indicators, take 2 http://launchpadlibrarian.net/39031554/app-indicators-take2.patch -- Support application indicators https://bugs.launchpad.net/bugs/497857 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497857] Re: Support application indicators
Hopefully final changes, based on what Sebastien pointed out on IRC, and another thing I noticed: 1) preprocessed out the code to blink completely in the case of using app indicators 2) the #ifdef/#endif's sometimes were separated by a bit, so I added a comment on each #endif to be #endif /* HAVE_APP_INDICATOR */ ?field.comment=Hopefully final changes, based on what Sebastien pointed out on IRC, and another thing I noticed: 1) preprocessed out the code to blink completely in the case of using app indicators 2) the #ifdef/#endif's sometimes were separated by a bit, so I added a comment on each #endif to be #endif /* HAVE_APP_INDICATOR */ Should be ready for upstream. ** Patch added: Take 3 http://launchpadlibrarian.net/39033229/app-indicators-take3.patch -- Support application indicators https://bugs.launchpad.net/bugs/497857 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497853] Re: Support application indicators
Not sure how to best remove the code duplication, so pending any other suggestions from Ken, likely ready for upstream review. ** Patch added: Updated patch with configure.in changes suggested by Ken http://launchpadlibrarian.net/38928367/app-indicators-take-2.patch -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to brasero in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497857] Re: Support application indicators
Note: As agreed on with jcastro, this only supports showing green when plenty of time before locked - showing red right before - locking. The original behavior shows gradients of green as time progresses and then flashing red right before locking, then red when locked. ** Patch added: Support for application indicators http://launchpadlibrarian.net/38931559/app-indicators.patch ** Changed in: gnome-control-center (Ubuntu) Status: In Progress = Fix Committed ** Changed in: gnome-control-center (Ubuntu) Assignee: Travis B. Hartwell (nafai) = Ken VanDine (ken-vandine) -- Support application indicators https://bugs.launchpad.net/bugs/497857 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497853] Re: Support application indicators
Patch was made against upstream git tag BRASERO_2_29_6, matching the version in Lucid, and I have verified patch both cleanly applies against the original tarball acquired via apt-get source -d brasero (using patch -p0) and against git HEAD (via git rebase). Feature complete with the following caveats. particularly to make it upstream acceptable: - Probably need to add a flag to configure like --enable/disable-app-indicators. My autoconf foo is weak, so I left that undone. - When compiling with app-indicator support, libbrasero-burn/brasero-tray is still compiled and linked, which is unnecessary. I tried added #ifdefs in Makefile.am around the lines which included brasero-tray.c and brasero-tray.h, but that didn't work. - I have code duplication between the existing libbrasero-burn/brasero-tray.c and the new libbrasero-burn/brasero-app-indicator.c, due to a cut and paste job to get started. The areas I'm concerned about: - in libbrasero-burn/brasero-app-indicator.c, the function brasero_app_indicator_set_progress_menu_text (starting line 227) is largely a copy of libbrasero-burn/brasero-tray.c, the function brasero_tray_icon_set_tooltip (starting line 244), except for the portion where the menu item label is set vs. the original tooltip being set. - similarly, libbrasero-burn/brasero-app-indicator.c, function brasero_app_indicator_set_progress (starting line 281) is largely a copy of libbrasero-burn/brasero-tray.c, function brasero_tray_icon_set_progress (starting line 293), except for the calls to set the tooltip and set the icon. I wasn't sure how to address these the best. It didn't make sense to inherit BraseroAppIndicator from BraseroTrayIcon because BraseroTrayIcon itself is a sub-class of GtkStatusIcon. Should I just move the common calculation / string creation methods out to a separate .h/.c pair and call those from each? That leaves the question of where to free the string. Any other suggestions would be great so I can improve my patches in the future. ** Patch added: Patch to use Application Indicators http://launchpadlibrarian.net/38906062/app-indicators.patch -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to brasero in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497853] Re: Support application indicators
Will attach patch to upstream bug after Ken has had a chance to review it. ** Changed in: brasero (Ubuntu Lucid) Status: In Progress = Fix Committed ** Changed in: brasero (Ubuntu Lucid) Assignee: Travis B. Hartwell (nafai) = Ken VanDine (ken-vandine) -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to brasero in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497853] Re: Support application indicators
** Changed in: brasero (Ubuntu Lucid) Status: Triaged = In Progress -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to brasero in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 497857] Re: Support application indicators
** Changed in: gnome-control-center (Ubuntu) Status: Triaged = In Progress -- Support application indicators https://bugs.launchpad.net/bugs/497857 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
