[Bug 1078297] Re: Crashes with GLib.child_watch_add
This bug was fixed in the package pygobject - 3.4.0-1ubuntu0.1 --- pygobject (3.4.0-1ubuntu0.1) quantal-proposed; urgency=low * Add 00git_lock_gil_in_child_watch_add.patch: Fix crash with GLib.child_watch_add() by locking the Python interpreter, to avoid race conditions in multi-threaded programs. (LP: #1078297) -- Martin PittTue, 13 Nov 2012 16:18:17 +0100 ** Changed in: pygobject (Ubuntu Quantal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to pygobject in Ubuntu. https://bugs.launchpad.net/bugs/1078297 Title: Crashes with GLib.child_watch_add To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pygobject/+bug/1078297/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1078297] Re: Crashes with GLib.child_watch_add
** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to pygobject in Ubuntu. https://bugs.launchpad.net/bugs/1078297 Title: Crashes with GLib.child_watch_add To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pygobject/+bug/1078297/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1078297] Re: Crashes with GLib.child_watch_add
Hello Daniel, or anyone else affected, Accepted pygobject into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/pygobject/3.4.0-1ubuntu0.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: pygobject (Ubuntu Quantal) Status: In Progress => Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to pygobject in Ubuntu. https://bugs.launchpad.net/bugs/1078297 Title: Crashes with GLib.child_watch_add To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pygobject/+bug/1078297/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1078297] Re: Crashes with GLib.child_watch_add
** Description changed: In a complex application, I'm seeing crashes when the destroy notify of GLib.child_watch_add is called. #0 0x004b5c78 in tupledealloc.24592 (op=0x316dc80) at ../Objects/tupleobject.c:218 #1 0x2b7c1553abc7 in child_watch_dnotify (data=0x345a320) at /build/buildd/pygobject-3.4.0/gi/_glib/glibmodule.c:355 #2 0x2b7c1409c108 in g_source_callback_unref (cb_data=0x3475f40) at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:1457 #3 g_source_callback_unref (cb_data=0x3475f40) at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:1449 #4 0x2b7c1409c70a in g_source_destroy_internal (source=source@entry= 0x3471370, context=context@entry=0x1d08a30, have_lock=have_lock@entry=1) at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:1123 #5 0x2b7c1409eb00 in g_main_dispatch (context=0x1d08a30) at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:2739 The problem has been fixed upstream http://git.gnome.org/browse/pygobject/commit/?h=pygobject-3-4&id=a06e0d021d74c95cd517abb3e6ef5ff0037de679 REGRESSION POTENTIAL: Very low. This just adds locking around the reference handling to avoid race conditions with concurrent access. pyglib_gil_state_{ensure,release}() is used all over the place in pygobject, but it was forgotten in this particular function. SRU TEST CASE: This is rather hard to reproduce, as it is a race condition in a multi-threaded program. As Daniel can reproduce it rather well, I suggest to ask him to verify the SRU. - Michael Vogt proposed a test case: - - open software-center - - go to a app with reviews - - click on "useful": "YES" - - verify that it takes a long time + See also bug 1083694 which is the same hang for software-center; this + also has a test case. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to pygobject in Ubuntu. https://bugs.launchpad.net/bugs/1078297 Title: Crashes with GLib.child_watch_add To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pygobject/+bug/1078297/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1078297] Re: Crashes with GLib.child_watch_add
** Description changed: In a complex application, I'm seeing crashes when the destroy notify of GLib.child_watch_add is called. #0 0x004b5c78 in tupledealloc.24592 (op=0x316dc80) at ../Objects/tupleobject.c:218 #1 0x2b7c1553abc7 in child_watch_dnotify (data=0x345a320) at /build/buildd/pygobject-3.4.0/gi/_glib/glibmodule.c:355 #2 0x2b7c1409c108 in g_source_callback_unref (cb_data=0x3475f40) at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:1457 #3 g_source_callback_unref (cb_data=0x3475f40) at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:1449 #4 0x2b7c1409c70a in g_source_destroy_internal (source=source@entry= 0x3471370, context=context@entry=0x1d08a30, have_lock=have_lock@entry=1) at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:1123 #5 0x2b7c1409eb00 in g_main_dispatch (context=0x1d08a30) at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:2739 The problem has been fixed upstream http://git.gnome.org/browse/pygobject/commit/?h=pygobject-3-4&id=a06e0d021d74c95cd517abb3e6ef5ff0037de679 REGRESSION POTENTIAL: Very low. This just adds locking around the reference handling to avoid race conditions with concurrent access. pyglib_gil_state_{ensure,release}() is used all over the place in pygobject, but it was forgotten in this particular function. SRU TEST CASE: This is rather hard to reproduce, as it is a race condition in a multi-threaded program. As Daniel can reproduce it rather well, I suggest to ask him to verify the SRU. + + Michael Vogt proposed a test case: + - open software-center + - go to a app with reviews + - click on "useful": "YES" + - verify that it takes a long time -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to pygobject in Ubuntu. https://bugs.launchpad.net/bugs/1078297 Title: Crashes with GLib.child_watch_add To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pygobject/+bug/1078297/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1078297] Re: Crashes with GLib.child_watch_add
I uploaded the fix for Quantal to the -proposed queue for SRU team review. ** Changed in: pygobject (Ubuntu Quantal) Status: New => In Progress ** Description changed: In a complex application, I'm seeing crashes when the destroy notify of GLib.child_watch_add is called. #0 0x004b5c78 in tupledealloc.24592 (op=0x316dc80) - at ../Objects/tupleobject.c:218 - #1 0x2b7c1553abc7 in child_watch_dnotify (data=0x345a320) - at /build/buildd/pygobject-3.4.0/gi/_glib/glibmodule.c:355 - #2 0x2b7c1409c108 in g_source_callback_unref (cb_data=0x3475f40) - at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:1457 - #3 g_source_callback_unref (cb_data=0x3475f40) - at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:1449 - #4 0x2b7c1409c70a in g_source_destroy_internal (source=source@entry= - 0x3471370, context=context@entry=0x1d08a30, have_lock=have_lock@entry=1) - at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:1123 - #5 0x2b7c1409eb00 in g_main_dispatch (context=0x1d08a30) - at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:2739 + at ../Objects/tupleobject.c:218 + #1 0x2b7c1553abc7 in child_watch_dnotify (data=0x345a320) + at /build/buildd/pygobject-3.4.0/gi/_glib/glibmodule.c:355 + #2 0x2b7c1409c108 in g_source_callback_unref (cb_data=0x3475f40) + at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:1457 + #3 g_source_callback_unref (cb_data=0x3475f40) + at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:1449 + #4 0x2b7c1409c70a in g_source_destroy_internal (source=source@entry= + 0x3471370, context=context@entry=0x1d08a30, have_lock=have_lock@entry=1) + at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:1123 + #5 0x2b7c1409eb00 in g_main_dispatch (context=0x1d08a30) + at /build/buildd/glib2.0-2.34.0/./glib/gmain.c:2739 The problem has been fixed upstream http://git.gnome.org/browse/pygobject/commit/?h=pygobject-3-4&id=a06e0d021d74c95cd517abb3e6ef5ff0037de679 + + REGRESSION POTENTIAL: Very low. This just adds locking around the + reference handling to avoid race conditions with concurrent access. + pyglib_gil_state_{ensure,release}() is used all over the place in + pygobject, but it was forgotten in this particular function. + + SRU TEST CASE: This is rather hard to reproduce, as it is a race + condition in a multi-threaded program. As Daniel can reproduce it rather + well, I suggest to ask him to verify the SRU. ** Changed in: pygobject (Ubuntu Quantal) Assignee: (unassigned) => Martin Pitt (pitti) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to pygobject in Ubuntu. https://bugs.launchpad.net/bugs/1078297 Title: Crashes with GLib.child_watch_add To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pygobject/+bug/1078297/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1078297] Re: Crashes with GLib.child_watch_add
This was fixed in raring in 3.4.2-1. ** Also affects: pygobject (Ubuntu Quantal) Importance: Undecided Status: New ** Also affects: pygobject (Ubuntu Raring) Importance: Undecided Status: New ** Changed in: pygobject (Ubuntu Raring) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to pygobject in Ubuntu. https://bugs.launchpad.net/bugs/1078297 Title: Crashes with GLib.child_watch_add To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pygobject/+bug/1078297/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1078297] Re: Crashes with GLib.child_watch_add
Forgot to mention this happens with Ubuntu 12.10, both 32 and 64 bit. Package version is 3.4.0-1 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to pygobject in Ubuntu. https://bugs.launchpad.net/bugs/1078297 Title: Crashes with GLib.child_watch_add To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pygobject/+bug/1078297/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs