[Bug 1302077] Re: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP
** Branch linked: lp:~ubuntu-desktop/nautilus/ubuntu -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/1302077 Title: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1302077/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1302077] Re: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP
Uploaded, thanks! ** Changed in: nautilus (Ubuntu) Status: New = Fix Committed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/1302077 Title: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1302077/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1302077] Re: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP
Timm Lunn says this is going to cause regressions with the hicontrast theme. I reverted the merge. He said he'll follow up here to explain the details. ** Changed in: nautilus (Ubuntu) Status: Fix Committed = Confirmed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/1302077 Title: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1302077/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1302077] Re: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP
Leo this will cause regressions, particularly for users of the high contrast theme. The overrides should be only applied to Radiance/Ambiance so you should check that in addition to XDG_CURRENT_DESKTOP. Or if you can make the actual Radiance/Ambiance themes behave properly then this patch can be dropped. However nautilus uses a completely non- standard implementation of header bars so I didnt want to mess with that. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/1302077 Title: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1302077/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1302077] Re: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP
** Branch linked: lp:~l3on/ubuntu/trusty/nautilus/fix-1302077 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/1302077 Title: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1302077/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1302077] Re: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP
An this should be moved into themes: + css_string = GtkButton#toolbar-button {padding: 9px;}; + toolbar_override_css (button, toolbar-button, css_string); + -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/1302077 Title: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1302077/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1302077] Re: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP
An this is should be moved into themes: + css_string = GtkButton#toolbar-button {padding: 9px;}; + toolbar_override_css (button, toolbar-button, css_string); + -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/1302077 Title: Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1302077/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs