[Bug 2003104] Re: gnome-terminal transparency ignored in full screen mode

2023-01-23 Thread Daniel van Vugt
For completeness I bisected the cause of the issue (introduced in mutter
43.1):

909616b20876478bc56932cd18c8e85e982645f6 is the first bad commit
commit 909616b20876478bc56932cd18c8e85e982645f6
Author: Sebastian Wick 
Date:   Tue May 3 18:47:57 2022 +0200

window-actor/wayland: Draw black background for fullscreen windows

Fullscreen Wayland toplevel surfaces don't need to respect the
configured size in which case it should be shown centered on the monitor
with a black background. The black background becomes part of the window
geometry.

The surface container is responsible for correctly culling the surfaces
and making sure the surface actors are removed from the actor tree to
avoid destroying them.

The window actor culling implementation assumes all surfaces to be direct
children of said actor. The introduction of the surface_container actor
broke that assumption. This implements the culling interface in
MetaWindowActorWayland which is aware of the actor surface_container and
fullscreen state.

v2: Fix forwarding culling to surface even if there is a background.
v2: Don't alter passed geometry.
v2: Update window geometry code documentation to reflect these changes.
v2: Only use constrained rect if we're acked fullscreen.

Part-of: 

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to mutter in Ubuntu.
https://bugs.launchpad.net/bugs/2003104

Title:
  gnome-terminal transparency ignored in full screen mode

To manage notifications about this bug go to:
https://bugs.launchpad.net/mutter/+bug/2003104/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003104] Re: gnome-terminal transparency ignored in full screen mode

2023-01-19 Thread Bug Watch Updater
** Changed in: wayland
   Status: Unknown => New

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to mutter in Ubuntu.
https://bugs.launchpad.net/bugs/2003104

Title:
  gnome-terminal transparency ignored in full screen mode

To manage notifications about this bug go to:
https://bugs.launchpad.net/mutter/+bug/2003104/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003104] Re: gnome-terminal transparency ignored in full screen mode

2023-01-18 Thread Daniel van Vugt
I was expecting upstream to say "won't fix". Aside from the protocol
saying it's the expected behaviour, we also wouldn't want to impact
performance of fullscreen games just because they accidentally used RGBA
instead of RGBX or RGB. So disallowing anything to show through in full
screen makes sense to me, on balance.

** Also affects: wayland (Ubuntu)
   Importance: Undecided
   Status: New

** Bug watch added: gitlab.freedesktop.org/wayland/wayland-protocols/-/issues 
#116
   https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/116

** Also affects: wayland via
   https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/116
   Importance: Unknown
   Status: Unknown

** Changed in: wayland (Ubuntu)
   Status: New => Won't Fix

** Changed in: mutter (Ubuntu)
   Status: Triaged => Won't Fix

** Changed in: mutter (Ubuntu)
   Importance: High => Undecided

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to mutter in Ubuntu.
https://bugs.launchpad.net/bugs/2003104

Title:
  gnome-terminal transparency ignored in full screen mode

To manage notifications about this bug go to:
https://bugs.launchpad.net/mutter/+bug/2003104/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003104] Re: gnome-terminal transparency ignored in full screen mode

2023-01-18 Thread Bug Watch Updater
** Changed in: mutter
   Status: Unknown => New

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to mutter in Ubuntu.
https://bugs.launchpad.net/bugs/2003104

Title:
  gnome-terminal transparency ignored in full screen mode

To manage notifications about this bug go to:
https://bugs.launchpad.net/mutter/+bug/2003104/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003104] Re: gnome-terminal transparency ignored in full screen mode

2023-01-18 Thread Jeremy Bicha
I verified that this regression also shows in Fedora 37. I verified
there because Fedora and Ubuntu ship a patch to enable transparency in
gnome-terminal; gnome-terminal upstream does not have that feature.

I also verified that this regression was introduced in mutter 43.1.
(transparency works in 43.0 but not in 43.1).

With that information, I found an upstream bug report. The initial
response was that the new behavior conforms to the specification and it
was suggested to maximize gnome-terminal instead of using fullscreen
mode if you want this feature.

** Changed in: mutter (Ubuntu)
 Assignee: Jeremy Bicha (jbicha) => (unassigned)

** Bug watch added: gitlab.gnome.org/GNOME/mutter/-/issues #2520
   https://gitlab.gnome.org/GNOME/mutter/-/issues/2520

** Also affects: mutter via
   https://gitlab.gnome.org/GNOME/mutter/-/issues/2520
   Importance: Unknown
   Status: Unknown

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to mutter in Ubuntu.
https://bugs.launchpad.net/bugs/2003104

Title:
  gnome-terminal transparency ignored in full screen mode

To manage notifications about this bug go to:
https://bugs.launchpad.net/mutter/+bug/2003104/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003104] Re: gnome-terminal transparency ignored in full screen mode

2023-01-18 Thread Jeremy Bicha
Thank you for reporting this bug and helpinig to make Ubuntu better.

I'm going to collect more data to report this issue upstream since this
issue is blocking us from being able to successfully SRU 43.2 to Ubuntu
22.10.

** Changed in: mutter (Ubuntu)
   Status: Confirmed => Triaged

** Changed in: mutter (Ubuntu)
   Importance: Undecided => High

** Tags added: regression-release

** Changed in: mutter (Ubuntu)
 Assignee: (unassigned) => Jeremy Bicha (jbicha)

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to mutter in Ubuntu.
https://bugs.launchpad.net/bugs/2003104

Title:
  gnome-terminal transparency ignored in full screen mode

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2003104/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003104] Re: gnome-terminal transparency ignored in full screen mode

2023-01-18 Thread Sergio Costas
Yes, it is. I tested it in a VM, and can reproduce it.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to mutter in Ubuntu.
https://bugs.launchpad.net/bugs/2003104

Title:
  gnome-terminal transparency ignored in full screen mode

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2003104/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003104] Re: gnome-terminal transparency ignored in full screen mode

2023-01-18 Thread Jeremy Bicha
Sergio, you mean that it looks like this bug was triggered when your
system updated from mutter 43.0-1ubuntu5 to
https://launchpad.net/ubuntu/+source/mutter/43.2-4ubuntu1 right?

** Summary changed:

- Transparency ignored in full screen mode
+ gnome-terminal transparency ignored in full screen mode

** Package changed: gnome-terminal (Ubuntu) => mutter (Ubuntu)

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-terminal in Ubuntu.
https://bugs.launchpad.net/bugs/2003104

Title:
  gnome-terminal transparency ignored in full screen mode

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2003104/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs