[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
closing the bug then since the new version is already in intrepid ** Changed in: gtk+2.0 (Ubuntu) Status: New => Fix Released -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
Argh, it seems that the loop is already gone in SVN (since r20342: 2008-06-10 Carlos Garnacho <[EMAIL PROTECTED]>, Bug 520874 - Should use gio directly). I can't get it to compile unfortunately, but I assume it's fixed. -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
could you open the bug on bugzilla.gnome.org and attach your change there for comments? there is no gtk upstream hackers in the ubuntu team so it would be better to use the gnome bugzilla there -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
I have analyzed and solved the problem I was seeing.
Let's look at gtk+2.0-2.12.9/gtk/gtkfilesystemmodel.c.
In the callback function got_root_folder_cb, there is this code:
if (gtk_file_folder_is_finished_loading (model->root_folder))
g_signal_emit (model, file_system_model_signals[FINISHED_LOADING], 0);
else
g_signal_connect_object (model->root_folder, "finished-loading",
G_CALLBACK
(root_folder_finished_loading_cb), model, 0);
Basically, this means: if the folder is already loaded, tell the dialog we're
done, otherwise wait for the folder to load (and then tell the dialog).
The function then goes on to populate the model with the files in the folder:
gtk_file_folder_list_children (model->root_folder, &roots, NULL);
...
for (tmp_list = roots; tmp_list; tmp_list = tmp_list->next) { ... }
This is where things go wrong; it seems that this loop isn't necessary at all.
The model is already populated in do_files_added.
If the folder hasn't been loaded yet, this doesn't even do anything because
gtk_file_folder_list_children will return an empty list. But if the folder IS
already loaded, then this loop will add all files a second time!
However, there is another question: Why does the above call to
gtk_file_folder_is_finished_loading only return true on the second path bar
click? In other words, why isn't the 'loaded' status reset before the second
click?
Well, there is some sort of caching going on, for a duration of
FOLDER_CACHE_LIFETIME. And guess what, it's exactly 2 seconds.
So, how do we solve the problem? Simply remove the superfluous loop mentioned
above. Of course this might have nasty side effects, so someone who's familiar
with gtk's internals should have a look at what's going on here.
Now another issue crops up. The selection doesn't show up after the second
click. Maybe someone else can figure that one out.
** Attachment added: "patch"
http://launchpadlibrarian.net/16226113/patch
--
Duplicate file entries after double-clicking path button in file dialog
https://bugs.launchpad.net/bugs/239085
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
** Changed in: gtk+2.0 (Ubuntu) Status: Incomplete => New -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
I created a new user, but it has the same problem. Also, it doesn't just happen if I double click the buttons. If I get focus on one and press Enter twice within about 2 seconds, the same thing happens. -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
no idea about the issue but it's likely something specific to your configuration, to debug by somebody having the issue, you can try using a new user on the same installation and see if you still get the issue, could be some user configuration -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
$ dpkg -l|grep engines ii gtk2-engines 1:2.14.1-0ubuntu1 theme engines for GTK+ 2.x ii gtk2-engines-pixbuf2.12.9-3ubuntu4 Pixbuf-based theme for GTK+ 2.x -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
could you run "dpkg -l | grep gtk" and attach the information to a comment? -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
rather "dpkg -l | grep engines" -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
Actually, the duplicate says this is probably a bug in libgnomeui. Feel free to move if you think that's better (because I don't really know what I'm doing ;). -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
It's the GTK file chooser isn't it? I don't have a clean installation to test on, but try this: 1. Open a GTK 'Open file' dialog. 2. Enable the location field (button in top-left of dialog, or Ctrl+L). 3. Double click one of the path component buttons. -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
could you describe how to trigger the issue on a new ubuntu installation? are you sure that's a gtk bug? ** Changed in: gtk+2.0 (Ubuntu) Status: New => Incomplete -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 239085] Re: Duplicate file entries after double-clicking path button in file dialog
This always happens for me when I have the 'Location' entry box on. It never happens when I have it off. In Diaa Sami's screenshot I also see that it is on. Can anyone confirm this behaviour? ** Changed in: gtk+2.0 (Ubuntu) Sourcepackagename: gtk-qt-engine => gtk+2.0 -- Duplicate file entries after double-clicking path button in file dialog https://bugs.launchpad.net/bugs/239085 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
