[Bug 40122] Re: Patch: build 2 libgoffice variants (gnome and gtk)

[Jani Monoses]

** Changed in: goffice (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
Patch: build 2 libgoffice variants (gnome and gtk)
https://launchpad.net/bugs/40122

--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 40122] Re: Patch: build 2 libgoffice variants (gnome and gtk)

[Daniel Holbach]

Looks good, ready to upload.

** Changed in: goffice (Ubuntu)
 Assignee: (unassigned) => Daniel Holbach

** Changed in: goffice (Ubuntu)
   Status: In Progress => Fix Committed

-- 
Patch: build 2 libgoffice variants (gnome and gtk)
https://launchpad.net/bugs/40122

--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 40122] Re: Patch: build 2 libgoffice variants (gnome and gtk)

[Gauvain Pocentek]

** Attachment added: "Updated debdiff"
   http://librarian.launchpad.net/2474955/goffice.debdiff

-- 
Patch: build 2 libgoffice variants (gnome and gtk)
https://launchpad.net/bugs/40122

--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 40122] Re: Patch: build 2 libgoffice variants (gnome and gtk)

[Gauvain Pocentek]

Reopening this bug, a new patch is coming.

** Changed in: goffice (Ubuntu)
   Status: Fix Released => In Progress

** Attachment added: "New patch"
   http://librarian.launchpad.net/2433767/goffice.debdiff

-- 
Patch: build 2 libgoffice variants (gnome and gtk)
https://launchpad.net/bugs/40122

--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 40122] Re: Patch: build 2 libgoffice variants (gnome and gtk)

[Daniel Holbach]

 goffice (0.2.1-3ubuntu3) dapper; urgency=low
 .
   * Build both gnome dependent and independent packages.
   * New created binary packages:
 - libgoffice-gtk-1-2
 - libgoffice-gtk-1-2-dbg


** Changed in: goffice (Ubuntu)
   Status: Unconfirmed => Fix Released

-- 
Patch: build 2 libgoffice variants (gnome and gtk)
https://launchpad.net/bugs/40122

--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 40122] Re: Patch: build 2 libgoffice variants (gnome and gtk)

[Gauvain Pocentek]

** Attachment added: "Real new patch"
   http://librarian.launchpad.net/2339802/goffice.debdiff

-- 
Patch: build 2 libgoffice variants (gnome and gtk)
https://launchpad.net/bugs/40122

--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 40122] Re: Patch: build 2 libgoffice variants (gnome and gtk)

[Gauvain Pocentek]

** Attachment added: "Debdiff against current package"
   http://librarian.launchpad.net/2339712/soundconverter.debdiff

-- 
Patch: build 2 libgoffice variants (gnome and gtk)
https://launchpad.net/bugs/40122

--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 40122] Re: Patch: build 2 libgoffice variants (gnome and gtk)

[Daniel Holbach]

Hey Gauvain, nice work on the patch. It generally looks ok to me, but could you 
please update it to the current version and pay attention to not drop stuff by 
accident? For example this piece of debian/rules hackery
-find -type f -name 'Makefile.am' | sed -e 's/\.am$$//' | xargs rm -f

was simply dropped. Let's try to keep the diff as small as possible. If there 
are other improvements to make, let's not do them now.

-- 
Patch: build 2 libgoffice variants (gnome and gtk)
https://launchpad.net/bugs/40122

--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs