[Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it
Ayan and I investigated this, and found out an interesting thing: When I explicitly use losetup/mount/umount/losetup -d as in comment 40, the aforementioned kernel patch [1] takes care to send a change uevent when the losetup -d happens. However, when I use the approach that usb-creator uses, things still go wrong: sudo mount -o loop ~/download/ubuntu/natty-desktop-amd64.iso /mnt This sends a change event on loop0 which causes udev/udisks/etc. to re-read the device, and see that there's an iso9660 file system on it. sudo umount /mnt This does NOT send a change event on loop0, although it does tear down the loop device. So after that, udev/udisks (and thus the gvfs stack) still think that /dev/loop0 is a mountable iso9660 file system. A workaround would be to poke the loop device in the usb creator backend: def UnmountFile(self, device, sender=None, conn=None): popen(['umount', device]) +popen(['udevadm', 'trigger', '--verbose', '--sysname-match=loop0']) Ayan is currently testing this. But the proper bug fix would be to either fix umount to tear down loop0 more properly so that the kernel patch kicks in, or fix the kernel to also send a change event on the missing case that umount triggers if it unmounts a loop device that was mounted with -o loop. [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c3473c63542d53740f175f3a515257ae159e998b ** Package changed: gnome-disk-utility (Ubuntu) = linux (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-disk-utility in Ubuntu. https://bugs.launchpad.net/bugs/548546 Title: Nautilus does not remove usb drive made with USB-Creator after unmounting it -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it
I can still reproduce the bug under Maverick. If one mounts a loopback filesystem under /media, things work fine. Examining the gvfs code, it appears to explicitly ignores udisks signals for mounts outside of /media. See _g_unix_mount_point_guess_should_display() @ line 631 of gvfs-1.6.4/monitor/gdu/ggduvolumemonitor.c -- notice that this function is used in should_volume_be_ignored() and should_drive_be_ignored(). I've tried a patch to usb-creator that uses udisks --mount to mount the temp drive under /media and it works fine under Maverick. I'm still not familiar with all of the intricacies of how the mount and device events get propagated to nautilus. Please correct me if I'm wrong Martin. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-disk-utility in Ubuntu. https://bugs.launchpad.net/bugs/548546 Title: Nautilus does not remove usb drive made with USB-Creator after unmounting it -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
Re: [Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it
Ayan George [2011-04-10 19:52 -]: I've tried a patch to usb-creator that uses udisks --mount to mount the temp drive under /media and it works fine under Maverick. That might be a pointer to where the problem actually is, but I don't think we should do this. As this is an internal helper mount, it shouldn't be exposed to users in nautilus at all. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-disk-utility in Ubuntu. https://bugs.launchpad.net/bugs/548546 Title: Nautilus does not remove usb drive made with USB-Creator after unmounting it -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it.
** Changed in: gnome-disk-utility (Ubuntu Maverick) Assignee: Martin Pitt (pitti) = (unassigned) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-disk-utility in Ubuntu. https://bugs.launchpad.net/bugs/548546 Title: Nautilus does not remove usb drive made with USB-Creator after unmounting it. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it
I tried to reproduce this with sudo losetup /dev/loop0 download/ubuntu/natty-desktop-amd64.iso - Volume/Drive created and appears in palimpsest and nautilus sudo mount /dev/loop0 /mnt - Volume/Drive disappear in nautilus, as it's hidden from user sessions (not in /media); stays in palimpsest sudo umount /mnt - Volume/Drive reappear in nautilus, as it's now umounted; still stays around in palimpsest sudo losetup -d - volume/drive go away in nautilus/palimpsest So it's something more specific to what usb-creator does. Need to investigate that in more detail then (debug cycles are quite long with a full usb-creator write turnaround). -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-disk-utility in Ubuntu. https://bugs.launchpad.net/bugs/548546 Title: Nautilus does not remove usb drive made with USB-Creator after unmounting it -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it
Not important enough for an SRU. ** Changed in: gnome-disk-utility (Ubuntu Lucid) Status: Confirmed = Won't Fix ** Changed in: gnome-disk-utility (Ubuntu Maverick) Status: Confirmed = Won't Fix -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-disk-utility in Ubuntu. https://bugs.launchpad.net/bugs/548546 Title: Nautilus does not remove usb drive made with USB-Creator after unmounting it -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it.
Reproduced today after using usb-creator to test an ubuntu-based distro (elementary 0.1, based on maverick 32bit). Request formatting of the ejected volume, listed in nautilus with the distro name, prompts an error message Error creating partition table: helper exited with exit code 1: BLKRRPART ioctl failed for /dev/loop0: Invalid argument but the ghost volume then disappears. So this is another, if less clean, workaround. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-disk-utility in Ubuntu. https://bugs.launchpad.net/bugs/548546 Title: Nautilus does not remove usb drive made with USB-Creator after unmounting it. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it.
bug seems to be reproducible at will ** Changed in: gnome-disk-utility (Ubuntu Lucid) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-disk-utility in Ubuntu. https://bugs.launchpad.net/bugs/548546 Title: Nautilus does not remove usb drive made with USB-Creator after unmounting it. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it.
I used usb-creator yesterday to try ubuntu 11.04-beta1 (32bit). After successful creation of the bootable device I unmounted the volume and even chose safely remove after. After I removed the USB stick, Nautilus still displays /dev/loop0 as File 732MB (ubuntu-11.04-beta1-i386.iso). Trying ti mount it then gives this fs driver error: Error mounting: mount: wrong fs type, bad option, bad superblock on /dev/loop0, missing codepage or helper program, or other error (could this be the IDE device where you in fact use ide-scsi so that sr0 or sda or so is needed?) In some cases useful info is found in syslog - try dmesg | tail or so Workaround: checking it with gnome-disk-utility 2.30.1-1 returns the volume as not safe, but makes it disappear at last. Up-to-date Lucid 64bit here. usb-creator-gtk 0.2.22.1 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-disk-utility in Ubuntu. https://bugs.launchpad.net/bugs/548546 Title: Nautilus does not remove usb drive made with USB-Creator after unmounting it. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it.
Running Ubuntu 10.10Nautilus is sleeping when using the Places bookmarks. Lunch the folder and nothing happens -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-disk-utility in ubuntu. https://bugs.launchpad.net/bugs/548546 Title: Nautilus does not remove usb drive made with USB-Creator after unmounting it. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it.
** Package changed: nautilus (Ubuntu) = gnome-disk-utility (Ubuntu) ** Changed in: gnome-disk-utility (Ubuntu) Status: New = Triaged ** Changed in: gnome-disk-utility (Ubuntu Lucid) Assignee: Canonical Desktop Team (canonical-desktop-team) = (unassigned) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-disk-utility in ubuntu. https://bugs.launchpad.net/bugs/548546 Title: Nautilus does not remove usb drive made with USB-Creator after unmounting it. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it.
I think the bug is in libgdu. If the event custody chain is: kernel uevent - udev - udev uevent - (udisks sends D-BUS signal) - (libgdu + gvfs) We can test udisk with: $ udisks --monitor-detail You'll see that the is mounted flag is set properly when you mount and unmount a loop device. You can test gvfs with: $ gvfs-mount -io And you'll see the events are backwards there. -- Nautilus does not remove usb drive made with USB-Creator after unmounting it. https://bugs.launchpad.net/bugs/548546 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to nautilus in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 548546] Re: Nautilus does not remove usb drive made with USB-Creator after unmounting it.
** Summary changed: - nautilus not removing device after unmount + Nautilus does not remove usb drive made with USB-Creator after unmounting it. ** Changed in: nautilus (Ubuntu Maverick) Status: New = Confirmed -- Nautilus does not remove usb drive made with USB-Creator after unmounting it. https://bugs.launchpad.net/bugs/548546 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to nautilus in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs