Re: [Bug 43066] Re: Window list behaves bad when panel is vertical.

2009-08-10 Thread Carey Underwood
Removed a couple lingering bogus hardcoded values


** Attachment added: vertical.patch
   http://launchpadlibrarian.net/30098789/vertical.patch

-- 
Window list behaves bad when panel is vertical.
https://bugs.launchpad.net/bugs/43066
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is a direct subscriber.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


Re: [Bug 43066] Re: Window list behaves bad when panel is vertical.

2009-08-10 Thread Carey Underwood
I will as soon as I can.  I'm giving it one more day of use at work
today, and then I'll send the patch upstream.  I've been trying to
poke people in gimpnet's #gnome-hackers, but everyone scatters and
hides every time I bring up libwnck :p

-- 
Window list behaves bad when panel is vertical.
https://bugs.launchpad.net/bugs/43066
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is a direct subscriber.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


Re: [Bug 43066] Re: Window list behaves bad when panel is vertical.

2009-08-10 Thread Carey Underwood
In that case...

Last change to mostly fix an asymmetry in the use all available
space logic (doesn't handle right clicking in empty space properly in
vertical orientation, but this is still way better behaviour than
previously).

On Mon, Aug 10, 2009 at 8:39 AM, Sebastien Bacherseb...@ubuntu.com wrote:
 Upstream is doing patch review today for 2.27.90 tarballs due today
 would be nice to send the change now

 --
 Window list behaves bad when panel is vertical.
 https://bugs.launchpad.net/bugs/43066
 You received this bug notification because you are a direct subscriber
 of the bug.



** Attachment added: vertical.patch
   http://launchpadlibrarian.net/30115119/vertical.patch

-- 
Window list behaves bad when panel is vertical.
https://bugs.launchpad.net/bugs/43066
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is a direct subscriber.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


Re: [Bug 43066] Re: Window list behaves bad when panel is vertical.

2009-08-10 Thread Carey Underwood
Patch forwarded as to http://bugzilla.gnome.org/show_bug.cgi?id=86382
as attachment: http://bugzilla.gnome.org/attachment.cgi?id=140334

-- 
Window list behaves bad when panel is vertical.
https://bugs.launchpad.net/bugs/43066
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is a direct subscriber.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


Re: [Bug 43066] Re: Window list behaves bad when panel is vertical.

2009-08-08 Thread Carey Underwood
Tired of waiting, I have a hack job that beats libwnck22's tasklist.c
into submission.  And the best part is, it can be cleaned up into an
actual _proper_ patch!

On Wed, May 27, 2009 at 8:39 AM, Walter Hufhuf...@gmail.com wrote:
 Yay, this bug has finally been triaged!
 That means we'll see a fix soon, right? Right? Especially since the upstream 
 bug has an attached patch that fixes it? Right??

 --
 Window list behaves bad when panel is vertical.
 https://bugs.launchpad.net/bugs/43066
 You received this bug notification because you are a direct subscriber
 of a duplicate bug.



** Attachment added: woot.png
   http://launchpadlibrarian.net/30045954/woot.png

-- 
Window list behaves bad when panel is vertical.
https://bugs.launchpad.net/bugs/43066
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is a direct subscriber.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


Re: [Bug 43066] Re: Window list behaves bad when panel is vertical.

2009-08-08 Thread Carey Underwood
Horrible horrible patch that knowingly breaks grouping, and horizontal
panels.  But not in a fundamentally wrong way, just in a lets
comment out all this irrelevant code way.

Expect a cleaner patch really soon.


** Attachment added: vertical.patch
   http://launchpadlibrarian.net/30046252/vertical.patch

-- 
Window list behaves bad when panel is vertical.
https://bugs.launchpad.net/bugs/43066
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is a direct subscriber.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


Re: [Bug 43066] Re: Window list behaves bad when panel is vertical.

2009-08-08 Thread Carey Underwood
Cleaned up the patch significantly, re-enabled the grouping and
horizontal panels, and as an added bonus added multiple column support
back into the vertical panels, but only when they're _really_ full.

This patch is more suitable for sane eyes.

On Sat, Aug 8, 2009 at 1:12 AM, cwillucwi...@cwillu.com wrote:
 Horrible horrible patch that knowingly breaks grouping, and horizontal
 panels.  But not in a fundamentally wrong way, just in a lets
 comment out all this irrelevant code way.

 Expect a cleaner patch really soon.



** Attachment added: vertical.patch
   http://launchpadlibrarian.net/30048936/vertical.patch

** Attachment added: win.png
   http://launchpadlibrarian.net/30048937/win.png

-- 
Window list behaves bad when panel is vertical.
https://bugs.launchpad.net/bugs/43066
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is a direct subscriber.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

Re: [Bug 43066] Re: Window list behaves bad when panel is vertical.

2009-08-08 Thread Carey Underwood
A slightly cleaner patch again.


** Attachment added: vertical.patch
   http://launchpadlibrarian.net/30049128/vertical.patch

** Changed in: gnome-panel (Ubuntu)
   Status: Triaged = In Progress

** Changed in: gnome-panel (Ubuntu)
 Assignee: Ubuntu Desktop Bugs (desktop-bugs) = (unassigned)

-- 
Window list behaves bad when panel is vertical.
https://bugs.launchpad.net/bugs/43066
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is a direct subscriber.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs