Re: GitLab mirror considered harmful

[Michael Gratton]

On Tue, 5 Feb, 2019 at 4:12 PM, Michael Gratton  wrote:
If one of the reasons that the mirror is there to promote 
contributions, but there's been no or few successful contributions 
made and only negative reactions, then it's clearly failing at that.


*If* there's been no or few...

--
⊨ Michael Gratton, Percept Wrangler.
⚙ 


___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: GitLab mirror considered harmful

[Michael Gratton]

On Tue, 5 Feb, 2019 at 3:58 AM, Philip Chimento via desktop-devel-list 
 wrote:
Does anyone have any success stories to share? If it is actually 
helping other maintainers, then maybe we should just overhaul the bot 
a little (see suggestion below.)


This is what I was wondering as well. If one of the reasons that the 
mirror is there to promote contributions, but there's been no or few 
successful contributions made and only negative reactions, then it's 
clearly failing at that.


The fact that, as Chris mentioned, GitHub turns up higher in search 
engine results only compounds this.



For as long as GitHub does not support disabling PRs, we can think 
beyond the current solution and expand fron auto-close to something 
that brings the maintainers attention. Maybe opening an issue in 
GitLab that points to the original PR so that the maintainer can 
persuade the original PR author? Is this something maintainers would 
find acceptable?


Could we take it all the way and just push the PR branch to 
"$github_user_name/$branch_name" in the main repository on GitLab, 
and open a merge request automatically, then instruct the auto-close 
bot to direct the person to GitLab, possibly telling them how to 
create an account as well? Also tag the maintainer's GitHub account 
(if they have one) in the auto-close message, so they get a 
notification?


Something like this might help, especially if the bot could be 
bi-directional, i.e. keeps the GitHub PR open until the GitLab MR has 
been closed. Where's the existing GitHub bot's code located, anyone 
know? I couldn't find it sysadmin-bin and neither GitLab nor GitHub's 
code search helped. :)


//Mike

--
⊨ Michael Gratton, Percept Wrangler.
⚙ 


___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: GitLab mirror considered harmful

[Philip Chimento via desktop-devel-list]

On Mon, Feb 4, 2019 at 12:39 PM Alexandre Franke  wrote:

> On Mon, Feb 4, 2019 at 5:58 PM Philip Chimento wrote:
> > Could we take it all the way and just push the PR branch to
> "$github_user_name/$branch_name"
> > in the main repository on GitLab, and open a merge request
> automatically, then instruct the
> > auto-close bot to direct the person to GitLab, possibly telling them how
> to create an account
> > as well?
>
> Maybe even one step further: find out whether the contributor has an
> account on our gitlab (same email? Used their github account for
> authentication?) and fork the repo for them, then copy their github
> branch to this fork and open the MR.
>

I like it!
Although I think in a lot of the cases people who already have a
gitlab.gnome.org account will know not to submit PRs at GitHub :-)

> Also tag the maintainer's GitHub account (if they have one) in the
> auto-close message,
> > so they get a notification?
>
> Isn’t a mention on our gitlab instance enough in that case?
>

Probably, yes

>
> --
> Alexandre Franke
> GNOME Hacker
> ___
> desktop-devel-list mailing list
> desktop-devel-list@gnome.org
> https://mail.gnome.org/mailman/listinfo/desktop-devel-list
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: GitLab mirror considered harmful

[William Jon McCann via desktop-devel-list]

On Sun, Feb 3, 2019 at 9:55 PM Jan Tojnar via desktop-devel-list
 wrote:
> 3. GitLab does not support any references from gitrevisions(7) other
> than commit hash, compare
> https://github.com/GNOME/gnome-shell/commit/af34b7c25e39e727f7dbd6e3dae0e7c5fe60f141%5E
> and
> https://gitlab.gnome.org/GNOME/gnome-shell/commit/af34b7c25e39e727f7dbd6e3dae0e7c5fe60f141%5E

I was curious how they compared. This is what I see:
https://imgur.com/a/8K4kGKb
https://imgur.com/a/xbinw1R

Did I do it wrong?

Jon

ps. I tried to send this twice with attachments and I guess it
requires moderation
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: GitLab mirror considered harmful

[Alexandre Franke]

On Mon, Feb 4, 2019 at 5:58 PM Philip Chimento wrote:
> Could we take it all the way and just push the PR branch to 
> "$github_user_name/$branch_name"
> in the main repository on GitLab, and open a merge request automatically, 
> then instruct the
> auto-close bot to direct the person to GitLab, possibly telling them how to 
> create an account
> as well?

Maybe even one step further: find out whether the contributor has an
account on our gitlab (same email? Used their github account for
authentication?) and fork the repo for them, then copy their github
branch to this fork and open the MR.

> Also tag the maintainer's GitHub account (if they have one) in the auto-close 
> message,
> so they get a notification?

Isn’t a mention on our gitlab instance enough in that case?

-- 
Alexandre Franke
GNOME Hacker
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: GitLab mirror considered harmful

[mcatanzaro]

FWIW I only use our GitHub mirrors when our GitLab is running slow. But 
that happens often enough


On Mon, Feb 4, 2019 at 10:58 AM, philip.chime...@gmail.com wrote:
Could we take it all the way and just push the PR branch to 
"$github_user_name/$branch_name" in the main repository on GitLab, 
and open a merge request automatically, then instruct the auto-close 
bot to direct the person to GitLab, possibly telling them how to 
create an account as well? Also tag the maintainer's GitHub account 
(if they have one) in the auto-close message, so they get a 
notification?


Then we wind up with merge requests that the contributor cannot respond 
to, which we'll have to close manually. I'd rather just not know about 
the merge request if the contributor can't take the time to submit it 
on GitLab.


___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: GitLab mirror considered harmful

[Philip Chimento via desktop-devel-list]

On Mon, Feb 4, 2019 at 6:37 AM Alberto Ruiz  wrote:

> I agree with Michael here,
>
> I think a lot of people just default to github and being there has value
> in itself. The Pull Request is indeed a not so great situation and I think
> we should think hard about making it easy for people who took the time to
> contribute.
>

Since switching from Bugzilla to GitLab I've had exactly one person try to
contribute a GitHub pull request to GJS, who subsequently threw a temper
tantrum when he found out that GitHub was not the main repo and went on a
bizarre rant claiming that GitLab was a conspiracy so GNOME could collect
people's email addresses. I wasted my weekend figuring out how to respond
politely while still calling him out on that BS. I have not seen any
positive outcomes from the mirror since the switch to GitLab.

Does anyone have any success stories to share? If it is actually helping
other maintainers, then maybe we should just overhaul the bot a little (see
suggestion below.)

For as long as GitHub does not support disabling PRs, we can think beyond
> the current solution and expand fron auto-close to something that brings
> the maintainers attention. Maybe opening an issue in GitLab that points to
> the original PR so that the maintainer can persuade the original PR author?
> Is this something maintainers would find acceptable?
>

Could we take it all the way and just push the PR branch to
"$github_user_name/$branch_name" in the main repository on GitLab, and open
a merge request automatically, then instruct the auto-close bot to direct
the person to GitLab, possibly telling them how to create an account as
well? Also tag the maintainer's GitHub account (if they have one) in the
auto-close message, so they get a notification?

El lun., 4 feb. 2019 a las 14:27,  escribió:
>
>> On Sun, Feb 3, 2019 at 8:59 PM, Christopher Davis via
>> desktop-devel-list  wrote:
>> > If we keep the mirrors around, then we should at the very least
>> > ensure that pull requests aren't able to be opened at all
>> > on the repos.
>>
>> GitHub doesn't allow disabling pull requests, that's why we have the
>> auto-close bot. I believe someone from GNOME asked supporting this
>> previously and they told us no.
>>
>> FWIW I don't care if we leave the mirror up now that we have the
>> auto-close bot.
>>
>> Michael
>>
>> ___
>> desktop-devel-list mailing list
>> desktop-devel-list@gnome.org
>> https://mail.gnome.org/mailman/listinfo/desktop-devel-list
>>
>
>
> --
> Cheers,
> Alberto Ruiz
> ___
> desktop-devel-list mailing list
> desktop-devel-list@gnome.org
> https://mail.gnome.org/mailman/listinfo/desktop-devel-list
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: GitLab mirror considered harmful

[Christopher Davis via desktop-devel-list]

In some cases, the mirror shows up before our hosting in search engines 
like Google and DuckDuckGo.

I've been frustrated by that before.

Regards,
Chris

On Mon, Feb 4, 2019 at 9:51 AM, Milan Crha via desktop-devel-list 
 wrote:

On Mon, 2019-02-04 at 14:36 +, Alberto Ruiz wrote:

 Maybe opening an issue in GitLab that points to the original PR so
 that the maintainer can persuade the original PR author? Is this
 something maintainers would find acceptable?


Hi,
apart of duplicated space and work, that won't work for those whom do
not have an account on GitHub.

Why would not contributors accept the fact that GNOME hosts its
sources, bug tracker, ... in its own infrastructure? Do you think
contributors won't find the sources and so on, when they are only 
under
gnome.org umbrella? If I'd need to contribute to some project, I 
simply

accept code-of-conduct and the way the project does those things,
instead of trying to work on some mirror (where different rules can
apply).
Bye,
Milan

___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: GitLab mirror considered harmful

[Milan Crha via desktop-devel-list]

On Mon, 2019-02-04 at 14:36 +, Alberto Ruiz wrote:
> Maybe opening an issue in GitLab that points to the original PR so
> that the maintainer can persuade the original PR author? Is this
> something maintainers would find acceptable?

Hi,
apart of duplicated space and work, that won't work for those whom do
not have an account on GitHub.

Why would not contributors accept the fact that GNOME hosts its
sources, bug tracker, ... in its own infrastructure? Do you think
contributors won't find the sources and so on, when they are only under
gnome.org umbrella? If I'd need to contribute to some project, I simply
accept code-of-conduct and the way the project does those things,
instead of trying to work on some mirror (where different rules can
apply).
Bye,
Milan

___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: GitLab mirror considered harmful

[Alberto Ruiz]

I agree with Michael here,

I think a lot of people just default to github and being there has value in
itself. The Pull Request is indeed a not so great situation and I think we
should think hard about making it easy for people who took the time to
contribute.

For as long as GitHub does not support disabling PRs, we can think beyond
the current solution and expand fron auto-close to something that brings
the maintainers attention. Maybe opening an issue in GitLab that points to
the original PR so that the maintainer can persuade the original PR author?
Is this something maintainers would find acceptable?


El lun., 4 feb. 2019 a las 14:27,  escribió:

> On Sun, Feb 3, 2019 at 8:59 PM, Christopher Davis via
> desktop-devel-list  wrote:
> > If we keep the mirrors around, then we should at the very least
> > ensure that pull requests aren't able to be opened at all
> > on the repos.
>
> GitHub doesn't allow disabling pull requests, that's why we have the
> auto-close bot. I believe someone from GNOME asked supporting this
> previously and they told us no.
>
> FWIW I don't care if we leave the mirror up now that we have the
> auto-close bot.
>
> Michael
>
> ___
> desktop-devel-list mailing list
> desktop-devel-list@gnome.org
> https://mail.gnome.org/mailman/listinfo/desktop-devel-list
>


-- 
Cheers,
Alberto Ruiz
___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list

Re: GitLab mirror considered harmful

[mcatanzaro]

On Sun, Feb 3, 2019 at 8:59 PM, Christopher Davis via 
desktop-devel-list  wrote:
If we keep the mirrors around, then we should at the very least 
ensure that pull requests aren't able to be opened at all

on the repos.


GitHub doesn't allow disabling pull requests, that's why we have the 
auto-close bot. I believe someone from GNOME asked supporting this 
previously and they told us no.


FWIW I don't care if we leave the mirror up now that we have the 
auto-close bot.


Michael

___
desktop-devel-list mailing list
desktop-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/desktop-devel-list