Re: IMPORTANT: fix critical warnings before January 1st
On Fri, 2005-11-11 at 17:00 -0600, Federico Mena Quintero wrote: [...] As a deeper problem, things launched through bonobo-activation-server send their warnings to nowhere, /dev/null, empty space. YOU CAN'T SEE THESE WARNINGS EVEN IF YOU TRY. This is a known bug. [...] Sorry, I didn't look thorugh bugzilla for this yet, but here's a trivial patch fix this. Regards. -- Gustavo J. A. M. Carneiro [EMAIL PROTECTED] [EMAIL PROTECTED] The universe is always one step beyond logic Index: activation-server/activation-server-main.c === RCS file: /cvs/gnome/libbonobo/activation-server/activation-server-main.c,v retrieving revision 1.60 diff -u -p -d -r1.60 activation-server-main.c --- activation-server/activation-server-main.c 12 Aug 2004 20:46:04 - 1.60 +++ activation-server/activation-server-main.c 12 Nov 2005 11:52:20 - @@ -204,8 +204,6 @@ redirect_output (int ior_fd) dup2 (dev_null_fd, 0); if (ior_fd != 1) dup2 (dev_null_fd, 1); - if (ior_fd != 2) - dup2 (dev_null_fd, 2); return dev_null_fd; } ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
IMPORTANT: fix critical warnings before January 1st
Dear hackers of GNOME, Vincent announced this the other day: http://mail.gnome.org/archives/desktop-devel-list/2005-November/msg6.html And there was a discussion of how to implement this plan. Glib now supports setting an environment variable, G_DEBUG=fatal_criticals. Doing this will cause programs to abort when a critical warning gets triggered. What is a critical warning? This is a critical warning: gtk_widget_show (NULL); g_return_if_fail (widget != NULL); A critical warning is an indication that something has gone REALLY WRONG in your program and you should fix it right away. THE PROBLEM --- People, including hackers, run most programs from the panel menus, or from clicking on icons. They don't ever watch the console where these warnings appear. So, they don't get informed that something is wrong with the software. As a deeper problem, things launched through bonobo-activation-server send their warnings to nowhere, /dev/null, empty space. YOU CAN'T SEE THESE WARNINGS EVEN IF YOU TRY. This is a known bug. THE SOLUTION Fix the goddamn code, of course. Turning on G_DEBUG=fatal_criticals is an excellent way to catch these warnings: the culprit programs will just crash. Then you can use gdb on them. To avoid pissing everyone off, we'll enable this variable automatically on January 1st. In the meantime, we have over 1.5 months to proactively look for critical warnings and fix them. WHAT YOU SHOULD DO -- 1. Get Glib HEAD. 2. Turn on G_DEBUG=fatal_criticals when running your favorite programs. Maintainers: this means you. 3. Fix the bugs. DEADLINE Remember, on January 1st 2006 this change will happen automatically, and things that have not been fixed will start crashing all over the place. So fix them now. Love, Federico ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: IMPORTANT: fix critical warnings before January 1st
On 11/11/05, Luis Villa [EMAIL PROTECTED] wrote: On 11/11/05, Federico Mena Quintero [EMAIL PROTECTED] wrote: Remember, on January 1st 2006 this change will happen automatically, and things that have not been fixed will start crashing all over the place. So fix them now. In the meantime, maybe someone can collect and post lists of them? [And maybe someone should create a keyword for them in bugzilla?] Why a keyword over say the status whiteboard? I don't imagine that people will widely search for these after a couple months down the road (i.e. when we've cleaned almost all of them out), meaning it would just be keyword pollution. ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: IMPORTANT: fix critical warnings before January 1st
[Dropping the devel-announce-list cc until we have an announcement rather than discussion] On 11/11/05, Luis Villa [EMAIL PROTECTED] wrote: On 11/11/05, Elijah Newren [EMAIL PROTECTED] wrote: Why a keyword over say the status whiteboard? I don't imagine that people will widely search for these after a couple months down the road (i.e. when we've cleaned almost all of them out), meaning it would just be keyword pollution. Point. What would the standard word be to use in the whiteboard? I dunno. Anyone have good suggestions? critical-warning-crasher maybe? Also, as an aside, http://bugzilla.gnome.org/reports/boogle.cgi?query=-CRITICAL; seems to be fairly good at catching these as a first approximation, though the lack of case sensitivity also catches places where people say things like non-critical. It may be possible to generate a good enough query without manually marking all the relevant bugs. ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: IMPORTANT: fix critical warnings before January 1st
On 11/11/05, Luis Villa [EMAIL PROTECTED] wrote: On 11/11/05, Elijah Newren [EMAIL PROTECTED] wrote: I dunno. Anyone have good suggestions? critical-warning-crasher maybe? Also, as an aside, http://bugzilla.gnome.org/reports/boogle.cgi?query=-CRITICAL; seems to be fairly good at catching these as a first approximation, though the lack of case sensitivity also catches places where people say things like non-critical. It may be possible to generate a good enough query without manually marking all the relevant bugs. Oh, hrm, good point- I was assuming they'd be unqueryable. Well, it's still not perfect (though I'm guessing an enhancement to boogle or a manually crafted query could be much better). Also, in fact, my previous query only caught the cases where people printed the warnings printed at the terminal. If the user didn't do that but instead just submitted a stack trace, the query would be more like http://bugzilla.gnome.org/reports/boogle.cgi?query=G_LOG_LEVEL_CRITICAL (which happens to be a really tiny list, at the moment) ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
