Re: [gnome-session] rename gnome-session-save to gnome-session-quit
Hi,
(I don't want to pick on Jon here; that's just the latest commit like
this one)
I would appreciate if patches could get posted on bugzilla for review,
instead of being committed directly without asking maintainers. I know
I'm not the fastest reviewer out there, but as I've told several times
before, if you think the patch is important and doesn't get a review
before the next release, then it's welcome to push the patch.
In this case, the patch is mostly good, but the man page is wrong
(--logout is the default behavior, but it's not mentioned and it's
unclear what happens by default; --no-prompt doesn't do anything with
--power-off).
Vincent
Le jeudi 24 février 2011, à 22:56 +, William Jon McCann a écrit :
> commit 8663860ff44b9a5e441e4909a49eee4cfa08378d
> Author: William Jon McCann
> Date: Thu Feb 24 17:38:13 2011 -0500
>
> rename gnome-session-save to gnome-session-quit
>
> Is much less misleading since it doesn't save anything.
>
> doc/man/Makefile.am|2 +-
> doc/man/gnome-session-quit.1 | 25
> doc/man/gnome-session-save.1 | 40 ---
> po/POTFILES.in |2 +-
> tools/Makefile.am | 10 +-
> .../{gnome-session-save.c => gnome-session-quit.c} | 116 +++
> 6 files changed, 51 insertions(+), 144 deletions(-)
> ---
> diff --git a/doc/man/Makefile.am b/doc/man/Makefile.am
> index 72f9a93..e42430a 100644
> --- a/doc/man/Makefile.am
> +++ b/doc/man/Makefile.am
> @@ -1,7 +1,7 @@
> man_MANS = \
> gnome-session.1 \
> gnome-session-properties.1 \
> - gnome-session-save.1
> + gnome-session-quit.1
>
> EXTRA_DIST = \
> $(man_MANS)
> diff --git a/doc/man/gnome-session-quit.1 b/doc/man/gnome-session-quit.1
> new file mode 100644
> index 000..2f6df84
> --- /dev/null
> +++ b/doc/man/gnome-session-quit.1
> @@ -0,0 +1,25 @@
> +.\"
> +.\" gnome-session-quit manual page.
> +.\" (C) 2000 Miguel de Icaza (mig...@helixcode.com)
> +.\" (C) 2009-2010 Vincent Untz (vu...@gnome.org)
> +.\"
> +.TH GNOME-SESSION-QUIT 1 "GNOME"
> +.SH NAME
> +gnome-session-quit \- End the current GNOME session
> +.SH SYNOPSIS
> +.B gnome-session-quit [\-\-logout] [\-\-power-off] [\-\-no-prompt]
> +.SH DESCRIPTION
> +The \fIgnome-session-quit\fP program can be used to end a GNOME session.
> +.PP
> +If called with the \fB\-\-logout\fP option the user will be prompted
> +to confirm logout. The \fB\-\-no\-prompt\fP option can be used to end
> +the session without user interaction.
> +.PP
> +When the \fB\-\-power\-off\fP option is given the user will be
> +prompted to confirm system power off. The \fB\-\-no\-prompt\fP option
> +can be used to power off without user interaction.
> +.SH BUGS
> +If you find bugs in the \fIgnome-session-quit\fP program, please report
> +these on https://bugzilla.gnome.org.
> +.SH SEE ALSO
> +.BR gnome-session(1)
> diff --git a/po/POTFILES.in b/po/POTFILES.in
> index 4b3a1a1..1e7491d 100644
> --- a/po/POTFILES.in
> +++ b/po/POTFILES.in
> @@ -20,4 +20,4 @@ gnome-session/gsm-xsmp-client.c
> gnome-session/gsm-xsmp-server.c
> gnome-session/gsm-util.c
> gnome-session/main.c
> -tools/gnome-session-save.c
> +tools/gnome-session-quit.c
> diff --git a/tools/Makefile.am b/tools/Makefile.am
> index fbc41b5..f53a012 100644
> --- a/tools/Makefile.am
> +++ b/tools/Makefile.am
> @@ -1,14 +1,14 @@
> -bin_PROGRAMS = gnome-session-save
> +bin_PROGRAMS = gnome-session-quit
> libexec_PROGRAMS = gnome-session-is-accelerated
>
> AM_CPPFLAGS =
>
> AM_CFLAGS = $(WARN_CFLAGS)
>
> -gnome_session_save_SOURCES = \
> - gnome-session-save.c
> +gnome_session_quit_SOURCES = \
> + gnome-session-quit.c
>
> -gnome_session_save_CPPFLAGS =\
> +gnome_session_quit_CPPFLAGS =\
> $(AM_CPPFLAGS) \
> $(GNOME_SESSION_CFLAGS) \
> $(DBUS_GLIB_CFLAGS) \
> @@ -16,7 +16,7 @@ gnome_session_save_CPPFLAGS = \
> -DLOCALE_DIR=\""$(datadir)/locale"\"\
> $(DISABLE_DEPRECATED_CFLAGS)
>
> -gnome_session_save_LDADD = \
> +gnome_session_quit_LDADD = \
> $(SM_LIBS) \
> $(ICE_LIBS) \
> $(GNOME_SESSION_LIBS) \
> diff --git a/tools/gnome-session-save.c b/tools/gnome-session-quit.c
> similarity index 59%
> rename from tools/gnome-session-save.c
> rename to tools/gnome-session-quit.c
> index 28f6443..f5d1838 100644
> --- a/tools/gnome-session-save.c
> +++ b/tools/gnome-session-quit.c
> @@ -43,54 +43,23 @@ enum {
> GSM_LOGOUT_MODE_FORCE
> };
>
> -/* True if killing. This is deprecated, but we keep it for compatibility
> - * reasons.
Re: [gnome-session] rename gnome-session-save to gnome-session-quit
On Mon, 2011-02-28 at 13:56 +0100, Vincent Untz wrote: > Hi, > > (I don't want to pick on Jon here; that's just the latest commit like > this one) > > I would appreciate if patches could get posted on bugzilla for review, > instead of being committed directly without asking maintainers. I know > I'm not the fastest reviewer out there, but as I've told several times > before, if you think the patch is important and doesn't get a review > before the next release, then it's welcome to push the patch. > > In this case, the patch is mostly good, but the man page is wrong > (--logout is the default behavior, but it's not mentioned and it's > unclear what happens by default; --no-prompt doesn't do anything with > --power-off). The equivalent patch made to gnome-settings-daemon/plugins/media-keys would also be appreciated. Cheers ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: [gnome-session] rename gnome-session-save to gnome-session-quit
On Mon, 2011-02-28 at 12:58 +, Bastien Nocera wrote: > On Mon, 2011-02-28 at 13:56 +0100, Vincent Untz wrote: > > Hi, > > > > (I don't want to pick on Jon here; that's just the latest commit like > > this one) > > > > I would appreciate if patches could get posted on bugzilla for review, > > instead of being committed directly without asking maintainers. I know > > I'm not the fastest reviewer out there, but as I've told several times > > before, if you think the patch is important and doesn't get a review > > before the next release, then it's welcome to push the patch. > > > > In this case, the patch is mostly good, but the man page is wrong > > (--logout is the default behavior, but it's not mentioned and it's > > unclear what happens by default; --no-prompt doesn't do anything with > > --power-off). > > The equivalent patch made to gnome-settings-daemon/plugins/media-keys > would also be appreciated. Which was already done. Never mind, and thanks :) ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: [gnome-session] rename gnome-session-save to gnome-session-quit
Hi Vincent,
I wrote most of gnome-session and am still listed as a maintainer.
So, I'm not sure what the problem is. I agree in principle with using
code review which is why I asked a few people to look the patch over
for me.
This is crunch time man. It is all about getting it done.
Thanks,
Jon
On Mon, Feb 28, 2011 at 7:56 AM, Vincent Untz wrote:
> Hi,
>
> (I don't want to pick on Jon here; that's just the latest commit like
> this one)
>
> I would appreciate if patches could get posted on bugzilla for review,
> instead of being committed directly without asking maintainers. I know
> I'm not the fastest reviewer out there, but as I've told several times
> before, if you think the patch is important and doesn't get a review
> before the next release, then it's welcome to push the patch.
>
> In this case, the patch is mostly good, but the man page is wrong
> (--logout is the default behavior, but it's not mentioned and it's
> unclear what happens by default; --no-prompt doesn't do anything with
> --power-off).
>
> Vincent
>
> Le jeudi 24 février 2011, à 22:56 +, William Jon McCann a écrit :
>> commit 8663860ff44b9a5e441e4909a49eee4cfa08378d
>> Author: William Jon McCann
>> Date: Thu Feb 24 17:38:13 2011 -0500
>>
>> rename gnome-session-save to gnome-session-quit
>>
>> Is much less misleading since it doesn't save anything.
>>
>> doc/man/Makefile.am | 2 +-
>> doc/man/gnome-session-quit.1 | 25
>> doc/man/gnome-session-save.1 | 40 ---
>> po/POTFILES.in | 2 +-
>> tools/Makefile.am | 10 +-
>> .../{gnome-session-save.c => gnome-session-quit.c} | 116
>> +++
>> 6 files changed, 51 insertions(+), 144 deletions(-)
>> ---
>> diff --git a/doc/man/Makefile.am b/doc/man/Makefile.am
>> index 72f9a93..e42430a 100644
>> --- a/doc/man/Makefile.am
>> +++ b/doc/man/Makefile.am
>> @@ -1,7 +1,7 @@
>> man_MANS = \
>> gnome-session.1 \
>> gnome-session-properties.1 \
>> - gnome-session-save.1
>> + gnome-session-quit.1
>>
>> EXTRA_DIST = \
>> $(man_MANS)
>> diff --git a/doc/man/gnome-session-quit.1 b/doc/man/gnome-session-quit.1
>> new file mode 100644
>> index 000..2f6df84
>> --- /dev/null
>> +++ b/doc/man/gnome-session-quit.1
>> @@ -0,0 +1,25 @@
>> +.\"
>> +.\" gnome-session-quit manual page.
>> +.\" (C) 2000 Miguel de Icaza (mig...@helixcode.com)
>> +.\" (C) 2009-2010 Vincent Untz (vu...@gnome.org)
>> +.\"
>> +.TH GNOME-SESSION-QUIT 1 "GNOME"
>> +.SH NAME
>> +gnome-session-quit \- End the current GNOME session
>> +.SH SYNOPSIS
>> +.B gnome-session-quit [\-\-logout] [\-\-power-off] [\-\-no-prompt]
>> +.SH DESCRIPTION
>> +The \fIgnome-session-quit\fP program can be used to end a GNOME session.
>> +.PP
>> +If called with the \fB\-\-logout\fP option the user will be prompted
>> +to confirm logout. The \fB\-\-no\-prompt\fP option can be used to end
>> +the session without user interaction.
>> +.PP
>> +When the \fB\-\-power\-off\fP option is given the user will be
>> +prompted to confirm system power off. The \fB\-\-no\-prompt\fP option
>> +can be used to power off without user interaction.
>> +.SH BUGS
>> +If you find bugs in the \fIgnome-session-quit\fP program, please report
>> +these on https://bugzilla.gnome.org.
>> +.SH SEE ALSO
>> +.BR gnome-session(1)
>> diff --git a/po/POTFILES.in b/po/POTFILES.in
>> index 4b3a1a1..1e7491d 100644
>> --- a/po/POTFILES.in
>> +++ b/po/POTFILES.in
>> @@ -20,4 +20,4 @@ gnome-session/gsm-xsmp-client.c
>> gnome-session/gsm-xsmp-server.c
>> gnome-session/gsm-util.c
>> gnome-session/main.c
>> -tools/gnome-session-save.c
>> +tools/gnome-session-quit.c
>> diff --git a/tools/Makefile.am b/tools/Makefile.am
>> index fbc41b5..f53a012 100644
>> --- a/tools/Makefile.am
>> +++ b/tools/Makefile.am
>> @@ -1,14 +1,14 @@
>> -bin_PROGRAMS = gnome-session-save
>> +bin_PROGRAMS = gnome-session-quit
>> libexec_PROGRAMS = gnome-session-is-accelerated
>>
>> AM_CPPFLAGS =
>>
>> AM_CFLAGS = $(WARN_CFLAGS)
>>
>> -gnome_session_save_SOURCES = \
>> - gnome-session-save.c
>> +gnome_session_quit_SOURCES = \
>> + gnome-session-quit.c
>>
>> -gnome_session_save_CPPFLAGS = \
>> +gnome_session_quit_CPPFLAGS = \
>> $(AM_CPPFLAGS) \
>> $(GNOME_SESSION_CFLAGS) \
>> $(DBUS_GLIB_CFLAGS) \
>> @@ -16,7 +16,7 @@ gnome_session_save_CPPFLAGS = \
>> -DLOCALE_DIR=\""$(datadir)/locale"\" \
>> $(DISABLE_DEPRECATED_CFLAGS)
>>
>> -gnome_session_save_LDADD = \
>> +gnome_session_quit_LDADD = \
>> $(SM_LIBS) \
>> $(ICE_LIBS) \
>> $(GN
Re: [gnome-session] rename gnome-session-save to gnome-session-quit
Le lundi 28 février 2011, à 08:25 -0500, William Jon McCann a écrit : > Hi Vincent, > > I wrote most of gnome-session and am still listed as a maintainer. Actually, Dan wrote most of the new gnome-session ;-) And I'm sorry, but with two commits in 2011, two commits in 2010 and 10 commits in 2009 (9 of them were in January), I don't consider you as an active maintainer of gnome-session. Don't get me wrong: I do appreciate the patch, I do appreciate what you brought to gnome-session in the past, I do want you to keep patchin gnome-session. And I'm happy with this specific change. Except that it's not 100% right, as a review by a maintainer would have shown. Also, as I wrote, it's not about you specifically, I've seen this from several people. > So, I'm not sure what the problem is. I agree in principle with using > code review which is why I asked a few people to look the patch over > for me. Did you ask the other maintainers? > This is crunch time man. It is all about getting it done. Sure, I agree, which is why I don't block anybody from pushing commits if there was no review in bugzilla after a while. Vincent -- Les gens heureux ne sont pas pressés. ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: [gnome-session] rename gnome-session-save to gnome-session-quit
Le lundi 28 février 2011, à 14:53 +0100, Vincent Untz a écrit : > Also, as I wrote, it's not about you specifically, I've seen this from > several people. Just to make it extremely clear: this is the issue I have. If people want to step up and become co-maintainers of my modules, then please state so. I'll generally be happy to have less maintainer hats. Let me apologize to Jon -- it was not my intention to put him under a bad light for this commit; his commit was simply the last one highlighting a more generic issue. And it was probably not the best example as his commit was mostly right. Cheers, Vincent -- Les gens heureux ne sont pas pressés. ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
