Re: AT-SPI hard code freeze break request
Le vendredi 14 septembre 2007, à 09:42 -0700, Eitan Isaacson a écrit : > Hi. > > This is to request a freeze break on two outstanding patches: > http://bugzilla.gnome.org/show_bug.cgi?id=467366 > http://bugzilla.gnome.org/show_bug.cgi?id=472301 > > The first one is a fix to allow new Firefox 3 event types to be caught. > As you know, Firefox has it's own schedule, and they could afford major > changes now. I think it would be worth putting in that fix so we could > interop with FF3 in this next release. > > The second one is an API conformance bug. We would like to have this in > the earliest version possible since it is a small but fairly significant > fix. > > The above is the opinion of Willie Walker and I with Li Yuan's consent. Those two are not easy to me: the code changes seem okay, but I know nothing about this code base so I can't know if it can have any negative impact. Has this been well-tested? Vincent -- Les gens heureux ne sont pas pressés. ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: AT-SPI hard code freeze break request
Hi All: GNOME 2.20.0 is pyatspi's first official release to the world, so we want to get the API as close to AT-SPI as possible. In addition, we want it to support the impending FF3 event type annotation feature. The patches in question accomplish these goals and have been tested by various members of the AT-SPI, Accerciser, and Orca teams. http://bugzilla.gnome.org/show_bug.cgi?id=467366 is most important because it will allow the new Firefox 3 annotated event types to come through to users of pyatspi (e.g., Dogtail, LDTP, Accerciser, and soon Orca). Without this patch, the annotated Firefox 3 event types do not make it through, breaking any pyatspi client that happens to be listening for the events, whether they are annotated or not. http://bugzilla.gnome.org/show_bug.cgi?id=472301 is important as well because it will allow users of pyatspi to get the expected experience of AT-SPI where the return value of the event handler specifies whether or not to consume a device event. Without this patch, the return value is ignored, breaking with the expected experience of AT-SPI. Hope this helps, and thank you for your consideration, Will On Sat, 2007-09-15 at 10:40 +0200, Vincent Untz wrote: > Le vendredi 14 septembre 2007, à 09:42 -0700, Eitan Isaacson a écrit : > > Hi. > > > > This is to request a freeze break on two outstanding patches: > > http://bugzilla.gnome.org/show_bug.cgi?id=467366 > > http://bugzilla.gnome.org/show_bug.cgi?id=472301 > > > > The first one is a fix to allow new Firefox 3 event types to be caught. > > As you know, Firefox has it's own schedule, and they could afford major > > changes now. I think it would be worth putting in that fix so we could > > interop with FF3 in this next release. > > > > The second one is an API conformance bug. We would like to have this in > > the earliest version possible since it is a small but fairly significant > > fix. > > > > The above is the opinion of Willie Walker and I with Li Yuan's consent. > > Those two are not easy to me: the code changes seem okay, but I know > nothing about this code base so I can't know if it can have any negative > impact. > > Has this been well-tested? > > Vincent > ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: AT-SPI hard code freeze break request
On 9/15/07, Willie Walker <[EMAIL PROTECTED]> wrote: > Hi All: > > GNOME 2.20.0 is pyatspi's first official release to the world, so we > want to get the API as close to AT-SPI as possible. In addition, we > want it to support the impending FF3 event type annotation feature. The > patches in question accomplish these goals and have been tested by > various members of the AT-SPI, Accerciser, and Orca teams. > > http://bugzilla.gnome.org/show_bug.cgi?id=467366 is most important > because it will allow the new Firefox 3 annotated event types to come > through to users of pyatspi (e.g., Dogtail, LDTP, Accerciser, and soon > Orca). Without this patch, the annotated Firefox 3 event types do not > make it through, breaking any pyatspi client that happens to be > listening for the events, whether they are annotated or not. > > http://bugzilla.gnome.org/show_bug.cgi?id=472301 is important as well > because it will allow users of pyatspi to get the expected experience of > AT-SPI where the return value of the event handler specifies whether or > not to consume a device event. Without this patch, the return value is > ignored, breaking with the expected experience of AT-SPI. I really hate hard code freeze break requests of this magnitude, but given your testing and careful explanation...and the fact that new changes in FF are somewhat forcing your hand, here's approval 1 of 2. ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: AT-SPI hard code freeze break request
On 9/15/07, Eitan Isaacson <[EMAIL PROTECTED]> wrote: > Hi. > > I am assuming this is the green light to apply the patch of the first > bug? Nope, you need two approvals from r-t members for any freeze break approval. I gave you one of them (for each patch). You'll need another for each patch before they can be committed. Elijah ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: AT-SPI hard code freeze break request
Le samedi 15 septembre 2007, à 10:20 -0600, Elijah Newren a écrit : > On 9/15/07, Willie Walker <[EMAIL PROTECTED]> wrote: > > Hi All: > > > > GNOME 2.20.0 is pyatspi's first official release to the world, so we > > want to get the API as close to AT-SPI as possible. In addition, we > > want it to support the impending FF3 event type annotation feature. The > > patches in question accomplish these goals and have been tested by > > various members of the AT-SPI, Accerciser, and Orca teams. > > > > http://bugzilla.gnome.org/show_bug.cgi?id=467366 is most important > > because it will allow the new Firefox 3 annotated event types to come > > through to users of pyatspi (e.g., Dogtail, LDTP, Accerciser, and soon > > Orca). Without this patch, the annotated Firefox 3 event types do not > > make it through, breaking any pyatspi client that happens to be > > listening for the events, whether they are annotated or not. > > > > http://bugzilla.gnome.org/show_bug.cgi?id=472301 is important as well > > because it will allow users of pyatspi to get the expected experience of > > AT-SPI where the return value of the event handler specifies whether or > > not to consume a device event. Without this patch, the return value is > > ignored, breaking with the expected experience of AT-SPI. > > I really hate hard code freeze break requests of this magnitude, but > given your testing and careful explanation...and the fact that new > changes in FF are somewhat forcing your hand, here's approval 1 of 2. Thanks for the extended explanation, Willie. Let's get this in. Approval 2 of 2. Vincent -- Les gens heureux ne sont pas pressés. ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: AT-SPI hard code freeze break request
Hi. I am assuming this is the green light to apply the patch of the first bug? Cheers, Eitan. On Sat, 2007-09-15 at 10:20 -0600, Elijah Newren wrote: > I really hate hard code freeze break requests of this magnitude, but > given your testing and careful explanation...and the fact that new > changes in FF are somewhat forcing your hand, here's approval 1 of 2. signature.asc Description: This is a digitally signed message part ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: AT-SPI hard code freeze break request
Thanks for the thumbs up. Committing changes now. On Sat, 2007-09-15 at 23:30 +0200, Vincent Untz wrote: > Le samedi 15 septembre 2007, à 10:20 -0600, Elijah Newren a écrit : > > On 9/15/07, Willie Walker <[EMAIL PROTECTED]> wrote: > > > Hi All: > > > > > > GNOME 2.20.0 is pyatspi's first official release to the world, so we > > > want to get the API as close to AT-SPI as possible. In addition, we > > > want it to support the impending FF3 event type annotation feature. The > > > patches in question accomplish these goals and have been tested by > > > various members of the AT-SPI, Accerciser, and Orca teams. > > > > > > http://bugzilla.gnome.org/show_bug.cgi?id=467366 is most important > > > because it will allow the new Firefox 3 annotated event types to come > > > through to users of pyatspi (e.g., Dogtail, LDTP, Accerciser, and soon > > > Orca). Without this patch, the annotated Firefox 3 event types do not > > > make it through, breaking any pyatspi client that happens to be > > > listening for the events, whether they are annotated or not. > > > > > > http://bugzilla.gnome.org/show_bug.cgi?id=472301 is important as well > > > because it will allow users of pyatspi to get the expected experience of > > > AT-SPI where the return value of the event handler specifies whether or > > > not to consume a device event. Without this patch, the return value is > > > ignored, breaking with the expected experience of AT-SPI. > > > > I really hate hard code freeze break requests of this magnitude, but > > given your testing and careful explanation...and the fact that new > > changes in FF are somewhat forcing your hand, here's approval 1 of 2. > > Thanks for the extended explanation, Willie. > > Let's get this in. Approval 2 of 2. > > Vincent > signature.asc Description: This is a digitally signed message part ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: AT-SPI hard code freeze break request
Thanks for the thumbs up. Committing changes now. On Sat, 2007-09-15 at 23:30 +0200, Vincent Untz wrote: > Le samedi 15 septembre 2007, à 10:20 -0600, Elijah Newren a écrit : > > On 9/15/07, Willie Walker <[EMAIL PROTECTED]> wrote: > > > Hi All: > > > > > > GNOME 2.20.0 is pyatspi's first official release to the world, so we > > > want to get the API as close to AT-SPI as possible. In addition, we > > > want it to support the impending FF3 event type annotation feature. The > > > patches in question accomplish these goals and have been tested by > > > various members of the AT-SPI, Accerciser, and Orca teams. > > > > > > http://bugzilla.gnome.org/show_bug.cgi?id=467366 is most important > > > because it will allow the new Firefox 3 annotated event types to come > > > through to users of pyatspi (e.g., Dogtail, LDTP, Accerciser, and soon > > > Orca). Without this patch, the annotated Firefox 3 event types do not > > > make it through, breaking any pyatspi client that happens to be > > > listening for the events, whether they are annotated or not. > > > > > > http://bugzilla.gnome.org/show_bug.cgi?id=472301 is important as well > > > because it will allow users of pyatspi to get the expected experience of > > > AT-SPI where the return value of the event handler specifies whether or > > > not to consume a device event. Without this patch, the return value is > > > ignored, breaking with the expected experience of AT-SPI. > > > > I really hate hard code freeze break requests of this magnitude, but > > given your testing and careful explanation...and the fact that new > > changes in FF are somewhat forcing your hand, here's approval 1 of 2. > > Thanks for the extended explanation, Willie. > > Let's get this in. Approval 2 of 2. > > Vincent > signature.asc Description: This is a digitally signed message part ___ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list
