[Desktop-packages] [Bug 584632]
For those who want to see this in Thunderbird 38 -- I suggest talking to the Thunderbird people and asking them if they can cherry-pick the patch for Thunderbird without affecting Firefox. If it's really a huge improvement for them, maybe they'll be willing to accept it despite lack of testing. Perhaps file a bug against the Thunderbird product, or get on IRC/e-mail/etc. with the appropriate people. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in thunderbird package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 584632]
(In reply to Jorg K from comment #110) Where in the mochitest.ini do I put my new test? I put it right at the front since I don't understand the syntax of skip-if. Does that skip the next line? Perhaps you can suggest a line where it should go. Or say: After such and such. Just add a line that says [test_bug756984.html] (assuming that's the file's name). Put it right before the next test line, like [test_bug784410.html] or whatever. The skip-if, support-files, etc. lines apply to the preceding test file, so don't put it before one of those lines. (This is confusing. I looked it up in the online docs: https://ci.mozilla.org/job/mozilla-central-docs/Tree_Documentation/build/buildsystem/test_manifests.html) In the test I use a span123/span to get offset 3 when clicking behind it. Without the span, I get offset 4, which I find surprising, or clicking at the front gives offset 1 instead of 0. FF 36 does the same, so I guess it's right, but I'd like to understand why 4 and not 3, or 1 and not 0. Why does the span make a difference? You have a newline at the beginning of the div. That's the first character in the text node (although it doesn't normally render). If you did div id='div1'123br456br/div all on one line, the offsets would be as you expected even without the span. Anyway, the tests are passed. Without my changes, the first test fails as expected. As I said in comment #106: There are already tests for hitting the end key and navigating with the arrow keys, so this test should be the only one we need additionally. Sounds great! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in thunderbird package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 584632]
(In reply to Jorg K from comment #106) Pushed to try server (thanks guys for the support!): https://treeherder.mozilla.org/#/jobs?repo=tryrevision=9782fa678cd1 Treeherder isn't loading for me right now, but someone else who looked said it seemed fine. Just out of interest: Why build on all platforms and then just execute on Linux? I mean, why build it in the first place? Just to see that it compiles? If it already compiled once, and I only rerun tests, that doesn't make too much sense. Yes, to see that it compiles. Different platforms use different compilers, and maybe sometimes different compiler versions, and they treat different things as errors. Compiling the code on all platforms is usually a good resources-safety tradeoff. (Ideally all tests would be run on all platforms, but it overloads the try servers.) Further steps: If this try run goes well, the only thing missing is a test for the changes I made. Two scenarios are already covered by the existing tests which I had to change: the moving around with the left arrow and the jumping to the end of the line with a key stroke. What's missing is the clicking beyond the end of the line. The first try run in comment #71 was done with only the code to fix the clicking. No tests failed, so there wasn't a test for this, so it needs to be added now. Sounds good! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in thunderbird package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 584632]
Try running the tests locally without your patches if you want to be sure (hg qpop -a will get rid of them if you're using mq). If they fail even without your patches, don't worry about it. In theory all tests should work on all supported platforms and configurations, but in practice some small fraction will break on some systems for various reasons, and in practice we only require that they work on the try servers. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in thunderbird package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 584632]
(In reply to Jorg K from comment #92) OK, but how do I send the patch to the try server? I have my level 1 access rights and I believe SSH is set up correctly. I tried hg push -f ssh://mozi...@jorgk.com@hg.mozilla.org/try/ *before* coming across the hg qnew command. It returned: No changes found or words to that extent. I haven't tried after the hg qnew. So what is the exact sequence of commands? BTW, I'm on Windows 7. 30 seconds of your time save me three hours of (very frustrating) research (since I want to focus on the problem and not the infrastructure). If you have some changes you want to commit, and no patches currently applied: hg qnew mypatchname # This saves your changes to an mq patch hg qnew -m try: -b do -p all -u all[x64] -t none try # Make a second patch with the try line hg push -f mc-try # Make sure you have Magnus' line in .hg/hgrc hg qdelete try # Delete the empty try patch Note: this will leave you with a patch in mq called mypatchname with your changes. If you make any new changes to the patch and want to submit to try again, do the same, except instead of the first line, do hg qref to refresh the existing patch instead of making a new one. To view your existing patches, try hg qser -s; to move around, you can use hg qpop and hg qpush and hg qgoto; for more help, try hg help mq or hg help commandname. If you see any weird changes that only appear on some platforms and don't look related to your changes, they're probably random (intermittent) failures that are unrelated to your changes. You can usually spot changes that you really caused because they'll show up on all platforms, and look related to your changes. If you're not sure, you can ask us, or ask on IRC for a quicker response. However, this stuff worries me (3x crashed, 1x time out) 965721 Intermittent test_bug409604.html, test_bug719533.html, test_richtext2.html, test_bug412567.html | application crashed [@ imgStatusTracker::RecordCancel()] 969526 Intermittent test_richtext.html,test_richtext2.html,test_bug436801.html | application crashed [@ KERNELBASE.dll + 0x89ae4] (ABORT: Should have mProgressTracker until we create mImage: 'mProgressTracker') 1129538 Intermittent test_draggableprop.html,test_richtext2.html | application crashed [@ mozalloc_abort(char const*)] after ABORT: Should have given mProgressTracker to mImage: '!mProgressTracker', file /image/src/imgRequest.cpp, line 149 1142900 Intermittent test_richtext2.html | application timed out after 330 seconds with no output Any comments on these crashes and time-outs? Don't worry about those. These tests fail sometimes at random -- it's not connected to your changes. P.S.: Would you be able to let me know your time-zone so I know when not to expect feedback ;-) I'm UTC+0200, and switching to UTC+0300 this Thursday night. Last I was aware, Ehsan lives in eastern Canada and so should be UTC-0400. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in thunderbird package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 584632]
A good try line to use by default for editor changes is: try: -b do -p all -u all[x64] -t none This will build on all platforms (to detect compile errors), and will run tests only on 64-bit Linux (to avoid wasting resources). If there might be platform-specific test failures, remove the [x64], but I don't think you need to do that here. For Mercurial -- if you're using mq (which you should), you don't ever want to do hg commit. The patch you've attached is exactly right. Here are the try results for you: https://treeherder.mozilla.org/#/jobs?repo=tryrevision=fd11f71e3daa -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in thunderbird package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 584632]
Okay, this caused some try failures. One of them is an unexpected pass in richtext2, which is good! It means you just have to update the test so it knows we're supposed to pass now. In the case of richtext2, you want to edit the file editor/libeditor/tests/browserscope/lib/richtext2/currentStatus.js and remove the appropriate lines (this is different from how most tests need to be updated). To check that it worked, run this (which may take a while and you have to keep the browser window focused): ./mach mochitest-plain editor/libeditor/tests/browserscope If you're on Linux, you should be able to install the appropriate package for the xvfb-run command and use this instead so it runs without creating a window you have to keep in focus: xvfb-run ./mach mochitest-plain editor/libeditor/tests/browserscope The other failure I see is layout/generic/test/test_movement_by_characters.html, which you need to look at. It could be your patch has a problem, or it could be the test needs to be updated. If you're having trouble, please feel free to ask for help! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in thunderbird package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 584632]
The failure in editor/libeditor/tests/test_selection_move_commands.xul also needs looking at. Otherwise, looks good! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in thunderbird package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 584632]
For the record, from black-box testing of WebKit a few years ago, it looked like it normalized the selection after every change. Even if you called .addRange(), it copied the range and then stuck the selection endpoints inside a nearby text node if available, etc. I think it's taking things too far to change script-specified selections, but the right way to do this is probably to have some sort of helper method in Selection like NormalizePoint(nsINode*, int32_t) and call it before every user-initiated selection change. We might want to disallow other types of user-created selections from occurring in the future, although my brain is too rusty to supply any. Do we want to allow a selection like bfoo/b{}ibar/i, with the selection collapsed in between the b and i? IIRC, WebKit in my testing forced this to be bfoo[]/bibar/i (always making it on the previous text node). A ten-second test in WordPad suggests this is the right thing to do. I don't think any of this has to be in the scope of the current bug, though. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in thunderbird package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 584632]
The try results look good to me, so you just need to include an automated regression test (mochitest) and you can ask a reviewer to approve it to be included in Firefox. You want to add a file patterned off something like this: https://dxr.mozilla.org/mozilla- central/source/layout/generic/test/test_bug970363.html You could base it off one of the tests you attached to this bug, but instead of asking the user to click, you have to synthesize a click using a function from EventUtils.js https://dxr.mozilla.org/mozilla- central/source/testing/mochitest/tests/SimpleTest/EventUtils.js, possibly synthesizeMouse. And instead of doing alert(), do something like is(myVariable, #text, selection should be in text node). You have to add your test's name to the file layout/generic/test/mochitest.ini, and then you can run it with ./mach mochitest-plain layout/generic/test/test_bug756984.html. It should fail before the patch is applied, and pass after the patch is applied. Thanks a ton for working on this! If you want feedback from me on if your test looks good before asking for review, please feel free to ask me via the feedback flag when uploading your patch. I'm probably less busy than the reviewers. :) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in thunderbird package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 584632]
Oops, I missed that part of comment #68 -- should have read more carefully. I don't know what more there is to do, since it passed a try run. But that's why Ehsan is in charge and not me. ;) In any event, you will need a test at the end of the day, so you could still go ahead and write it now. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in thunderbird package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 584632]
(In reply to Jorg K from comment #18) OK, when you say editor you mean composer. The component that allows the user to more or less WYSIWYG enter text (with fonts, colour, etc.) and pictures and creates HTML which is sent out. I mean the code under editor/ in the Gecko source tree, which handles the backend of editors for both Firefox and Thunderbird. Thunderbird's composer uses the Gecko editor for composing mail, but also has its own code that it puts on top, so the post you link to may be referring to that. This bug is in the editor itself, not the Thunderbird-specific code. The two bugs you mentioned are Thunderbird-specific and not related to the editor (note Product: Thunderbird, vs. this bug with Product: Core). That said, I actually haven't been paying much attention, and for all I know it could be someone has started working on editor again recently and I didn't notice. It doesn't seem so based on glancing at the log, but I didn't look at the commits in detail. If people are working on Thunderbird more, maybe they'll want to fix stuff in the editor too, since some high-profile Thunderbird bugs are really editor bugs. So we can still hope! :) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 584632]
(In reply to Jorg K from comment #12) This bug is still current at version 31.2.0 and 33 beta. Given that it's been carried over from bug 250539 created in 2004, it might be a good idea to one day do something about it ;-) Unfortunately, we have no one actively working on the editor component, so basically all editor bugs on indefinitely on hold. Occasionally one or two gets fixed here or there, but as things stand, I wouldn't count on it. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 888355] Re: users-admin should not allow creation of users with encrypted home who aren't asked for password on login
*** This bug is a duplicate of bug 577563 *** https://bugs.launchpad.net/bugs/577563 In 11.10, hitting the super/meta/whatever key and typing Users gets me Users and Groups (= users-admin) and also User Accounts (= gnome- control-center?). User Accounts is the one that shows up in System Settings... from the button in the upper right. If we're not supposed to use users-admin anymore, shouldn't it be removed? I upgraded from 11.04, if that helps. Should I file a separate bug? If it's no longer maintained, surely it should be uninstalled when the user upgrades. I can confirm that the new applet doesn't allow the same issue to arise, because it just doesn't allow you to do either of the two conflicting things. This seems like a, well, not really optimal solution to the problem, but I can't argue it's not a solution. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-system-tools in Ubuntu. https://bugs.launchpad.net/bugs/888355 Title: users-admin should not allow creation of users with encrypted home who aren't asked for password on login Status in “gnome-system-tools” package in Ubuntu: Triaged Bug description: Tested in Ubuntu 11.04 and 11.10. Steps to reproduce: 1) Go to Users and Groups (users-admin) 2) Click Add 3) Pick any name 4) Check Encrypt home folder to protect sensitive data 5) Click OK 6) Set any password 7) Check Don't ask for password on login 8) Click OK Expected result: An error is raised at some point, because the user will not be able to log in. Actual result: User is created normally. On login, the user is not prompted for their password, so the login fails. In Ubuntu 11.04, some cryptic error messages display and the GUI hangs; in Ubuntu 11.10, you're returned to the login screen. Since the user is not prompted for their password, the home directory cannot be decrypted, so login will fail. The two options are contradictory, and it should be impossible to select both. It might also be worthwhile if the program responsible for login (gdm?) detected this conflict and prompted the user for their password, ignoring the preference not to be prompted. However, the preferences are still logically contradictory, so the administrator should not be allowed to select both when creating a user. Bug #581303 and Bug #577563 are related, but were filed against gdm and eCryptfs. The problem should still be fixed in users-admin regardless of whether there's a workaround in gdm. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-system-tools/+bug/888355/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 577563] Re: Automatic login fails and computer hangs (Lucid)
So does Ubuntu plan to switch to the new upstream applet in a future version? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-system-tools in Ubuntu. https://bugs.launchpad.net/bugs/577563 Title: Automatic login fails and computer hangs (Lucid) Status in “gnome-system-tools” package in Ubuntu: Triaged Bug description: Binary package hint: gdm 1) Ubuntu 10.04 LTS 2) gdm: Installed: 2.30.0-0ubuntu5 Candidate: 2.30.0-0ubuntu5 Version table: *** 2.30.0-0ubuntu5 0 500 http://nl.archive.ubuntu.com/ubuntu/ lucid/main Packages 100 /var/lib/dpkg/status 3) I expected Ubuntu to login automatically when booting: In the screen System Administration Users and Groups Password Change I select the box 'Don't ask for password on login' (automatic login). 4) Instead, when I boot the computer: - It boots fine until the login screen is loaded - Then I select my account on the login screen. - Next, I get a bunch of different error messages, in the following order: (1) Could not update ICEauthority file /home/user/.ICEauthority (2) Error message that reads something like: Problem with the configuration server, (3) Error from Nautilus: (translated from dutch): Cannot create mandatory directories: /home/user/Desktop /home/user/.nautilus (4) Update Window: Record your encryption passphrase No idea what I have to do with this, if I execute the suggested action, this has no effect, and the system doesn't respond as indicated in the window itself. (5) Now I get the blank default Desktop background, with nothing on it (no menu's, links, etc.) I am sort of logged in however, because I can get a screen to shut down, restart etc., when pushing my computer's on/off button. And after a break I get the normal login window that asks my password. If I enter it, the system hangs. Maybe this bug has to do with messed up file permissions? I have no idea. Maybe it's related to the fact that my home directory is encrypted (encryptfs) Work-around to be able to login again and turn autmatic login off: boot with recovery mode, log in manually from the command prompt, and run 'startx' to start up ubuntu. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-system-tools/+bug/577563/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 888355] [NEW] users-admin should not allow creation of users with encrypted home who aren't asked for password on login
Public bug reported: Tested in Ubuntu 11.04 and 11.10. Steps to reproduce: 1) Go to Users and Groups (users-admin) 2) Click Add 3) Pick any name 4) Check Encrypt home folder to protect sensitive data 5) Click OK 6) Set any password 7) Check Don't ask for password on login 8) Click OK Expected result: An error is raised at some point, because the user will not be able to log in. Actual result: User is created normally. On login, the user is not prompted for their password, so the login fails. In Ubuntu 11.04, some cryptic error messages display and the GUI hangs; in Ubuntu 11.10, you're returned to the login screen. Since the user is not prompted for their password, the home directory cannot be decrypted, so login will fail. The two options are contradictory, and it should be impossible to select both. It might also be worthwhile if the program responsible for login (gdm?) detected this conflict and prompted the user for their password, ignoring the preference not to be prompted. However, the preferences are still logically contradictory, so the administrator should not be allowed to select both when creating a user. Bug #581303 and Bug #577563 are related, but were filed against gdm and eCryptfs. The problem should still be fixed in users-admin regardless of whether there's a workaround in gdm. ** Affects: gnome-system-tools (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-system-tools in Ubuntu. https://bugs.launchpad.net/bugs/888355 Title: users-admin should not allow creation of users with encrypted home who aren't asked for password on login Status in “gnome-system-tools” package in Ubuntu: New Bug description: Tested in Ubuntu 11.04 and 11.10. Steps to reproduce: 1) Go to Users and Groups (users-admin) 2) Click Add 3) Pick any name 4) Check Encrypt home folder to protect sensitive data 5) Click OK 6) Set any password 7) Check Don't ask for password on login 8) Click OK Expected result: An error is raised at some point, because the user will not be able to log in. Actual result: User is created normally. On login, the user is not prompted for their password, so the login fails. In Ubuntu 11.04, some cryptic error messages display and the GUI hangs; in Ubuntu 11.10, you're returned to the login screen. Since the user is not prompted for their password, the home directory cannot be decrypted, so login will fail. The two options are contradictory, and it should be impossible to select both. It might also be worthwhile if the program responsible for login (gdm?) detected this conflict and prompted the user for their password, ignoring the preference not to be prompted. However, the preferences are still logically contradictory, so the administrator should not be allowed to select both when creating a user. Bug #581303 and Bug #577563 are related, but were filed against gdm and eCryptfs. The problem should still be fixed in users-admin regardless of whether there's a workaround in gdm. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-system-tools/+bug/888355/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 577563] Re: Automatic login fails and computer hangs (Lucid)
In reply to comment #1: the bug is not invalid, and this is not a local issue. See bug #888355 for detailed steps to reproduce. The combination of these two preferences makes login impossible. The user administration tool should make such combinations impossible (bug #888355), but if they do occur somehow, gdm should ask for the password so that it can decrypt the home directory. At the very least, it should raise a clear error message. Currently it gives very cryptic errors and login hangs (on Ubuntu 11.04), or it gives no error message at all and just returns you to the login screen (on Ubuntu 11.10). There's definitely room for improvement here. ** Changed in: gdm (Ubuntu) Status: Invalid = Confirmed ** Changed in: gdm (Ubuntu) Status: Confirmed = New -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gdm in Ubuntu. https://bugs.launchpad.net/bugs/577563 Title: Automatic login fails and computer hangs (Lucid) Status in “gdm” package in Ubuntu: New Bug description: Binary package hint: gdm 1) Ubuntu 10.04 LTS 2) gdm: Installed: 2.30.0-0ubuntu5 Candidate: 2.30.0-0ubuntu5 Version table: *** 2.30.0-0ubuntu5 0 500 http://nl.archive.ubuntu.com/ubuntu/ lucid/main Packages 100 /var/lib/dpkg/status 3) I expected Ubuntu to login automatically when booting: In the screen System Administration Users and Groups Password Change I select the box 'Don't ask for password on login' (automatic login). 4) Instead, when I boot the computer: - It boots fine until the login screen is loaded - Then I select my account on the login screen. - Next, I get a bunch of different error messages, in the following order: (1) Could not update ICEauthority file /home/user/.ICEauthority (2) Error message that reads something like: Problem with the configuration server, (3) Error from Nautilus: (translated from dutch): Cannot create mandatory directories: /home/user/Desktop /home/user/.nautilus (4) Update Window: Record your encryption passphrase No idea what I have to do with this, if I execute the suggested action, this has no effect, and the system doesn't respond as indicated in the window itself. (5) Now I get the blank default Desktop background, with nothing on it (no menu's, links, etc.) I am sort of logged in however, because I can get a screen to shut down, restart etc., when pushing my computer's on/off button. And after a break I get the normal login window that asks my password. If I enter it, the system hangs. Maybe this bug has to do with messed up file permissions? I have no idea. Maybe it's related to the fact that my home directory is encrypted (encryptfs) Work-around to be able to login again and turn autmatic login off: boot with recovery mode, log in manually from the command prompt, and run 'startx' to start up ubuntu. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/577563/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp