[Desktop-packages] [Bug 116453]
(In reply to Jason Crain from comment #14) > (In reply to Nelson Benitez from comment #13) > > Hi Jason, thank you very much for the patch, btw, today I was reading this > > pdf: > > > > http://www.compsci.hunter.cuny.edu/~sweiss/course_materials/csci493.70/ > > lecture_notes/GTK_textview.pdf > > > > and noticed that lot of words with double f, like 'buffer', are not > > found[1] when searching for it, also when copied to gedit it shows the > > unicode not found glyph inplace of the 'ff' in the word. > > > > So, is your patch covering this double f case? > > No, it does not fix that. That file has a different problem and I don't see > a way of fixing it. The PDF creator would need to add some extra > information before we could guess that character code 27 should be a double > f. Thanks Jason for explanation, indeed it was a problem in the PDF creator. Just for completeness I'm posting link describing the problem and solution in pdfTEX: http://tex.stackexchange.com/questions/31113/enable-searching-in-a -pdflatex-generated-document Regards, -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/116453 Title: evince can not find ü in attached PDF Status in Poppler: Fix Released Status in poppler package in Ubuntu: Fix Committed Bug description: Binary package hint: evince 1) lsb_release -rd Description: Ubuntu Vivid Vervet (development branch) Release: 15.04 2) apt-cache policy evince evince: Installed: 3.14.1-0ubuntu1 Candidate: 3.14.1-0ubuntu1 Version table: *** 3.14.1-0ubuntu1 0 500 http://us.archive.ubuntu.com/ubuntu/ vivid/main amd64 Packages 100 /var/lib/dpkg/status 3) What is expected to happen with the attached document is when one searches for: über it is found: https://bugs.launchpad.net/ubuntu/+source/poppler/+bug/116453/+attachment/102979/+files/example.pdf 4) What happens instead is it does not return any matches. WORKAROUND: Use the built-in PDF viewer+search with chromium-browser or chrome (doesn't work in Firefox). apt-cache policy chromium-browser chromium-browser: Installed: 39.0.2171.65-0ubuntu0.14.04.1.1064 Candidate: 39.0.2171.65-0ubuntu0.14.04.1.1064 Version table: *** 39.0.2171.65-0ubuntu0.14.04.1.1064 0 500 http://us.archive.ubuntu.com/ubuntu/ trusty-updates/universe amd64 Packages 500 http://security.ubuntu.com/ubuntu/ trusty-security/universe amd64 Packages 100 /var/lib/dpkg/status 34.0.1847.116-0ubuntu2 0 500 http://us.archive.ubuntu.com/ubuntu/ trusty/universe amd64 Packages apt-cache policy google-chrome-stable:i386 google-chrome-stable:i386: Installed: 39.0.2171.95-1 Candidate: 39.0.2171.95-1 Version table: *** 39.0.2171.95-1 0 500 http://dl.google.com/linux/chrome/deb/ stable/main i386 Packages 100 /var/lib/dpkg/status ProblemType: Bug Architecture: i386 Date: Wed May 23 18:22:27 2007 DistroRelease: Ubuntu 7.04 ExecutablePath: /usr/bin/evince Package: evince 0.8.1-0ubuntu1 PackageArchitecture: i386 ProcEnviron: LANGUAGE=en_US:en PATH=~/local/bin:~/local/lib:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games LANG=en_US.UTF-8 SHELL=/bin/bash SourcePackage: evince Uname: Linux copper 2.6.20-15-generic #2 SMP Sun Apr 15 07:36:31 UTC 2007 i686 GNU/Linux To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/116453/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 116453]
Hi Jason, thank you very much for the patch, btw, today I was reading this pdf: http://www.compsci.hunter.cuny.edu/~sweiss/course_materials/csci493.70/lecture_notes/GTK_textview.pdf and noticed that lot of words with double f, like 'buffer', are not found[1] when searching for it, also when copied to gedit it shows the unicode not found glyph inplace of the 'ff' in the word. So, is your patch covering this double f case? If so, please ignore this comment, but for a quick reading over this bug I thought this double f case was not handled as it wasn't accented word or diacritic. Thank you. [1] Some 'buffer' words are found, the ones in a code block, but the ones in the normal text are not. Eg. the 5th paragraph of the fourth page, that starts with Locations within a text buffer are represented... -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/116453 Title: evince can not find ü in attached PDF Status in Poppler: Fix Released Status in poppler package in Ubuntu: Fix Committed Bug description: Binary package hint: evince 1) lsb_release -rd Description: Ubuntu Vivid Vervet (development branch) Release: 15.04 2) apt-cache policy evince evince: Installed: 3.14.1-0ubuntu1 Candidate: 3.14.1-0ubuntu1 Version table: *** 3.14.1-0ubuntu1 0 500 http://us.archive.ubuntu.com/ubuntu/ vivid/main amd64 Packages 100 /var/lib/dpkg/status 3) What is expected to happen with the attached document is when one searches for: über it is found: https://bugs.launchpad.net/ubuntu/+source/poppler/+bug/116453/+attachment/102979/+files/example.pdf 4) What happens instead is it does not return any matches. WORKAROUND: Use the built-in PDF viewer+search with chromium-browser or chrome (doesn't work in Firefox). apt-cache policy chromium-browser chromium-browser: Installed: 39.0.2171.65-0ubuntu0.14.04.1.1064 Candidate: 39.0.2171.65-0ubuntu0.14.04.1.1064 Version table: *** 39.0.2171.65-0ubuntu0.14.04.1.1064 0 500 http://us.archive.ubuntu.com/ubuntu/ trusty-updates/universe amd64 Packages 500 http://security.ubuntu.com/ubuntu/ trusty-security/universe amd64 Packages 100 /var/lib/dpkg/status 34.0.1847.116-0ubuntu2 0 500 http://us.archive.ubuntu.com/ubuntu/ trusty/universe amd64 Packages apt-cache policy google-chrome-stable:i386 google-chrome-stable:i386: Installed: 39.0.2171.95-1 Candidate: 39.0.2171.95-1 Version table: *** 39.0.2171.95-1 0 500 http://dl.google.com/linux/chrome/deb/ stable/main i386 Packages 100 /var/lib/dpkg/status ProblemType: Bug Architecture: i386 Date: Wed May 23 18:22:27 2007 DistroRelease: Ubuntu 7.04 ExecutablePath: /usr/bin/evince Package: evince 0.8.1-0ubuntu1 PackageArchitecture: i386 ProcEnviron: LANGUAGE=en_US:en PATH=~/local/bin:~/local/lib:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11:/usr/games LANG=en_US.UTF-8 SHELL=/bin/bash SourcePackage: evince Uname: Linux copper 2.6.20-15-generic #2 SMP Sun Apr 15 07:36:31 UTC 2007 i686 GNU/Linux To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/116453/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 599846]
Thank you! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/599846 Title: firefox right click open containing folder should highlight file Status in The Mozilla Firefox Browser: Fix Released Status in “firefox” package in Ubuntu: Confirmed Bug description: Binary package hint: firefox The only reason I am assuming this is a bug is because the functionality is in Windows. Basically, if the user right clicks on a file in the Downloads of Firefox and selects Open Containing Folder, Nautilus should open with the file highlighted to make the file easier to find. 1) The release of Ubuntu you are using, via 'lsb_release -rd' or System - About Ubuntu. Description: Ubuntu 10.04 LTS Release: 10.04 2) The version of the package you are using, via 'apt-cache policy packagename' or by checking in Synaptic. Installed: 3.6.3+nobinonly-0ubuntu4 Candidate: 3.6.3+nobinonly-0ubuntu4 Version table: *** 3.6.3+nobinonly-0ubuntu4 0 500 http://us.archive.ubuntu.com/ubuntu/ lucid/main Packages 100 /var/lib/dpkg/status 3) What you expected to happen I expected my file to be highlighted. 4) What happened instead Nautilus opened, but the file was not highlighted. ProblemType: Bug DistroRelease: Ubuntu 10.04 Package: firefox 3.6.3+nobinonly-0ubuntu4 ProcVersionSignature: Ubuntu 2.6.32-22.36-generic 2.6.32.11+drm33.2 Uname: Linux 2.6.32-22-generic i686 Architecture: i386 Date: Tue Jun 29 11:15:58 2010 FirefoxPackages: firefox 3.6.3+nobinonly-0ubuntu4 firefox-gnome-support 3.6.3+nobinonly-0ubuntu4 firefox-branding 3.6.3+nobinonly-0ubuntu4 abroswer N/A abrowser-branding N/A InstallationMedia: Ubuntu 10.04 LTS Lucid Lynx - Release i386 (20100429) ProcEnviron: LANG=en_US.utf8 SHELL=/bin/bash SourcePackage: firefox To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/599846/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 129219]
Thank you! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/129219 Title: firefox download manager - Open containing folder with preselected file in nautilus/file manager Status in The Mozilla Firefox Browser: Fix Released Status in “firefox” package in Ubuntu: Triaged Status in “nautilus” package in Ubuntu: Invalid Bug description: Binary package hint: firefox After a right click on a downloaded file in the download manager, when you choose Open containing folder it just open the file manager Nautilus in the folder of the file. It should select the file in the file manager and scroll the window if necessary like Firefox does in its Win32 version. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/129219/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 599846]
Hi Karl, is this now ok to commit? if so, could you commit for me? (I don't have commit rights).. Thanks! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/599846 Title: firefox right click open containing folder should highlight file Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Confirmed Bug description: Binary package hint: firefox The only reason I am assuming this is a bug is because the functionality is in Windows. Basically, if the user right clicks on a file in the Downloads of Firefox and selects Open Containing Folder, Nautilus should open with the file highlighted to make the file easier to find. 1) The release of Ubuntu you are using, via 'lsb_release -rd' or System - About Ubuntu. Description: Ubuntu 10.04 LTS Release: 10.04 2) The version of the package you are using, via 'apt-cache policy packagename' or by checking in Synaptic. Installed: 3.6.3+nobinonly-0ubuntu4 Candidate: 3.6.3+nobinonly-0ubuntu4 Version table: *** 3.6.3+nobinonly-0ubuntu4 0 500 http://us.archive.ubuntu.com/ubuntu/ lucid/main Packages 100 /var/lib/dpkg/status 3) What you expected to happen I expected my file to be highlighted. 4) What happened instead Nautilus opened, but the file was not highlighted. ProblemType: Bug DistroRelease: Ubuntu 10.04 Package: firefox 3.6.3+nobinonly-0ubuntu4 ProcVersionSignature: Ubuntu 2.6.32-22.36-generic 2.6.32.11+drm33.2 Uname: Linux 2.6.32-22-generic i686 Architecture: i386 Date: Tue Jun 29 11:15:58 2010 FirefoxPackages: firefox 3.6.3+nobinonly-0ubuntu4 firefox-gnome-support 3.6.3+nobinonly-0ubuntu4 firefox-branding 3.6.3+nobinonly-0ubuntu4 abroswer N/A abrowser-branding N/A InstallationMedia: Ubuntu 10.04 LTS Lucid Lynx - Release i386 (20100429) ProcEnviron: LANG=en_US.utf8 SHELL=/bin/bash SourcePackage: firefox To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/599846/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 129219]
Hi Karl, is this now ok to commit? if so, could you commit for me? (I don't have commit rights).. Thanks! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/129219 Title: firefox download manager - Open containing folder with preselected file in nautilus/file manager Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “nautilus” package in Ubuntu: Invalid Bug description: Binary package hint: firefox After a right click on a downloaded file in the download manager, when you choose Open containing folder it just open the file manager Nautilus in the folder of the file. It should select the file in the file manager and scroll the window if necessary like Firefox does in its Win32 version. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/129219/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 599846]
Created attachment 829607 0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch (In reply to Karl Tomlinson (:karlt) from comment #20) Comment on attachment 826479 0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch Thanks. This is good. Just some minor things: Updated patch with those things corrected. :-) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/599846 Title: firefox right click open containing folder should highlight file Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Confirmed Bug description: Binary package hint: firefox The only reason I am assuming this is a bug is because the functionality is in Windows. Basically, if the user right clicks on a file in the Downloads of Firefox and selects Open Containing Folder, Nautilus should open with the file highlighted to make the file easier to find. 1) The release of Ubuntu you are using, via 'lsb_release -rd' or System - About Ubuntu. Description: Ubuntu 10.04 LTS Release: 10.04 2) The version of the package you are using, via 'apt-cache policy packagename' or by checking in Synaptic. Installed: 3.6.3+nobinonly-0ubuntu4 Candidate: 3.6.3+nobinonly-0ubuntu4 Version table: *** 3.6.3+nobinonly-0ubuntu4 0 500 http://us.archive.ubuntu.com/ubuntu/ lucid/main Packages 100 /var/lib/dpkg/status 3) What you expected to happen I expected my file to be highlighted. 4) What happened instead Nautilus opened, but the file was not highlighted. ProblemType: Bug DistroRelease: Ubuntu 10.04 Package: firefox 3.6.3+nobinonly-0ubuntu4 ProcVersionSignature: Ubuntu 2.6.32-22.36-generic 2.6.32.11+drm33.2 Uname: Linux 2.6.32-22-generic i686 Architecture: i386 Date: Tue Jun 29 11:15:58 2010 FirefoxPackages: firefox 3.6.3+nobinonly-0ubuntu4 firefox-gnome-support 3.6.3+nobinonly-0ubuntu4 firefox-branding 3.6.3+nobinonly-0ubuntu4 abroswer N/A abrowser-branding N/A InstallationMedia: Ubuntu 10.04 LTS Lucid Lynx - Release i386 (20100429) ProcEnviron: LANG=en_US.utf8 SHELL=/bin/bash SourcePackage: firefox To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/599846/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 129219]
Created attachment 829607 0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch (In reply to Karl Tomlinson (:karlt) from comment #20) Comment on attachment 826479 0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch Thanks. This is good. Just some minor things: Updated patch with those things corrected. :-) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/129219 Title: firefox download manager - Open containing folder with preselected file in nautilus/file manager Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “nautilus” package in Ubuntu: Invalid Bug description: Binary package hint: firefox After a right click on a downloaded file in the download manager, when you choose Open containing folder it just open the file manager Nautilus in the folder of the file. It should select the file in the file manager and scroll the window if necessary like Firefox does in its Win32 version. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/129219/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 599846]
(In reply to Karl Tomlinson (:karlt) from comment #17)
Comment on attachment 813885
0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch
Thank you for working out how to do this, Nelson. This looks like the right
approach.
You're welcome!, and sorry for getting back to you after a couple weeks but
I've been busy lately with only some spare time on weekends.
Putting this in the nsGIOService is fine, even though the current
implementation doesn't use GIO, because GIO's GDBus will be the preferred
DBus
library once Mozilla is no longer supporting older systems, and the method is
similar to other existing methods on nsGIOService.
The interface can be simplified to just one additional method on
nsIGIOService
that returns NS_ERROR_NOT_AVAILABLE or similar when FileManager1 is not
available.
Done.
ListActivatableNames doesn't sound like what we want here. I assume that is
looking for /usr/share/dbus-1/services/org.freedesktop.FileManager1.service,
but the interface may be provided by a non activatable application such as a
daemon in the desktop environment. That is in fact the appropriate way to
support the interface because it means that different applications can be
selected by the user [1]. What Nautilus does [2][3] is unfortunate because
it
means that people that don't want Nautilus used to reveal a file will have to
uninstall nautilus from the system, removing the option of other users using
Nautilus.
Yes you're right, although file managers are a somewhat special case of a
program
very attached to its desktop environment, but they should still play well with
other file managers. Thanks for the links.
The simplest approach would be to use the synchronous dbus_g_proxy_call() so
that we know whether the call succeeds. Given this particular use of DBus
where the user is wanting to open a new application, or at least a new
window,
which is going to take time, the additional round trip time via the DBus
daemon is not going to be major.
Done, using dbus_g_proxy_call() now.
Perhaps the call could set a flag if it fails, in order to save checking the
DBus call each time for systems without FileManager1, or perhaps there is a
Done.
way to register for notifications when the interface becomes available, but
that may be more trouble than it is worth. Similarly I imagine there is a
notification when the interface is no longer available (the destroy signal
maybe?) so the call would need only be synchronous the first time, but that
can be a future optimization when necessary.
I left this out of the patch to keep it simple, but as you said it can be added
in a future update.
Gecko file style is to use spaces for indentation, with no tabs.
Call dbus_connection_set_exit_on_disconnect(dbusConnection, false) in case
this is the first use of the connection.
Done.
+ char *uris[2] = { (char*)PromiseFlatCString(uri).get(), NULL };
The PromiseFlatCString usage is not good because the pointer is used after
the
PromiseFlatCString is destroyed.
I expect uri.get() can be used here.
Please use const_cast instead of (char*), or, perhaps better, make this
const char *uris[2].
Done.
(In reply to Nelson Benítez León from comment #12)
some file managers when
passed a full uri would try to 'run' the file (as was thunar in xfce or
konqueror in kde)
I was surprised by that behavior too. I think there is a KDE bug report on
that.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/599846
Title:
firefox right click open containing folder should highlight file
Status in The Mozilla Firefox Browser:
Confirmed
Status in “firefox” package in Ubuntu:
Confirmed
Bug description:
Binary package hint: firefox
The only reason I am assuming this is a bug is because the
functionality is in Windows. Basically, if the user right clicks on a
file in the Downloads of Firefox and selects Open Containing Folder,
Nautilus should open with the file highlighted to make the file easier
to find.
1) The release of Ubuntu you are using, via 'lsb_release -rd' or System -
About Ubuntu.
Description: Ubuntu 10.04 LTS
Release: 10.04
2) The version of the package you are using, via 'apt-cache policy
packagename' or by checking in Synaptic.
Installed: 3.6.3+nobinonly-0ubuntu4
Candidate: 3.6.3+nobinonly-0ubuntu4
Version table:
*** 3.6.3+nobinonly-0ubuntu4 0
500 http://us.archive.ubuntu.com/ubuntu/ lucid/main Packages
100 /var/lib/dpkg/status
3) What you expected to happen
I expected my file to be highlighted.
4) What happened instead
Nautilus opened, but the file was not highlighted.
ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: firefox 3.6.3+nobinonly-0ubuntu4
ProcVersionSignature: Ubuntu 2.6.32-22.36-generic 2.6.32.11+drm33.2
Uname: Linux 2.6.32-22-generic i686
[Desktop-packages] [Bug 129219]
(In reply to Karl Tomlinson (:karlt) from comment #17)
Comment on attachment 813885
0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch
Thank you for working out how to do this, Nelson. This looks like the right
approach.
You're welcome!, and sorry for getting back to you after a couple weeks but
I've been busy lately with only some spare time on weekends.
Putting this in the nsGIOService is fine, even though the current
implementation doesn't use GIO, because GIO's GDBus will be the preferred
DBus
library once Mozilla is no longer supporting older systems, and the method is
similar to other existing methods on nsGIOService.
The interface can be simplified to just one additional method on
nsIGIOService
that returns NS_ERROR_NOT_AVAILABLE or similar when FileManager1 is not
available.
Done.
ListActivatableNames doesn't sound like what we want here. I assume that is
looking for /usr/share/dbus-1/services/org.freedesktop.FileManager1.service,
but the interface may be provided by a non activatable application such as a
daemon in the desktop environment. That is in fact the appropriate way to
support the interface because it means that different applications can be
selected by the user [1]. What Nautilus does [2][3] is unfortunate because
it
means that people that don't want Nautilus used to reveal a file will have to
uninstall nautilus from the system, removing the option of other users using
Nautilus.
Yes you're right, although file managers are a somewhat special case of a
program
very attached to its desktop environment, but they should still play well with
other file managers. Thanks for the links.
The simplest approach would be to use the synchronous dbus_g_proxy_call() so
that we know whether the call succeeds. Given this particular use of DBus
where the user is wanting to open a new application, or at least a new
window,
which is going to take time, the additional round trip time via the DBus
daemon is not going to be major.
Done, using dbus_g_proxy_call() now.
Perhaps the call could set a flag if it fails, in order to save checking the
DBus call each time for systems without FileManager1, or perhaps there is a
Done.
way to register for notifications when the interface becomes available, but
that may be more trouble than it is worth. Similarly I imagine there is a
notification when the interface is no longer available (the destroy signal
maybe?) so the call would need only be synchronous the first time, but that
can be a future optimization when necessary.
I left this out of the patch to keep it simple, but as you said it can be added
in a future update.
Gecko file style is to use spaces for indentation, with no tabs.
Call dbus_connection_set_exit_on_disconnect(dbusConnection, false) in case
this is the first use of the connection.
Done.
+ char *uris[2] = { (char*)PromiseFlatCString(uri).get(), NULL };
The PromiseFlatCString usage is not good because the pointer is used after
the
PromiseFlatCString is destroyed.
I expect uri.get() can be used here.
Please use const_cast instead of (char*), or, perhaps better, make this
const char *uris[2].
Done.
(In reply to Nelson Benítez León from comment #12)
some file managers when
passed a full uri would try to 'run' the file (as was thunar in xfce or
konqueror in kde)
I was surprised by that behavior too. I think there is a KDE bug report on
that.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/129219
Title:
firefox download manager - Open containing folder with preselected
file in nautilus/file manager
Status in The Mozilla Firefox Browser:
Confirmed
Status in “firefox” package in Ubuntu:
Triaged
Status in “nautilus” package in Ubuntu:
Invalid
Bug description:
Binary package hint: firefox
After a right click on a downloaded file in the download manager, when
you choose Open containing folder it just open the file manager
Nautilus in the folder of the file. It should select the file in the
file manager and scroll the window if necessary like Firefox does in
its Win32 version.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/129219/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 599846]
Created attachment 826479 0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch Updated patch. Created from FIREFOX_AURORA_27_BASE tag. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/599846 Title: firefox right click open containing folder should highlight file Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Confirmed Bug description: Binary package hint: firefox The only reason I am assuming this is a bug is because the functionality is in Windows. Basically, if the user right clicks on a file in the Downloads of Firefox and selects Open Containing Folder, Nautilus should open with the file highlighted to make the file easier to find. 1) The release of Ubuntu you are using, via 'lsb_release -rd' or System - About Ubuntu. Description: Ubuntu 10.04 LTS Release: 10.04 2) The version of the package you are using, via 'apt-cache policy packagename' or by checking in Synaptic. Installed: 3.6.3+nobinonly-0ubuntu4 Candidate: 3.6.3+nobinonly-0ubuntu4 Version table: *** 3.6.3+nobinonly-0ubuntu4 0 500 http://us.archive.ubuntu.com/ubuntu/ lucid/main Packages 100 /var/lib/dpkg/status 3) What you expected to happen I expected my file to be highlighted. 4) What happened instead Nautilus opened, but the file was not highlighted. ProblemType: Bug DistroRelease: Ubuntu 10.04 Package: firefox 3.6.3+nobinonly-0ubuntu4 ProcVersionSignature: Ubuntu 2.6.32-22.36-generic 2.6.32.11+drm33.2 Uname: Linux 2.6.32-22-generic i686 Architecture: i386 Date: Tue Jun 29 11:15:58 2010 FirefoxPackages: firefox 3.6.3+nobinonly-0ubuntu4 firefox-gnome-support 3.6.3+nobinonly-0ubuntu4 firefox-branding 3.6.3+nobinonly-0ubuntu4 abroswer N/A abrowser-branding N/A InstallationMedia: Ubuntu 10.04 LTS Lucid Lynx - Release i386 (20100429) ProcEnviron: LANG=en_US.utf8 SHELL=/bin/bash SourcePackage: firefox To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/599846/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 129219]
Created attachment 826479 0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch Updated patch. Created from FIREFOX_AURORA_27_BASE tag. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/129219 Title: firefox download manager - Open containing folder with preselected file in nautilus/file manager Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “nautilus” package in Ubuntu: Invalid Bug description: Binary package hint: firefox After a right click on a downloaded file in the download manager, when you choose Open containing folder it just open the file manager Nautilus in the folder of the file. It should select the file in the file manager and scroll the window if necessary like Firefox does in its Win32 version. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/129219/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 599846]
Created attachment 813887 screencast of firefox with patch applied, in fedora 19 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/599846 Title: firefox right click open containing folder should highlight file Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Confirmed Bug description: Binary package hint: firefox The only reason I am assuming this is a bug is because the functionality is in Windows. Basically, if the user right clicks on a file in the Downloads of Firefox and selects Open Containing Folder, Nautilus should open with the file highlighted to make the file easier to find. 1) The release of Ubuntu you are using, via 'lsb_release -rd' or System - About Ubuntu. Description: Ubuntu 10.04 LTS Release: 10.04 2) The version of the package you are using, via 'apt-cache policy packagename' or by checking in Synaptic. Installed: 3.6.3+nobinonly-0ubuntu4 Candidate: 3.6.3+nobinonly-0ubuntu4 Version table: *** 3.6.3+nobinonly-0ubuntu4 0 500 http://us.archive.ubuntu.com/ubuntu/ lucid/main Packages 100 /var/lib/dpkg/status 3) What you expected to happen I expected my file to be highlighted. 4) What happened instead Nautilus opened, but the file was not highlighted. ProblemType: Bug DistroRelease: Ubuntu 10.04 Package: firefox 3.6.3+nobinonly-0ubuntu4 ProcVersionSignature: Ubuntu 2.6.32-22.36-generic 2.6.32.11+drm33.2 Uname: Linux 2.6.32-22-generic i686 Architecture: i386 Date: Tue Jun 29 11:15:58 2010 FirefoxPackages: firefox 3.6.3+nobinonly-0ubuntu4 firefox-gnome-support 3.6.3+nobinonly-0ubuntu4 firefox-branding 3.6.3+nobinonly-0ubuntu4 abroswer N/A abrowser-branding N/A InstallationMedia: Ubuntu 10.04 LTS Lucid Lynx - Release i386 (20100429) ProcEnviron: LANG=en_US.utf8 SHELL=/bin/bash SourcePackage: firefox To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/599846/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 129219]
Created attachment 813885 0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch Hi, this patch uses the File Manager DBus Interface[1] to launch file manager and select a file. When this DBus interface is not present, then the current code is used, so to not break backward compatibility. The DBus call to check if the file manager interface is present is only called once, I used a static variable for that. -- A quick note about how I got to this patch, I firstly cooked up a patch that used gio api to find out the handler application of the inode/directory mime type, so that returned me the current file manager application, and then I would just call it with the full uri of the downloaded file, but then I realize how painful linux diversity can be.. some file managers when passed a full uri would try to 'run' the file (as was thunar in xfce or konqueror in kde) while others would do the expected behaviour (open folder and select file) only when a specific flag was passed on the command line, so this was a file manager hell but.. fortunately, the DBus file manager interface[1] is the perfect solution to this, defining a common and concrete interface to open and reveal a file in the default file manager, although currently is only implemented by nautilus, it was agreed on FreeDesktop list by kde and xfce too, so when they happen to implement it they will get this nice open and reveal behaviour from firefox but in the meantime they will get the current code which just opens the folder. [1] http://www.freedesktop.org/wiki/Specifications/file-manager- interface/ -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/129219 Title: firefox download manager - Open containing folder with preselected file in nautilus/file manager Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “nautilus” package in Ubuntu: Invalid Bug description: Binary package hint: firefox After a right click on a downloaded file in the download manager, when you choose Open containing folder it just open the file manager Nautilus in the folder of the file. It should select the file in the file manager and scroll the window if necessary like Firefox does in its Win32 version. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/129219/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 129219]
Created attachment 813887 screencast of firefox with patch applied, in fedora 19 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/129219 Title: firefox download manager - Open containing folder with preselected file in nautilus/file manager Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Triaged Status in “nautilus” package in Ubuntu: Invalid Bug description: Binary package hint: firefox After a right click on a downloaded file in the download manager, when you choose Open containing folder it just open the file manager Nautilus in the folder of the file. It should select the file in the file manager and scroll the window if necessary like Firefox does in its Win32 version. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/129219/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 599846]
Created attachment 813885 0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch Hi, this patch uses the File Manager DBus Interface[1] to launch file manager and select a file. When this DBus interface is not present, then the current code is used, so to not break backward compatibility. The DBus call to check if the file manager interface is present is only called once, I used a static variable for that. -- A quick note about how I got to this patch, I firstly cooked up a patch that used gio api to find out the handler application of the inode/directory mime type, so that returned me the current file manager application, and then I would just call it with the full uri of the downloaded file, but then I realize how painful linux diversity can be.. some file managers when passed a full uri would try to 'run' the file (as was thunar in xfce or konqueror in kde) while others would do the expected behaviour (open folder and select file) only when a specific flag was passed on the command line, so this was a file manager hell but.. fortunately, the DBus file manager interface[1] is the perfect solution to this, defining a common and concrete interface to open and reveal a file in the default file manager, although currently is only implemented by nautilus, it was agreed on FreeDesktop list by kde and xfce too, so when they happen to implement it they will get this nice open and reveal behaviour from firefox but in the meantime they will get the current code which just opens the folder. [1] http://www.freedesktop.org/wiki/Specifications/file-manager- interface/ -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/599846 Title: firefox right click open containing folder should highlight file Status in The Mozilla Firefox Browser: Confirmed Status in “firefox” package in Ubuntu: Confirmed Bug description: Binary package hint: firefox The only reason I am assuming this is a bug is because the functionality is in Windows. Basically, if the user right clicks on a file in the Downloads of Firefox and selects Open Containing Folder, Nautilus should open with the file highlighted to make the file easier to find. 1) The release of Ubuntu you are using, via 'lsb_release -rd' or System - About Ubuntu. Description: Ubuntu 10.04 LTS Release: 10.04 2) The version of the package you are using, via 'apt-cache policy packagename' or by checking in Synaptic. Installed: 3.6.3+nobinonly-0ubuntu4 Candidate: 3.6.3+nobinonly-0ubuntu4 Version table: *** 3.6.3+nobinonly-0ubuntu4 0 500 http://us.archive.ubuntu.com/ubuntu/ lucid/main Packages 100 /var/lib/dpkg/status 3) What you expected to happen I expected my file to be highlighted. 4) What happened instead Nautilus opened, but the file was not highlighted. ProblemType: Bug DistroRelease: Ubuntu 10.04 Package: firefox 3.6.3+nobinonly-0ubuntu4 ProcVersionSignature: Ubuntu 2.6.32-22.36-generic 2.6.32.11+drm33.2 Uname: Linux 2.6.32-22-generic i686 Architecture: i386 Date: Tue Jun 29 11:15:58 2010 FirefoxPackages: firefox 3.6.3+nobinonly-0ubuntu4 firefox-gnome-support 3.6.3+nobinonly-0ubuntu4 firefox-branding 3.6.3+nobinonly-0ubuntu4 abroswer N/A abrowser-branding N/A InstallationMedia: Ubuntu 10.04 LTS Lucid Lynx - Release i386 (20100429) ProcEnviron: LANG=en_US.utf8 SHELL=/bin/bash SourcePackage: firefox To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/599846/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1085526]
Hi, as I cannot help with coding (on this specific issue), I've opened a bounty on FreedomSponsors: http://www.freedomsponsors.org/core/issue/319/support-for-digital- signatures Anyone interested on this bug is welcome to pledge more money by visiting the above link, this money will probably not be enough for the needed work time, but I see it as a nice reward in exchange for the great contribution that completing this bug is. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document Status in Poppler: Confirmed Status in “evince” package in Ubuntu: Triaged Bug description: Just updated in last few weeks, i think ubuntu 12.4 To sign the document i have to send it to my neighbors windows computer, open it, sign it, then send it, then I get a note from echo sign that the document was sent with my signature. ProblemType: Bug DistroRelease: Ubuntu 11.10 Package: evince 3.2.1-0ubuntu2.3 ProcVersionSignature: Ubuntu 3.0.0-27.44-generic 3.0.45 Uname: Linux 3.0.0-27-generic i686 ApportVersion: 1.23-0ubuntu4 Architecture: i386 Date: Fri Nov 30 18:13:25 2012 ExecutablePath: /usr/bin/evince InstallationMedia: Ubuntu 11.04 Natty Narwhal - Release i386 (20110427.1) ProcEnviron: PATH=(custom, no user) LANG=en_US.UTF-8 SHELL=/bin/bash SourcePackage: evince UpgradeStatus: Upgraded to oneiric on 2012-11-18 (12 days ago) To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 740506]
Hi, as I cannot help with coding (on this specific issue), I've opened a bounty on FreedomSponsors: http://www.freedomsponsors.org/core/issue/319/support-for-digital- signatures Anyone interested on this bug is welcome to pledge more money by visiting the above link, this money will probably not be enough for the needed work time, but I see it as a nice reward in exchange for the great contribution that completing this bug is. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures Status in Poppler: Confirmed Status in “poppler” package in Ubuntu: Triaged Bug description: Binary package hint: evince This is a feature request to verify digital signatures. I'm receiving more and more digitally signed PDF's and evince already acknowledges them with: Signature Not Verified Digitally signed by signer Date: time stamp Reason: reason Location: location but it would be great if Evince would be integrated into the distro's ca-certificate infrastructure to verify these signatures. To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/740506/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
