[Desktop-packages] [Bug 541951]
(In reply to Mike Hommey [:glandium] from comment #46)
> The preferences code is being heavily refactored, and this needs to wait a
> bit for things to settle first. That being said, I do think the ideal timing
> for this would be to get it into 60. Nick, what do you think?
If things go well with the prefs changes this might be possible in 60,
it just depends how quickly the work goes.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/541951
Title:
Firefox 3.6 does not honour lockPref
Status in Mozilla Firefox:
Fix Released
Status in firefox package in Ubuntu:
Fix Released
Bug description:
Binary package hint: firefox
In firefox 3.5 the following worked:
Set
lockPref("network.proxy.type", 5);
in /etc/firefox-3.5/pref/firefox.js
Setting lockPref in /etc/firefox/pref/firefox.js in firefox 3.6 does
not lock down the proxy.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 541951]
Comment on attachment 8931547
Bug 440908 - Allow preference files to set locked prefs.
https://reviewboard.mozilla.org/r/202672/#review208008
As per our IRC discussion, I think this is a good feature, and the patch
does a good job of implementing it. But before doing this I'd like to
officially split the prefs file format in two -- one format for default
prefs, and one for user prefs -- and then only support `locked_pref` in
default prefs files. And I want to need to think about that for a bit,
just to make sure it's a good idea.
::: modules/libpref/Preferences.cpp:238
(Diff revision 1)
> enum
> {
>kPrefSetDefault = 1,
>kPrefForceSet = 2,
>kPrefSticky = 4,
> + kPrefLocked = 8,
The patches in bug 1394578 are going to bitrot this again. Sorry :(
::: modules/libpref/Preferences.cpp:949
(Diff revision 1)
>char* mLbEnd; // line buffer end
>char* mVb; // value buffer (ptr into mLb)
>Maybe mVtype; // pref value type
>bool mIsDefault;// true if (default) pref
>bool mIsSticky; // true if (sticky) pref
> + bool mIsLocked; // true if (locked) pref
It would be nice to replace these three bools with a single enum that
has the following alternatives: Default, StickyDefault, LockedDefault,
User. That would simplify some of the code below.
::: modules/libpref/test/unit/test_lockedprefs.js:20
(Diff revision 1)
> +}
> +
> +add_test(function notChangedFromAPI() {
> + resetAndLoad(["data/testPrefLocked.js"]);
> + Assert.strictEqual(ps.getBoolPref("testPref.unlocked.bool"), true);
> + Assert.strictEqual(ps.getBoolPref("testPref.locked.bool"), false);
Keeping track of the true and false values here is tricky. If you
changed it to an int you could make the "testPref.locked.int" use 100
and 101, and "testPref.unlocked.int" use 200 and 201, or something like
that, and it would be a bit easier to read.
::: modules/libpref/test/unit/test_lockedprefs.js:24
(Diff revision 1)
> + Assert.strictEqual(ps.getBoolPref("testPref.unlocked.bool"), true);
> + Assert.strictEqual(ps.getBoolPref("testPref.locked.bool"), false);
> +
> + ps.setBoolPref("testPref.unlocked.bool", false);
> + Assert.ok(ps.prefHasUserValue("testPref.unlocked.bool"),
> +"should be able to set an unlocked pref");
This string comment isn't quite right, because you can set a locked
pref.
::: modules/libpref/test/unit/test_lockedprefs.js:29
(Diff revision 1)
> +"should be able to set an unlocked pref");
> + Assert.strictEqual(ps.getBoolPref("testPref.unlocked.bool"), false);
> +
> + ps.setBoolPref("testPref.locked.bool", true);
> + Assert.ok(ps.prefHasUserValue("testPref.locked.bool"),
> +"somehow, the user value is still set");
This comment string is a bit weird too.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/541951
Title:
Firefox 3.6 does not honour lockPref
Status in Mozilla Firefox:
Fix Released
Status in firefox package in Ubuntu:
Fix Released
Bug description:
Binary package hint: firefox
In firefox 3.5 the following worked:
Set
lockPref("network.proxy.type", 5);
in /etc/firefox-3.5/pref/firefox.js
Setting lockPref in /etc/firefox/pref/firefox.js in firefox 3.6 does
not lock down the proxy.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 541951]
Created attachment 8956310
Bug 440908 - Add support for `sticky` and `locked` attributes to default prefs.
Sticky prefs are already specifiable with `sticky_pref`, but this is a more
general attribute mechanism. The ability to specify a locked pref in the data
file is new.
The patch also adds nsIPrefService.readDefaultPrefsFromFile, to match the
existing nsIPrefService.readUserPrefsFromFile method, and converts a number of
the existing tests to use it.
Review commit: https://reviewboard.mozilla.org/r/225184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225184/
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/541951
Title:
Firefox 3.6 does not honour lockPref
Status in Mozilla Firefox:
Fix Released
Status in firefox package in Ubuntu:
Fix Released
Bug description:
Binary package hint: firefox
In firefox 3.5 the following worked:
Set
lockPref("network.proxy.type", 5);
in /etc/firefox-3.5/pref/firefox.js
Setting lockPref in /etc/firefox/pref/firefox.js in firefox 3.6 does
not lock down the proxy.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 541951]
Created attachment 8956309
Bug 440908 - Remove gIsAnyPrefLocked.
It optimizes Preferences::IsLocked(), but that function is called fewer than
200 times while starting the browser and opening a range of tabs.
Review commit: https://reviewboard.mozilla.org/r/225182/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225182/
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/541951
Title:
Firefox 3.6 does not honour lockPref
Status in Mozilla Firefox:
Fix Released
Status in firefox package in Ubuntu:
Fix Released
Bug description:
Binary package hint: firefox
In firefox 3.5 the following worked:
Set
lockPref("network.proxy.type", 5);
in /etc/firefox-3.5/pref/firefox.js
Setting lockPref in /etc/firefox/pref/firefox.js in firefox 3.6 does
not lock down the proxy.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 541951]
https://hg.mozilla.org/integration/mozilla-inbound/rev/edb57fbc6beac233b12486fa7d7381220339de0f
Bug 440908 - Remove gIsAnyPrefLocked. r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/b82802657783b6188e320ba966183ae1eedabf62
Bug 440908 - Add support for `sticky` and `locked` attributes to default prefs.
r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1d9ef8f7c0ecdc6b9d8fa33b8b2a9238e0ad64f
Bug 440908 - Convert sticky prefs in default pref files to the new syntax.
r=glandium
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/541951
Title:
Firefox 3.6 does not honour lockPref
Status in Mozilla Firefox:
Fix Released
Status in firefox package in Ubuntu:
Fix Released
Bug description:
Binary package hint: firefox
In firefox 3.5 the following worked:
Set
lockPref("network.proxy.type", 5);
in /etc/firefox-3.5/pref/firefox.js
Setting lockPref in /etc/firefox/pref/firefox.js in firefox 3.6 does
not lock down the proxy.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 541951]
Created attachment 8956311
Bug 440908 - Convert sticky prefs in default pref files to the new syntax.
Review commit: https://reviewboard.mozilla.org/r/225186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225186/
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/541951
Title:
Firefox 3.6 does not honour lockPref
Status in Mozilla Firefox:
Fix Released
Status in firefox package in Ubuntu:
Fix Released
Bug description:
Binary package hint: firefox
In firefox 3.5 the following worked:
Set
lockPref("network.proxy.type", 5);
in /etc/firefox-3.5/pref/firefox.js
Setting lockPref in /etc/firefox/pref/firefox.js in firefox 3.6 does
not lock down the proxy.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 541951]
> clang-format changed its mind, I guess?
No, chutten changed that code in bug 1435753. I generally run `./mach
clang-format -p modules/libpref`. Perhaps I should just run `./mach
clang-format` instead...
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/541951
Title:
Firefox 3.6 does not honour lockPref
Status in Mozilla Firefox:
Fix Released
Status in firefox package in Ubuntu:
Fix Released
Bug description:
Binary package hint: firefox
In firefox 3.5 the following worked:
Set
lockPref("network.proxy.type", 5);
in /etc/firefox-3.5/pref/firefox.js
Setting lockPref in /etc/firefox/pref/firefox.js in firefox 3.6 does
not lock down the proxy.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 623844]
(In reply to Mike Hommey [:glandium] from comment #46)
> The preferences code is being heavily refactored, and this needs to wait a
> bit for things to settle first. That being said, I do think the ideal timing
> for this would be to get it into 60. Nick, what do you think?
If things go well with the prefs changes this might be possible in 60,
it just depends how quickly the work goes.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/623844
Title:
lockpref not honored in /etc/thunderbird/pref/thunderbird.js
Status in Mozilla Thunderbird:
Fix Released
Status in thunderbird package in Ubuntu:
New
Bug description:
Binary package hint: thunderbird
appended /etc/thunderbird/pref/thunderbird.js with the following line:
lockpref("app.update.enabled", false);
When starting Thunderbird and checking the config app.update.enabled
is set to false, but can be edited by the user.
ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: thunderbird 3.0.6+build2+nobinonly-0ubuntu0.10.04.1
ProcVersionSignature: Ubuntu 2.6.32-24.39-generic 2.6.32.15+drm33.5
Uname: Linux 2.6.32-24-generic x86_64
Architecture: amd64
Date: Wed Aug 25 09:58:43 2010
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
ProcEnviron:
PATH=(custom, no user)
LANG=de_DE.utf8
SHELL=/bin/bash
SourcePackage: thunderbird
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 623844]
Created attachment 8956309
Bug 440908 - Remove gIsAnyPrefLocked.
It optimizes Preferences::IsLocked(), but that function is called fewer than
200 times while starting the browser and opening a range of tabs.
Review commit: https://reviewboard.mozilla.org/r/225182/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225182/
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/623844
Title:
lockpref not honored in /etc/thunderbird/pref/thunderbird.js
Status in Mozilla Thunderbird:
Fix Released
Status in thunderbird package in Ubuntu:
New
Bug description:
Binary package hint: thunderbird
appended /etc/thunderbird/pref/thunderbird.js with the following line:
lockpref("app.update.enabled", false);
When starting Thunderbird and checking the config app.update.enabled
is set to false, but can be edited by the user.
ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: thunderbird 3.0.6+build2+nobinonly-0ubuntu0.10.04.1
ProcVersionSignature: Ubuntu 2.6.32-24.39-generic 2.6.32.15+drm33.5
Uname: Linux 2.6.32-24-generic x86_64
Architecture: amd64
Date: Wed Aug 25 09:58:43 2010
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
ProcEnviron:
PATH=(custom, no user)
LANG=de_DE.utf8
SHELL=/bin/bash
SourcePackage: thunderbird
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 623844]
Created attachment 8956310
Bug 440908 - Add support for `sticky` and `locked` attributes to default prefs.
Sticky prefs are already specifiable with `sticky_pref`, but this is a more
general attribute mechanism. The ability to specify a locked pref in the data
file is new.
The patch also adds nsIPrefService.readDefaultPrefsFromFile, to match the
existing nsIPrefService.readUserPrefsFromFile method, and converts a number of
the existing tests to use it.
Review commit: https://reviewboard.mozilla.org/r/225184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225184/
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/623844
Title:
lockpref not honored in /etc/thunderbird/pref/thunderbird.js
Status in Mozilla Thunderbird:
Fix Released
Status in thunderbird package in Ubuntu:
New
Bug description:
Binary package hint: thunderbird
appended /etc/thunderbird/pref/thunderbird.js with the following line:
lockpref("app.update.enabled", false);
When starting Thunderbird and checking the config app.update.enabled
is set to false, but can be edited by the user.
ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: thunderbird 3.0.6+build2+nobinonly-0ubuntu0.10.04.1
ProcVersionSignature: Ubuntu 2.6.32-24.39-generic 2.6.32.15+drm33.5
Uname: Linux 2.6.32-24-generic x86_64
Architecture: amd64
Date: Wed Aug 25 09:58:43 2010
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
ProcEnviron:
PATH=(custom, no user)
LANG=de_DE.utf8
SHELL=/bin/bash
SourcePackage: thunderbird
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 623844]
https://hg.mozilla.org/integration/mozilla-inbound/rev/edb57fbc6beac233b12486fa7d7381220339de0f
Bug 440908 - Remove gIsAnyPrefLocked. r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/b82802657783b6188e320ba966183ae1eedabf62
Bug 440908 - Add support for `sticky` and `locked` attributes to default prefs.
r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1d9ef8f7c0ecdc6b9d8fa33b8b2a9238e0ad64f
Bug 440908 - Convert sticky prefs in default pref files to the new syntax.
r=glandium
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/623844
Title:
lockpref not honored in /etc/thunderbird/pref/thunderbird.js
Status in Mozilla Thunderbird:
Fix Released
Status in thunderbird package in Ubuntu:
New
Bug description:
Binary package hint: thunderbird
appended /etc/thunderbird/pref/thunderbird.js with the following line:
lockpref("app.update.enabled", false);
When starting Thunderbird and checking the config app.update.enabled
is set to false, but can be edited by the user.
ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: thunderbird 3.0.6+build2+nobinonly-0ubuntu0.10.04.1
ProcVersionSignature: Ubuntu 2.6.32-24.39-generic 2.6.32.15+drm33.5
Uname: Linux 2.6.32-24-generic x86_64
Architecture: amd64
Date: Wed Aug 25 09:58:43 2010
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
ProcEnviron:
PATH=(custom, no user)
LANG=de_DE.utf8
SHELL=/bin/bash
SourcePackage: thunderbird
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 623844]
Created attachment 8956311
Bug 440908 - Convert sticky prefs in default pref files to the new syntax.
Review commit: https://reviewboard.mozilla.org/r/225186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225186/
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/623844
Title:
lockpref not honored in /etc/thunderbird/pref/thunderbird.js
Status in Mozilla Thunderbird:
Fix Released
Status in thunderbird package in Ubuntu:
New
Bug description:
Binary package hint: thunderbird
appended /etc/thunderbird/pref/thunderbird.js with the following line:
lockpref("app.update.enabled", false);
When starting Thunderbird and checking the config app.update.enabled
is set to false, but can be edited by the user.
ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: thunderbird 3.0.6+build2+nobinonly-0ubuntu0.10.04.1
ProcVersionSignature: Ubuntu 2.6.32-24.39-generic 2.6.32.15+drm33.5
Uname: Linux 2.6.32-24-generic x86_64
Architecture: amd64
Date: Wed Aug 25 09:58:43 2010
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
ProcEnviron:
PATH=(custom, no user)
LANG=de_DE.utf8
SHELL=/bin/bash
SourcePackage: thunderbird
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 623844]
> clang-format changed its mind, I guess?
No, chutten changed that code in bug 1435753. I generally run `./mach
clang-format -p modules/libpref`. Perhaps I should just run `./mach
clang-format` instead...
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/623844
Title:
lockpref not honored in /etc/thunderbird/pref/thunderbird.js
Status in Mozilla Thunderbird:
Fix Released
Status in thunderbird package in Ubuntu:
New
Bug description:
Binary package hint: thunderbird
appended /etc/thunderbird/pref/thunderbird.js with the following line:
lockpref("app.update.enabled", false);
When starting Thunderbird and checking the config app.update.enabled
is set to false, but can be edited by the user.
ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: thunderbird 3.0.6+build2+nobinonly-0ubuntu0.10.04.1
ProcVersionSignature: Ubuntu 2.6.32-24.39-generic 2.6.32.15+drm33.5
Uname: Linux 2.6.32-24-generic x86_64
Architecture: amd64
Date: Wed Aug 25 09:58:43 2010
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
ProcEnviron:
PATH=(custom, no user)
LANG=de_DE.utf8
SHELL=/bin/bash
SourcePackage: thunderbird
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 623844]
Comment on attachment 8931547
Bug 440908 - Allow preference files to set locked prefs.
https://reviewboard.mozilla.org/r/202672/#review208008
As per our IRC discussion, I think this is a good feature, and the patch
does a good job of implementing it. But before doing this I'd like to
officially split the prefs file format in two -- one format for default
prefs, and one for user prefs -- and then only support `locked_pref` in
default prefs files. And I want to need to think about that for a bit,
just to make sure it's a good idea.
::: modules/libpref/Preferences.cpp:238
(Diff revision 1)
> enum
> {
>kPrefSetDefault = 1,
>kPrefForceSet = 2,
>kPrefSticky = 4,
> + kPrefLocked = 8,
The patches in bug 1394578 are going to bitrot this again. Sorry :(
::: modules/libpref/Preferences.cpp:949
(Diff revision 1)
>char* mLbEnd; // line buffer end
>char* mVb; // value buffer (ptr into mLb)
>Maybe mVtype; // pref value type
>bool mIsDefault;// true if (default) pref
>bool mIsSticky; // true if (sticky) pref
> + bool mIsLocked; // true if (locked) pref
It would be nice to replace these three bools with a single enum that
has the following alternatives: Default, StickyDefault, LockedDefault,
User. That would simplify some of the code below.
::: modules/libpref/test/unit/test_lockedprefs.js:20
(Diff revision 1)
> +}
> +
> +add_test(function notChangedFromAPI() {
> + resetAndLoad(["data/testPrefLocked.js"]);
> + Assert.strictEqual(ps.getBoolPref("testPref.unlocked.bool"), true);
> + Assert.strictEqual(ps.getBoolPref("testPref.locked.bool"), false);
Keeping track of the true and false values here is tricky. If you
changed it to an int you could make the "testPref.locked.int" use 100
and 101, and "testPref.unlocked.int" use 200 and 201, or something like
that, and it would be a bit easier to read.
::: modules/libpref/test/unit/test_lockedprefs.js:24
(Diff revision 1)
> + Assert.strictEqual(ps.getBoolPref("testPref.unlocked.bool"), true);
> + Assert.strictEqual(ps.getBoolPref("testPref.locked.bool"), false);
> +
> + ps.setBoolPref("testPref.unlocked.bool", false);
> + Assert.ok(ps.prefHasUserValue("testPref.unlocked.bool"),
> +"should be able to set an unlocked pref");
This string comment isn't quite right, because you can set a locked
pref.
::: modules/libpref/test/unit/test_lockedprefs.js:29
(Diff revision 1)
> +"should be able to set an unlocked pref");
> + Assert.strictEqual(ps.getBoolPref("testPref.unlocked.bool"), false);
> +
> + ps.setBoolPref("testPref.locked.bool", true);
> + Assert.ok(ps.prefHasUserValue("testPref.locked.bool"),
> +"somehow, the user value is still set");
This comment string is a bit weird too.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/623844
Title:
lockpref not honored in /etc/thunderbird/pref/thunderbird.js
Status in Mozilla Thunderbird:
Fix Released
Status in thunderbird package in Ubuntu:
New
Bug description:
Binary package hint: thunderbird
appended /etc/thunderbird/pref/thunderbird.js with the following line:
lockpref("app.update.enabled", false);
When starting Thunderbird and checking the config app.update.enabled
is set to false, but can be edited by the user.
ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: thunderbird 3.0.6+build2+nobinonly-0ubuntu0.10.04.1
ProcVersionSignature: Ubuntu 2.6.32-24.39-generic 2.6.32.15+drm33.5
Uname: Linux 2.6.32-24-generic x86_64
Architecture: amd64
Date: Wed Aug 25 09:58:43 2010
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
ProcEnviron:
PATH=(custom, no user)
LANG=de_DE.utf8
SHELL=/bin/bash
SourcePackage: thunderbird
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1802520] Re: gnome-terminal prints gnome settings daemon log messages (?) every time I launch it
I just upgraded to 18.10 and have the same problem. For me, the output when opening a single gnome-terminal is the following. # watch_fast: "/com/canonical/unity-gtk-module/" (establishing: 0, active: 0) # unwatch_fast: "/com/canonical/unity-gtk-module/" (active: 0, establishing: 1) # watch_established: "/com/canonical/unity-gtk-module/" (establishing: 0) # watch_fast: "/org/gnome/terminal/legacy/" (establishing: 0, active: 0) # unwatch_fast: "/org/gnome/terminal/legacy/" (active: 0, establishing: 1) # watch_established: "/org/gnome/terminal/legacy/" (establishing: 0) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-terminal in Ubuntu. https://bugs.launchpad.net/bugs/1802520 Title: gnome-terminal prints gnome settings daemon log messages (?) every time I launch it Status in gnome-terminal package in Ubuntu: Confirmed Bug description: $ gnome-terminal # watch_fast: "/org/gnome/terminal/legacy/" (establishing: 0, active: 0) # unwatch_fast: "/org/gnome/terminal/legacy/" (active: 0, establishing: 1) # watch_established: "/org/gnome/terminal/legacy/" (establishing: 0) $ Those three log messages printed when I run gnome-terminal are new in 18.10. See also https://gitlab.gnome.org/GNOME/gnome-terminal/issues/42. ProblemType: Bug DistroRelease: Ubuntu 18.10 Package: gnome-terminal 3.30.1-1ubuntu1 [modified: usr/share/applications/org.gnome.Terminal.desktop] ProcVersionSignature: Ubuntu 4.18.0-10.11-generic 4.18.12 Uname: Linux 4.18.0-10-generic x86_64 ApportVersion: 2.20.10-0ubuntu13 Architecture: amd64 CurrentDesktop: ubuntu:GNOME Date: Fri Nov 9 09:18:38 2018 InstallationDate: Installed on 2018-09-27 (42 days ago) InstallationMedia: Ubuntu 18.04.1 LTS "Bionic Beaver" - Release amd64 (20180725) SourcePackage: gnome-terminal UpgradeStatus: Upgraded to cosmic on 2018-11-08 (0 days ago) modified.conffile..etc.apport.crashdb.conf: [modified] mtime.conffile..etc.apport.crashdb.conf: 2018-10-04T06:36:50.792292 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/1802520/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 911540]
The smaps reading code is long gone, so this shouldn't be a problem any more. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/911540 Title: about:memory displays a weird error due to lacking access to /proc/self/smaps Status in The Mozilla Firefox Browser: Invalid Status in “firefox” package in Ubuntu: Triaged Bug description: Please note, this only affects users when the apparmor profile is enabled. An error occurred when collecting a multi-reporter's results: [Exception... \Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMemoryMultiReporter.collectReports]\ nsresult: \0x80004005 (NS_ERROR_FAILURE)\ location: \JS frame :: chrome://global/content/aboutMemory.js :: getReportersByProcess :: line 295\ data: no] The error should go away on Ubuntu after bug 911494 is fixed. Bug 911494 is about apparmor blocking access to /proc/self/smaps. Upstream seems interested in refining this message. This bug is about refining the message rather than making it go away. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/911540/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
