[Desktop-packages] [Bug 1141106] Re: usr/bin/libreoffice script bad symlink following
** Changed in: libreoffice (Debian) Status: New => Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libreoffice in Ubuntu. https://bugs.launchpad.net/bugs/1141106 Title: usr/bin/libreoffice script bad symlink following Status in LibreOffice: Fix Released Status in libreoffice package in Ubuntu: Fix Released Status in libreoffice package in Debian: Fix Released Bug description: 1:4.0.0~beta2-0ubuntu2 content of usr/bin/libreoffice: sd_cwd=`pwd` sd_res=$0 while [ -h "$sd_res" ] ; do cd "`dirname "$sd_res"`" sd_basename=`basename "$sd_res"` sd_res=`ls -l "$sd_basename" | sed "s/.*$sd_basename -> //g"` done cd "`dirname "$sd_res"`" sd_prog=`pwd` cd "$sd_cwd" sd_res is a symlink in ubuntu so it goes in there please use something sane like readlink to get the target instead of that weird sed line a user in #ubuntu+1 reports issues with it because he apparently has some invalid locale in the month part of ls -l: he gets: 02:04 /usr/bin/libreoffice: 49: cd: can't cd to lrwxrwxrwx 1 root root 34 ���../lib/libreoffice/program 02:04 /usr/bin/libreoffice: 156: exec: /usr/bin/oosplash: not found To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1141106/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1141106] Re: usr/bin/libreoffice script bad symlink following
** Changed in: libreoffice (Ubuntu) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libreoffice in Ubuntu. https://bugs.launchpad.net/bugs/1141106 Title: usr/bin/libreoffice script bad symlink following Status in LibreOffice Productivity Suite: Fix Released Status in libreoffice package in Ubuntu: Fix Released Status in libreoffice package in Debian: New Bug description: 1:4.0.0~beta2-0ubuntu2 content of usr/bin/libreoffice: sd_cwd=`pwd` sd_res=$0 while [ -h $sd_res ] ; do cd `dirname $sd_res` sd_basename=`basename $sd_res` sd_res=`ls -l $sd_basename | sed s/.*$sd_basename - //g` done cd `dirname $sd_res` sd_prog=`pwd` cd $sd_cwd sd_res is a symlink in ubuntu so it goes in there please use something sane like readlink to get the target instead of that weird sed line a user in #ubuntu+1 reports issues with it because he apparently has some invalid locale in the month part of ls -l: he gets: 02:04 Allard /usr/bin/libreoffice: 49: cd: can't cd to lrwxrwxrwx 1 root root 34 ���../lib/libreoffice/program 02:04 Allard /usr/bin/libreoffice: 156: exec: /usr/bin/oosplash: not found To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1141106/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1141106] Re: usr/bin/libreoffice script bad symlink following
** Changed in: df-libreoffice Status: Incomplete = Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libreoffice in Ubuntu. https://bugs.launchpad.net/bugs/1141106 Title: usr/bin/libreoffice script bad symlink following Status in LibreOffice Productivity Suite: Fix Released Status in “libreoffice” package in Ubuntu: Fix Committed Status in “libreoffice” package in Debian: New Bug description: 1:4.0.0~beta2-0ubuntu2 content of usr/bin/libreoffice: sd_cwd=`pwd` sd_res=$0 while [ -h $sd_res ] ; do cd `dirname $sd_res` sd_basename=`basename $sd_res` sd_res=`ls -l $sd_basename | sed s/.*$sd_basename - //g` done cd `dirname $sd_res` sd_prog=`pwd` cd $sd_cwd sd_res is a symlink in ubuntu so it goes in there please use something sane like readlink to get the target instead of that weird sed line a user in #ubuntu+1 reports issues with it because he apparently has some invalid locale in the month part of ls -l: he gets: 02:04 Allard /usr/bin/libreoffice: 49: cd: can't cd to lrwxrwxrwx 1 root root 34 ���../lib/libreoffice/program 02:04 Allard /usr/bin/libreoffice: 156: exec: /usr/bin/oosplash: not found To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1141106/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1141106] Re: usr/bin/libreoffice script bad symlink following
I stumbled on a similar bug, Libreoffice wouldn't start caused by a homemade (experimental) `ls` script in ~/bin. Seems Libreoffice is calling `ls` instead of `/bin/ls` -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libreoffice in Ubuntu. https://bugs.launchpad.net/bugs/1141106 Title: usr/bin/libreoffice script bad symlink following Status in LibreOffice Productivity Suite: Incomplete Status in “libreoffice” package in Ubuntu: Fix Committed Status in “libreoffice” package in Debian: New Bug description: 1:4.0.0~beta2-0ubuntu2 content of usr/bin/libreoffice: sd_cwd=`pwd` sd_res=$0 while [ -h $sd_res ] ; do cd `dirname $sd_res` sd_basename=`basename $sd_res` sd_res=`ls -l $sd_basename | sed s/.*$sd_basename - //g` done cd `dirname $sd_res` sd_prog=`pwd` cd $sd_cwd sd_res is a symlink in ubuntu so it goes in there please use something sane like readlink to get the target instead of that weird sed line a user in #ubuntu+1 reports issues with it because he apparently has some invalid locale in the month part of ls -l: he gets: 02:04 Allard /usr/bin/libreoffice: 49: cd: can't cd to lrwxrwxrwx 1 root root 34 ���../lib/libreoffice/program 02:04 Allard /usr/bin/libreoffice: 156: exec: /usr/bin/oosplash: not found To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1141106/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1141106] Re: usr/bin/libreoffice script bad symlink following
** Bug watch added: freedesktop.org Bugzilla #62192 https://bugs.freedesktop.org/show_bug.cgi?id=62192 ** Also affects: df-libreoffice via https://bugs.freedesktop.org/show_bug.cgi?id=62192 Importance: Unknown Status: Unknown ** Changed in: libreoffice (Ubuntu) Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libreoffice in Ubuntu. https://bugs.launchpad.net/bugs/1141106 Title: usr/bin/libreoffice script bad symlink following Status in LibreOffice Productivity Suite: Unknown Status in “libreoffice” package in Ubuntu: Fix Committed Status in “libreoffice” package in Debian: New Bug description: 1:4.0.0~beta2-0ubuntu2 content of usr/bin/libreoffice: sd_cwd=`pwd` sd_res=$0 while [ -h $sd_res ] ; do cd `dirname $sd_res` sd_basename=`basename $sd_res` sd_res=`ls -l $sd_basename | sed s/.*$sd_basename - //g` done cd `dirname $sd_res` sd_prog=`pwd` cd $sd_cwd sd_res is a symlink in ubuntu so it goes in there please use something sane like readlink to get the target instead of that weird sed line a user in #ubuntu+1 reports issues with it because he apparently has some invalid locale in the month part of ls -l: he gets: 02:04 Allard /usr/bin/libreoffice: 49: cd: can't cd to lrwxrwxrwx 1 root root 34 ���../lib/libreoffice/program 02:04 Allard /usr/bin/libreoffice: 156: exec: /usr/bin/oosplash: not found To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1141106/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1141106] Re: usr/bin/libreoffice script bad symlink following
Launchpad has imported 8 comments from the remote bug at https://bugs.freedesktop.org/show_bug.cgi?id=62192. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2013-03-11T21:50:24+00:00 ExecutorElassus wrote: Problem description: I ran into this problem last year, in the same month, and here I am again. This section of code is in /usr/lib/libreoffice/program/soffice: --- # resolve installation directory sd_cwd=`pwd` if [ -h $0 ] ; then sd_basename=`basename $0` sd_script=`ls -l $0 | sed s/.*${sd_basename} - //g` cd `dirname $0` cd `dirname $sd_script` else cd `dirname $0` fi sd_prog=`pwd` cd $sd_cwd - The gentoo developers rightly refer to this code as completely broken, as it causes LibreOffice to puke on launch when trying to determine the month string of its working directory if used on a system for which certain months use non-standard characters. For instance, in Gremany, the current month is März. Launching LO any time between now and 2013-04-01 will cause LO to fail with the following error: - $ libreoffice ls: error initializing month strings /usr/bin/libreoffice: line 58: cd: lrwxrwxrwx 1 root root 38 10. Mä/usr/lib64/libreoffice/program: No such file or directory /usr/bin/libreoffice: line 180: /usr/bin/oosplash: No such file or directory Steps to reproduce: 1. set the filesystem locale to German (any variant) 2. try to launch LO in the month of March 3. cry Current behavior: the launcher pukes Expected behavior: the launcher could maybe use a coreutil that is pretty good at reading month strings? In any case, it should launch properly. Cheers, Operating System: Linux (Other) Version: 4.0.1.2 release Reply at: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1141106/comments/1 On 2013-04-16T05:28:10+00:00 timar wrote: This is an easy hack. The only trick is that the solution need to work on a wide variety of systems, not on Linux only. See also: http://stackoverflow.com/questions/7665/how-to-resolve-symbolic-links-in-a-shell-script Reply at: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1141106/comments/6 On 2013-06-14T09:14:07+00:00 Erik Auerswald wrote: Created attachment 80803 Set LC_ALL=C The script should be locale independent. Set LC_ALL=C to do this. Reply at: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1141106/comments/7 On 2013-06-14T20:21:09+00:00 Erik Auerswald wrote: Unconditionally overwriting locale settings might have unintended consequences for the started LibreOffice program. Thus I have written two alternative patches: 1. libreoffice_bug62192_minimal_fix.patch This fixes the offending 'ls' call only. 2. libreoffice_bug62192_involved_fix.patch This saves the current LC_ALL setting, sets the POSIX locale for (most of) the script, and restores the original setting before exec'ing the LibreOffice binary. The minimal fix seems quite safe, but the more invovled one should be tested on several different systems. BTW, this bug is not reproducible with Debian GNU/Linux (checked, old stable, stable and unstable), because the GNU sed used copes with non- ASCII input. Reply at: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1141106/comments/8 On 2013-06-14T20:22:10+00:00 Erik Auerswald wrote: Created attachment 80825 [PATCH] Minimal fix: use POSIX locale for ls call only Reply at: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1141106/comments/9 On 2013-06-14T20:23:13+00:00 Erik Auerswald wrote: Created attachment 80826 [PATCH] Save LC_ALL, use POSIX locale for script, and restore LC_ALL before starting LibreOffice Reply at: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1141106/comments/10 On 2013-07-09T21:43:39+00:00 Björn Michaelsen wrote: Patch looks good, pushed as: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=e75b8e9b4bf720f3bcf479c6915d7815bf8f3e6e to master. @Erik: Could you send a blanket statement as per: https://wiki.documentfoundation.org/Development/Developers#Developers_and_Contributors_list to libreoff...@lists.freedesktop.org? Reply at:
[Desktop-packages] [Bug 1141106] Re: usr/bin/libreoffice script bad symlink following
Yes, should be fixed with a test for `which readlink` and only then a fallback to the sed-voodoo in. Code pointer is: http://opengrok.libreoffice.org/search?q=sd_resproject=core -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libreoffice in Ubuntu. https://bugs.launchpad.net/bugs/1141106 Title: usr/bin/libreoffice script bad symlink following Status in “libreoffice” package in Ubuntu: Confirmed Status in “libreoffice” package in Debian: New Bug description: 1:4.0.0~beta2-0ubuntu2 content of usr/bin/libreoffice: sd_cwd=`pwd` sd_res=$0 while [ -h $sd_res ] ; do cd `dirname $sd_res` sd_basename=`basename $sd_res` sd_res=`ls -l $sd_basename | sed s/.*$sd_basename - //g` done cd `dirname $sd_res` sd_prog=`pwd` cd $sd_cwd sd_res is a symlink in ubuntu so it goes in there please use something sane like readlink to get the target instead of that weird sed line a user in #ubuntu+1 reports issues with it because he apparently has some invalid locale in the month part of ls -l: he gets: 02:04 Allard /usr/bin/libreoffice: 49: cd: can't cd to lrwxrwxrwx 1 root root 34 ���../lib/libreoffice/program 02:04 Allard /usr/bin/libreoffice: 156: exec: /usr/bin/oosplash: not found To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1141106/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1141106] Re: usr/bin/libreoffice script bad symlink following
while it seems obvious to use readlink, it think the original rationale here was to be POSIXy-correct. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libreoffice in Ubuntu. https://bugs.launchpad.net/bugs/1141106 Title: usr/bin/libreoffice script bad symlink following Status in “libreoffice” package in Ubuntu: Confirmed Status in “libreoffice” package in Debian: New Bug description: 1:4.0.0~beta2-0ubuntu2 content of usr/bin/libreoffice: sd_cwd=`pwd` sd_res=$0 while [ -h $sd_res ] ; do cd `dirname $sd_res` sd_basename=`basename $sd_res` sd_res=`ls -l $sd_basename | sed s/.*$sd_basename - //g` done cd `dirname $sd_res` sd_prog=`pwd` cd $sd_cwd sd_res is a symlink in ubuntu so it goes in there please use something sane like readlink to get the target instead of that weird sed line a user in #ubuntu+1 reports issues with it because he apparently has some invalid locale in the month part of ls -l: he gets: 02:04 Allard /usr/bin/libreoffice: 49: cd: can't cd to lrwxrwxrwx 1 root root 34 ���../lib/libreoffice/program 02:04 Allard /usr/bin/libreoffice: 156: exec: /usr/bin/oosplash: not found To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1141106/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1141106] Re: usr/bin/libreoffice script bad symlink following
one can try readlink and fall back to the thing that breaks under unusual circumstances only if its not there. But for ubuntu/debian we don't even need to care, we have readlink in coreutils. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libreoffice in Ubuntu. https://bugs.launchpad.net/bugs/1141106 Title: usr/bin/libreoffice script bad symlink following Status in “libreoffice” package in Ubuntu: Confirmed Status in “libreoffice” package in Debian: New Bug description: 1:4.0.0~beta2-0ubuntu2 content of usr/bin/libreoffice: sd_cwd=`pwd` sd_res=$0 while [ -h $sd_res ] ; do cd `dirname $sd_res` sd_basename=`basename $sd_res` sd_res=`ls -l $sd_basename | sed s/.*$sd_basename - //g` done cd `dirname $sd_res` sd_prog=`pwd` cd $sd_cwd sd_res is a symlink in ubuntu so it goes in there please use something sane like readlink to get the target instead of that weird sed line a user in #ubuntu+1 reports issues with it because he apparently has some invalid locale in the month part of ls -l: he gets: 02:04 Allard /usr/bin/libreoffice: 49: cd: can't cd to lrwxrwxrwx 1 root root 34 ���../lib/libreoffice/program 02:04 Allard /usr/bin/libreoffice: 156: exec: /usr/bin/oosplash: not found To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1141106/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1141106] Re: usr/bin/libreoffice script bad symlink following
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: libreoffice (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libreoffice in Ubuntu. https://bugs.launchpad.net/bugs/1141106 Title: usr/bin/libreoffice script bad symlink following Status in “libreoffice” package in Ubuntu: Confirmed Status in “libreoffice” package in Debian: New Bug description: 1:4.0.0~beta2-0ubuntu2 content of usr/bin/libreoffice: sd_cwd=`pwd` sd_res=$0 while [ -h $sd_res ] ; do cd `dirname $sd_res` sd_basename=`basename $sd_res` sd_res=`ls -l $sd_basename | sed s/.*$sd_basename - //g` done cd `dirname $sd_res` sd_prog=`pwd` cd $sd_cwd sd_res is a symlink in ubuntu so it goes in there please use something sane like readlink to get the target instead of that weird sed line a user in #ubuntu+1 reports issues with it because he apparently has some invalid locale in the month part of ls -l: he gets: 02:04 Allard /usr/bin/libreoffice: 49: cd: can't cd to lrwxrwxrwx 1 root root 34 ���../lib/libreoffice/program 02:04 Allard /usr/bin/libreoffice: 156: exec: /usr/bin/oosplash: not found To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1141106/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1141106] Re: usr/bin/libreoffice script bad symlink following
** Changed in: libreoffice (Debian) Status: Unknown = New -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libreoffice in Ubuntu. https://bugs.launchpad.net/bugs/1141106 Title: usr/bin/libreoffice script bad symlink following Status in “libreoffice” package in Ubuntu: New Status in “libreoffice” package in Debian: New Bug description: 1:4.0.0~beta2-0ubuntu2 content of usr/bin/libreoffice: sd_cwd=`pwd` sd_res=$0 while [ -h $sd_res ] ; do cd `dirname $sd_res` sd_basename=`basename $sd_res` sd_res=`ls -l $sd_basename | sed s/.*$sd_basename - //g` done cd `dirname $sd_res` sd_prog=`pwd` cd $sd_cwd sd_res is a symlink in ubuntu so it goes in there please use something sane like readlink to get the target instead of that weird sed line a user in #ubuntu+1 reports issues with it because he apparently has some invalid locale in the month part of ls -l: he gets: 02:04 Allard /usr/bin/libreoffice: 49: cd: can't cd to lrwxrwxrwx 1 root root 34 ���../lib/libreoffice/program 02:04 Allard /usr/bin/libreoffice: 156: exec: /usr/bin/oosplash: not found To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1141106/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1141106] Re: usr/bin/libreoffice script bad symlink following
** Bug watch added: Debian Bug tracker #702191 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702191 ** Also affects: libreoffice (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702191 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libreoffice in Ubuntu. https://bugs.launchpad.net/bugs/1141106 Title: usr/bin/libreoffice script bad symlink following Status in “libreoffice” package in Ubuntu: New Status in “libreoffice” package in Debian: Unknown Bug description: 1:4.0.0~beta2-0ubuntu2 content of usr/bin/libreoffice: sd_cwd=`pwd` sd_res=$0 while [ -h $sd_res ] ; do cd `dirname $sd_res` sd_basename=`basename $sd_res` sd_res=`ls -l $sd_basename | sed s/.*$sd_basename - //g` done cd `dirname $sd_res` sd_prog=`pwd` cd $sd_cwd sd_res is a symlink in ubuntu so it goes in there please use something sane like readlink to get the target instead of that weird sed line a user in #ubuntu+1 reports issues with it because he apparently has some invalid locale in the month part of ls -l: he gets: 02:04 Allard /usr/bin/libreoffice: 49: cd: can't cd to lrwxrwxrwx 1 root root 34 ���../lib/libreoffice/program 02:04 Allard /usr/bin/libreoffice: 156: exec: /usr/bin/oosplash: not found To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1141106/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp