[Desktop-packages] [Bug 1204778] Re: [xmir] Graphics corruption - damage tracking
** Changed in: xserver-xorg-video-intel (Ubuntu) Status: Triaged = Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to xserver-xorg-video-intel in Ubuntu. https://bugs.launchpad.net/bugs/1204778 Title: [xmir] Graphics corruption - damage tracking Status in “xserver-xorg-video-intel” package in Ubuntu: Fix Released Bug description: It looks like we're failing to flush rendering appropriately in Chris Wilson's xmir branch. This is easiest to see when running xterm in a raw X session; Unity hides it. This bug here to attract anyone else noticing this in the mir-staging PPA. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1204778/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1204778] Re: [xmir] Graphics corruption - damage tracking
diff --git a/src/sna/sna_xmir.c b/src/sna/sna_xmir.c index ae1f2c9..e056129 100644 --- a/src/sna/sna_xmir.c +++ b/src/sna/sna_xmir.c @@ -111,13 +111,12 @@ sna_xmir_buffer_available(WindowPtr win) } static void -sna_xmir_submit_dirty_window(WindowPtr win, DamagePtr damage) +sna_xmir_submit_dirty_window(WindowPtr win) { if (!xmir_window_has_free_buffer(win)) return; - if (sna_xmir_copy_to_mir(win, DamageRegion(damage))) - DamageEmpty(damage); + sna_xmir_copy_to_mir(win, xmir_window_get_dirty(win)); } static const xmir_driver sna_xmir_driver = { ** Attachment added: xf86-video-intel patch https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1204778/+attachment/3749668/+files/thingy -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to xserver-xorg-video-intel in Ubuntu. https://bugs.launchpad.net/bugs/1204778 Title: [xmir] Graphics corruption - damage tracking Status in “xserver-xorg-video-intel” package in Ubuntu: Triaged Bug description: It looks like we're failing to flush rendering appropriately in Chris Wilson's xmir branch. This is easiest to see when running xterm in a raw X session; Unity hides it. This bug here to attract anyone else noticing this in the mir-staging PPA. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1204778/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1204778] Re: [xmir] Graphics corruption - damage tracking
And, in between firefighting, here's an update to the xserver patch to report correct damage regions. Tested to work, not necessarily to be correct :) ** Attachment added: xserver patch https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1204778/+attachment/3749669/+files/thingy -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to xserver-xorg-video-intel in Ubuntu. https://bugs.launchpad.net/bugs/1204778 Title: [xmir] Graphics corruption - damage tracking Status in “xserver-xorg-video-intel” package in Ubuntu: Triaged Bug description: It looks like we're failing to flush rendering appropriately in Chris Wilson's xmir branch. This is easiest to see when running xterm in a raw X session; Unity hides it. This bug here to attract anyone else noticing this in the mir-staging PPA. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1204778/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1204778] Re: [xmir] Graphics corruption - damage tracking
Tracking the RawRegion is going to be a perf nightmare, I think. Maybe just track damage extents and hope for the best? Most of the time rendering redraws either a full window or a tiny rectangle of it (cursor movement vs scrolling). -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to xserver-xorg-video-intel in Ubuntu. https://bugs.launchpad.net/bugs/1204778 Title: [xmir] Graphics corruption - damage tracking Status in “xserver-xorg-video-intel” package in Ubuntu: Triaged Bug description: It looks like we're failing to flush rendering appropriately in Chris Wilson's xmir branch. This is easiest to see when running xterm in a raw X session; Unity hides it. This bug here to attract anyone else noticing this in the mir-staging PPA. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1204778/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 1204778] Re: [xmir] Graphics corruption - damage tracking
** Summary changed: - [xmir] Graphics corruption - failure to flush rendering? + [xmir] Graphics corruption - damage tracking -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to xserver-xorg-video-intel in Ubuntu. https://bugs.launchpad.net/bugs/1204778 Title: [xmir] Graphics corruption - damage tracking Status in “xserver-xorg-video-intel” package in Ubuntu: Triaged Bug description: It looks like we're failing to flush rendering appropriately in Chris Wilson's xmir branch. This is easiest to see when running xterm in a raw X session; Unity hides it. This bug here to attract anyone else noticing this in the mir-staging PPA. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1204778/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp