Re: [Desktop-packages] [Bug 1673276] [NEW] Improvements to Debian rules file

2017-03-15 Thread Chad Miller 
Thanks!


On Wed, Mar 15, 2017 at 6:39 PM, Michael Catanzaro 
wrote:

> Public bug reported:
>
> Hi, I help maintain the Chromium package in Endless OS, which is based
> on Ubuntu's package. We have two minor improvements to the Debian rules
> file that you probably want. These diffs are based on your Xenial v56
> package. First, a simple typo:
>
> >From b794c427fa8146e8f3eb38f593c0d6e0d42692c7 Mon Sep 17 00:00:00 2001
> From: Michael Catanzaro 
> Date: Mon, 2 Jan 2017 18:39:20 -0600
> Subject: [PATCH] Fix upstream typo in rules file
>
> So now we know armhf has not been tested
> ---
>  debian/rules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debian/rules b/debian/rules
> index 881dd1a..3baa6d2 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -127,7 +127,7 @@ else ifeq (armhf,$(DEB_HOST_ARCH))
>  common_defines += target_cpu="arm"
>  #common_defines += arm_optionally_use_neon=false   # implies Android in
> 2016-10
>  common_defines += arm_use_neon=false
> -common_defined += arm_float_abi="hard" arm_use_thumb=true
> +common_defines += arm_float_abi="hard" arm_use_thumb=true
>  else ifeq (arm64,$(DEB_HOST_ARCH))
>  common_defines += target_cpu="arm64"
>  else ifeq (i386,$(DEB_HOST_ARCH))
>
>
> Second we have a patch to remove some environment variables that are
> ignored by the new build system:
>
> >From 3d7d37f64a31f4dad7e43bf78269a714bae1ed42 Mon Sep 17 00:00:00 2001
> From: Michael Catanzaro 
> Date: Sun, 8 Jan 2017 14:37:03 -0600
> Subject: [PATCH] Remove unused code from rules file
>
> All of these environment variables are ignored by the GN build, so it is
> misleading to keep them here.
>
> Also, remove the incorrect comment immediately below, since it prefaces
> a list of features that are both enabled and disabled.
> ---
>  debian/rules | 11 ---
>  1 file changed, 11 deletions(-)
>
> diff --git a/debian/rules b/debian/rules
> index 773b78e..33b7374 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -62,17 +62,6 @@ DEB_DH_SCOUR_ARGS += -Xsvg
>  DEB_DH_SHLIBDEPS_ARGS_chromium-codecs-ffmpeg := -ldebian/chromium-codecs-
> ffmpeg/$(LIB_DIR)
>  DEB_DH_SHLIBDEPS_ARGS_chromium-codecs-ffmpeg-extra :=
> -ldebian/chromium-codecs-ffmpeg-extra/$(LIB_DIR)
>
> -### linker flags to avoid memory allocation issues on 32-bit
> -export LDFLAGS+=-Wl,--no-keep-memory -Wl,--stats
> -
> -# See https://bugs.chromium.org/p/v8/issues/detail?id=3782
> -#export CFLAGS+=-fno-delete-null-pointer-checks
> -
> -export CC := $(shell which gcc-4 gcc-5 gcc cc |head -1)
> -export CXX := $(shell which g++-4 g+++5 g++ c++ |head -1)
> -export CPP := $(shell which g++-4 g+++5 g++ c++ |head -1)
> -
> -# disabled features
>  common_defines+=\
> enable_google_now=false \
> enable_hangout_services_extension=true \
>
> ** Affects: chromium-browser (Ubuntu)
>  Importance: Undecided
>  Status: New
>
> --
> You received this bug notification because you are subscribed to
> chromium-browser in Ubuntu.
> Matching subscriptions: Cr
> https://bugs.launchpad.net/bugs/1673276
>
> Title:
>   Improvements to Debian rules file
>
> Status in chromium-browser package in Ubuntu:
>   New
>
> Bug description:
>   Hi, I help maintain the Chromium package in Endless OS, which is based
>   on Ubuntu's package. We have two minor improvements to the Debian
>   rules file that you probably want. These diffs are based on your
>   Xenial v56 package. First, a simple typo:
>
>   From b794c427fa8146e8f3eb38f593c0d6e0d42692c7 Mon Sep 17 00:00:00 2001
>   From: Michael Catanzaro 
>   Date: Mon, 2 Jan 2017 18:39:20 -0600
>   Subject: [PATCH] Fix upstream typo in rules file
>
>   So now we know armhf has not been tested
>   ---
>debian/rules | 2 +-
>1 file changed, 1 insertion(+), 1 deletion(-)
>
>   diff --git a/debian/rules b/debian/rules
>   index 881dd1a..3baa6d2 100755
>   --- a/debian/rules
>   +++ b/debian/rules
>   @@ -127,7 +127,7 @@ else ifeq (armhf,$(DEB_HOST_ARCH))
>common_defines += target_cpu="arm"
>#common_defines += arm_optionally_use_neon=false   # implies Android in
> 2016-10
>common_defines += arm_use_neon=false
>   -common_defined += arm_float_abi="hard" arm_use_thumb=true
>   +common_defines += arm_float_abi="hard" arm_use_thumb=true
>else ifeq (arm64,$(DEB_HOST_ARCH))
>common_defines += target_cpu="arm64"
>else ifeq (i386,$(DEB_HOST_ARCH))
>
>
>   Second we have a patch to remove some environment variables that are
> ignored by the new build system:
>
>   From 3d7d37f64a31f4dad7e43bf78269a714bae1ed42 Mon Sep 17 00:00:00 2001
>   From: Michael Catanzaro 
>   Date: Sun, 8 Jan 2017 14:37:03 -0600
>   Subject: [PATCH] Remove unused code from rules file
>
>   All of these environment variables are ignored by the GN build, so it is
>   misleading to keep them here.
>
>   Also, remove the incorrect comment immediately below, since it

[Desktop-packages] [Bug 1673276] [NEW] Improvements to Debian rules file

2017-03-15 Thread Michael Catanzaro 
Public bug reported:

Hi, I help maintain the Chromium package in Endless OS, which is based
on Ubuntu's package. We have two minor improvements to the Debian rules
file that you probably want. These diffs are based on your Xenial v56
package. First, a simple typo:

>From b794c427fa8146e8f3eb38f593c0d6e0d42692c7 Mon Sep 17 00:00:00 2001
From: Michael Catanzaro 
Date: Mon, 2 Jan 2017 18:39:20 -0600
Subject: [PATCH] Fix upstream typo in rules file

So now we know armhf has not been tested
---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 881dd1a..3baa6d2 100755
--- a/debian/rules
+++ b/debian/rules
@@ -127,7 +127,7 @@ else ifeq (armhf,$(DEB_HOST_ARCH))
 common_defines += target_cpu="arm"
 #common_defines += arm_optionally_use_neon=false   # implies Android in 2016-10
 common_defines += arm_use_neon=false
-common_defined += arm_float_abi="hard" arm_use_thumb=true
+common_defines += arm_float_abi="hard" arm_use_thumb=true
 else ifeq (arm64,$(DEB_HOST_ARCH))
 common_defines += target_cpu="arm64"
 else ifeq (i386,$(DEB_HOST_ARCH))


Second we have a patch to remove some environment variables that are ignored by 
the new build system:

>From 3d7d37f64a31f4dad7e43bf78269a714bae1ed42 Mon Sep 17 00:00:00 2001
From: Michael Catanzaro 
Date: Sun, 8 Jan 2017 14:37:03 -0600
Subject: [PATCH] Remove unused code from rules file

All of these environment variables are ignored by the GN build, so it is
misleading to keep them here.

Also, remove the incorrect comment immediately below, since it prefaces
a list of features that are both enabled and disabled.
---
 debian/rules | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/debian/rules b/debian/rules
index 773b78e..33b7374 100755
--- a/debian/rules
+++ b/debian/rules
@@ -62,17 +62,6 @@ DEB_DH_SCOUR_ARGS += -Xsvg
 DEB_DH_SHLIBDEPS_ARGS_chromium-codecs-ffmpeg := 
-ldebian/chromium-codecs-ffmpeg/$(LIB_DIR)
 DEB_DH_SHLIBDEPS_ARGS_chromium-codecs-ffmpeg-extra := 
-ldebian/chromium-codecs-ffmpeg-extra/$(LIB_DIR)
 
-### linker flags to avoid memory allocation issues on 32-bit
-export LDFLAGS+=-Wl,--no-keep-memory -Wl,--stats
-
-# See https://bugs.chromium.org/p/v8/issues/detail?id=3782
-#export CFLAGS+=-fno-delete-null-pointer-checks
-
-export CC := $(shell which gcc-4 gcc-5 gcc cc |head -1)
-export CXX := $(shell which g++-4 g+++5 g++ c++ |head -1)
-export CPP := $(shell which g++-4 g+++5 g++ c++ |head -1)
-
-# disabled features
 common_defines+=\
enable_google_now=false \
enable_hangout_services_extension=true \

** Affects: chromium-browser (Ubuntu)
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/1673276

Title:
  Improvements to Debian rules file

Status in chromium-browser package in Ubuntu:
  New

Bug description:
  Hi, I help maintain the Chromium package in Endless OS, which is based
  on Ubuntu's package. We have two minor improvements to the Debian
  rules file that you probably want. These diffs are based on your
  Xenial v56 package. First, a simple typo:

  From b794c427fa8146e8f3eb38f593c0d6e0d42692c7 Mon Sep 17 00:00:00 2001
  From: Michael Catanzaro 
  Date: Mon, 2 Jan 2017 18:39:20 -0600
  Subject: [PATCH] Fix upstream typo in rules file

  So now we know armhf has not been tested
  ---
   debian/rules | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

  diff --git a/debian/rules b/debian/rules
  index 881dd1a..3baa6d2 100755
  --- a/debian/rules
  +++ b/debian/rules
  @@ -127,7 +127,7 @@ else ifeq (armhf,$(DEB_HOST_ARCH))
   common_defines += target_cpu="arm"
   #common_defines += arm_optionally_use_neon=false   # implies Android in 
2016-10
   common_defines += arm_use_neon=false
  -common_defined += arm_float_abi="hard" arm_use_thumb=true
  +common_defines += arm_float_abi="hard" arm_use_thumb=true
   else ifeq (arm64,$(DEB_HOST_ARCH))
   common_defines += target_cpu="arm64"
   else ifeq (i386,$(DEB_HOST_ARCH))

  
  Second we have a patch to remove some environment variables that are ignored 
by the new build system:

  From 3d7d37f64a31f4dad7e43bf78269a714bae1ed42 Mon Sep 17 00:00:00 2001
  From: Michael Catanzaro 
  Date: Sun, 8 Jan 2017 14:37:03 -0600
  Subject: [PATCH] Remove unused code from rules file

  All of these environment variables are ignored by the GN build, so it is
  misleading to keep them here.

  Also, remove the incorrect comment immediately below, since it prefaces
  a list of features that are both enabled and disabled.
  ---
   debian/rules | 11 ---
   1 file changed, 11 deletions(-)

  diff --git a/debian/rules b/debian/rules
  index 773b78e..33b7374 100755
  --- a/debian/rules
  +++ b/debian/rules
  @@ -62,17 +62,6 @@ DEB_DH_SCOUR_ARGS += -Xsvg