[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-03-14 Thread Nathan Teodosio
** Changed in: chromium-browser (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  Fix Released
Status in chromium-browser source package in Bionic:
  Fix Released

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-03-14 Thread Nathan Teodosio
Glad to hear that, and thanks for the cooperation!

** Changed in: chromium-browser (Ubuntu Bionic)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  Fix Committed
Status in chromium-browser source package in Bionic:
  Fix Released

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-03-10 Thread theofficialgman
I can confirm the be build from the ppa works on arm64. Thank you!

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  Fix Committed
Status in chromium-browser source package in Bionic:
  Fix Committed

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-03-10 Thread Nathan Teodosio
** Also affects: chromium-browser (Ubuntu Bionic)
   Importance: Undecided
   Status: New

** Changed in: chromium-browser (Ubuntu Bionic)
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  Fix Committed
Status in chromium-browser source package in Bionic:
  Fix Committed

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


Re: [Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-03-08 Thread Nathan Teodosio
Can you please try ppa:canonical-chromium-builds/stage?

https://launchpad.net/~canonical-chromium-builds/+archive/ubuntu/stage

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  Fix Committed

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


Re: [Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-03-07 Thread Nathan Teodosio
Ah, didn't know you were in Bionic. I'll build it in a PPA.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  Fix Committed

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-03-06 Thread theofficialgman
ae you able to put it in the ubuntu bionic beta chromium ppa? I can't
really test the snap due to kernel incompatibility.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  Fix Committed

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-03-06 Thread Nathan Teodosio
Marking as "fix committed" but before passing it on to the other
channels I'd need confirmation.

** Changed in: chromium-browser (Ubuntu)
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  Fix Committed

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-03-01 Thread Nathan Teodosio
Can you please test the snap from the edge channel (snap refresh
--channel edge chromium) and report whether it solves the issue?

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  In Progress

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-02-27 Thread Nathan Teodosio
Indeed, and, if I'm reading it correctly, that's why widevine-enable-
version-string.patch[1] has changes such as

  -#if BUILDFLAG(BUNDLE_WIDEVINE_CDM)
  +#if BUILDFLAG(ENABLE_WIDEVINE_CDM_COMPONENT)

Since I don't see why Widevine shouldn't be enabled on Armhf too, I'm
simply removing the 'target_cpu == "x64"' check.

Currently building on the edge channel.

[1] https://git.launchpad.net/~chromium-team/chromium-browser/+git/snap-
from-source/tree/build/chromium-patches/widevine-enable-version-
string.patch?h=dev

** Changed in: chromium-browser (Ubuntu)
   Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  In Progress

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-02-24 Thread theofficialgman
just to note, this patch replaces the cdm_registration.cc changes from
widevine-enable-version-string.patch but you still need the changes to
widevine_cdm_version.h from that patch

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  Triaged

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-02-24 Thread Nathan Teodosio
** Changed in: chromium-browser (Ubuntu)
   Status: New => Triaged

** Changed in: chromium-browser (Ubuntu)
   Importance: Undecided => High

** Changed in: chromium-browser (Ubuntu)
 Assignee: (unassigned) => Nathan Teodosio (nteodosio)

** Changed in: chromium-browser (Ubuntu)
   Importance: High => Medium

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  Triaged

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-02-24 Thread theofficialgman
widevine isn't supplied with the chromium deb on linux amd64. you are 
misinterpreting what the flag does. if bundled is not set, then you hit this 
case always and widevine is never checked 
https://source.chromium.org/chromium/chromium/src/+/main:chrome/common/media/cdm_registration.cc;l=207?q=%22Widevine%20enabled%20but%20no%20library%20found%22=chromium
you get this error in log (which is what is happening on arm64 rn): 
`[31833:31833:0216/204151.842227:VERBOSE1:cdm_registration.cc(189)] Widevine 
enabled but no library found`
bundled being set does not actually result in widevine being downloaded from 
google and supplied along with chromium which is what you are assuming it means.

on linux amd64, windows x86/x64/arm64, macos x64/arm64, and cros
arm/arm64/x64 the BUNDLE_WIDEVINE_CDM flag gets set during the build for
chromium and chrome
https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/widevine/cdm/widevine.gni#23

you could add an `|| target_cpu == "arm64"` under the linux case and get the 
same result as my patches I assume but I followed piOS and fedora 
chromium-freeworld's lead with their patches: 
https://github.com/rpmfusion/chromium-freeworld/blob/d2165a468332661df1439208eb930661caaa9f1e/chromium-enable-widevine.patch#L7-L8
https://github.com/RPi-Distro/chromium-browser/blob/ecaf4660a61064c1c2338131d6a4f0807c424123/debian/patches/widevine-other-locations#L19-L20

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  New

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-02-24 Thread Nathan Teodosio
Thanks for submitting a report with your patch.

> currently BUNDLE_WIDEVINE_CDM does not get set for arm64 linux (but
does on amd64 linux)

Do you have evidence for amd64 having it bundled? I don't think we
bundle Widevine for any oarchitecture.

As such, I wonder whether the last two sections of the patch are
necessary.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  New

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp


[Desktop-packages] [Bug 2008433] Re: Request to enable WidevineCDM checking on ARM64

2023-02-23 Thread Ubuntu Foundations Team Bug Bot
The attachment "widevine-enable-all-architectures.patch" seems to be a
patch.  If it isn't, please remove the "patch" flag from the attachment,
remove the "patch" tag, and if you are a member of the ~ubuntu-
reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by
~brian-murray, for any issues please contact him.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/2008433

Title:
  Request to enable WidevineCDM checking on ARM64

Status in chromium-browser package in Ubuntu:
  New

Bug description:
  If possible, could you please include a patch to enable widevinecdm
  checking on ARM64 linux? currently BUNDLE_WIDEVINE_CDM does not get
  set for arm64 linux (but does on amd64 linux) so chromium does not
  even check for widevine even if we have it available and placed in the
  directory manually.

  I am currently using the attached patch of my making when testing
  locally to correct this issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/2008433/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp