[Desktop-packages] [Bug 261595] Re: Thunderbird corrupts Mailbox when hd is full
Also happens on IMAP-based setups i.e. GMail. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird: Fix Released Status in thunderbird package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
*** Bug 535636 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Fix Released Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
(In reply to :Irving Reid from comment #51) This might be worth slipping in to the closed tree, to make sure it shows up in the next successful nightly. I advocate for this. I believe leave messages on the server is a commonly used setting. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Fix Released Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Now the tree is at least building partially, I've landed this: https://hg.mozilla.org/comm-central/rev/a5e88cd9f942 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Fix Released Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595] Re: Thunderbird corrupts Mailbox when hd is full
** Changed in: thunderbird Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Fix Released Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
This might be worth slipping in to the closed tree, to make sure it shows up in the next successful nightly. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
I can't speak to the original intent of this bug. But, with a local build including attachment 800048 the symptoms of bug 913502 are gone. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
(In reply to Hiroyuki Ikezoe (:hiro) from comment #47) Created attachment 800048 followup_fix_for_bug239455.patch This bug did not fix at all. nsISafeOutputStream.finish has to be invoked to overwrite popstate.dat. see bug 913502 That seems to occur only if you set the pref leave messages on the server. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Thanks Hiro. I overlooked this. Patch looks good to me. We don't need to check for NS_FAILED(rv) again, because either way void is returned. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Created attachment 800048 followup_fix_for_bug239455.patch This bug did not fix at all. nsISafeOutputStream.finish has to be invoked to overwrite popstate.dat. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595] Re: Thunderbird corrupts Mailbox when hd is full
** Changed in: thunderbird Status: Fix Released = Confirmed -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Hi Irving, thanks for the review. For some reason I did not get/read the notification email from Mozilla. I, too, noticed that there are other places which would deserve attention and use of a similar function. However, I would prefer this patch to go through first, and that we make another bug to (1) identify those code segments/files, (2) discuss the appropriate solution for each and, then, (3) write a patch, which I can help with. So I would ask for this patch to go through as is, since you indicated it is ok. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Fix Released Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
I have marked the bug so that the patch will be checked in. Johannes, please file the follow-up bug for the remaining work on the other similar places. Please CC me there. I hope you can work on that bug too. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Fix Released Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
The follow-up bug is at Bug 912465 (feel free to change the component, etc). Lets continue there. Thank you Irving, Aceman, and Ryan. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Fix Released Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
https://hg.mozilla.org/comm-central/rev/92726142b524 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Fix Released Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595] Re: Thunderbird corrupts Mailbox when hd is full
** Changed in: thunderbird Status: In Progress = Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Fix Released Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Johannes do you want to do what Irving is proposing ? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: In Progress Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Comment on attachment 756486 Write updated popstate in tempfile first, then move over Review of attachment 756486: - Thanks so much for the patch; sorry it took so long for me to review it. I'm OK with either landing this patch as is, or expanding it to refactor out the other places in mailnews where we create safe, buffered output streams. ::: mailnews/base/util/nsMsgUtils.cpp @@ +1438,4 @@ return rv; } +nsresult MsgNewSafeBufferedFileOutputStream(nsIOutputStream **aResult, There are a couple of other places in mailnews where we're creating safe output streams; it would be great to update those to use this helper function instead of repeating the code, as part of this patch. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: In Progress Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Created attachment 756486 Write updated popstate in tempfile first, then move over As in Bug 246675, using NS_NewSafeLocalFileOutputStream now, which is an existing implementation that writes to a temp file first. I verified that this patch works using strace and filling the disk. Writing to the temp file fails, and rename is not done, preserving the original file. I think MsgNewSafeBufferedFileOutputStream should now be used in a number of other places. Please review. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: In Progress Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
So when you reference bug 246675, why do you not use the nsISafeFileOutputStream ? Is it not applicable to the file here? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: In Progress Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Comment on attachment 756011 Write updated popstate in tempfile first, then copy over You need to request reviews for patches. Setting it for you. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: In Progress Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Created attachment 756290 Write updated popstate in tempfile first, then move over Can't reproduce disk full bug using this patch. Can reproduce disk full bug without this patch. Move does not fail when the disk is full. For testing, the disk must be filled up between connecting to the server and closing the connection, because Thunderbird does not try to fetch new messages anymore if the disk is full. I just now saw Bug 246675 is the right approach. Will make an update -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: In Progress Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Created attachment 756011 Write updated popstate in tempfile first, then copy over This patch should prevent the bug, because move does not fail when the disk is full. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: In Progress Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
17.0.5 (64bit), ~50.000 POP emails, this bug is annoying. I use this addon to get rid of the havoc: https://addons.mozilla.org/en-us/thunderbird/addon/remove-duplicate-messages-alte/ But junk mail, manually removed before, can remain. With the DiskSpaceAvailableInStore(file, spaceRequested) function proposed in https://bugzilla.mozilla.org/attachment.cgi?id=735319action=diff the proposed criterion could be implemented. I think writing the new content of popstate.dat to a temporary file and then moving it over would be saner, because then you can never enter a corrupt state. This bug may be more closely related to Bug 263142 than Bug 789679 (new dep?), and pehaps can be resolved together. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: In Progress Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Cool, thanks for the patch. The patch you referenced (https://bugzilla.mozilla.org/attachment.cgi?id=735319action=diff) was already checked in. Also bug 640371 should help this case as it refuses to download any new messages if there is less than several MB of free disk space. Even if we rewrote popstate.dat in that case (but unchanged) there should be enough space to do it. But your patch may cover some more cases (e.g. if the disk is filled by other program and some messages are only marked for deletion on server). I just wonder why net_pop3_write_state can't report any failure to higher levels. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: In Progress Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595] Re: Thunderbird corrupts Mailbox when hd is full
** Changed in: thunderbird Status: Confirmed = In Progress -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: In Progress Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
*** Bug 599664 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
(In reply to :aceman from comment #28) However we still should check for free space before popstate.dat is rewritten. Any proposals on what to check? Current size of popstate.dat*2 + 4MB of spare? Anything more clever? What sizes of popstate.dat have you guys seen in the wild? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
The largest I find recorded in my emails and bug reports is 1.8MB. But bienvenu would have great historical knowledge here. how about popstate.dat*3 + X MB, where X is what we are using elsewhere as buffer against disaster size? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
*** Bug 765610 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Adding some searchwords for better retrievability. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
I can confirm this bug on Linux running Thunderbird version 17.0.2 (64bit). This only happens with POP-Accounts. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
I think this is not fixed. The checks for free disk space before pop3 download are not sufficient. We may help this in bug 640371 (do not even start pop3 download if disk space is not enough for all the messages to be downloaded) and bug 789679, where we actually check free disk space on some more operations in TB. In all the checks, we only allow the operation if there still remains at least 4MB free disk space after the operation. So 4MB should be enough to rewrite the popstate.dat file. However we still should check for free space before popstate.dat is rewritten. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
reopening. It's not clear (to me) whether comment 19 was a sufficient test. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595] Re: Thunderbird corrupts Mailbox when hd is full
** Changed in: thunderbird Status: Invalid = Confirmed -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Confirmed Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 261595]
Hi guy, I am facing the same problem running Thunderbird 17.0.2 in Ubuntu Linux 12.10, 64Bit. When the system runs out of hard drive memory Thunderbird starts to download all mails again. I am using a POP server. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbird corrupts Mailbox when hd is full Status in Mozilla Thunderbird Mail and News: Invalid Status in “thunderbird” package in Ubuntu: Triaged Bug description: Binary package hint: mozilla-thunderbird I fetched the POP3 EMails and the last Message got cut in the middle. Other than in Bug #23302 there was NO warning about little space. Then I got a warning after the error the little space and freed some space up. Now it fetched all allready fetched mails again and added some junk from another email into the unfinished email. In the end this is not so severe, but the check for little space should kick in before and it should not get to corruption of email data. Seen in ubuntu 8.04.1 with thunderbird 2.0.0.16. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/261595/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
