Re: [Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
Excellent! Thanks for your work Timothy :) On 31 October 2012 20:39, Timothy Arceri <316...@bugs.launchpad.net> wrote: > Hi Chris, > I managed to figure out my build issues and have submitted a > patch to the upstream gtk bug. I've also asked for a review on the GTK dev > mailing list so fingers crossed someone takes a look at it. > > > ** Changed in: hundredpapercuts >Status: Triaged => In Progress > > -- > You received this bug notification because you are subscribed to One > Hundred Paper Cuts. > Matching subscriptions: Papercut bug mail > https://bugs.launchpad.net/bugs/316959 > > Title: > Music folder appears twice in Rhythmbox > > Status in GTK+ GUI Toolkit: > Confirmed > Status in One Hundred Paper Cuts: > In Progress > Status in The Rhythmbox Music Management Application: > Expired > Status in “gtk+3.0” package in Ubuntu: > Confirmed > Status in “rhythmbox” package in Ubuntu: > Invalid > > Bug description: > On a clean and updated install of Intrepid, if you open Rhythmbox, > select Import Folder, and then look on the quick list to the left hand > side of the chooser box, you will see Music twice. The first time > where I think Network should be, then the 2nd time where it should be > with home directories. > > Attached is a screenshot of what I am seeing. > > To manage notifications about this bug go to: > https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions > -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in GTK+ GUI Toolkit: Confirmed Status in One Hundred Paper Cuts: In Progress Status in The Rhythmbox Music Management Application: Expired Status in “gtk+3.0” package in Ubuntu: Confirmed Status in “rhythmbox” package in Ubuntu: Invalid Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
Hi Chris, I managed to figure out my build issues and have submitted a patch to the upstream gtk bug. I've also asked for a review on the GTK dev mailing list so fingers crossed someone takes a look at it. ** Changed in: hundredpapercuts Status: Triaged => In Progress -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in GTK+ GUI Toolkit: Confirmed Status in One Hundred Paper Cuts: In Progress Status in The Rhythmbox Music Management Application: Expired Status in “gtk+3.0” package in Ubuntu: Confirmed Status in “rhythmbox” package in Ubuntu: Invalid Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
Re: [Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
Timothy, what are the issues? If you can upload the code you're working on somewhere (Launchpad, Github, etc) or simply share it with Ubuntu One, then I can try building it myself. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in GTK+ GUI Toolkit: Confirmed Status in One Hundred Paper Cuts: Triaged Status in The Rhythmbox Music Management Application: Expired Status in “gtk+3.0” package in Ubuntu: Confirmed Status in “rhythmbox” package in Ubuntu: Invalid Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
** Changed in: gtk+3.0 (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in GTK+ GUI Toolkit: Confirmed Status in One Hundred Paper Cuts: Triaged Status in The Rhythmbox Music Management Application: Expired Status in “gtk+3.0” package in Ubuntu: Confirmed Status in “rhythmbox” package in Ubuntu: Invalid Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
Chris, that may be so but we should still attempt to fix the bug in GTK so that it doesn't happen again in future and so it fixes any issues with other applications i.e Totem. >From what I can make out in the code here is the problem: gtk_file_chooser_add_shortcut_folder is implemented in http://git.gnome.org/browse/gtk+/tree/gtk/gtkfilechooserdefault.c as gtk_file_chooser_default_add_shortcut_folder (GtkFileChooser *chooser, GFile *file, GError **error) Priority is given to any shortcuts added by the application over any bookmarks added at construction time (see line: 8002 if (pos >= 0 && pos < shortcuts_get_index (impl, SHORTCUTS_BOOKMARKS_SEPARATOR)) ) This shows that any existing bookmarks are ignored and the shortcut is added anyway. The problem appears to be that the duplicate bookmark is not then removed. Note that if you drag and drop one of the other bookmarks than the duplicate correctly disappears. So there seems to be code on the bookmarks side that checks for duplicates, the problem is they have already been created before the shortcut is added. I tried splitting up the above if statement and adding an else to the second condition where I attempt to remove the bookmark based on the pos but I'm having real trouble building GTK on my machine which I'm not sure I can resolve. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in GTK+ GUI Toolkit: Confirmed Status in One Hundred Paper Cuts: Triaged Status in The Rhythmbox Music Management Application: Expired Status in “gtk+3.0” package in Ubuntu: Confirmed Status in “rhythmbox” package in Ubuntu: Invalid Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
** Changed in: rhythmbox Status: New => Expired -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in GTK+ GUI Toolkit: Confirmed Status in One Hundred Paper Cuts: Triaged Status in The Rhythmbox Music Management Application: Expired Status in “gtk+3.0” package in Ubuntu: Confirmed Status in “rhythmbox” package in Ubuntu: Invalid Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
Comment from the developer: "This no longer occurs with the new import dialog. I'll have to work out whether I actually wanted that to happen or whether I just didn't bother to keep the code that adds the shortcut for the Music folder." Timothy, what's your take on this? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in GTK+ GUI Toolkit: Confirmed Status in One Hundred Paper Cuts: Triaged Status in The Rhythmbox Music Management Application: New Status in “gtk+3.0” package in Ubuntu: Confirmed Status in “rhythmbox” package in Ubuntu: Invalid Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
** Changed in: rhythmbox (Ubuntu) Status: Triaged => Invalid ** Also affects: gtk+3.0 (Ubuntu) Importance: Undecided Status: New ** Changed in: gtk+3.0 (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in GTK+ GUI Toolkit: Confirmed Status in One Hundred Paper Cuts: Triaged Status in The Rhythmbox Music Management Application: New Status in “gtk+3.0” package in Ubuntu: Confirmed Status in “rhythmbox” package in Ubuntu: Invalid Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
** Changed in: gtk Status: Unknown => Confirmed ** Changed in: gtk Importance: Unknown => Medium -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in GTK+ GUI Toolkit: Confirmed Status in One Hundred Paper Cuts: Triaged Status in The Rhythmbox Music Management Application: New Status in “rhythmbox” package in Ubuntu: Triaged Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
Removing the code as in comment #9 just hides the real problem. As I said the real bug is in GTK -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in GTK+ GUI Toolkit: Unknown Status in One Hundred Paper Cuts: Triaged Status in The Rhythmbox Music Management Application: New Status in “rhythmbox” package in Ubuntu: Triaged Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
Removing the code as in comment #9 removes the "Music" entry from the upper section. I can't determine where the list in the lower section is generated, although the documentation (http://developer.gnome.org/gtk/2.24/GtkFileChooser.html#GtkFileChooser.description) suggests it can come from "various sources". Perhaps somebody who understands Gnome better can find it. Unless we can determine at runtime that there is a duplicate entry, it may happen that bluntly removing the code actually removes the only copy of that entry. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in GTK+ GUI Toolkit: Unknown Status in One Hundred Paper Cuts: Triaged Status in The Rhythmbox Music Management Application: New Status in “rhythmbox” package in Ubuntu: Triaged Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
Hi Chris, This is a GTK bug rather than a specific Rhythmbox issue. The upstream GTK bug I've linked describes the same thing happening in Totem. I'll have a look to see if I can fix this in GTK. ** Changed in: hundredpapercuts Status: Confirmed => Triaged ** Changed in: hundredpapercuts Assignee: Papercuts Ninja (papercuts-ninja) => Timothy Arceri (t-fridey) ** Bug watch added: GNOME Bug Tracker #577806 https://bugzilla.gnome.org/show_bug.cgi?id=577806 ** Also affects: gtk via https://bugzilla.gnome.org/show_bug.cgi?id=577806 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in GTK+ GUI Toolkit: Unknown Status in One Hundred Paper Cuts: Triaged Status in The Rhythmbox Music Management Application: New Status in “rhythmbox” package in Ubuntu: Triaged Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/gtk/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
Another issue I've noticed is that only the first entry can be clicked. Any attempt to click on the second entry results in the first one being selected. I think that Rhythmbox simply shouldn't be adding this bookmark if it's going to cause problems, both from technical and usability perspectives. Comment #9 proposes what I think could be a very simple fix for this, provided the code hasn't changed so much in the two and half years since it was posted. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in One Hundred Paper Cuts: Confirmed Status in The Rhythmbox Music Management Application: New Status in “rhythmbox” package in Ubuntu: Triaged Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
** Changed in: hundredpapercuts Assignee: (unassigned) => Papercuts Ninja (papercuts-ninja) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in One Hundred Paper Cuts: Confirmed Status in The Rhythmbox Music Management Application: New Status in “rhythmbox” package in Ubuntu: Triaged Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
[Desktop-packages] [Bug 316959] Re: Music folder appears twice in Rhythmbox
** Also affects: hundredpapercuts Importance: Undecided Status: New ** Changed in: hundredpapercuts Status: New => Confirmed ** Changed in: hundredpapercuts Importance: Undecided => Low ** Changed in: hundredpapercuts Milestone: None => raring-round-1 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/316959 Title: Music folder appears twice in Rhythmbox Status in One Hundred Paper Cuts: Confirmed Status in The Rhythmbox Music Management Application: New Status in “rhythmbox” package in Ubuntu: Triaged Bug description: On a clean and updated install of Intrepid, if you open Rhythmbox, select Import Folder, and then look on the quick list to the left hand side of the chooser box, you will see Music twice. The first time where I think Network should be, then the 2nd time where it should be with home directories. Attached is a screenshot of what I am seeing. To manage notifications about this bug go to: https://bugs.launchpad.net/hundredpapercuts/+bug/316959/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
