Review Request 24862: Accumulo-3021 Limit size of split rows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24862/ --- Review request for accumulo. Bugs: Accumulo-3021 https://issues.apache.org/jira/browse/Accumulo-3021 Repository: accumulo Description --- Added constraint for maximum end row size. Checked this constraint before any split is done. A unit test was added to test the added constraint when both a user initiaed a tablet split and when an automatic split occurs. This test also tests to make sure that when new data is added to a table that is small enough to be used as an end row the table splits. Diffs - core/src/main/java/org/apache/accumulo/core/conf/Property.java 85c56f8 server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 82045b6 test/src/test/java/org/apache/accumulo/test/Accumulo3021IT.java PRE-CREATION Diff: https://reviews.apache.org/r/24862/diff/ Testing --- Passes unit tests. Thanks, Jenna Huston
Re: Review Request 24862: Accumulo-3021 Limit size of split rows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24862/ --- (Updated Aug. 19, 2014, 5:13 p.m.) Review request for accumulo and kturner. Bugs: Accumulo-3021 https://issues.apache.org/jira/browse/Accumulo-3021 Repository: accumulo Description --- Added constraint for maximum end row size. Checked this constraint before any split is done. A unit test was added to test the added constraint when both a user initiaed a tablet split and when an automatic split occurs. This test also tests to make sure that when new data is added to a table that is small enough to be used as an end row the table splits. Diffs - core/src/main/java/org/apache/accumulo/core/conf/Property.java 85c56f8 server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 82045b6 test/src/test/java/org/apache/accumulo/test/Accumulo3021IT.java PRE-CREATION Diff: https://reviews.apache.org/r/24862/diff/ Testing --- Passes unit tests. Thanks, Jenna Huston
Re: Review Request 24862: Accumulo-3021 Limit size of split rows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24862/ --- (Updated Aug. 20, 2014, 6:28 p.m.) Review request for accumulo and kturner. Bugs: Accumulo-3021 https://issues.apache.org/jira/browse/Accumulo-3021 Repository: accumulo Description --- Added constraint for maximum end row size. Checked this constraint before any split is done. A unit test was added to test the added constraint when both a user initiaed a tablet split and when an automatic split occurs. This test also tests to make sure that when new data is added to a table that is small enough to be used as an end row the table splits. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/conf/Property.java 85c56f8 server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 82045b6 test/src/test/java/org/apache/accumulo/test/LargeSplitRowIT.java PRE-CREATION Diff: https://reviews.apache.org/r/24862/diff/ Testing --- Passes unit tests. Thanks, Jenna Huston
Re: Review Request 24862: Accumulo-3021 Limit size of split rows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24862/ --- (Updated Aug. 20, 2014, 7:45 p.m.) Review request for accumulo and kturner. Bugs: Accumulo-3021 https://issues.apache.org/jira/browse/Accumulo-3021 Repository: accumulo Description --- Added constraint for maximum end row size. Checked this constraint before any split is done. A unit test was added to test the added constraint when both a user initiaed a tablet split and when an automatic split occurs. This test also tests to make sure that when new data is added to a table that is small enough to be used as an end row the table splits. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/conf/Property.java 85c56f8 server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 82045b6 test/src/test/java/org/apache/accumulo/test/LargeSplitRowIT.java PRE-CREATION Diff: https://reviews.apache.org/r/24862/diff/ Testing --- Passes unit tests. Thanks, Jenna Huston
Accumulo-2841
John Vines, would it be ok if I worked on and submitted a patch to Accumulo ticket 2841? Thanks! Jenna
Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/ --- Review request for accumulo. Bugs: ACCUMULO-3176 https://issues.apache.org/jira/browse/ACCUMULO-3176 Repository: accumulo Description --- Gives the ability to add properties to tables before they are initialized. Therefore these properties will take effect before the default tablet is created. We create a NewTableConfiguration class and send that in the create method as opposed to adding another method. Diffs - core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 97f538d core/src/main/java/org/apache/accumulo/core/client/impl/NewTableConfiguration.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java e46b9c9 core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 32dbb28 core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 35cbdd2 core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 08750fe core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java 02838ed proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java 81b39d2 test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java PRE-CREATION Diff: https://reviews.apache.org/r/26188/diff/ Testing --- New IT, ran unit test and integration tests Thanks, Jenna Huston
Re: Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties
On Oct. 6, 2014, 2:19 p.m., Jenna Huston wrote: > > Did you plan to change the proxy API and/or create table command in shell? I am in the process of testing the new command option in the shell. Can you suggest a test that would be good to look at for testing the new option. - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/#review55498 --- On Oct. 3, 2014, 5:30 p.m., Jenna Huston wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26188/ > --- > > (Updated Oct. 3, 2014, 5:30 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3176 > https://issues.apache.org/jira/browse/ACCUMULO-3176 > > > Repository: accumulo > > > Description > --- > > Gives the ability to add properties to tables before they are initialized. > Therefore these properties will take effect before the default tablet is > created. We create a NewTableConfiguration class and send that in the create > method as opposed to adding another method. > > > Diffs > - > > > core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java > 97f538d > > core/src/main/java/org/apache/accumulo/core/client/impl/NewTableConfiguration.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java > e46b9c9 > core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java > 32dbb28 > core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java > 35cbdd2 > > core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java > 08750fe > > core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java > 02838ed > proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add > > shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java > 81b39d2 > > test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/26188/diff/ > > > Testing > --- > > New IT, ran unit test and integration tests > > > Thanks, > > Jenna Huston > >
Re: Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/ --- (Updated Oct. 6, 2014, 6:27 p.m.) Review request for accumulo. Bugs: ACCUMULO-3176 https://issues.apache.org/jira/browse/ACCUMULO-3176 Repository: accumulo Description --- Gives the ability to add properties to tables before they are initialized. Therefore these properties will take effect before the default tablet is created. We create a NewTableConfiguration class and send that in the create method as opposed to adding another method. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/client/NewTableConfiguration.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 97f538d core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java e46b9c9 core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 32dbb28 core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 35cbdd2 core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 08750fe core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java 02838ed proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java 81b39d2 test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java PRE-CREATION test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 5a068af Diff: https://reviews.apache.org/r/26188/diff/ Testing --- New IT, ran unit test and integration tests Thanks, Jenna Huston
Re: Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/ --- (Updated Oct. 6, 2014, 6:40 p.m.) Review request for accumulo. Bugs: ACCUMULO-3176 https://issues.apache.org/jira/browse/ACCUMULO-3176 Repository: accumulo Description --- Gives the ability to add properties to tables before they are initialized. Therefore these properties will take effect before the default tablet is created. We create a NewTableConfiguration class and send that in the create method as opposed to adding another method. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/client/NewTableConfiguration.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 97f538d core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java e46b9c9 core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 32dbb28 core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 35cbdd2 core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 08750fe core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java 02838ed proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java 81b39d2 test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java PRE-CREATION test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 5a068af Diff: https://reviews.apache.org/r/26188/diff/ Testing --- New IT, ran unit test and integration tests Thanks, Jenna Huston
Re: Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/ --- (Updated Oct. 7, 2014, 1:35 p.m.) Review request for accumulo. Bugs: ACCUMULO-3176 https://issues.apache.org/jira/browse/ACCUMULO-3176 Repository: accumulo Description --- Gives the ability to add properties to tables before they are initialized. Therefore these properties will take effect before the default tablet is created. We create a NewTableConfiguration class and send that in the create method as opposed to adding another method. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/client/NewTableConfiguration.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 97f538d core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java e46b9c9 core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 32dbb28 core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 35cbdd2 core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 08750fe core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java 02838ed proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java 81b39d2 test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java PRE-CREATION test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 5a068af Diff: https://reviews.apache.org/r/26188/diff/ Testing --- New IT, ran unit test and integration tests Thanks, Jenna Huston
Re: Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/ --- (Updated Oct. 8, 2014, 3:05 p.m.) Review request for accumulo. Bugs: ACCUMULO-3176 https://issues.apache.org/jira/browse/ACCUMULO-3176 Repository: accumulo Description --- Gives the ability to add properties to tables before they are initialized. Therefore these properties will take effect before the default tablet is created. We create a NewTableConfiguration class and send that in the create method as opposed to adding another method. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/client/NewTableConfiguration.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 97f538d core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java e46b9c9 core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 32dbb28 core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 35cbdd2 core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 08750fe core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java 02838ed proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java 81b39d2 test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java PRE-CREATION test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 5a068af Diff: https://reviews.apache.org/r/26188/diff/ Testing --- New IT, ran unit test and integration tests Thanks, Jenna Huston
Re: Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties
> On Oct. 7, 2014, 6:16 p.m., Josh Elser wrote: > > core/src/main/java/org/apache/accumulo/core/client/NewTableConfiguration.java, > > line 52 > > <https://reviews.apache.org/r/26188/diff/4/?file=714575#file714575line52> > > > > Some javadoc here about how "withoutDefaultIterators" really means "no > > VersioningIterator" would be good. Actually, will we have other default > > iterators down the road? Maybe it makes sense to just rename this to be > > 'withoutVersioningIterator" or similar? > > Christopher Tubbs wrote: > +1 for the javadoc, but regarding the name, I actually thought the > opposite. There is no context right now to explain why there should be > options to configure one particular iterator, but not the others. The context > that should be conveyed is that this particular iterator is on by default, so > I think the name should reflect that. The javadoc should definitely highlight > which iterators are included in the defaults, though. > > Josh Elser wrote: > My only concern was calling it "default iterators" when there is only one > default iterator. If we're future proofing for more default iterators in the > future, that's fine. That would reduce the number of methods we eventually > need for NewTableConfiguration. > > Josh Elser wrote: > Actually, it's a little inconsistent right now using a boolean to track > limitVersion. I think it would make more sense to rely on getProperties in > the server instead of both getProperties and getLimitVersion. This then makes > limitVersion private. Then, the implementation can perform a merge of the > default iterator properties with the user-set properties and get a consistent > view of what all properties would be (rather than the boolean + the map). I think I made all of the changes we talked about yesturday. If I forgot something let me know. - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/#review55670 --- On Oct. 7, 2014, 1:35 p.m., Jenna Huston wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26188/ > --- > > (Updated Oct. 7, 2014, 1:35 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3176 > https://issues.apache.org/jira/browse/ACCUMULO-3176 > > > Repository: accumulo > > > Description > --- > > Gives the ability to add properties to tables before they are initialized. > Therefore these properties will take effect before the default tablet is > created. We create a NewTableConfiguration class and send that in the create > method as opposed to adding another method. > > > Diffs > - > > > core/src/main/java/org/apache/accumulo/core/client/NewTableConfiguration.java > PRE-CREATION > > core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java > 97f538d > > core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java > e46b9c9 > core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java > 32dbb28 > core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java > 35cbdd2 > > core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java > 08750fe > > core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java > 02838ed > proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add > > shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java > 81b39d2 > > test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java > PRE-CREATION > test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 5a068af > > Diff: https://reviews.apache.org/r/26188/diff/ > > > Testing > --- > > New IT, ran unit test and integration tests > > > Thanks, > > Jenna Huston > >
Re: Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/ --- (Updated Oct. 8, 2014, 3:21 p.m.) Review request for accumulo. Changes --- Took out some tracers that I missed. Bugs: ACCUMULO-3176 https://issues.apache.org/jira/browse/ACCUMULO-3176 Repository: accumulo Description --- Gives the ability to add properties to tables before they are initialized. Therefore these properties will take effect before the default tablet is created. We create a NewTableConfiguration class and send that in the create method as opposed to adding another method. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/client/NewTableConfiguration.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 97f538d core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java e46b9c9 core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 32dbb28 core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 35cbdd2 core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 08750fe core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java 02838ed proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java 81b39d2 test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java PRE-CREATION test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 5a068af Diff: https://reviews.apache.org/r/26188/diff/ Testing --- New IT, ran unit test and integration tests Thanks, Jenna Huston
Re: Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/ --- (Updated Oct. 8, 2014, 6:28 p.m.) Review request for accumulo. Bugs: ACCUMULO-3176 https://issues.apache.org/jira/browse/ACCUMULO-3176 Repository: accumulo Description --- Gives the ability to add properties to tables before they are initialized. Therefore these properties will take effect before the default tablet is created. We create a NewTableConfiguration class and send that in the create method as opposed to adding another method. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/client/NewTableConfiguration.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 97f538d core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java e46b9c9 core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 32dbb28 core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 35cbdd2 core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 08750fe core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java 02838ed proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java 81b39d2 test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java PRE-CREATION test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 5a068af Diff: https://reviews.apache.org/r/26188/diff/ Testing --- New IT, ran unit test and integration tests Thanks, Jenna Huston
Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26507/ --- Review request for accumulo. Bugs: ACCUMULO-3177 and ACCUMULO-3178 https://issues.apache.org/jira/browse/ACCUMULO-3177 https://issues.apache.org/jira/browse/ACCUMULO-3178 Repository: accumulo Description --- Added a per table volume chooser that allows tables to be given a specific volume chooser. The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table. When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser. Diffs - core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java b2341b6 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 4305e71 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 8d14cad server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java b435b0f server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 Diff: https://reviews.apache.org/r/26507/diff/ Testing --- New IT in the patch for ACCUMULO-3178. Could not test ACCUMULO-3177 without an example chooser. Thanks, Jenna Huston
Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26507/ --- (Updated Oct. 9, 2014, 5:23 p.m.) Review request for accumulo. Bugs: ACCUMULO-3177 and ACCUMULO-3178 https://issues.apache.org/jira/browse/ACCUMULO-3177 https://issues.apache.org/jira/browse/ACCUMULO-3178 Repository: accumulo Description --- Added a per table volume chooser that allows tables to be given a specific volume chooser. The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table. When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser. Diffs - core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java b2341b6 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 4305e71 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 8d14cad server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java b435b0f server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 Diff: https://reviews.apache.org/r/26507/diff/ Testing --- New IT in the patch for ACCUMULO-3178. Could not test ACCUMULO-3177 without an example chooser. File Attachments (updated) Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Thanks, Jenna Huston
Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/ --- Review request for accumulo. Bugs: ACCUMULO-3181 https://issues.apache.org/jira/browse/ACCUMULO-3181 Repository: accumulo Description --- Delayed adding paths to volume options until after a volume is chosen. Diffs - server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java c87074b server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 5cbffc3 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java f978439 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java 2f04922 server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 5b64053 server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 2bd0b47 Diff: https://reviews.apache.org/r/26514/diff/ Testing --- Ran existing VolumeIT. Thanks, Jenna Huston
Re: Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/ --- (Updated Oct. 14, 2014, 1 p.m.) Review request for accumulo. Bugs: ACCUMULO-3176 https://issues.apache.org/jira/browse/ACCUMULO-3176 Repository: accumulo Description --- Gives the ability to add properties to tables before they are initialized. Therefore these properties will take effect before the default tablet is created. We create a NewTableConfiguration class and send that in the create method as opposed to adding another method. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/client/NewTableConfiguration.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 97f538d core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java e46b9c9 core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 32dbb28 core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 35cbdd2 core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 08750fe core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java 02838ed proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java 81b39d2 test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java PRE-CREATION test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 5a068af Diff: https://reviews.apache.org/r/26188/diff/ Testing --- New IT, ran unit test and integration tests Thanks, Jenna Huston
Re: Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/ --- (Updated Oct. 14, 2014, 2:32 p.m.) Review request for accumulo. Bugs: ACCUMULO-3176 https://issues.apache.org/jira/browse/ACCUMULO-3176 Repository: accumulo Description --- Gives the ability to add properties to tables before they are initialized. Therefore these properties will take effect before the default tablet is created. We create a NewTableConfiguration class and send that in the create method as opposed to adding another method. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/client/NewTableConfiguration.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 97f538d core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java e46b9c9 core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 32dbb28 core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 35cbdd2 core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 08750fe core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java 02838ed proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java 81b39d2 test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java PRE-CREATION test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 5a068af Diff: https://reviews.apache.org/r/26188/diff/ Testing --- New IT, ran unit test and integration tests Thanks, Jenna Huston
Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser
> On Oct. 13, 2014, 6:05 p.m., Josh Elser wrote: > > server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java, > > line 34 > > <https://reviews.apache.org/r/26507/diff/1/?file=716757#file716757line34> > > > > Logging here could get pretty spammy on an active node. We should be > > able to extrapolate what the chosen volume was when the file actually gets > > written. Maybe pull them back to trace or just drop. Yeah just left these and most of the logging in for debugging purposes. Didn't want to have to put them back in if big changes were needed in this. > On Oct. 13, 2014, 6:05 p.m., Josh Elser wrote: > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java, > > line 578 > > <https://reviews.apache.org/r/26507/diff/1/?file=716761#file716761line578> > > > > Would be better to just make a VolumeChooserEnvironment that doesn't > > have any data (to use when !tableId.isPresent()). That collapses this down > > into the single choose(..) method. Made the VolumeChooserEnvironment optional and collapsed everything down to the new method. - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26507/#review56419 --- On Oct. 9, 2014, 5:23 p.m., Jenna Huston wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26507/ > --- > > (Updated Oct. 9, 2014, 5:23 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3177 and ACCUMULO-3178 > https://issues.apache.org/jira/browse/ACCUMULO-3177 > https://issues.apache.org/jira/browse/ACCUMULO-3178 > > > Repository: accumulo > > > Description > --- > > Added a per table volume chooser that allows tables to be given a specific > volume chooser. The second patch, ACCUMULO-3178, adds an example, a > preferred volume chooser which gives the preferred volume for a table. When > a table chooser is not specified, or a preferred volume is not specified > then, the default chooser is the RandomVolumeChooser. > > > Diffs > - > > core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 > > server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java > PRE-CREATION > > server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java > 2760b07 > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java > 8713c97 > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java > PRE-CREATION > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java > cbfdb5e > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java > b2341b6 > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > 82b77ee > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > 4305e71 > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java > 0f7ac22 > > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > 8d14cad > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > b8e7113 > server/master/src/main/java/org/apache/accumulo/master/Master.java b435b0f > > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java > 0a3d1d0 > > server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java > f56c1e2 > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > e923ebc > > server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java > dad9a75 > > Diff: https://reviews.apache.org/r/26507/diff/ > > > Testing > --- > > New IT in the patch for ACCUMULO-3178. Could not test ACCUMULO-3177 without > an example chooser. > > > File Attachments > > > Diff for 3178 > > https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch > > > Thanks, > > Jenna Huston > >
Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26507/ --- (Updated Oct. 14, 2014, 3:51 p.m.) Review request for accumulo. Bugs: ACCUMULO-3177 and ACCUMULO-3178 https://issues.apache.org/jira/browse/ACCUMULO-3177 https://issues.apache.org/jira/browse/ACCUMULO-3178 Repository: accumulo Description --- Added a per table volume chooser that allows tables to be given a specific volume chooser. The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table. When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java b2341b6 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 4305e71 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 8d14cad server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java b435b0f server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 Diff: https://reviews.apache.org/r/26507/diff/ Testing --- New IT in the patch for ACCUMULO-3178. Could not test ACCUMULO-3177 without an example chooser. File Attachments (updated) Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Updated Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Thanks, Jenna Huston
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/ --- (Updated Oct. 14, 2014, 8:27 p.m.) Review request for accumulo. Bugs: ACCUMULO-3181 https://issues.apache.org/jira/browse/ACCUMULO-3181 Repository: accumulo Description --- Delayed adding paths to volume options until after a volume is chosen. Diffs (updated) - server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java c87074b server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 5cbffc3 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java f978439 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java 2f04922 server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 5b64053 server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 2bd0b47 Diff: https://reviews.apache.org/r/26514/diff/ Testing --- Ran existing VolumeIT. Thanks, Jenna Huston
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
> On Oct. 20, 2014, 4:14 p.m., kturner wrote: > > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java, > > line 83 > > <https://reviews.apache.org/r/26514/diff/2/?file=721053#file721053line83> > > > > this was a call to getTemporaryDirs(), not getTablesDirs(). Good catch. Couldn't find a predefined constant for "/temp/". - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/#review57343 ------- On Oct. 20, 2014, 4:59 p.m., Jenna Huston wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26514/ > --- > > (Updated Oct. 20, 2014, 4:59 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3181 > https://issues.apache.org/jira/browse/ACCUMULO-3181 > > > Repository: accumulo > > > Description > --- > > Delayed adding paths to volume options until after a volume is chosen. > > > Diffs > - > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > c87074b > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > 5cbffc3 > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java > 0f7ac22 > > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > f978439 > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > b8e7113 > server/master/src/main/java/org/apache/accumulo/master/Master.java 2f04922 > > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java > 0a3d1d0 > > server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java > 5b64053 > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > 2bd0b47 > > Diff: https://reviews.apache.org/r/26514/diff/ > > > Testing > --- > > Ran existing VolumeIT. > > > Thanks, > > Jenna Huston > >
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/ --- (Updated Oct. 20, 2014, 4:59 p.m.) Review request for accumulo. Bugs: ACCUMULO-3181 https://issues.apache.org/jira/browse/ACCUMULO-3181 Repository: accumulo Description --- Delayed adding paths to volume options until after a volume is chosen. Diffs (updated) - server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java c87074b server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 5cbffc3 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java f978439 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java 2f04922 server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 5b64053 server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 2bd0b47 Diff: https://reviews.apache.org/r/26514/diff/ Testing --- Ran existing VolumeIT. Thanks, Jenna Huston
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
> On Oct. 20, 2014, 4:14 p.m., kturner wrote: > > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java, > > line 83 > > <https://reviews.apache.org/r/26514/diff/2/?file=721053#file721053line83> > > > > this was a call to getTemporaryDirs(), not getTablesDirs(). > > Jenna Huston wrote: > Good catch. Couldn't find a predefined constant for "/temp/". ops "/tmp/" - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/#review57343 ------- On Oct. 20, 2014, 4:59 p.m., Jenna Huston wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26514/ > --- > > (Updated Oct. 20, 2014, 4:59 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3181 > https://issues.apache.org/jira/browse/ACCUMULO-3181 > > > Repository: accumulo > > > Description > --- > > Delayed adding paths to volume options until after a volume is chosen. > > > Diffs > - > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > c87074b > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > 5cbffc3 > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java > 0f7ac22 > > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > f978439 > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > b8e7113 > server/master/src/main/java/org/apache/accumulo/master/Master.java 2f04922 > > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java > 0a3d1d0 > > server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java > 5b64053 > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > 2bd0b47 > > Diff: https://reviews.apache.org/r/26514/diff/ > > > Testing > --- > > Ran existing VolumeIT. > > > Thanks, > > Jenna Huston > >
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
> On Oct. 21, 2014, 4:27 p.m., kturner wrote: > > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java, > > line 82 > > <https://reviews.apache.org/r/26514/diff/3/?file=725859#file725859line82> > > > > this seems like the only code that called > > ServerConstants.getTemporaryDirs(). So I think the method can be removed > > from server constants. Not sure about the other methods in server > > constants that were being used w/ choose(), but could just try removing > > them and see if causes compile errors. I could get rid of ServerConstants.getTemporaryDirs(), but the rest of them were in use elsewhere. - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/#review57599 ------- On Oct. 20, 2014, 4:59 p.m., Jenna Huston wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26514/ > --- > > (Updated Oct. 20, 2014, 4:59 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3181 > https://issues.apache.org/jira/browse/ACCUMULO-3181 > > > Repository: accumulo > > > Description > --- > > Delayed adding paths to volume options until after a volume is chosen. > > > Diffs > - > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > c87074b > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > 5cbffc3 > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java > 0f7ac22 > > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > f978439 > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > b8e7113 > server/master/src/main/java/org/apache/accumulo/master/Master.java 2f04922 > > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java > 0a3d1d0 > > server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java > 5b64053 > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > 2bd0b47 > > Diff: https://reviews.apache.org/r/26514/diff/ > > > Testing > --- > > Ran existing VolumeIT. > > > Thanks, > > Jenna Huston > >
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/ --- (Updated Oct. 21, 2014, 6:12 p.m.) Review request for accumulo. Bugs: ACCUMULO-3181 https://issues.apache.org/jira/browse/ACCUMULO-3181 Repository: accumulo Description --- Delayed adding paths to volume options until after a volume is chosen. Diffs (updated) - server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java c87074b server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java fcecc37 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java f908d25 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 5b64053 server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 2bd0b47 Diff: https://reviews.apache.org/r/26514/diff/ Testing --- Ran existing VolumeIT. Thanks, Jenna Huston
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/ --- (Updated Oct. 21, 2014, 6:25 p.m.) Review request for accumulo. Changes --- Forgot to add in the change on the last update Bugs: ACCUMULO-3181 https://issues.apache.org/jira/browse/ACCUMULO-3181 Repository: accumulo Description --- Delayed adding paths to volume options until after a volume is chosen. Diffs (updated) - server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 10a864c server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java c87074b server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java fcecc37 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java f908d25 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 5b64053 server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 2bd0b47 Diff: https://reviews.apache.org/r/26514/diff/ Testing --- Ran existing VolumeIT. Thanks, Jenna Huston
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
> On Oct. 22, 2014, 5:20 a.m., Sean Busbey wrote: > > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java, > > lines 308-309 > > <https://reviews.apache.org/r/26514/diff/5/?file=727602#file727602line308> > > > > can these two really be on different volumes? > > > > if not, we shouldn't rely on the volumemanager to be coincidentally > > return the same twice. I think this is ok since it was like that before I changed anything, but I don't know for sure. > On Oct. 22, 2014, 5:20 a.m., Sean Busbey wrote: > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java, > > lines 242-243 > > <https://reviews.apache.org/r/26514/diff/5/?file=727601#file727601line242> > > > > please add javadoc for what the purpose of this method and what the > > returned value is supposed to represent. I only made one small change to this method, so I don't know enough about what it does to write an informative javadoc. - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/#review57745 --- On Oct. 21, 2014, 6:25 p.m., Jenna Huston wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26514/ > --- > > (Updated Oct. 21, 2014, 6:25 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3181 > https://issues.apache.org/jira/browse/ACCUMULO-3181 > > > Repository: accumulo > > > Description > --- > > Delayed adding paths to volume options until after a volume is chosen. > > > Diffs > - > > server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java > 10a864c > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > c87074b > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > fcecc37 > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java > 0f7ac22 > > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > f908d25 > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > b8e7113 > server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc > > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java > 0a3d1d0 > > server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java > 5b64053 > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > 2bd0b47 > > Diff: https://reviews.apache.org/r/26514/diff/ > > > Testing > --- > > Ran existing VolumeIT. > > > Thanks, > > Jenna Huston > >
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
> On Oct. 22, 2014, 5:20 a.m., Sean Busbey wrote: > > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java, > > lines 80-83 > > <https://reviews.apache.org/r/26514/diff/5/?file=727603#file727603line80> > > > > Please file a follow-on ticket to add docs to the user manual section > > on advanced HDFS recovery to cover our use of this directory. > > > > * that it temporary directory exists > > * how to check how much space it is using > > * what files might stick around in the case of failures and the > > relative safety of deleting them Can you open your own ticket so that what you want done comes across the way that you intend. This patch does not introduce the issue you are refering to. - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/#review57745 ------- On Oct. 21, 2014, 6:25 p.m., Jenna Huston wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26514/ > --- > > (Updated Oct. 21, 2014, 6:25 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3181 > https://issues.apache.org/jira/browse/ACCUMULO-3181 > > > Repository: accumulo > > > Description > --- > > Delayed adding paths to volume options until after a volume is chosen. > > > Diffs > - > > server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java > 10a864c > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > c87074b > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > fcecc37 > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java > 0f7ac22 > > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > f908d25 > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > b8e7113 > server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc > > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java > 0a3d1d0 > > server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java > 5b64053 > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > 2bd0b47 > > Diff: https://reviews.apache.org/r/26514/diff/ > > > Testing > --- > > Ran existing VolumeIT. > > > Thanks, > > Jenna Huston > >
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/ --- (Updated Oct. 23, 2014, 5:14 p.m.) Review request for accumulo. Changes --- Made suggested changes and ran IT's Bugs: ACCUMULO-3181 https://issues.apache.org/jira/browse/ACCUMULO-3181 Repository: accumulo Description --- Delayed adding paths to volume options until after a volume is chosen. Diffs (updated) - server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 10a864c server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java c87074b server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java fcecc37 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java f908d25 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 5b64053 server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 2bd0b47 Diff: https://reviews.apache.org/r/26514/diff/ Testing --- Ran existing VolumeIT. Thanks, Jenna Huston
Review Request 27096: ACCUMULO-3178 Create example preferred volumes chooser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27096/ --- Review request for accumulo. Bugs: ACCUMULO-3178 https://issues.apache.org/jira/browse/ACCUMULO-3178 Repository: accumulo Description --- Created example preferred volumes chooser and integration test Diffs - server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java PRE-CREATION test/src/test/java/org/apache/accumulo/test/VolumeChooserIT.java PRE-CREATION Diff: https://reviews.apache.org/r/27096/diff/ Testing --- New IT Thanks, Jenna Huston
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
> On Oct. 24, 2014, 2:38 a.m., Sean Busbey wrote: > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java, > > lines 248-253 > > <https://reviews.apache.org/r/26514/diff/6/?file=729943#file729943line248> > > > > First we use ServerConstants.TABLE_DIR to validate the input and then > > we use Constants.HDFS_TABLES_DIR to set up the new location. > > > > Why the difference? > > > > It's hard for me to tell if this is expected behavior because there > > isn't a method level javadoc. I used the wrong constant. ServerConstants.TABLE_DIR and Constants.HDFS_TABLES_DIR are the same, so I just switched it. - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/#review58226 ------- On Oct. 23, 2014, 5:14 p.m., Jenna Huston wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26514/ > --- > > (Updated Oct. 23, 2014, 5:14 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3181 > https://issues.apache.org/jira/browse/ACCUMULO-3181 > > > Repository: accumulo > > > Description > --- > > Delayed adding paths to volume options until after a volume is chosen. > > > Diffs > - > > server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java > 10a864c > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > c87074b > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > fcecc37 > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java > 0f7ac22 > > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > f908d25 > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > b8e7113 > server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc > > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java > 0a3d1d0 > > server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java > 5b64053 > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > 2bd0b47 > > Diff: https://reviews.apache.org/r/26514/diff/ > > > Testing > --- > > Ran existing VolumeIT. > > > Thanks, > > Jenna Huston > >
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/ --- (Updated Oct. 24, 2014, 8:02 p.m.) Review request for accumulo. Bugs: ACCUMULO-3181 https://issues.apache.org/jira/browse/ACCUMULO-3181 Repository: accumulo Description --- Delayed adding paths to volume options until after a volume is chosen. Diffs (updated) - server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 10a864c server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java c87074b server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java fcecc37 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java f908d25 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 5b64053 server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 2bd0b47 Diff: https://reviews.apache.org/r/26514/diff/ Testing --- Ran existing VolumeIT. Thanks, Jenna Huston
Re: Review Request 27096: ACCUMULO-3178 Create example preferred volumes chooser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27096/ --- (Updated Oct. 27, 2014, 8:05 p.m.) Review request for accumulo. Changes --- Changed patch to not depend on ACCUMULO-3176. Used namespace properties instead. Bugs: ACCUMULO-3178 https://issues.apache.org/jira/browse/ACCUMULO-3178 Repository: accumulo Description --- Created example preferred volumes chooser and integration test Diffs (updated) - server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java PRE-CREATION test/src/test/java/org/apache/accumulo/test/VolumeChooserIT.java PRE-CREATION Diff: https://reviews.apache.org/r/27096/diff/ Testing --- New IT Thanks, Jenna Huston
Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26507/ --- (Updated Oct. 27, 2014, 8:13 p.m.) Review request for accumulo. Changes --- Changed code to not depend on ACCUMULO-3176. Used namespace properties instead. Bugs: ACCUMULO-3177 and ACCUMULO-3178 https://issues.apache.org/jira/browse/ACCUMULO-3177 https://issues.apache.org/jira/browse/ACCUMULO-3178 Repository: accumulo Description --- Added a per table volume chooser that allows tables to be given a specific volume chooser. The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table. When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java e4a42dc server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 5f34279 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4 server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 44ca898 server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 Diff: https://reviews.apache.org/r/26507/diff/ Testing --- New IT in the patch for ACCUMULO-3178. Could not test ACCUMULO-3177 without an example chooser. File Attachments Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Updated Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Thanks, Jenna Huston
Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26507/ --- (Updated Oct. 27, 2014, 8:15 p.m.) Review request for accumulo. Bugs: ACCUMULO-3177 https://issues.apache.org/jira/browse/ACCUMULO-3177 Repository: accumulo Description --- Added a per table volume chooser that allows tables to be given a specific volume chooser. The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table. When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser. Diffs - core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java e4a42dc server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 5f34279 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4 server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 44ca898 server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 Diff: https://reviews.apache.org/r/26507/diff/ Testing --- New IT in the patch for ACCUMULO-3178. Could not test ACCUMULO-3177 without an example chooser. File Attachments Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Updated Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Thanks, Jenna Huston
Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26507/ --- (Updated Oct. 28, 2014, 12:48 p.m.) Review request for accumulo. Bugs: ACCUMULO-3177 https://issues.apache.org/jira/browse/ACCUMULO-3177 Repository: accumulo Description --- Added a per table volume chooser that allows tables to be given a specific volume chooser. The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table. When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java e4a42dc server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 5f34279 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4 server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 44ca898 server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 Diff: https://reviews.apache.org/r/26507/diff/ Testing --- New IT in the patch for ACCUMULO-3178. Could not test ACCUMULO-3177 without an example chooser. File Attachments Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Updated Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Thanks, Jenna Huston
Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
> On Oct. 28, 2014, 12:18 p.m., Sean Busbey wrote: > > Ship It! > > Sean Busbey wrote: > Please attach the final version of the patch to the jira ticket so it can > be applied. > > Thanks Jenna! Just attached it. - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/#review58788 --- On Oct. 24, 2014, 8:02 p.m., Jenna Huston wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26514/ > --- > > (Updated Oct. 24, 2014, 8:02 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3181 > https://issues.apache.org/jira/browse/ACCUMULO-3181 > > > Repository: accumulo > > > Description > --- > > Delayed adding paths to volume options until after a volume is chosen. > > > Diffs > - > > server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java > 10a864c > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > c87074b > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java > fcecc37 > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java > 0f7ac22 > > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java > f908d25 > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > b8e7113 > server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc > > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java > 0a3d1d0 > > server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java > 5b64053 > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java > 2bd0b47 > > Diff: https://reviews.apache.org/r/26514/diff/ > > > Testing > --- > > Ran existing VolumeIT. > > > Thanks, > > Jenna Huston > >
Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26507/ --- (Updated Nov. 26, 2014, 2:48 p.m.) Review request for accumulo. Changes --- Rebased onto the most current form of master. Bugs: ACCUMULO-3177 https://issues.apache.org/jira/browse/ACCUMULO-3177 Repository: accumulo Description --- Added a per table volume chooser that allows tables to be given a specific volume chooser. The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table. When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/conf/Property.java 1195668 server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 37d5088 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java baad742 server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java a15e05e server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java aa37e35 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 97b8cff server/base/src/main/java/org/apache/accumulo/server/util/RandomizeVolumes.java 002659d server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java 2c9fe9c server/master/src/main/java/org/apache/accumulo/master/Master.java 93691fb server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java f5ed941 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 1e4d40e server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 35067ce server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java b7d5b0e server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 test/src/main/java/org/apache/accumulo/test/FairVolumeChooser.java 9eb0c84 Diff: https://reviews.apache.org/r/26507/diff/ Testing --- New IT in the patch for ACCUMULO-3178. Could not test ACCUMULO-3177 without an example chooser. File Attachments Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Updated Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Thanks, Jenna Huston
Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26507/ --- (Updated Nov. 26, 2014, 3:39 p.m.) Review request for accumulo. Changes --- Small change to PerTableVolumeChooser Bugs: ACCUMULO-3177 https://issues.apache.org/jira/browse/ACCUMULO-3177 Repository: accumulo Description --- Added a per table volume chooser that allows tables to be given a specific volume chooser. The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table. When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/conf/Property.java 1195668 server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 37d5088 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java baad742 server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java a15e05e server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java aa37e35 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 97b8cff server/base/src/main/java/org/apache/accumulo/server/util/RandomizeVolumes.java 002659d server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java 2c9fe9c server/master/src/main/java/org/apache/accumulo/master/Master.java 93691fb server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java f5ed941 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 1e4d40e server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 35067ce server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java b7d5b0e server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 test/src/main/java/org/apache/accumulo/test/FairVolumeChooser.java 9eb0c84 Diff: https://reviews.apache.org/r/26507/diff/ Testing --- New IT in the patch for ACCUMULO-3178. Could not test ACCUMULO-3177 without an example chooser. File Attachments Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Updated Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Thanks, Jenna Huston
Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26507/ --- (Updated Dec. 4, 2014, 9:54 p.m.) Review request for accumulo. Changes --- Squashed in feedback from Christopher. Bugs: ACCUMULO-3177 https://issues.apache.org/jira/browse/ACCUMULO-3177 Repository: accumulo Description --- Added a per table volume chooser that allows tables to be given a specific volume chooser. The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table. When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/conf/Property.java c2c3587 server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 37d5088 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 6ebbe1e server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 670c541 server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java aa37e35 server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java dd3355a server/base/src/main/java/org/apache/accumulo/server/util/RandomizeVolumes.java 82cc855 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java 2c9fe9c server/master/src/main/java/org/apache/accumulo/master/Master.java d5d5145 server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 3d39891 server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 247645b server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 26a6928 server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java b7d5b0e server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 test/src/main/java/org/apache/accumulo/test/FairVolumeChooser.java 9eb0c84 Diff: https://reviews.apache.org/r/26507/diff/ Testing --- New IT in the patch for ACCUMULO-3178. Could not test ACCUMULO-3177 without an example chooser. File Attachments Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Updated Diff for 3178 https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch Thanks, Jenna Huston
Re: Review Request 27096: ACCUMULO-3178 Create example preferred volumes chooser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27096/ --- (Updated Dec. 4, 2014, 10:13 p.m.) Review request for accumulo. Changes --- Squashed in feedback from Christopher Bugs: ACCUMULO-3178 https://issues.apache.org/jira/browse/ACCUMULO-3178 Repository: accumulo Description --- Created example preferred volumes chooser and integration test Diffs (updated) - server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java PRE-CREATION server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 test/src/test/java/org/apache/accumulo/test/VolumeChooserIT.java PRE-CREATION Diff: https://reviews.apache.org/r/27096/diff/ Testing --- New IT Thanks, Jenna Huston
Re: Review Request 28873: ACCUMULO-3393 Follow-on work for per-table volume chooser.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28873/#review64576 --- server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java <https://reviews.apache.org/r/28873/#comment107345> I think that optimization is good, but this was intended to be an example of how users could use a PerTableVolumeChooser. Because of this I think that the simplier version is better for easy reading and using it as a guide for their own choosers. - Jenna Huston On Dec. 10, 2014, 2:58 p.m., Sean Busbey wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28873/ > --- > > (Updated Dec. 10, 2014, 2:58 p.m.) > > > Review request for accumulo and Jenna Huston. > > > Bugs: ACCUMULO-3393 > https://issues.apache.org/jira/browse/ACCUMULO-3393 > > > Repository: accumulo > > > Description > --- > > ACCUMULO-3393 Follow-on work for per-table volume chooser. > > Still has TODOs for additional tickets I need to file. I'll update the review > to remove once I have them all filed. I think everything marked TODO can wait > for a later ticket. Please comment on relevant section if you think something > needs to be done now. > > * docs clean up + code guideline compliance. > * ensure RandomVolumeChoosers are independent when used per-table. > * make sure that per-table choosers can keep state the way that global > choosers can > * make sure that a chooser can only pick from the options it is presented. > * avoid object creation in critical path for Tablet.split. > > > Diffs > - > > core/src/main/java/org/apache/accumulo/core/conf/Property.java > 4c2d0b41b3bce32449861da3ac42fa27deb2b182 > pom.xml 31601a1bf84e19b861e4f48b50824eeb77987b52 > server/base/pom.xml c21a168dec2092692f1ee6877c4703ee2d3e3977 > > server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java > 7a825c796eb5a25de8c748e2aba642f483697b9a > > server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java > 7ed7bba809a4e5e4b2d472c3327b15adb37251a7 > > server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java > f2eb2113cb848ed58ac5f41573c6ff2cde9b0a77 > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java > f523057b11a2dc42e82010675bb1ac8e3802f96d > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java > 890651e92f4c34514cb839b7b9ee9d23ad55070a > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java > dc1be739b634d91992894f8f27c2d9c184bd98cd > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > 877d01c2233cca086c1ac1539eb81cc282a7ceb4 > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > c0e1a9b991d61a4dbb127c74ae297f171434e7d5 > > server/base/src/test/java/org/apache/accumulo/server/fs/VolumeManagerImplTest.java > 582822a8ccbc398925a2184eed0b9d7fa853f9b4 > > Diff: https://reviews.apache.org/r/28873/diff/ > > > Testing > --- > > Ran through VolumeManagerImplTest and VolumeChooserIT > > > Thanks, > > Sean Busbey > >
Re: Review Request 28873: ACCUMULO-3393 Follow-on work for per-table volume chooser.
> On Dec. 10, 2014, 7:54 a.m., Christopher Tubbs wrote: > > server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java, > > line 99 > > <https://reviews.apache.org/r/28873/diff/1/?file=787889#file787889line99> > > > > Do we really need an object pool for a map which holds 0 or 1 element > > for the duration of a single, infrequently called method? A better > > optimization for this case would be to add an optimized get(String key) > > method to AccumuloConfiguration / TableConfiguration, so we don't have to > > use a map at all. > > Sean Busbey wrote: > This code path is in the critical section of tablet splitting, the > frequency of which varies greatly based on system deployment. There's already > a TODO for doing the refactoring you mention, which will allow us to later > remove the pooling entirely. > > Josh Elser wrote: > I really don't see the creation of a new HashMap as being critical WRT > the cost of waiting for a tablet to close, performing multiple metadata table > updates and then waiting for the tablets to come back online. > > Sean Busbey wrote: > Am I correct that we currently don't have any microbenchmarks that would > tell us one way or the other? > > Josh Elser wrote: > ditto what I said down below. > > Christopher Tubbs wrote: > As far as I know, we have not done any microbenchmarks on this. Which is > why I suggested it was premature optimization. I agree that waiting for an optimized get method would be better in the long run. - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28873/#review64511 --- On Dec. 10, 2014, 2:58 p.m., Sean Busbey wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28873/ > --- > > (Updated Dec. 10, 2014, 2:58 p.m.) > > > Review request for accumulo and Jenna Huston. > > > Bugs: ACCUMULO-3393 > https://issues.apache.org/jira/browse/ACCUMULO-3393 > > > Repository: accumulo > > > Description > --- > > ACCUMULO-3393 Follow-on work for per-table volume chooser. > > Still has TODOs for additional tickets I need to file. I'll update the review > to remove once I have them all filed. I think everything marked TODO can wait > for a later ticket. Please comment on relevant section if you think something > needs to be done now. > > * docs clean up + code guideline compliance. > * ensure RandomVolumeChoosers are independent when used per-table. > * make sure that per-table choosers can keep state the way that global > choosers can > * make sure that a chooser can only pick from the options it is presented. > * avoid object creation in critical path for Tablet.split. > > > Diffs > - > > core/src/main/java/org/apache/accumulo/core/conf/Property.java > 4c2d0b41b3bce32449861da3ac42fa27deb2b182 > pom.xml 31601a1bf84e19b861e4f48b50824eeb77987b52 > server/base/pom.xml c21a168dec2092692f1ee6877c4703ee2d3e3977 > > server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java > 7a825c796eb5a25de8c748e2aba642f483697b9a > > server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java > 7ed7bba809a4e5e4b2d472c3327b15adb37251a7 > > server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java > f2eb2113cb848ed58ac5f41573c6ff2cde9b0a77 > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java > f523057b11a2dc42e82010675bb1ac8e3802f96d > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java > 890651e92f4c34514cb839b7b9ee9d23ad55070a > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java > dc1be739b634d91992894f8f27c2d9c184bd98cd > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > 877d01c2233cca086c1ac1539eb81cc282a7ceb4 > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > c0e1a9b991d61a4dbb127c74ae297f171434e7d5 > > server/base/src/test/java/org/apache/accumulo/server/fs/VolumeManagerImplTest.java > 582822a8ccbc398925a2184eed0b9d7fa853f9b4 > > Diff: https://reviews.apache.org/r/28873/diff/ > > > Testing > --- > > Ran through VolumeManagerImplTest and VolumeChooserIT > > > Thanks, > > Sean Busbey > >
Re: Review Request 28873: ACCUMULO-3393 Follow-on work for per-table volume chooser.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28873/#review64972 --- Ship it! Ship It! - Jenna Huston On Dec. 12, 2014, 4:36 p.m., Sean Busbey wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28873/ > --- > > (Updated Dec. 12, 2014, 4:36 p.m.) > > > Review request for accumulo and Jenna Huston. > > > Bugs: ACCUMULO-3393 > https://issues.apache.org/jira/browse/ACCUMULO-3393 > > > Repository: accumulo > > > Description > --- > > ACCUMULO-3393 Follow-on work for per-table volume chooser. > > Still has TODOs for additional tickets I need to file. I'll update the review > to remove once I have them all filed. I think everything marked TODO can wait > for a later ticket. Please comment on relevant section if you think something > needs to be done now. > > * docs clean up + code guideline compliance. > * ensure RandomVolumeChoosers are independent when used per-table. > * make sure that per-table choosers can keep state the way that global > choosers can > * make sure that a chooser can only pick from the options it is presented. > * reduce object creation in critical path for Tablet.split. > > > Diffs > - > > core/src/main/java/org/apache/accumulo/core/conf/Property.java > 4c2d0b41b3bce32449861da3ac42fa27deb2b182 > > server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java > 7a825c796eb5a25de8c748e2aba642f483697b9a > > server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java > 7ed7bba809a4e5e4b2d472c3327b15adb37251a7 > > server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java > f2eb2113cb848ed58ac5f41573c6ff2cde9b0a77 > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java > f523057b11a2dc42e82010675bb1ac8e3802f96d > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java > 890651e92f4c34514cb839b7b9ee9d23ad55070a > > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java > dc1be739b634d91992894f8f27c2d9c184bd98cd > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java > 877d01c2233cca086c1ac1539eb81cc282a7ceb4 > > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java > c0e1a9b991d61a4dbb127c74ae297f171434e7d5 > > server/base/src/test/java/org/apache/accumulo/server/fs/VolumeManagerImplTest.java > 582822a8ccbc398925a2184eed0b9d7fa853f9b4 > > Diff: https://reviews.apache.org/r/28873/diff/ > > > Testing > --- > > Ran through VolumeManagerImplTest and VolumeChooserIT > > > Thanks, > > Sean Busbey > >
Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- Review request for accumulo. Bugs: ACCUMULO-3420 https://issues.apache.org/jira/browse/ACCUMULO-3420 Repository: accumulo Description --- Added an option to PrintInfo to get visibility metrics. Prints the number of times a visibilty is seen in each locality group. Also shows how many blocks in the locality group have his visibiltiy. Diffs - core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java 43586dd core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 9dcb3a5 Diff: https://reviews.apache.org/r/29176/diff/ Testing --- Tested with a few RFiles that I made. Thanks, Jenna Huston
Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo
> On Dec. 18, 2014, 4:19 p.m., Josh Elser wrote: > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java, > > line 36 > > <https://reviews.apache.org/r/29176/diff/1/?file=795044#file795044line36> > > > > Why the concurrent maps? I don't see anything in these changes that > > would require it now, do you have plans for something else in the future? These keep separate metrics. One for the density of that metric in the locality group and the other for how many blocks in that locality group this visiblity is seen in. - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review65499 ------- On Dec. 17, 2014, 8:31 p.m., Jenna Huston wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29176/ > --- > > (Updated Dec. 17, 2014, 8:31 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3420 > https://issues.apache.org/jira/browse/ACCUMULO-3420 > > > Repository: accumulo > > > Description > --- > > Added an option to PrintInfo to get visibility metrics. Prints the number of > times a visibilty is seen in each locality group. Also shows how many blocks > in the locality group have his visibiltiy. > > > Diffs > - > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java > 43586dd > core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 9dcb3a5 > > Diff: https://reviews.apache.org/r/29176/diff/ > > > Testing > --- > > Tested with a few RFiles that I made. > > > Thanks, > > Jenna Huston > >
Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo
> On Dec. 18, 2014, 4:19 p.m., Josh Elser wrote: > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java, > > line 36 > > <https://reviews.apache.org/r/29176/diff/1/?file=795044#file795044line36> > > > > Why the concurrent maps? I don't see anything in these changes that > > would require it now, do you have plans for something else in the future? > > Jenna Huston wrote: > These keep separate metrics. One for the density of that metric in the > locality group and the other for how many blocks in that locality group this > visiblity is seen in. > > Josh Elser wrote: > I understand why you're using a map, I'm confused about why you need a > concurrent datastructure. This appears to be single-threaded. The AtomicLongMap made it easier to increment counters of visibilities. With a regular map you have to delete what is there and then put in a new entry with the incremented count. - Jenna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review65499 ------- On Dec. 17, 2014, 8:31 p.m., Jenna Huston wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29176/ > --- > > (Updated Dec. 17, 2014, 8:31 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3420 > https://issues.apache.org/jira/browse/ACCUMULO-3420 > > > Repository: accumulo > > > Description > --- > > Added an option to PrintInfo to get visibility metrics. Prints the number of > times a visibilty is seen in each locality group. Also shows how many blocks > in the locality group have his visibiltiy. > > > Diffs > - > > core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java > PRE-CREATION > core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java > 43586dd > core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 9dcb3a5 > > Diff: https://reviews.apache.org/r/29176/diff/ > > > Testing > --- > > Tested with a few RFiles that I made. > > > Thanks, > > Jenna Huston > >
Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Dec. 18, 2014, 9:37 p.m.) Review request for accumulo. Changes --- Still working on a test, but wanted to get these changes out. Bugs: ACCUMULO-3420 https://issues.apache.org/jira/browse/ACCUMULO-3420 Repository: accumulo Description --- Added an option to PrintInfo to get visibility metrics. Prints the number of times a visibilty is seen in each locality group. Also shows how many blocks in the locality group have his visibiltiy. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java 43586dd core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 9dcb3a5 core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java PRE-CREATION Diff: https://reviews.apache.org/r/29176/diff/ Testing --- Tested with a few RFiles that I made. Thanks, Jenna Huston
Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Dec. 22, 2014, 3:22 p.m.) Review request for accumulo. Changes --- Added test Bugs: ACCUMULO-3420 https://issues.apache.org/jira/browse/ACCUMULO-3420 Repository: accumulo Description --- Added an option to PrintInfo to get visibility metrics. Prints the number of times a visibilty is seen in each locality group. Also shows how many blocks in the locality group have his visibiltiy. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java 43586dd core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 9dcb3a5 core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java PRE-CREATION core/src/test/java/org/apache/accumulo/core/file/rfile/RFileMetricsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/29176/diff/ Testing --- Tested with a few RFiles that I made. Thanks, Jenna Huston
Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Dec. 22, 2014, 3:25 p.m.) Review request for accumulo. Changes --- Fixed whitespace issues on test Bugs: ACCUMULO-3420 https://issues.apache.org/jira/browse/ACCUMULO-3420 Repository: accumulo Description --- Added an option to PrintInfo to get visibility metrics. Prints the number of times a visibilty is seen in each locality group. Also shows how many blocks in the locality group have his visibiltiy. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java 43586dd core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 9dcb3a5 core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java PRE-CREATION core/src/test/java/org/apache/accumulo/core/file/rfile/RFileMetricsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/29176/diff/ Testing --- Tested with a few RFiles that I made. Thanks, Jenna Huston
Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Jan. 8, 2015, 9:24 p.m.) Review request for accumulo. Changes --- Incorporated comments from Keith and Christopher Bugs: ACCUMULO-3420 https://issues.apache.org/jira/browse/ACCUMULO-3420 Repository: accumulo Description --- Added an option to PrintInfo to get visibility metrics. Prints the number of times a visibilty is seen in each locality group. Also shows how many blocks in the locality group have his visibiltiy. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java 43586dd core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 9dcb3a5 core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java PRE-CREATION core/src/test/java/org/apache/accumulo/core/file/rfile/RFileMetricsTest.java PRE-CREATION core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java 969b179 Diff: https://reviews.apache.org/r/29176/diff/ Testing --- Tested with a few RFiles that I made. Thanks, Jenna Huston
Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Jan. 9, 2015, 4:19 p.m.) Review request for accumulo. Changes --- Fixed a few javadoc problems. Bugs: ACCUMULO-3420 https://issues.apache.org/jira/browse/ACCUMULO-3420 Repository: accumulo Description --- Added an option to PrintInfo to get visibility metrics. Prints the number of times a visibilty is seen in each locality group. Also shows how many blocks in the locality group have his visibiltiy. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java f29efcc core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 0b464d8 core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java PRE-CREATION core/src/test/java/org/apache/accumulo/core/file/rfile/RFileMetricsTest.java PRE-CREATION core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java 1a83f33 Diff: https://reviews.apache.org/r/29176/diff/ Testing --- Tested with a few RFiles that I made. Thanks, Jenna Huston
Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Jan. 9, 2015, 9:39 p.m.) Review request for accumulo. Changes --- Fixed items from Christopher's feedback Bugs: ACCUMULO-3420 https://issues.apache.org/jira/browse/ACCUMULO-3420 Repository: accumulo Description --- Added an option to PrintInfo to get visibility metrics. Prints the number of times a visibilty is seen in each locality group. Also shows how many blocks in the locality group have his visibiltiy. Diffs (updated) - core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java f29efcc core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 0b464d8 core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/file/rfile/VisibilityMetric.java PRE-CREATION core/src/test/java/org/apache/accumulo/core/file/rfile/RFileMetricsTest.java PRE-CREATION core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java 1a83f33 Diff: https://reviews.apache.org/r/29176/diff/ Testing --- Tested with a few RFiles that I made. Thanks, Jenna Huston
