[GitHub] activemq-6 pull request: Few changes around docs and dependencies
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-6/pull/183 Few changes around docs and dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-6 master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-6/pull/183.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #183 commit 7ce776776a3492bd34eefe29c48da3fe7e2645c1 Author: Clebert Suconic Date: 2015-03-13T22:37:23Z Removing extra dependencies brought by transitivity on rest commit f47064c426550998099c087164bf315ce235ec55 Author: Clebert Suconic Date: 2015-03-13T22:37:28Z A Few fixes around docs using GMF (Github Markdown Flavored) on tables I also did some review of the huge table we have, removed a few columns such as the datatype and embedded the default on the description. Just trying to make easier to render and read --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (AMQ-5646) AMQP: Second receiver attaching to queue hangs
[ https://issues.apache.org/jira/browse/AMQ-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Bish updated AMQ-5646: -- Fix Version/s: 5.12.0 > AMQP: Second receiver attaching to queue hangs > -- > > Key: AMQ-5646 > URL: https://issues.apache.org/jira/browse/AMQ-5646 > Project: ActiveMQ > Issue Type: Bug > Components: AMQP >Affects Versions: 5.11.0 > Environment: ActiveMQ 5.11.1 release on Fedora 19 > Test client: http://amqpnetlite.codeplex.com/ > LinkTests.cs > http://amqpnetlite.codeplex.com/SourceControl/latest#test/Test.Amqp.NetMF/LinkTests.cs >Reporter: Chuck Rolke >Assignee: Timothy Bish > Fix For: 5.12.0 > > Attachments: amq-5.11-second-receiver-hangs.html, > qpidd-second-receiver-works.html > > > The last test in the file, TestMethod_AdvancedLinkFlowControl() hangs. The > test: > * opens a connection and session > * open a sender and send a batch of messages > * open a receiver with credit of 2 and no automatic credit renewal > * receive two messages, accept them > * open a second receiver with credit of 2 and no automatic credit renewal > * receive a two messages > The broker does not send the messages to the second receiver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (AMQ-5646) AMQP: Second receiver attaching to queue hangs
[ https://issues.apache.org/jira/browse/AMQ-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Bish resolved AMQ-5646. --- Resolution: Fixed Fixed by changes in AMQ-5661 > AMQP: Second receiver attaching to queue hangs > -- > > Key: AMQ-5646 > URL: https://issues.apache.org/jira/browse/AMQ-5646 > Project: ActiveMQ > Issue Type: Bug > Components: AMQP >Affects Versions: 5.11.0 > Environment: ActiveMQ 5.11.1 release on Fedora 19 > Test client: http://amqpnetlite.codeplex.com/ > LinkTests.cs > http://amqpnetlite.codeplex.com/SourceControl/latest#test/Test.Amqp.NetMF/LinkTests.cs >Reporter: Chuck Rolke >Assignee: Timothy Bish > Attachments: amq-5.11-second-receiver-hangs.html, > qpidd-second-receiver-works.html > > > The last test in the file, TestMethod_AdvancedLinkFlowControl() hangs. The > test: > * opens a connection and session > * open a sender and send a batch of messages > * open a receiver with credit of 2 and no automatic credit renewal > * receive two messages, accept them > * open a second receiver with credit of 2 and no automatic credit renewal > * receive a two messages > The broker does not send the messages to the second receiver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (AMQ-5661) AMQP: Honor receiver flow as the true prefetch value on a link.
[ https://issues.apache.org/jira/browse/AMQ-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Bish resolved AMQ-5661. --- Resolution: Fixed Link credit now configures subscription prefetch. Old prefetch value on the AMQP transport connector is now unused and deprecated and will be removed in a future release. > AMQP: Honor receiver flow as the true prefetch value on a link. > --- > > Key: AMQ-5661 > URL: https://issues.apache.org/jira/browse/AMQ-5661 > Project: ActiveMQ > Issue Type: Sub-task > Components: AMQP >Affects Versions: 5.11.0, 5.11.1 >Reporter: Timothy Bish >Assignee: Timothy Bish > Fix For: 5.12.0 > > > We currently don't honor the flow values sent from a receiver to indicate how > many messages our sender can produce (prefetch) and always maintain a fixed > value based either on a transport configuration option or the first non-zero > flow. This is however not in keeping with how the credit model is expected > to work in AMQP and leads to some issues with the brokers sender accepting > messages and buffering them until the receiver sends a flow thereby > preventing those messages from being dispatched to another receiver > subscribed to the same destination. > We need to honor the link credit and only dispatch when the receiver > indicates it is willing to take messages by sending more link credit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: ActiveMQ DSLs
Unfortunately your sample didn't show up on the mailing list…. I had to resort to looking at nabble. I think your example is too simple to see the benefits of a fluent api. For instance, you haven't added an object that itself needs configuration to a collection (e.g. transport connector). My experience is that they make configuring anything reasonably complicated 10x simpler and more pleasant :-) That being said….. I'm not familiar with the ".end()" idiom. Is this common? "standard"? I'd think it would be less confusing if they were .endTransportConnectors() etc so it was clear what you were ending. thanks david jencks On Mar 13, 2015, at 5:32 PM, artnaseef wrote: > I see "fluent is easier" as a valid argument to maintaining the project, but > not necessarily as a reason to pull it into the ActiveMQ main code base. > > Still, I am 50/50 on this myself. I personally don't have a need for > simpler configuration of embedded brokers. Also, the syntax of fluent > builders doesn't appeal to me personally, so that makes it harder for me to > buy-in. For example: > > Seems simpler to understand than (I'm making this one up - not using the > posted language): > > With that said - I acknowledge this is my opinion and welcome some > discussion of the benefit of including the code inside of ActiveMQ itself > (beyond the well-understood "it will then be maintained with the core > code"). > > Art > > > > -- > View this message in context: > http://activemq.2283324.n4.nabble.com/ActiveMQ-DSLs-tp4693171p4693202.html > Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
[jira] [Commented] (AMQ-5661) AMQP: Honor receiver flow as the true prefetch value on a link.
[ https://issues.apache.org/jira/browse/AMQ-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361187#comment-14361187 ] Timothy Bish commented on AMQ-5661: --- Root cause for this related issue. > AMQP: Honor receiver flow as the true prefetch value on a link. > --- > > Key: AMQ-5661 > URL: https://issues.apache.org/jira/browse/AMQ-5661 > Project: ActiveMQ > Issue Type: Sub-task > Components: AMQP >Affects Versions: 5.11.0, 5.11.1 >Reporter: Timothy Bish >Assignee: Timothy Bish > Fix For: 5.12.0 > > > We currently don't honor the flow values sent from a receiver to indicate how > many messages our sender can produce (prefetch) and always maintain a fixed > value based either on a transport configuration option or the first non-zero > flow. This is however not in keeping with how the credit model is expected > to work in AMQP and leads to some issues with the brokers sender accepting > messages and buffering them until the receiver sends a flow thereby > preventing those messages from being dispatched to another receiver > subscribed to the same destination. > We need to honor the link credit and only dispatch when the receiver > indicates it is willing to take messages by sending more link credit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (AMQ-5661) AMQP: Honor receiver flow as the true prefetch value on a link.
Timothy Bish created AMQ-5661: - Summary: AMQP: Honor receiver flow as the true prefetch value on a link. Key: AMQ-5661 URL: https://issues.apache.org/jira/browse/AMQ-5661 Project: ActiveMQ Issue Type: Sub-task Components: AMQP Affects Versions: 5.11.1, 5.11.0 Reporter: Timothy Bish Assignee: Timothy Bish Fix For: 5.12.0 We currently don't honor the flow values sent from a receiver to indicate how many messages our sender can produce (prefetch) and always maintain a fixed value based either on a transport configuration option or the first non-zero flow. This is however not in keeping with how the credit model is expected to work in AMQP and leads to some issues with the brokers sender accepting messages and buffering them until the receiver sends a flow thereby preventing those messages from being dispatched to another receiver subscribed to the same destination. We need to honor the link credit and only dispatch when the receiver indicates it is willing to take messages by sending more link credit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: ActiveMQ DSLs
I see "fluent is easier" as a valid argument to maintaining the project, but not necessarily as a reason to pull it into the ActiveMQ main code base. Still, I am 50/50 on this myself. I personally don't have a need for simpler configuration of embedded brokers. Also, the syntax of fluent builders doesn't appeal to me personally, so that makes it harder for me to buy-in. For example: Seems simpler to understand than (I'm making this one up - not using the posted language): With that said - I acknowledge this is my opinion and welcome some discussion of the benefit of including the code inside of ActiveMQ itself (beyond the well-understood "it will then be maintained with the core code"). Art -- View this message in context: http://activemq.2283324.n4.nabble.com/ActiveMQ-DSLs-tp4693171p4693202.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
Re: Active MQ implemenation from multiple clients/devices
Look at JMSReplyTo - it was intended specifically for that purpose. The requestor tells the processor where it wants the response delivered. This page[1] might help [1] http://activemq.apache.org/how-should-i-implement-request-response-with-jms.html -- View this message in context: http://activemq.2283324.n4.nabble.com/Active-MQ-implemenation-from-multiple-clients-devices-tp4693149p4693200.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
[jira] [Commented] (AMQ-5660) Dequeue count for Topics does not increase for durable subscribers
[ https://issues.apache.org/jira/browse/AMQ-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361127#comment-14361127 ] Arthur Naseef commented on AMQ-5660: Because of the nature of topics (being a broadcast) dequeue count is a little tricky. For example, how many times do you count a message consumed by multiple subscribers? Once after they all have consumed it (and what if one subscriber drops before acking the message)? Once per subscriber (leading to dequeue growing faster than enqueue)? And what about counting dequeue on non-durable subscriptions? For inflight messages or only acked messages? Messages published to a Topic with no consumers? In other words, the meaning of dequeue on a Topic itself is hard to nail down, and even if it were nailed down, it would be hard to use reliably. Also keep in mind that ActiveMQ does not store messages on Topics, but instead stores them on the subscriptions. Therefore, I find the best method of watching enqueue and dequeue counts for Topics is looking at individual subscriptions. > Dequeue count for Topics does not increase for durable subscribers > -- > > Key: AMQ-5660 > URL: https://issues.apache.org/jira/browse/AMQ-5660 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.6.0 > Environment: >Reporter: Jessy > > I upgraded my ActiveMQ from 5.2.1 to 5.6.0. > I have durable topic subscribers . > I see the "subcribers" tab in activemqConsole and i find that the these > subscribers are able to consume the messages from the topic . > The "subcribers" tab shows up all the counter's correctly - the dispatched > counter equals enqueue counter and dequeue counters. > However, When i check the topic's enque and dequeue count in "Topics" tab, I > see the dequeue count is always zero and not increased ,even thought the > subcribers are reported to consume them as seen in the "subcribers" tab. > I did not face this issue with my previous version of ActiveMQ - version > 5.2.1. > Version ActiveMQ 5.2.1 works very good in showing up the correct dequeue > count for durable topic subscribers. > My subscribers are on different versions of ActiveMQ. > Please advise the steps that i need to consider get the dequeue counter match > with the enqueue counter . > I came accross exactly the same issue on Jira for version 5.8.0. -- > https://issues.apache.org/jira/browse/AMQ-4965 > If this is a bug to be fixed, please help us get a fix for this. > Thanks > Jessy -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: ActiveMQ DSLs
Speaking as a non-user of AMQ, I would say that if this fluent approach is easier to use than the existing way of configuring and starting a broker in java, then it should be added to AMQ. thanks david jencks On Mar 13, 2015, at 4:13 PM, artnaseef wrote: > I'm 50/50 on this. Like Hadrian said, it's nice syntax, but does it really > add value? I don't see anything there that cannot be done already via java > code - is that right? > > I think this is a good project to maintain, but not sure it should go into > ActiveMQ itself. > > > > -- > View this message in context: > http://activemq.2283324.n4.nabble.com/ActiveMQ-DSLs-tp4693171p4693187.html > Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
Re: ActiveMQ DSLs
I'm 50/50 on this. Like Hadrian said, it's nice syntax, but does it really add value? I don't see anything there that cannot be done already via java code - is that right? I think this is a good project to maintain, but not sure it should go into ActiveMQ itself. -- View this message in context: http://activemq.2283324.n4.nabble.com/ActiveMQ-DSLs-tp4693171p4693187.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
Re: ActiveMQ DSLs
Good job, but I don't think it's a good idea. Sure, interesting
syntactic sugar, but what problem does it solve? Who would use it? Json
or YAML would be way more interesting imho.
Hadrian
On 03/13/2015 12:13 PM, Jakub Korab wrote:
Hi All,
In working on a separate project, I found the need to instantiate
multiple different ActiveMQ configurations. Rather than writing up a lot
of different XML configs or messing around with assembling BrokerService
instances, I wrote a DSL that mimics the ActiveMQ config schema via a
directed builder pattern, much like Camel. Here's an example:
BrokerContext context = new
BrokerContext(ActiveMQBrokers.broker("embeddedBroker").useJmx(false).persistent(false)
.transportConnectors()
.transportConnector("openwire", "tcp://0.0.0.0:61616").end()
.end()
.plugins()
.simpleAuthenticationPlugin()
.users()
.authenticationUser("user").password("pass").groups("guests").end()
.end()
.end()
.end()));
context.start();
...
context.end();
Unlike Camel, the DSL itself defines a model that is used to instantiate
a BrokerService. Camel has an intermediate set of VOs
(org.apache.camel.model) between the Java DSL and the implementation. I
had a go at generating a similar model via JAXB from the ActiveMQ
schema, to abstract away the DSL/XBean config, but the generated classes
were hideous and I abandoned the approach.
I also developed a testing DSL for JUnit that allows you to spin up
these configurations, and rely on the JUnit runner to start up and shut
down the broker. The test DSL also allows for the definition of proxies
(using the ActiveMQ SocketProxy class) to easily simulate network outages.
A full writeup and source code are available at
https://github.com/jkorab/activemq-dsls
As it stands, the DSL is a work in progress that supports my own code,
but I think it would be useful as something provided by ActiveMQ itself.
I would like to contribute what I have written so far, and develop it
further (perhaps cleaning up a bunch of ActiveMQ tests to use it in an
"eating your own dogfood" way). I was initially thinking that it could
be part of activemq-broker in the src/test tree, and once it gets
fleshed out, moved to src/main. The set of config options in ActiveMQ is
huge, and retrofitting tests would be an ideal way of evolving it and
validating that everything works before making it public.
I think that this is something that would be useful, as I have seen
ActiveMQ deployments where the broker was defined in Java. This is
particularly useful where there are is a broker network with a bunch of
network connectors from a broker, each with dynamically or statically
included or excluded destinations, used in conjuction with composite
destinations to route messages in "just the right way". That sort of
thing is much better expressed in code rather than huge slabs of XML.
What do you think? Is this something that would be worthwhile to have in
ActiveMQ?
Jakub
[jira] [Resolved] (AMQ-5602) AMQP: Create simple Proton based client to be used in testing
[ https://issues.apache.org/jira/browse/AMQ-5602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Bish resolved AMQ-5602. --- Resolution: Fixed added new proton-j based test client on master along some initial work on validation tests for AMQP conformance. > AMQP: Create simple Proton based client to be used in testing > - > > Key: AMQ-5602 > URL: https://issues.apache.org/jira/browse/AMQ-5602 > Project: ActiveMQ > Issue Type: Sub-task > Components: AMQP >Affects Versions: 5.11.0, 5.11.1 >Reporter: Timothy Bish >Assignee: Timothy Bish > Fix For: 5.12.0 > > > The current AMQP implementation depends on testing using the prototype JMS > 1.0 client from QPid. This present a few difficulties when it comes to unit > testing the AMQP bits in that it is quite difficult to test the AMQP > functionality directly as the client attempts to map AMQP to JMS but that is > not the only valid type of client interaction nor is it compliant with the > developing JMS mapping work. > We should develop a thin proton wrapper client that lets us more easily > recreate various client interactions with the broker and test compliance with > AMQP 1.0 expected behaviors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: ActiveMQ DSLs
I second Tim there. Good job !
Regards
JB
On 03/13/2015 07:08 PM, Timothy Bish wrote:
On 03/13/2015 12:13 PM, Jakub Korab wrote:
Hi All,
In working on a separate project, I found the need to instantiate
multiple different ActiveMQ configurations. Rather than writing up a
lot of different XML configs or messing around with assembling
BrokerService instances, I wrote a DSL that mimics the ActiveMQ config
schema via a directed builder pattern, much like Camel. Here's an
example:
BrokerContext context = new
BrokerContext(ActiveMQBrokers.broker("embeddedBroker").useJmx(false).persistent(false)
.transportConnectors()
.transportConnector("openwire", "tcp://0.0.0.0:61616").end()
.end()
.plugins()
.simpleAuthenticationPlugin()
.users()
.authenticationUser("user").password("pass").groups("guests").end()
.end()
.end()
.end()));
context.start();
...
context.end();
Unlike Camel, the DSL itself defines a model that is used to
instantiate a BrokerService. Camel has an intermediate set of VOs
(org.apache.camel.model) between the Java DSL and the implementation.
I had a go at generating a similar model via JAXB from the ActiveMQ
schema, to abstract away the DSL/XBean config, but the generated
classes were hideous and I abandoned the approach.
I also developed a testing DSL for JUnit that allows you to spin up
these configurations, and rely on the JUnit runner to start up and
shut down the broker. The test DSL also allows for the definition of
proxies (using the ActiveMQ SocketProxy class) to easily simulate
network outages.
A full writeup and source code are available at
https://github.com/jkorab/activemq-dsls
As it stands, the DSL is a work in progress that supports my own code,
but I think it would be useful as something provided by ActiveMQ
itself. I would like to contribute what I have written so far, and
develop it further (perhaps cleaning up a bunch of ActiveMQ tests to
use it in an "eating your own dogfood" way). I was initially thinking
that it could be part of activemq-broker in the src/test tree, and
once it gets fleshed out, moved to src/main. The set of config options
in ActiveMQ is huge, and retrofitting tests would be an ideal way of
evolving it and validating that everything works before making it public.
I think that this is something that would be useful, as I have seen
ActiveMQ deployments where the broker was defined in Java. This is
particularly useful where there are is a broker network with a bunch
of network connectors from a broker, each with dynamically or
statically included or excluded destinations, used in conjuction with
composite destinations to route messages in "just the right way". That
sort of thing is much better expressed in code rather than huge slabs
of XML.
What do you think? Is this something that would be worthwhile to have
in ActiveMQ?
Jakub
Cool stuff, definitely seems like something we ought to consider adding.
--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: ActiveMQ DSLs
On 03/13/2015 12:13 PM, Jakub Korab wrote:
Hi All,
In working on a separate project, I found the need to instantiate
multiple different ActiveMQ configurations. Rather than writing up a
lot of different XML configs or messing around with assembling
BrokerService instances, I wrote a DSL that mimics the ActiveMQ config
schema via a directed builder pattern, much like Camel. Here's an
example:
BrokerContext context = new
BrokerContext(ActiveMQBrokers.broker("embeddedBroker").useJmx(false).persistent(false)
.transportConnectors()
.transportConnector("openwire", "tcp://0.0.0.0:61616").end()
.end()
.plugins()
.simpleAuthenticationPlugin()
.users()
.authenticationUser("user").password("pass").groups("guests").end()
.end()
.end()
.end()));
context.start();
...
context.end();
Unlike Camel, the DSL itself defines a model that is used to
instantiate a BrokerService. Camel has an intermediate set of VOs
(org.apache.camel.model) between the Java DSL and the implementation.
I had a go at generating a similar model via JAXB from the ActiveMQ
schema, to abstract away the DSL/XBean config, but the generated
classes were hideous and I abandoned the approach.
I also developed a testing DSL for JUnit that allows you to spin up
these configurations, and rely on the JUnit runner to start up and
shut down the broker. The test DSL also allows for the definition of
proxies (using the ActiveMQ SocketProxy class) to easily simulate
network outages.
A full writeup and source code are available at
https://github.com/jkorab/activemq-dsls
As it stands, the DSL is a work in progress that supports my own code,
but I think it would be useful as something provided by ActiveMQ
itself. I would like to contribute what I have written so far, and
develop it further (perhaps cleaning up a bunch of ActiveMQ tests to
use it in an "eating your own dogfood" way). I was initially thinking
that it could be part of activemq-broker in the src/test tree, and
once it gets fleshed out, moved to src/main. The set of config options
in ActiveMQ is huge, and retrofitting tests would be an ideal way of
evolving it and validating that everything works before making it public.
I think that this is something that would be useful, as I have seen
ActiveMQ deployments where the broker was defined in Java. This is
particularly useful where there are is a broker network with a bunch
of network connectors from a broker, each with dynamically or
statically included or excluded destinations, used in conjuction with
composite destinations to route messages in "just the right way". That
sort of thing is much better expressed in code rather than huge slabs
of XML.
What do you think? Is this something that would be worthwhile to have
in ActiveMQ?
Jakub
Cool stuff, definitely seems like something we ought to consider adding.
--
Tim Bish
Sr Software Engineer | RedHat Inc.
tim.b...@redhat.com | www.redhat.com
skype: tabish121 | twitter: @tabish121
blog: http://timbish.blogspot.com/
[jira] [Commented] (AMQ-5026) Replicated LevelDB Store getting EOF exception
[ https://issues.apache.org/jira/browse/AMQ-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360786#comment-14360786 ] gbsnaker commented on AMQ-5026: --- I hava the same problem in my clusters. do you resove this problem? > Replicated LevelDB Store getting EOF exception > -- > > Key: AMQ-5026 > URL: https://issues.apache.org/jira/browse/AMQ-5026 > Project: ActiveMQ > Issue Type: Bug > Components: activemq-leveldb-store >Affects Versions: 5.10.0 >Reporter: kal patel > > 3 brokers setup for ReplicatedLevelDB master/slave conf. > running producer and slow consumer and doing failover by stopping master > broker. > After few failovers, the leveldb throws EOF exception while reading record > from the store. > using the latest source code from activemq 5.10 branch. > The file that has the issue: > [root@vmx0568 data]# ls -l /solidstate/ldbkp/1f4022e4.log > -rw-r--r--. 1 root root 91500224 Jan 17 14:44 > /solidstate/ldbkp/1f4022e4.log > [root@vmx0568 data]# > Client | main > 2014-01-17 14:44:19,118 | INFO | locator read: DataLocator(24b41aac, 2283) | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,118 | INFO | Seq read: 260217 | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,118 | INFO | locator read: DataLocator(24b423ee, 2283) | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,118 | INFO | Seq read: 260218 | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,118 | INFO | locator read: DataLocator(24b42d02, 2283) | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,118 | INFO | Seq read: 260219 | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,118 | INFO | locator read: DataLocator(24b43628, 2283) | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,118 | INFO | Seq read: 260220 | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,118 | INFO | locator read: DataLocator(24b43f6a, 2283) | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,118 | INFO | Seq read: 260221 | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,118 | INFO | locator read: DataLocator(24b4487e, 2283) | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,118 | INFO | Seq read: 260222 | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,118 | INFO | locator read: DataLocator(24b451a4, 2283) | > org.apache.activemq.leveldb.LevelDBClient | main > 2014-01-17 14:44:19,124 | INFO | No IOExceptionHandler registered, ignoring > IO exception | org.apache.activemq.broker.BrokerService | LevelDB IOException > handler. > java.io.EOFException: File '/solidstate/ldbkp/1f4022e4.log' offset: > 91500234 > at > org.apache.activemq.leveldb.RecordLog$LogReader.read(RecordLog.scala:299) > at > org.apache.activemq.leveldb.RecordLog$$anonfun$read$2.apply(RecordLog.scala:564) > > at > org.apache.activemq.leveldb.RecordLog$$anonfun$read$2.apply(RecordLog.scala:564) > > at > org.apache.activemq.leveldb.RecordLog.get_reader(RecordLog.scala:554) > at org.apache.activemq.leveldb.RecordLog.read(RecordLog.scala:564) > at > org.apache.activemq.leveldb.LevelDBClient.getMessage(LevelDBClient.scala:1318) > > at > org.apache.activemq.leveldb.LevelDBClient$$anonfun$queueCursor$1.apply(LevelDBClient.scala:1257) > > at > org.apache.activemq.leveldb.LevelDBClient$$anonfun$queueCursor$1.apply(LevelDBClient.scala:1252) > > at > org.apache.activemq.leveldb.LevelDBClient$$anonfun$collectionCursor$1$$anonfun$apply$mcV$sp$12.apply(LevelDBClient.scala:1342) > > at > org.apache.activemq.leveldb.LevelDBClient$$anonfun$collectionCursor$1$$anonfun$apply$mcV$sp$12.apply(LevelDBClient.scala:1341) > > at > org.apache.activemq.leveldb.LevelDBClient$RichDB.check$4(LevelDBClient.scala:323) > > at > org.apache.activemq.leveldb.LevelDBClient$RichDB.cursorRange(LevelDBClient.scala:325) > > at > org.apache.activemq.leveldb.LevelDBClient$$anonfun$collectionCursor$1.apply$mcV$sp(LevelDBClient.scala:1341) > > at > org.apache.activemq.leveldb.LevelDBClient$$anonfun$collectionCursor$1.apply(LevelDBClient.scala:1341) > > at > org.apache.activemq.leveldb.LevelDBClient$$anonfun$collectionCursor$1.apply(LevelDBClient.scala:1341) > > at > org.apache.activemq.leveldb.LevelDBClient.usingIndex(LevelDBClient.scala:1019) > > at > org.apache.activemq.leveldb.LevelDBClient$$anonfun$might_fail_using_index$1.apply(LevelDBClient.scala:1025) > > at > org.apache.activemq.leveldb.Lev
Re: [VOTE] Apache ActiveMQ 6.0.0 (RC2)
The source archive and/or tag (depending on who you ask) is the ultimate release at the end of the day. The binaries are only conveniences, but as we do ship them are expected to be treated similaly in terms of license/notice handling, and they often tend to be treated as component parts of the release process as a result. Certainly I would be surprisd to find anything in the releases area of repository.apache.org that hadnt been voted on in some way, even though only by proxy of the matching source artifact release. The apache parent pom adds the tooling leading to creation of the LICENCE and NOTICE files in the jar files. It has always been my understanding they do need to be there, mainly a result of seeing other projects pulled up on not having them. http://apache.org/legal/src-headers.html#faq mentions: Does the policy apply to binary/object files, such as executables or JAR files? Yes. Even if there are no source files within the release, the LICENSE file and NOTICE file are still both required within every ASF distribution -- whether the unit of distribution is a .jar, .msi, .tar/.?gz, .zip, .exe installer, or any other file format used for distributions. For example, Windows .exe files must not be used as a unit of distribution unless they are installers and include the LICENSE and NOTICE files in their installation. The interesting bit there would be deciding whether something (a .jar) was not 'a unit of distribution' because it was included inside something else that was (a tar.gz). Including the files seems easier/safer :-) Robbie On 13 March 2015 at 17:09, Gary Tully wrote: > The apache release process covers the artifacts in apache/dist[1] > The jars in maven are outside the process from what I understand and > as such they do not need a LICENSE or NOTICE file. > > However, I see some value in putting them in there, but I also see a > potential downside, because it may suggest that they are 'released' > artifacts that have been voted on by a PMC, which will not be the > case. It may be a case of maven tech adoption going ahead of explicit > policy. > What is an apache release may indeed, in the future, extend to what is > in maven, and we will be ahead of the curve with the inclusion of > these two files :-) > > [1] http://www.apache.org/dev/release.html#where-do-releases-go > > On 13 March 2015 at 16:15, Robbie Gemmell wrote: >> On 13 March 2015 at 15:59, Martyn Taylor wrote: >>> >>> On 13/03/15 15:16, Robbie Gemmell wrote: I downloaded the src+bin tar.gz files, and gave the src build a run through and kicked the tyres on the binary. The NPE from RC1 when using an AMQP client is now fixed. In the docs the links to the configuration index now work, and the table there now links to the .html files rather than the .md files. For the docs, the project-info page near the start is still 404's. >>> >>> Thanks. Looking at some of the diff since RC1, I noticed that some JSON related source files had their 'JSON licence' restored to them. They should be mentioned in the distro LICENCE files as a result, either including the license or pointing to it in the tree. >>> >>> Given that the activemq-core-client jar covers these source files it it's >>> LICENSE, am I correct in assuming there is no need to add this again in the >>> binary distribution? i.e. apache-activemq-6.0.0-bin i.e. we should only >>> need to add this to the LICENSE file in the source distribution? >> >> I think it needs to be there (anyone else know otherwise?), and I >> would personally add it since the LICENSE file in the distribution >> root ultimately lets people know what terms the various included bits >> are under. The ones in the jars also need to be there because jars are >> also distributions themselves and people can/do use them in isolation >> (e.g from a maven repo). >> The activemq-core-client jar has the ASLv2 included twice in its META-INF/LICENCE file, likely due to the appended-resources file for adding the licence for the JSON bits. >>> >>> Yes. The build appears to append the license rather than overwrite as we >>> had thought. There was a base64.txt licence file previously that went away; is that code no longer included? >>> >>> Clebert already replied to this. But yes this is no longer included. >>> Robbie On 13 March 2015 at 14:05, Gary Tully wrote: > > Thanks for the fast turnaround. > > NOTICE and LICENCE files look correct in both source and binary distros. > > source builds, tests run, resulting binary looks great. > > However, I found one Cat-x transitive dep that breaks the build. > I added an exclusion and the source builds find, so the dependency is > not required but it needs to be removed. > > Detail: > [ERROR] Failed to execute goal on project activemq-rest: Could not > resolve dependencies for project >
Re: [VOTE] Apache ActiveMQ 6.0.0 (RC2)
The apache release process covers the artifacts in apache/dist[1] The jars in maven are outside the process from what I understand and as such they do not need a LICENSE or NOTICE file. However, I see some value in putting them in there, but I also see a potential downside, because it may suggest that they are 'released' artifacts that have been voted on by a PMC, which will not be the case. It may be a case of maven tech adoption going ahead of explicit policy. What is an apache release may indeed, in the future, extend to what is in maven, and we will be ahead of the curve with the inclusion of these two files :-) [1] http://www.apache.org/dev/release.html#where-do-releases-go On 13 March 2015 at 16:15, Robbie Gemmell wrote: > On 13 March 2015 at 15:59, Martyn Taylor wrote: >> >> On 13/03/15 15:16, Robbie Gemmell wrote: >>> >>> I downloaded the src+bin tar.gz files, and gave the src build a run >>> through and kicked the tyres on the binary. The NPE from RC1 when >>> using an AMQP client is now fixed. In the docs the links to the >>> configuration index now work, and the table there now links to the >>> .html files rather than the .md files. >>> >>> For the docs, the project-info page near the start is still 404's. >> >> Thanks. >>> >>> >>> Looking at some of the diff since RC1, I noticed that some JSON >>> related source files had their 'JSON licence' restored to them. They >>> should be mentioned in the distro LICENCE files as a result, either >>> including the license or pointing to it in the tree. >> >> Given that the activemq-core-client jar covers these source files it it's >> LICENSE, am I correct in assuming there is no need to add this again in the >> binary distribution? i.e. apache-activemq-6.0.0-bin i.e. we should only >> need to add this to the LICENSE file in the source distribution? >>> > > I think it needs to be there (anyone else know otherwise?), and I > would personally add it since the LICENSE file in the distribution > root ultimately lets people know what terms the various included bits > are under. The ones in the jars also need to be there because jars are > also distributions themselves and people can/do use them in isolation > (e.g from a maven repo). > >>> The >>> activemq-core-client jar has the ASLv2 included twice in its >>> META-INF/LICENCE file, likely due to the appended-resources file for >>> adding the licence for the JSON bits. >> >> Yes. The build appears to append the license rather than overwrite as we >> had thought. >>> >>> >>> There was a base64.txt licence file previously that went away; is that >>> code no longer included? >> >> Clebert already replied to this. But yes this is no longer included. >> >>> >>> Robbie >>> >>> On 13 March 2015 at 14:05, Gary Tully wrote: Thanks for the fast turnaround. NOTICE and LICENCE files look correct in both source and binary distros. source builds, tests run, resulting binary looks great. However, I found one Cat-x transitive dep that breaks the build. I added an exclusion and the source builds find, so the dependency is not required but it needs to be removed. Detail: [ERROR] Failed to execute goal on project activemq-rest: Could not resolve dependencies for project org.apache.activemq.rest:activemq-rest:jar:6.0.0: The repository system is offline but the artifact org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec:jar:1.0.1.Final .. Resolution: org.jboss.resteasy resteasy-jaxrs org.jboss.spec.javax.annotationjboss-annotations-api_1.1_spec So this is another -1. However, with this issue fixed and no regressions - I am ready to +1 this release. Shout out to other pmc members - even if you don't intend to vote, can you take a few moments to cast your eyes over the artifacts. As this is a first release, we need many eyes to validate there are no glaring omissions. On 12 March 2015 at 21:30, Martyn Taylor wrote: > > Hello all. > > I've cut a second release candidate of Apache ActiveMQ 6.0.0 addressing > the > initial RC feedback from community members. > > This is a first release of the HornetQ code donation with support for > AMQP, > STOMP, CORE and OPENWIRE > > > The release notes can be found here: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12328953 > > The binary distributions can be found here: > > https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ > > The source archives can be found here: > > https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ > > The Maven repository is here: > > https://re
Re: [VOTE] Apache ActiveMQ 6.0.0 (RC2)
On 13/03/15 16:15, Robbie Gemmell wrote: On 13 March 2015 at 15:59, Martyn Taylor wrote: On 13/03/15 15:16, Robbie Gemmell wrote: I downloaded the src+bin tar.gz files, and gave the src build a run through and kicked the tyres on the binary. The NPE from RC1 when using an AMQP client is now fixed. In the docs the links to the configuration index now work, and the table there now links to the .html files rather than the .md files. For the docs, the project-info page near the start is still 404's. Thanks. Looking at some of the diff since RC1, I noticed that some JSON related source files had their 'JSON licence' restored to them. They should be mentioned in the distro LICENCE files as a result, either including the license or pointing to it in the tree. Given that the activemq-core-client jar covers these source files it it's LICENSE, am I correct in assuming there is no need to add this again in the binary distribution? i.e. apache-activemq-6.0.0-bin i.e. we should only need to add this to the LICENSE file in the source distribution? I think it needs to be there (anyone else know otherwise?), and I would personally add it since the LICENSE file in the distribution root ultimately lets people know what terms the various included bits are under. The ones in the jars also need to be there because jars are also distributions themselves and people can/do use them in isolation (e.g from a maven repo). Thanks Robbie. We'll include them in the source and binary distribution (as well as the jars). The activemq-core-client jar has the ASLv2 included twice in its META-INF/LICENCE file, likely due to the appended-resources file for adding the licence for the JSON bits. Yes. The build appears to append the license rather than overwrite as we had thought. There was a base64.txt licence file previously that went away; is that code no longer included? Clebert already replied to this. But yes this is no longer included. Robbie On 13 March 2015 at 14:05, Gary Tully wrote: Thanks for the fast turnaround. NOTICE and LICENCE files look correct in both source and binary distros. source builds, tests run, resulting binary looks great. However, I found one Cat-x transitive dep that breaks the build. I added an exclusion and the source builds find, so the dependency is not required but it needs to be removed. Detail: [ERROR] Failed to execute goal on project activemq-rest: Could not resolve dependencies for project org.apache.activemq.rest:activemq-rest:jar:6.0.0: The repository system is offline but the artifact org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec:jar:1.0.1.Final .. Resolution: org.jboss.resteasy resteasy-jaxrs org.jboss.spec.javax.annotationjboss-annotations-api_1.1_spec So this is another -1. However, with this issue fixed and no regressions - I am ready to +1 this release. Shout out to other pmc members - even if you don't intend to vote, can you take a few moments to cast your eyes over the artifacts. As this is a first release, we need many eyes to validate there are no glaring omissions. On 12 March 2015 at 21:30, Martyn Taylor wrote: Hello all. I've cut a second release candidate of Apache ActiveMQ 6.0.0 addressing the initial RC feedback from community members. This is a first release of the HornetQ code donation with support for AMQP, STOMP, CORE and OPENWIRE The release notes can be found here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12328953 The binary distributions can be found here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ The source archives can be found here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ The Maven repository is here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/ The source tag: https://git-wip-us.apache.org/repos/asf?p=activemq-6.git;a=tag;h=refs/tags/6.0.0 The project website for that version has been staged to: http://people.apache.org/~martyntaylor/ The vote will remain open for 72 hours. [ ] +1 approve the release as Apache ActiveMQ 6.0.0 [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here's my (non-binding) +1 Regards Martyn
Re: [VOTE] Apache ActiveMQ 6.0.0 (RC2)
On 13 March 2015 at 15:59, Martyn Taylor wrote: > > On 13/03/15 15:16, Robbie Gemmell wrote: >> >> I downloaded the src+bin tar.gz files, and gave the src build a run >> through and kicked the tyres on the binary. The NPE from RC1 when >> using an AMQP client is now fixed. In the docs the links to the >> configuration index now work, and the table there now links to the >> .html files rather than the .md files. >> >> For the docs, the project-info page near the start is still 404's. > > Thanks. >> >> >> Looking at some of the diff since RC1, I noticed that some JSON >> related source files had their 'JSON licence' restored to them. They >> should be mentioned in the distro LICENCE files as a result, either >> including the license or pointing to it in the tree. > > Given that the activemq-core-client jar covers these source files it it's > LICENSE, am I correct in assuming there is no need to add this again in the > binary distribution? i.e. apache-activemq-6.0.0-bin i.e. we should only > need to add this to the LICENSE file in the source distribution? >> I think it needs to be there (anyone else know otherwise?), and I would personally add it since the LICENSE file in the distribution root ultimately lets people know what terms the various included bits are under. The ones in the jars also need to be there because jars are also distributions themselves and people can/do use them in isolation (e.g from a maven repo). >> The >> activemq-core-client jar has the ASLv2 included twice in its >> META-INF/LICENCE file, likely due to the appended-resources file for >> adding the licence for the JSON bits. > > Yes. The build appears to append the license rather than overwrite as we > had thought. >> >> >> There was a base64.txt licence file previously that went away; is that >> code no longer included? > > Clebert already replied to this. But yes this is no longer included. > >> >> Robbie >> >> On 13 March 2015 at 14:05, Gary Tully wrote: >>> >>> Thanks for the fast turnaround. >>> >>> NOTICE and LICENCE files look correct in both source and binary distros. >>> >>> source builds, tests run, resulting binary looks great. >>> >>> However, I found one Cat-x transitive dep that breaks the build. >>> I added an exclusion and the source builds find, so the dependency is >>> not required but it needs to be removed. >>> >>> Detail: >>> [ERROR] Failed to execute goal on project activemq-rest: Could not >>> resolve dependencies for project >>> org.apache.activemq.rest:activemq-rest:jar:6.0.0: The repository >>> system is offline but the artifact >>> >>> org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec:jar:1.0.1.Final >>> .. >>> >>> Resolution: >>> >>>org.jboss.resteasy >>>resteasy-jaxrs >>> >>> >>> org.jboss.spec.javax.annotationjboss-annotations-api_1.1_spec >>> >>> >>> >>> >>> So this is another -1. >>> >>> However, with this issue fixed and no regressions - I am ready to +1 >>> this release. >>> >>> Shout out to other pmc members - even if you don't intend to vote, can >>> you take a few moments to cast your eyes over the artifacts. >>> As this is a first release, we need many eyes to validate there are no >>> glaring omissions. >>> >>> >>> >>> On 12 March 2015 at 21:30, Martyn Taylor wrote: Hello all. I've cut a second release candidate of Apache ActiveMQ 6.0.0 addressing the initial RC feedback from community members. This is a first release of the HornetQ code donation with support for AMQP, STOMP, CORE and OPENWIRE The release notes can be found here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12328953 The binary distributions can be found here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ The source archives can be found here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ The Maven repository is here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/ The source tag: https://git-wip-us.apache.org/repos/asf?p=activemq-6.git;a=tag;h=refs/tags/6.0.0 The project website for that version has been staged to: http://people.apache.org/~martyntaylor/ The vote will remain open for 72 hours. [ ] +1 approve the release as Apache ActiveMQ 6.0.0 [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here's my (non-binding) +1 Regards Martyn > >
Re: [VOTE] Apache ActiveMQ 6.0.0 (RC2)
On 13/03/15 15:59, Martyn Taylor wrote: On 13/03/15 15:16, Robbie Gemmell wrote: I downloaded the src+bin tar.gz files, and gave the src build a run through and kicked the tyres on the binary. The NPE from RC1 when using an AMQP client is now fixed. In the docs the links to the configuration index now work, and the table there now links to the .html files rather than the .md files. For the docs, the project-info page near the start is still 404's. Thanks. Looking at some of the diff since RC1, I noticed that some JSON related source files had their 'JSON licence' restored to them. They should be mentioned in the distro LICENCE files as a result, either including the license or pointing to it in the tree. Given that the activemq-core-client jar covers these source files it it's LICENSE, am I correct in assuming there is no need to add this again in the binary distribution? i.e. apache-activemq-6.0.0-bin i.e. we should only need to add this to the LICENSE file in the source distribution? Nevermind... reading the documentation, it is implied that the license will be needed in both places: http://www.apache.org/dev/licensing-howto.html#alv2-dep. We'll update. Thanks. The activemq-core-client jar has the ASLv2 included twice in its META-INF/LICENCE file, likely due to the appended-resources file for adding the licence for the JSON bits. Yes. The build appears to append the license rather than overwrite as we had thought. There was a base64.txt licence file previously that went away; is that code no longer included? Clebert already replied to this. But yes this is no longer included. Robbie On 13 March 2015 at 14:05, Gary Tully wrote: Thanks for the fast turnaround. NOTICE and LICENCE files look correct in both source and binary distros. source builds, tests run, resulting binary looks great. However, I found one Cat-x transitive dep that breaks the build. I added an exclusion and the source builds find, so the dependency is not required but it needs to be removed. Detail: [ERROR] Failed to execute goal on project activemq-rest: Could not resolve dependencies for project org.apache.activemq.rest:activemq-rest:jar:6.0.0: The repository system is offline but the artifact org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec:jar:1.0.1.Final .. Resolution: org.jboss.resteasy resteasy-jaxrs org.jboss.spec.javax.annotationjboss-annotations-api_1.1_spec So this is another -1. However, with this issue fixed and no regressions - I am ready to +1 this release. Shout out to other pmc members - even if you don't intend to vote, can you take a few moments to cast your eyes over the artifacts. As this is a first release, we need many eyes to validate there are no glaring omissions. On 12 March 2015 at 21:30, Martyn Taylor wrote: Hello all. I've cut a second release candidate of Apache ActiveMQ 6.0.0 addressing the initial RC feedback from community members. This is a first release of the HornetQ code donation with support for AMQP, STOMP, CORE and OPENWIRE The release notes can be found here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12328953 The binary distributions can be found here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ The source archives can be found here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ The Maven repository is here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/ The source tag: https://git-wip-us.apache.org/repos/asf?p=activemq-6.git;a=tag;h=refs/tags/6.0.0 The project website for that version has been staged to: http://people.apache.org/~martyntaylor/ The vote will remain open for 72 hours. [ ] +1 approve the release as Apache ActiveMQ 6.0.0 [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here's my (non-binding) +1 Regards Martyn
ActiveMQ DSLs
Hi All,
In working on a separate project, I found the need to instantiate
multiple different ActiveMQ configurations. Rather than writing up a lot
of different XML configs or messing around with assembling BrokerService
instances, I wrote a DSL that mimics the ActiveMQ config schema via a
directed builder pattern, much like Camel. Here's an example:
BrokerContext context = new
BrokerContext(ActiveMQBrokers.broker("embeddedBroker").useJmx(false).persistent(false)
.transportConnectors()
.transportConnector("openwire", "tcp://0.0.0.0:61616").end()
.end()
.plugins()
.simpleAuthenticationPlugin()
.users()
.authenticationUser("user").password("pass").groups("guests").end()
.end()
.end()
.end()));
context.start();
...
context.end();
Unlike Camel, the DSL itself defines a model that is used to instantiate
a BrokerService. Camel has an intermediate set of VOs
(org.apache.camel.model) between the Java DSL and the implementation. I
had a go at generating a similar model via JAXB from the ActiveMQ
schema, to abstract away the DSL/XBean config, but the generated classes
were hideous and I abandoned the approach.
I also developed a testing DSL for JUnit that allows you to spin up
these configurations, and rely on the JUnit runner to start up and shut
down the broker. The test DSL also allows for the definition of proxies
(using the ActiveMQ SocketProxy class) to easily simulate network outages.
A full writeup and source code are available at
https://github.com/jkorab/activemq-dsls
As it stands, the DSL is a work in progress that supports my own code,
but I think it would be useful as something provided by ActiveMQ itself.
I would like to contribute what I have written so far, and develop it
further (perhaps cleaning up a bunch of ActiveMQ tests to use it in an
"eating your own dogfood" way). I was initially thinking that it could
be part of activemq-broker in the src/test tree, and once it gets
fleshed out, moved to src/main. The set of config options in ActiveMQ is
huge, and retrofitting tests would be an ideal way of evolving it and
validating that everything works before making it public.
I think that this is something that would be useful, as I have seen
ActiveMQ deployments where the broker was defined in Java. This is
particularly useful where there are is a broker network with a bunch of
network connectors from a broker, each with dynamically or statically
included or excluded destinations, used in conjuction with composite
destinations to route messages in "just the right way". That sort of
thing is much better expressed in code rather than huge slabs of XML.
What do you think? Is this something that would be worthwhile to have in
ActiveMQ?
Jakub
Re: [VOTE] Apache ActiveMQ 6.0.0 (RC2)
On 13 March 2015 at 15:30, Clebert Suconic wrote: >> There was a base64.txt licence file previously that went away; is that > code no longer included? > > > We are using the Base64 from here: > http://iharder.sourceforge.net/current/java/base64/ > > > Where he states you can license it anyway you wanted, for that we > removed the base64 license. > > Do you see any issues with it? > He says you dont need to worry about matching it up to another license, just use it as its public domain, but that he will license it to you under any reasonable license if contacted to ask for that. He does say do anything you want with it, which possibly includes simply using it with a different licence by yourself but I'm not sure on that at all, IANAL. Asking on legal@ (or seeing if somoene else previosuly did) might be the way to go. I would personally just call out the that files were released into public domain, as per http://www.apache.org/legal/resolved.html#can-works-placed-in-the-public-domain-be-included-in-apache-products. > > Regarding the docs: > > I guess the website doc wasn't updated with the release, only on the > distribution. We will update it before the final upload though. > It was the distribution that I tried, I'll admit I hadn't even got as far down the email to notice the link to the website thus far :) > I'm doing some work on that part now to convert everything to > Markdown. So even the PDF format will have the links fixed. > > > > We will take a look at the licenses.. thanks again! > > > > > On Fri, Mar 13, 2015 at 11:16 AM, Robbie Gemmell > wrote: >> I downloaded the src+bin tar.gz files, and gave the src build a run >> through and kicked the tyres on the binary. The NPE from RC1 when >> using an AMQP client is now fixed. In the docs the links to the >> configuration index now work, and the table there now links to the >> .html files rather than the .md files. >> >> For the docs, the project-info page near the start is still 404's. >> >> Looking at some of the diff since RC1, I noticed that some JSON >> related source files had their 'JSON licence' restored to them. They >> should be mentioned in the distro LICENCE files as a result, either >> including the license or pointing to it in the tree. The >> activemq-core-client jar has the ASLv2 included twice in its >> META-INF/LICENCE file, likely due to the appended-resources file for >> adding the licence for the JSON bits. >> >> There was a base64.txt licence file previously that went away; is that >> code no longer included? >> >> Robbie >> >> On 13 March 2015 at 14:05, Gary Tully wrote: >>> Thanks for the fast turnaround. >>> >>> NOTICE and LICENCE files look correct in both source and binary distros. >>> >>> source builds, tests run, resulting binary looks great. >>> >>> However, I found one Cat-x transitive dep that breaks the build. >>> I added an exclusion and the source builds find, so the dependency is >>> not required but it needs to be removed. >>> >>> Detail: >>> [ERROR] Failed to execute goal on project activemq-rest: Could not >>> resolve dependencies for project >>> org.apache.activemq.rest:activemq-rest:jar:6.0.0: The repository >>> system is offline but the artifact >>> org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec:jar:1.0.1.Final >>> .. >>> >>> Resolution: >>> >>> org.jboss.resteasy >>> resteasy-jaxrs >>> >>> >>> org.jboss.spec.javax.annotationjboss-annotations-api_1.1_spec >>> >>> >>> >>> >>> So this is another -1. >>> >>> However, with this issue fixed and no regressions - I am ready to +1 >>> this release. >>> >>> Shout out to other pmc members - even if you don't intend to vote, can >>> you take a few moments to cast your eyes over the artifacts. >>> As this is a first release, we need many eyes to validate there are no >>> glaring omissions. >>> >>> >>> >>> On 12 March 2015 at 21:30, Martyn Taylor wrote: Hello all. I've cut a second release candidate of Apache ActiveMQ 6.0.0 addressing the initial RC feedback from community members. This is a first release of the HornetQ code donation with support for AMQP, STOMP, CORE and OPENWIRE The release notes can be found here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12328953 The binary distributions can be found here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ The source archives can be found here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ The Maven repository is here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/ The source tag: https://git-wip-us.apache.org/repos/asf?p=activemq-6.git;a=tag;h=refs/tags/6.0.0 The project website for that version has been staged to: http://people.apache.org/~martynt
Re: [VOTE] Apache ActiveMQ 6.0.0 (RC2)
On 13/03/15 15:16, Robbie Gemmell wrote: I downloaded the src+bin tar.gz files, and gave the src build a run through and kicked the tyres on the binary. The NPE from RC1 when using an AMQP client is now fixed. In the docs the links to the configuration index now work, and the table there now links to the .html files rather than the .md files. For the docs, the project-info page near the start is still 404's. Thanks. Looking at some of the diff since RC1, I noticed that some JSON related source files had their 'JSON licence' restored to them. They should be mentioned in the distro LICENCE files as a result, either including the license or pointing to it in the tree. Given that the activemq-core-client jar covers these source files it it's LICENSE, am I correct in assuming there is no need to add this again in the binary distribution? i.e. apache-activemq-6.0.0-bin i.e. we should only need to add this to the LICENSE file in the source distribution? The activemq-core-client jar has the ASLv2 included twice in its META-INF/LICENCE file, likely due to the appended-resources file for adding the licence for the JSON bits. Yes. The build appears to append the license rather than overwrite as we had thought. There was a base64.txt licence file previously that went away; is that code no longer included? Clebert already replied to this. But yes this is no longer included. Robbie On 13 March 2015 at 14:05, Gary Tully wrote: Thanks for the fast turnaround. NOTICE and LICENCE files look correct in both source and binary distros. source builds, tests run, resulting binary looks great. However, I found one Cat-x transitive dep that breaks the build. I added an exclusion and the source builds find, so the dependency is not required but it needs to be removed. Detail: [ERROR] Failed to execute goal on project activemq-rest: Could not resolve dependencies for project org.apache.activemq.rest:activemq-rest:jar:6.0.0: The repository system is offline but the artifact org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec:jar:1.0.1.Final .. Resolution: org.jboss.resteasy resteasy-jaxrs org.jboss.spec.javax.annotationjboss-annotations-api_1.1_spec So this is another -1. However, with this issue fixed and no regressions - I am ready to +1 this release. Shout out to other pmc members - even if you don't intend to vote, can you take a few moments to cast your eyes over the artifacts. As this is a first release, we need many eyes to validate there are no glaring omissions. On 12 March 2015 at 21:30, Martyn Taylor wrote: Hello all. I've cut a second release candidate of Apache ActiveMQ 6.0.0 addressing the initial RC feedback from community members. This is a first release of the HornetQ code donation with support for AMQP, STOMP, CORE and OPENWIRE The release notes can be found here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12328953 The binary distributions can be found here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ The source archives can be found here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ The Maven repository is here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/ The source tag: https://git-wip-us.apache.org/repos/asf?p=activemq-6.git;a=tag;h=refs/tags/6.0.0 The project website for that version has been staged to: http://people.apache.org/~martyntaylor/ The vote will remain open for 72 hours. [ ] +1 approve the release as Apache ActiveMQ 6.0.0 [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here's my (non-binding) +1 Regards Martyn
Re: [VOTE] Apache ActiveMQ 6.0.0 (RC2)
> There was a base64.txt licence file previously that went away; is that code no longer included? We are using the Base64 from here: http://iharder.sourceforge.net/current/java/base64/ Where he states you can license it anyway you wanted, for that we removed the base64 license. Do you see any issues with it? Regarding the docs: I guess the website doc wasn't updated with the release, only on the distribution. We will update it before the final upload though. I'm doing some work on that part now to convert everything to Markdown. So even the PDF format will have the links fixed. We will take a look at the licenses.. thanks again! On Fri, Mar 13, 2015 at 11:16 AM, Robbie Gemmell wrote: > I downloaded the src+bin tar.gz files, and gave the src build a run > through and kicked the tyres on the binary. The NPE from RC1 when > using an AMQP client is now fixed. In the docs the links to the > configuration index now work, and the table there now links to the > .html files rather than the .md files. > > For the docs, the project-info page near the start is still 404's. > > Looking at some of the diff since RC1, I noticed that some JSON > related source files had their 'JSON licence' restored to them. They > should be mentioned in the distro LICENCE files as a result, either > including the license or pointing to it in the tree. The > activemq-core-client jar has the ASLv2 included twice in its > META-INF/LICENCE file, likely due to the appended-resources file for > adding the licence for the JSON bits. > > There was a base64.txt licence file previously that went away; is that > code no longer included? > > Robbie > > On 13 March 2015 at 14:05, Gary Tully wrote: >> Thanks for the fast turnaround. >> >> NOTICE and LICENCE files look correct in both source and binary distros. >> >> source builds, tests run, resulting binary looks great. >> >> However, I found one Cat-x transitive dep that breaks the build. >> I added an exclusion and the source builds find, so the dependency is >> not required but it needs to be removed. >> >> Detail: >> [ERROR] Failed to execute goal on project activemq-rest: Could not >> resolve dependencies for project >> org.apache.activemq.rest:activemq-rest:jar:6.0.0: The repository >> system is offline but the artifact >> org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec:jar:1.0.1.Final >> .. >> >> Resolution: >> >> org.jboss.resteasy >> resteasy-jaxrs >> >> >> org.jboss.spec.javax.annotationjboss-annotations-api_1.1_spec >> >> >> >> >> So this is another -1. >> >> However, with this issue fixed and no regressions - I am ready to +1 >> this release. >> >> Shout out to other pmc members - even if you don't intend to vote, can >> you take a few moments to cast your eyes over the artifacts. >> As this is a first release, we need many eyes to validate there are no >> glaring omissions. >> >> >> >> On 12 March 2015 at 21:30, Martyn Taylor wrote: >>> Hello all. >>> >>> I've cut a second release candidate of Apache ActiveMQ 6.0.0 addressing the >>> initial RC feedback from community members. >>> >>> This is a first release of the HornetQ code donation with support for AMQP, >>> STOMP, CORE and OPENWIRE >>> >>> >>> The release notes can be found here: >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12328953 >>> >>> The binary distributions can be found here: >>> https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ >>> >>> The source archives can be found here: >>> https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ >>> >>> The Maven repository is here: >>> https://repository.apache.org/content/repositories/orgapacheactivemq-1037/ >>> >>> The source tag: >>> https://git-wip-us.apache.org/repos/asf?p=activemq-6.git;a=tag;h=refs/tags/6.0.0 >>> >>> The project website for that version has been staged to: >>> http://people.apache.org/~martyntaylor/ >>> >>> The vote will remain open for 72 hours. >>> >>> [ ] +1 approve the release as Apache ActiveMQ 6.0.0 >>> [ ] +0 no opinion >>> [ ] -1 disapprove (and reason why) >>> >>> Here's my (non-binding) +1 >>> >>> Regards >>> >>> Martyn -- Clebert Suconic http://community.jboss.org/people/clebert.suco...@jboss.com http://clebertsuconic.blogspot.com
Re: [VOTE] Apache ActiveMQ 6.0.0 (RC2)
I downloaded the src+bin tar.gz files, and gave the src build a run through and kicked the tyres on the binary. The NPE from RC1 when using an AMQP client is now fixed. In the docs the links to the configuration index now work, and the table there now links to the .html files rather than the .md files. For the docs, the project-info page near the start is still 404's. Looking at some of the diff since RC1, I noticed that some JSON related source files had their 'JSON licence' restored to them. They should be mentioned in the distro LICENCE files as a result, either including the license or pointing to it in the tree. The activemq-core-client jar has the ASLv2 included twice in its META-INF/LICENCE file, likely due to the appended-resources file for adding the licence for the JSON bits. There was a base64.txt licence file previously that went away; is that code no longer included? Robbie On 13 March 2015 at 14:05, Gary Tully wrote: > Thanks for the fast turnaround. > > NOTICE and LICENCE files look correct in both source and binary distros. > > source builds, tests run, resulting binary looks great. > > However, I found one Cat-x transitive dep that breaks the build. > I added an exclusion and the source builds find, so the dependency is > not required but it needs to be removed. > > Detail: > [ERROR] Failed to execute goal on project activemq-rest: Could not > resolve dependencies for project > org.apache.activemq.rest:activemq-rest:jar:6.0.0: The repository > system is offline but the artifact > org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec:jar:1.0.1.Final > .. > > Resolution: > > org.jboss.resteasy > resteasy-jaxrs > > > org.jboss.spec.javax.annotationjboss-annotations-api_1.1_spec > > > > > So this is another -1. > > However, with this issue fixed and no regressions - I am ready to +1 > this release. > > Shout out to other pmc members - even if you don't intend to vote, can > you take a few moments to cast your eyes over the artifacts. > As this is a first release, we need many eyes to validate there are no > glaring omissions. > > > > On 12 March 2015 at 21:30, Martyn Taylor wrote: >> Hello all. >> >> I've cut a second release candidate of Apache ActiveMQ 6.0.0 addressing the >> initial RC feedback from community members. >> >> This is a first release of the HornetQ code donation with support for AMQP, >> STOMP, CORE and OPENWIRE >> >> >> The release notes can be found here: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12328953 >> >> The binary distributions can be found here: >> https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ >> >> The source archives can be found here: >> https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ >> >> The Maven repository is here: >> https://repository.apache.org/content/repositories/orgapacheactivemq-1037/ >> >> The source tag: >> https://git-wip-us.apache.org/repos/asf?p=activemq-6.git;a=tag;h=refs/tags/6.0.0 >> >> The project website for that version has been staged to: >> http://people.apache.org/~martyntaylor/ >> >> The vote will remain open for 72 hours. >> >> [ ] +1 approve the release as Apache ActiveMQ 6.0.0 >> [ ] +0 no opinion >> [ ] -1 disapprove (and reason why) >> >> Here's my (non-binding) +1 >> >> Regards >> >> Martyn
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Github user mastanik commented on the pull request: https://github.com/apache/activemq-6/pull/182#issuecomment-79029355 Sure, I will update it as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [CANCEL][VOTE] Apache ActiveMQ 6.0.0 (RC2)
Even though we are canceling the vote we would appreciate feedback from other PMCs as Gary Mentioned. On Fri, Mar 13, 2015 at 10:35 AM, Martyn Taylor wrote: > Cancelling vote. Another RC will follow addressing the Cat X issue as > described by Gary Tully. > > On 12/03/15 21:30, Martyn Taylor wrote: >> >> Hello all. >> >> I've cut a second release candidate of Apache ActiveMQ 6.0.0 addressing >> the initial RC feedback from community members. >> >> This is a first release of the HornetQ code donation with support for >> AMQP, STOMP, CORE and OPENWIRE >> >> >> The release notes can be found here: >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12328953 >> >> The binary distributions can be found here: >> >> https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ >> >> The source archives can be found here: >> >> https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ >> >> The Maven repository is here: >> https://repository.apache.org/content/repositories/orgapacheactivemq-1037/ >> >> The source tag: >> >> https://git-wip-us.apache.org/repos/asf?p=activemq-6.git;a=tag;h=refs/tags/6.0.0 >> >> The project website for that version has been staged to: >> http://people.apache.org/~martyntaylor/ >> >> The vote will remain open for 72 hours. >> >> [ ] +1 approve the release as Apache ActiveMQ 6.0.0 >> [ ] +0 no opinion >> [ ] -1 disapprove (and reason why) >> >> Here's my (non-binding) +1 >> >> Regards >> >> Martyn > > -- Clebert Suconic http://community.jboss.org/people/clebert.suco...@jboss.com http://clebertsuconic.blogspot.com
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-6/pull/182#issuecomment-79020971 If you have a chance also, add a paragraph to the docs :) I will do it right away if you don't have time to do it.. but please advise if that's the case so I will do the docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-6/pull/182#issuecomment-79020069 I will hold the PR open until you do it then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[CANCEL][VOTE] Apache ActiveMQ 6.0.0 (RC2)
Cancelling vote. Another RC will follow addressing the Cat X issue as described by Gary Tully. On 12/03/15 21:30, Martyn Taylor wrote: Hello all. I've cut a second release candidate of Apache ActiveMQ 6.0.0 addressing the initial RC feedback from community members. This is a first release of the HornetQ code donation with support for AMQP, STOMP, CORE and OPENWIRE The release notes can be found here: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12328953 The binary distributions can be found here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ The source archives can be found here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ The Maven repository is here: https://repository.apache.org/content/repositories/orgapacheactivemq-1037/ The source tag: https://git-wip-us.apache.org/repos/asf?p=activemq-6.git;a=tag;h=refs/tags/6.0.0 The project website for that version has been staged to: http://people.apache.org/~martyntaylor/ The vote will remain open for 72 hours. [ ] +1 approve the release as Apache ActiveMQ 6.0.0 [ ] +0 no opinion [ ] -1 disapprove (and reason why) Here's my (non-binding) +1 Regards Martyn
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Github user mastanik commented on the pull request: https://github.com/apache/activemq-6/pull/182#issuecomment-78994222 Yes, sure, I will update this pr when it is done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [VOTE] Apache ActiveMQ 6.0.0 (RC2)
Thanks for the fast turnaround. NOTICE and LICENCE files look correct in both source and binary distros. source builds, tests run, resulting binary looks great. However, I found one Cat-x transitive dep that breaks the build. I added an exclusion and the source builds find, so the dependency is not required but it needs to be removed. Detail: [ERROR] Failed to execute goal on project activemq-rest: Could not resolve dependencies for project org.apache.activemq.rest:activemq-rest:jar:6.0.0: The repository system is offline but the artifact org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec:jar:1.0.1.Final .. Resolution: org.jboss.resteasy resteasy-jaxrs org.jboss.spec.javax.annotationjboss-annotations-api_1.1_spec So this is another -1. However, with this issue fixed and no regressions - I am ready to +1 this release. Shout out to other pmc members - even if you don't intend to vote, can you take a few moments to cast your eyes over the artifacts. As this is a first release, we need many eyes to validate there are no glaring omissions. On 12 March 2015 at 21:30, Martyn Taylor wrote: > Hello all. > > I've cut a second release candidate of Apache ActiveMQ 6.0.0 addressing the > initial RC feedback from community members. > > This is a first release of the HornetQ code donation with support for AMQP, > STOMP, CORE and OPENWIRE > > > The release notes can be found here: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12328953 > > The binary distributions can be found here: > https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ > > The source archives can be found here: > https://repository.apache.org/content/repositories/orgapacheactivemq-1037/org/apache/activemq/apache-activemq/6.0.0/ > > The Maven repository is here: > https://repository.apache.org/content/repositories/orgapacheactivemq-1037/ > > The source tag: > https://git-wip-us.apache.org/repos/asf?p=activemq-6.git;a=tag;h=refs/tags/6.0.0 > > The project website for that version has been staged to: > http://people.apache.org/~martyntaylor/ > > The vote will remain open for 72 hours. > > [ ] +1 approve the release as Apache ActiveMQ 6.0.0 > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Here's my (non-binding) +1 > > Regards > > Martyn
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-6/pull/182#issuecomment-78967583 Nicely done... +1 on me for a merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (AMQ-5659) Add safety measure against infinite loop when store exception prevents message removal
[
https://issues.apache.org/jira/browse/AMQ-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
metatech updated AMQ-5659:
--
Attachment: purge_queue_abort_loop_v3.patch
V3 of the patch fixes the incorrect threshold
> Add safety measure against infinite loop when store exception prevents
> message removal
> --
>
> Key: AMQ-5659
> URL: https://issues.apache.org/jira/browse/AMQ-5659
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 5.7.0
> Environment: ServiceMix 4.5.3
>Reporter: metatech
> Attachments: purge_queue_abort_loop.patch,
> purge_queue_abort_loop_v2.patch, purge_queue_abort_loop_v3.patch
>
>
> When the broker is configured with a database store, the "purge" operation
> enters an infinite loop when the message removal operation fails, for
> instance when the broker datasource is being restarted (see example stack
> trace below).
> Here is a patch which adds a safety measure, in case the "dequeue" count of
> the queue does not increase between 2 messages removal operations. The check
> is not garanteed to detect the problem on the next iteration, because a
> business consumer might also be dequeuing messages from the queue. But the
> "purge" is probably much faster than the business consumer, so if it fails to
> remove 2 messages in a row, it is enough to detect the problem and abort the
> infinite loop.
> {code}
> 2015-03-05 15:38:30,353 | WARN | 14571659-2202099 | |
> JDBCPersistenceAdapter | Could not get JDBC connection: Data source
> is closed
> java.sql.SQLException: Data source is closed
> at
> org.apache.commons.dbcp.BasicDataSource.createDataSource(BasicDataSource.java:1362)
> at
> org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044)
> at
> org.apache.activemq.store.jdbc.TransactionContext.getConnection(TransactionContext.java:58)
> at
> org.apache.activemq.store.jdbc.adapter.DefaultJDBCAdapter.getStoreSequenceId(DefaultJDBCAdapter.java:285)
> at
> org.apache.activemq.store.jdbc.JDBCPersistenceAdapter.getStoreSequenceIdForMessageId(JDBCPersistenceAdapter.java:787)
> at
> org.apache.activemq.store.jdbc.JDBCMessageStore.removeMessage(JDBCMessageStore.java:194)
> at
> org.apache.activemq.store.memory.MemoryTransactionStore.removeMessage(MemoryTransactionStore.java:358)
> at
> org.apache.activemq.store.memory.MemoryTransactionStore$1.removeAsyncMessage(MemoryTransactionStore.java:166)
> at org.apache.activemq.broker.region.Queue.acknowledge(Queue.java:846)
> at
> org.apache.activemq.broker.region.Queue.removeMessage(Queue.java:1602)
> at
> org.apache.activemq.broker.region.Queue.removeMessage(Queue.java:1594)
> at
> org.apache.activemq.broker.region.Queue.removeMessage(Queue.java:1579)
> at org.apache.activemq.broker.region.Queue.purge(Queue.java:1158)
> at org.apache.activemq.broker.jmx.QueueView.purge(QueueView.java:54)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
Github user HornetQBot commented on the pull request: https://github.com/apache/activemq-6/pull/182#issuecomment-78891438 Can one of the admins verify this patch by saying "ok to test"? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-6 pull request: Added possibility to intercept stomp fram...
GitHub user mastanik opened a pull request: https://github.com/apache/activemq-6/pull/182 Added possibility to intercept stomp frames Initially I was trying to log all the incoming stomp frames from the client on a server side, but could not find any easy way of doing this. This pr adds possibility to intercept stomp frames via interceptor section in activemq-configuration.xml. Interceptor list was already passed as a parameter to StompProtocolManager constructor, but was not used in any way. I decided to introduce new abstract class which implements Interceptor interface as the simplest solution and then invoke its intercept method like it is done with the regular interceptors. Clients need to extend this class and put it under activemq class path, just as a regular jms interceptor. Looking forward to your comments, and feel free to reject it in case it does not make any sense. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mastanik/activemq-6 master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-6/pull/182.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #182 commit 05b469589dc7fe5b4f9e58654437e3501b6bc2f9 Author: nberdikov Date: 2015-03-13T09:29:33Z Added possibility to intercept stomp frames --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-6 pull request:
Github user mtaylor commented on the pull request: https://github.com/apache/activemq-6/commit/1e9ac1bbc34a3ee028806d35b4c05f09b256e81f#commitcomment-10181666 In docs/user-manual/en/configuration-index.md: In docs/user-manual/en/configuration-index.md on line 48: @clebertsuconic Actually you're right. The HTML elements are legitimate in markdown syntax, I presume this was left over from before we did the conversion. I'll follow up with a fix to use proper md links. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-6 pull request:
Github user mtaylor commented on the pull request: https://github.com/apache/activemq-6/commit/1e9ac1bbc34a3ee028806d35b4c05f09b256e81f#commitcomment-10181597 In docs/user-manual/en/configuration-index.md: In docs/user-manual/en/configuration-index.md on line 48: @clebertsuconic This file should be fully markdown. We need to go through the docs and ensure that they have all been converted from html to markdown. This fixes the broken links in html for the time being. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (AMQ-5659) Add safety measure against infinite loop when store exception prevents message removal
[
https://issues.apache.org/jira/browse/AMQ-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360133#comment-14360133
]
metatech commented on AMQ-5659:
---
Gary, breaking out of the "for" loop is not enough. We really want to break the
2 nested loops + skip the reset of the queue count performed at the end of the
method.
> Add safety measure against infinite loop when store exception prevents
> message removal
> --
>
> Key: AMQ-5659
> URL: https://issues.apache.org/jira/browse/AMQ-5659
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 5.7.0
> Environment: ServiceMix 4.5.3
>Reporter: metatech
> Attachments: purge_queue_abort_loop.patch,
> purge_queue_abort_loop_v2.patch
>
>
> When the broker is configured with a database store, the "purge" operation
> enters an infinite loop when the message removal operation fails, for
> instance when the broker datasource is being restarted (see example stack
> trace below).
> Here is a patch which adds a safety measure, in case the "dequeue" count of
> the queue does not increase between 2 messages removal operations. The check
> is not garanteed to detect the problem on the next iteration, because a
> business consumer might also be dequeuing messages from the queue. But the
> "purge" is probably much faster than the business consumer, so if it fails to
> remove 2 messages in a row, it is enough to detect the problem and abort the
> infinite loop.
> {code}
> 2015-03-05 15:38:30,353 | WARN | 14571659-2202099 | |
> JDBCPersistenceAdapter | Could not get JDBC connection: Data source
> is closed
> java.sql.SQLException: Data source is closed
> at
> org.apache.commons.dbcp.BasicDataSource.createDataSource(BasicDataSource.java:1362)
> at
> org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044)
> at
> org.apache.activemq.store.jdbc.TransactionContext.getConnection(TransactionContext.java:58)
> at
> org.apache.activemq.store.jdbc.adapter.DefaultJDBCAdapter.getStoreSequenceId(DefaultJDBCAdapter.java:285)
> at
> org.apache.activemq.store.jdbc.JDBCPersistenceAdapter.getStoreSequenceIdForMessageId(JDBCPersistenceAdapter.java:787)
> at
> org.apache.activemq.store.jdbc.JDBCMessageStore.removeMessage(JDBCMessageStore.java:194)
> at
> org.apache.activemq.store.memory.MemoryTransactionStore.removeMessage(MemoryTransactionStore.java:358)
> at
> org.apache.activemq.store.memory.MemoryTransactionStore$1.removeAsyncMessage(MemoryTransactionStore.java:166)
> at org.apache.activemq.broker.region.Queue.acknowledge(Queue.java:846)
> at
> org.apache.activemq.broker.region.Queue.removeMessage(Queue.java:1602)
> at
> org.apache.activemq.broker.region.Queue.removeMessage(Queue.java:1594)
> at
> org.apache.activemq.broker.region.Queue.removeMessage(Queue.java:1579)
> at org.apache.activemq.broker.region.Queue.purge(Queue.java:1158)
> at org.apache.activemq.broker.jmx.QueueView.purge(QueueView.java:54)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
