Re: Need Some Guide

[Dhanika Thathsara]

@Timothy Thank you so much. I appreciate your help.

Munasinghe D.T

On Tue, Jun 21, 2016 at 1:31 AM, Timothy Bish  wrote:

> On 06/20/2016 03:57 PM, Dhanika Thathsara wrote:
>
>> I am new to the open source community. I would like to contribute to the
>> activemq project. So I would like to help this project by solving bugs.
>> So I found this,
>> https://issues.apache.org/jira/browse/AMQ-6327
>> So I need help from you guys because I'm a beginner.
>> Please give me some guide lines to do this.
>>
>>
>> Best Regards,
>> Dhanika Thathsara,
>> University of Peradeniya.(undergrduate).
>>
>> The project code is located on Github, check out the code and build it
> using maven, once you've tackled that then get it imported into an IDE like
> Eclipse or Idea and get the unit tests running, then start spending some
> time getting familiar with the code, there's tons of unit tests already in
> there dive in.
>
> --
> Tim Bish
> twitter: @tabish121
> blog: http://timbish.blogspot.com/
>
>

[GitHub] activemq-artemis pull request #590: Mapped journal

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/590#discussion_r67806421
  
--- Diff: artemis-journal/pom.xml ---
@@ -15,57 +15,81 @@
   limitations under the License.
 -->
 http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
-   4.0.0
+4.0.0
 
-   
-  org.apache.activemq
-  artemis-pom
-  1.4.0-SNAPSHOT
-   
+
+org.apache.activemq
+artemis-pom
+1.4.0-SNAPSHOT
+
 
-   artemis-journal
-   jar
-   ActiveMQ Artemis Journal
+artemis-journal
+jar
+ActiveMQ Artemis Journal
 
-   
-  ${project.basedir}/..
-   
+
+${project.basedir}/..
+
 
-   
-  
- org.jboss.logging
- jboss-logging-processor
- provided
- true
-  
+
+
+org.jboss.logging
+jboss-logging-processor
+provided
+true
+
 
-  
-  
- org.jboss.logging
- jboss-logging
-  
-  
- org.jboss.logmanager
- jboss-logmanager
- test
-  
-  
- org.apache.activemq
- artemis-commons
- ${project.version}
-  
-  
- org.apache.activemq
- artemis-native
- ${project.version}
-  
-  
-  
- junit
- junit
- test
-  
-   
-
+
+
+org.jboss.logging
+jboss-logging
+
+
+org.jboss.logmanager
+jboss-logmanager
+test
+
+
+org.apache.activemq
+artemis-commons
+${project.version}
+
+
+org.apache.activemq
+artemis-native
+${project.version}
+
+
+
+junit
+junit
+test
+
+
+net.openhft
--- End diff --

And this is the licence for the JMH tool dependences:

http://hg.openjdk.java.net/code-tools/jmh/file/448bd18c85f6/LICENSE
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #590: Mapped journal

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/590#discussion_r67805864
  
--- Diff: artemis-journal/pom.xml ---
@@ -15,57 +15,81 @@
   limitations under the License.
 -->
 http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
-   4.0.0
+4.0.0
 
-   
-  org.apache.activemq
-  artemis-pom
-  1.4.0-SNAPSHOT
-   
+
+org.apache.activemq
+artemis-pom
+1.4.0-SNAPSHOT
+
 
-   artemis-journal
-   jar
-   ActiveMQ Artemis Journal
+artemis-journal
+jar
+ActiveMQ Artemis Journal
 
-   
-  ${project.basedir}/..
-   
+
+${project.basedir}/..
+
 
-   
-  
- org.jboss.logging
- jboss-logging-processor
- provided
- true
-  
+
+
+org.jboss.logging
+jboss-logging-processor
+provided
+true
+
 
-  
-  
- org.jboss.logging
- jboss-logging
-  
-  
- org.jboss.logmanager
- jboss-logmanager
- test
-  
-  
- org.apache.activemq
- artemis-commons
- ${project.version}
-  
-  
- org.apache.activemq
- artemis-native
- ${project.version}
-  
-  
-  
- junit
- junit
- test
-  
-   
-
+
+
+org.jboss.logging
+jboss-logging
+
+
+org.jboss.logmanager
+jboss-logmanager
+test
+
+
+org.apache.activemq
+artemis-commons
+${project.version}
+
+
+org.apache.activemq
+artemis-native
+${project.version}
+
+
+
+junit
+junit
+test
+
+
+net.openhft
--- End diff --

These are the licences of the two OpenHFT's dependences:

https://github.com/OpenHFT/Chronicle-Core/blob/master/LICENSE.adoc
https://github.com/OpenHFT/Java-Thread-Affinity/blob/master/LICENSE

And for JMH i've to check:
http://openjdk.java.net/projects/code-tools/jmh/

All of these are the dependences of the tools used to do the benchmark.

I'll follow this:
https://activemq.apache.org/artemis/docs/1.2.0/hacking-guide/code.html

To add the test dependences or there is something more i need to know?the 
first two licenses are ok?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #590: Mapped journal

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/590#discussion_r67803444
  
--- Diff: artemis-journal/pom.xml ---
@@ -15,57 +15,81 @@
   limitations under the License.
 -->
 http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
-   4.0.0
+4.0.0
 
-   
-  org.apache.activemq
-  artemis-pom
-  1.4.0-SNAPSHOT
-   
+
+org.apache.activemq
+artemis-pom
+1.4.0-SNAPSHOT
+
 
-   artemis-journal
-   jar
-   ActiveMQ Artemis Journal
+artemis-journal
+jar
+ActiveMQ Artemis Journal
 
-   
-  ${project.basedir}/..
-   
+
+${project.basedir}/..
+
 
-   
-  
- org.jboss.logging
- jboss-logging-processor
- provided
- true
-  
+
+
+org.jboss.logging
+jboss-logging-processor
+provided
+true
+
 
-  
-  
- org.jboss.logging
- jboss-logging
-  
-  
- org.jboss.logmanager
- jboss-logmanager
- test
-  
-  
- org.apache.activemq
- artemis-commons
- ${project.version}
-  
-  
- org.apache.activemq
- artemis-native
- ${project.version}
-  
-  
-  
- junit
- junit
- test
-  
-   
-
+
+
+org.jboss.logging
+jboss-logging
+
+
+org.jboss.logmanager
+jboss-logmanager
+test
+
+
+org.apache.activemq
+artemis-commons
+${project.version}
+
+
+org.apache.activemq
+artemis-native
+${project.version}
+
+
+
+junit
+junit
+test
+
+
+net.openhft
--- End diff --

what are these? what's the license?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/548
  
@mtaylor  I want to compare this against #590. Especially on a test that is 
being added. 

Franceso proposed a garbage free approach on the journal that makes sense.. 
and I want to make sure this wouldn't make it inviable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #593: ARTEMIS-585 support send on dynamic sender link

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/593
  
@tabish121  Actually not hang, the receive timeout is 500 seconds, maybe we 
can reduce it to 5?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #593: ARTEMIS-585 support send on dynamic sender link

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/593
  
hmm, when I run the test in failure condition (without fix) it shows the 
correct error message but the test seems hang there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Need Some Guide

[Timothy Bish]

On 06/20/2016 03:57 PM, Dhanika Thathsara wrote:

I am new to the open source community. I would like to contribute to the
activemq project. So I would like to help this project by solving bugs.
So I found this,
https://issues.apache.org/jira/browse/AMQ-6327
So I need help from you guys because I'm a beginner.
Please give me some guide lines to do this.


Best Regards,
Dhanika Thathsara,
University of Peradeniya.(undergrduate).

The project code is located on Github, check out the code and build it 
using maven, once you've tackled that then get it imported into an IDE 
like Eclipse or Idea and get the unit tests running, then start spending 
some time getting familiar with the code, there's tons of unit tests 
already in there dive in.


--
Tim Bish
twitter: @tabish121
blog: http://timbish.blogspot.com/

Need Some Guide

[Dhanika Thathsara]

I am new to the open source community. I would like to contribute to the
activemq project. So I would like to help this project by solving bugs.
So I found this,
https://issues.apache.org/jira/browse/AMQ-6327
So I need help from you guys because I'm a beginner.
Please give me some guide lines to do this.


Best Regards,
Dhanika Thathsara,
University of Peradeniya.(undergrduate).

[GitHub] activemq-artemis pull request #594: ARTEMIS-579 document reload for JAAS mod...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/594

ARTEMIS-579 document reload for JAAS modules



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-579

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/594.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #594


commit e1b6393f70732bdadaa9df5058efbedb7883d824
Author: jbertram 
Date:   2016-06-20T18:40:30Z

ARTEMIS-579 document reload for JAAS modules




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Looking for advice

[Chalaka Chamupathi Sudusinghe]

Hi,

I like to contribute to activemq project but i am new to open source community.
so i clone the project from git hub and open it with eclipse ide and i
was able to build one module at a time.
then i start looking for a bug to start and i found this
"https://issues.apache.org/jira/browse/AMQ-5727; issues to start.

so i like to know, is my approach good or need to change and the bug i
looking is good for beginners or need to change.

-- 
Thanks and Regards,

Chalaka Chamupathi Sudusinghe

Undergraduate at University of Peradeniya Faculty of Engineering.

Email : chalakachamupa...@gmail.com
Linkedin : https://lk.linkedin.com/in/chalakachamupathisudusinghe
Blog   : https://chalakachamupathisudusinghe.blogspot.com
Github: https://github.com/Chalakachamupathi

[GitHub] activemq-artemis pull request #593: ARTEMIS-585 support send on dynamic send...

[tabish121]

GitHub user tabish121 opened a pull request:

https://github.com/apache/activemq-artemis/pull/593

ARTEMIS-585 support send on dynamic sender link

The sender abstraction must be able to update its sender address in the
case of dynamic senders whose target address is not set until the code
initializes the link and creates a destination for it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-585

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/593.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #593


commit bab2438d64d375311ec20a1380b783d28b5c31f4
Author: Timothy Bish 
Date:   2016-06-20T15:34:49Z

ARTEMIS-585 support send on dynamic sender link

The sender abstraction must be able to update its sender address in the
case of dynamic senders whose target address is not set until the code
initializes the link and creates a destination for it.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message

[mtaylor]

Github user mtaylor commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/588#discussion_r67702691
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
 ---
@@ -309,6 +309,12 @@ void slowConsumerDetected(String sessionID,
@Message(id = 221052, value = "trying to deploy topic {0}", format = 
Message.Format.MESSAGE_FORMAT)
void deployTopic(SimpleString topicName);
 
+   @LogMessage(level = Logger.Level.INFO)
--- End diff --

I see.  Merged.  Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/588


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message

[jbertram]

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/588#discussion_r67690084
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
 ---
@@ -309,6 +309,12 @@ void slowConsumerDetected(String sessionID,
@Message(id = 221052, value = "trying to deploy topic {0}", format = 
Message.Format.MESSAGE_FORMAT)
void deployTopic(SimpleString topicName);
 
+   @LogMessage(level = Logger.Level.INFO)
--- End diff --

The ID of the message is tied to the "level" of the message per the JavaDoc 
on the class.  Therefore since the level changed the ID changed as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

[mtaylor]

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/548
  
@clebertsuconic I think we can start looking at this now that we have 1.3.0 
out the door.  Are you able review?  Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #588: ARTEMIS-563 update POODLE message

[mtaylor]

Github user mtaylor commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/588#discussion_r67671276
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
 ---
@@ -309,6 +309,12 @@ void slowConsumerDetected(String sessionID,
@Message(id = 221052, value = "trying to deploy topic {0}", format = 
Message.Format.MESSAGE_FORMAT)
void deployTopic(SimpleString topicName);
 
+   @LogMessage(level = Logger.Level.INFO)
--- End diff --

What is the reason for adding a new message here (with different ID) vs 
just adding the change to the existing message?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #589: ARTEMIS-409 clarify STOMP login failure ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/589


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #591: Fix minor build issue (parent pom versio...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/591


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #592: fixed minor formatting typos

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/592


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #592: fixed minor formatting typos

[LionelCons]

GitHub user LionelCons opened a pull request:

https://github.com/apache/activemq-artemis/pull/592

fixed minor formatting typos



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/LionelCons/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/592.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #592


commit 0ce077eea1917415de846d70cb08419e612e0925
Author: Lionel Cons 
Date:   2016-06-20T07:37:11Z

fixed minor formatting typos




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #591: Fix minor build issue (parent pom versio...

[gaohoward]

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/591

Fix minor build issue (parent pom version)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis master_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/591.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #591


commit e9838611919d5952a65b348761fbbf61f896f02d
Author: Howard Gao 
Date:   2016-06-20T07:14:12Z

Fix minor build issue (parent pom version)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Active MQ Performance

[ActiveMQ Investigation]

Out of two issues, I am able to resolve first one (Queue taking considerable
time on persistent messages). Topic was fast because by default,
concurrentStoreAndDispatchTopics is false for Topic. For Queue, it's
enabled. But main difference was enableJournalDiskSyncs on each message.
>From SAR command, I found that IO wait time was quite high. Sometime 30%. I
switched off enableJournalDiskSyncs and concurrentStoreAndDispatchQueues and
it worked.

I think it's not ideal and makes it less reliable when broker kills but it
works until I find an alternative to wait io.

Still looking into for seconding issue.

Thanks
Ajay Kumar



--
View this message in context: 
http://activemq.2283324.n4.nabble.com/Active-MQ-Performance-tp4712952p4713145.html
Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.