[GitHub] activemq-artemis pull request #617: ARTEMIS-607 Added interceptor support fo...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/617 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #617: ARTEMIS-607 Added interceptor support for MQTT ...
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/617 Ok, I rebased from master and squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #622: ARTEMIS-578 cert authn/z for STOMP
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/622#discussion_r69647599 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java --- @@ -16,6 +16,7 @@ */ package org.apache.activemq.artemis.core.protocol.stomp.v11; +import javax.security.cert.X509Certificate; --- End diff -- This was implemented on core via https://issues.apache.org/jira/browse/ARTEMIS-261. This PR is just for Stomp. I believe other protocols will need to be examined on an individual basis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #622: ARTEMIS-578 cert authn/z for STOMP
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/622#discussion_r69647099 --- Diff: artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v11/StompFrameHandlerV11.java --- @@ -16,6 +16,7 @@ */ package org.apache.activemq.artemis.core.protocol.stomp.v11; +import javax.security.cert.X509Certificate; --- End diff -- this will only work on Stomp? what about other protocols? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #622: ARTEMIS-578 cert authn/z for STOMP
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/622 ARTEMIS-578 cert authn/z for STOMP You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-578 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/622.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #622 commit e706fb899631a37e8bf7ef50fd7e6c76f9215eec Author: jbertram Date: 2016-06-21T17:03:16Z ARTEMIS-578 cert authn/z for STOMP --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #620: ARTEMIS-612 Improving Failback's max rep...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/620 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #621: ARTEMIS-584 add validated user to msg
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/621#discussion_r69644037
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/ActiveMQJAASSecurityManager.java
---
@@ -80,31 +81,41 @@ public ActiveMQJAASSecurityManager(String
configurationName, String certificateC
}
@Override
- public boolean validateUser(String user, String password) {
--- End diff --
I just checked and Wildfly won't build after this change.
I know at least one user who was writing his own SecurityManager, so this
would break not just wildfly.
it's part of the SPI, so we can't change it without breaking API.
as we talked, make a SecurityManager3 and add what you need there, check of
instanceof of the new corrent interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #621: ARTEMIS-584 add validated user to msg
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/621#discussion_r69641957
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/ActiveMQJAASSecurityManager.java
---
@@ -80,31 +81,41 @@ public ActiveMQJAASSecurityManager(String
configurationName, String certificateC
}
@Override
- public boolean validateUser(String user, String password) {
--- End diff --
this may break integration with integrated systems, such as wildfly, but it
applies to any user maybe?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #621: ARTEMIS-584 add validated user to msg
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/621 ARTEMIS-584 add validated user to msg Implements a new feature to aid in security auditing by adding the name of the validated user to the messages it sends. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-584 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/621.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #621 commit 1a6bd8863c56bd3c6c8817261fa5afa738a444f1 Author: jbertram Date: 2016-06-29T02:33:44Z ARTEMIS-584 add validated user to msg Implements a new feature to aid in security auditing by adding the name of the validated user to the messages it sends. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #621: ARTEMIS-584 add validated user to msg
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/621 I ran the full test-suite. There were no new failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #610: Artemis build enhancements
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/610 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #620: ARTEMIS-612 Improving Failback's max rep...
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/620 ARTEMIS-612 Improving Failback's max replication The server will always restart now, with older files being removed. The system will now move current data into ./oldreplica.#, and remove old ones. All the logic for moving these files is encapsulated at FileMoveManager. You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-612 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/620.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #620 commit bbb69b327acc2fc6ed9e0bfa7ff4d13dc95dd777 Author: Clebert Suconic Date: 2016-06-27T18:52:59Z ARTEMIS-612 Improving Failback's max replication The server will always restart now, with older files being removed. The system will now move current data into ./oldreplica.#, and remove old ones. All the logic for moving these files is encapsulated at FileMoveManager. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #610: Artemis build enhancements
Github user glauciom commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/610#discussion_r69613608 --- Diff: pom.xml --- @@ -112,8 +112,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 + 1.8 --- End diff -- Okay, just reverted to 1.7 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #616: Various cleanups
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/616 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #617: ARTEMIS-607 Added interceptor support for MQTT ...
Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/617 Up to you. I won't be able to squash until this evening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/613 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #619: ARTEMIS-610 update clientFailureCheckPer...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/619 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #619: ARTEMIS-610 update clientFailureCheckPer...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/619 ARTEMIS-610 update clientFailureCheckPeriod doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-610 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/619.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #619 commit fd49dc99d193ecab25c54a6dbd96adaecd6f3d7a Author: jbertram Date: 2016-07-05T16:33:16Z ARTEMIS-610 update clientFailureCheckPeriod doc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #610: Artemis build enhancements
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/610#discussion_r69594043 --- Diff: pom.xml --- @@ -112,8 +112,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 + 1.8 --- End diff -- I would just leave 1.7, until there is a good reason to be 1.8. that way we would move the codebase to 1.8 on purpose, where there is the API need. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #617: ARTEMIS-607 Added interceptor support for MQTT ...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/617 These look good.. I can squash them at the time of the merge. I will run the whole testsuite just in case. (It takes 2 hours or so now) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/613#discussion_r69583184 --- Diff: examples/features/standard/rest/dup-send/README.txt --- @@ -1,5 +1,5 @@ System Requirements: -You will need JDK 1.6 and Maven to run this example. This example has been tested with Maven 2.2.1. It may or may not work +You will need JDK 1.8 and Maven to run this example. This example has been tested with Maven 3.3.3. It may or may not work --- End diff -- We can probably leave 1.8 on the docs, and still let the build to work with 1.7. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Time for yet another board report, please lend a hand
Hi All,
I hope everyone in the northern hemisphere is enjoying their summer.
It is that time again, please take a few moments to help compile the
development activity within the project over the last three months:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65145183
Your assistance with this matter is greatly appreciated,
Bruce
--
perl -e 'print
unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61Ehttp://bit.ly/2je6cQ
Blog: http://bsnyder.org/
[GitHub] activemq-artemis pull request #618: Upgrade ApacheRat to 0.12
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/618 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #617: ARTEMIS-607 Added interceptor support for MQTT ...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/617 Could you squash these two commits together? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: RAT Checks get stuck on Artemis Integration Test Module
Changing to the -n option to -f gives a preview listing of what would be deleted. You can use -e flags to prevent deleting certain things, like any IDE config dirs. On 5 July 2016 at 00:26, John D. Ament wrote: > Doing a git clean fixed it. But last time I blindly run a command I get > from the internet, killed my IDE. > > > > On Mon, Jul 4, 2016 at 12:37 PM Martyn Taylor wrote: > >> Hi John, >> >> I believe there is an issue in Apache Rat 0.11 that will sometimes result >> in the maven build hanging during a license check when an unlicensed file >> is present. If this happens check the folder root directory for unlicensed >> files (eventually the Rat check will complete but it can hang for a long >> time). >> >> I've opened an Artemis PR to upgrade Rat to 0.12 that should address the >> issue going forward. >> >> Cheers >> Martyn >> >> On Mon, Jul 4, 2016 at 3:03 PM, Clebert Suconic > > >> wrote: >> >> > Try cleaning the env. >> > >> > Git clean -xdf >> > Then repeat ? >> > >> > On Monday, July 4, 2016, John D. Ament wrote: >> > >> > > While building the profile from the PR builder, the RAT checks seem to >> > get >> > > stuck on my machine. It's not a slow machine by any means - OS X >> > 10.11.5, >> > > 2.3 ghz i7 w/ 16 gb ram. >> > > >> > > It gets to this point in the build and just stalls. Anyone else get >> > this? >> > > >> > > John >> > > >> > > [INFO] --- maven-checkstyle-plugin:2.17:check (default) @ >> > integration-tests >> > > --- >> > > [INFO] Starting audit... >> > > Audit done. >> > > [INFO] >> > > [INFO] --- apache-rat-plugin:0.11:check (default) @ integration-tests >> --- >> > > [INFO] 51 implicit excludes (use -debug for more details). >> > > [INFO] Exclude: **/*.txt >> > > [INFO] Exclude: **/*.md >> > > [INFO] Exclude: etc/org.eclipse.* >> > > [INFO] Exclude: docs/**/*.json >> > > [INFO] Exclude: docs/**/_book/ >> > > [INFO] Exclude: **/target/ >> > > [INFO] Exclude: **/META-INF/services/* >> > > [INFO] Exclude: **/*.iml >> > > [INFO] Exclude: **/*.jceks >> > > [INFO] Exclude: **/*.jks >> > > [INFO] Exclude: **/org/apache/activemq/artemis/utils/json/** >> > > [INFO] Exclude: **/org/apache/activemq/artemis/utils/Base64.java >> > > [INFO] Exclude: **/.settings/** >> > > [INFO] Exclude: **/.project >> > > [INFO] Exclude: **/.classpath >> > > [INFO] Exclude: **/.checkstyle >> > > [INFO] Exclude: **/.factorypath >> > > [INFO] Exclude: ratReport.txt >> > > [INFO] Exclude: **/org.apache.activemq.artemis.cfg >> > > [INFO] Exclude: **/*.data >> > > [INFO] Exclude: **/*.bin >> > > [INFO] Exclude: **/src/test/resources/keystore >> > > [INFO] Exclude: **/*.log >> > > [INFO] Exclude: **/*.redo >> > > [INFO] Exclude: **/node/** >> > > [INFO] Exclude: **/node_modules/** >> > > [INFO] Exclude: **/package.json >> > > [INFO] Exclude: **/npm-shrinkwrap.json >> > > [INFO] Exclude: **/CMakeCache.txt >> > > [INFO] Exclude: **/CMakeFiles/ >> > > [INFO] Exclude: **/Makefile >> > > [INFO] Exclude: **/cmake_install.cmake >> > > [INFO] Exclude: >> > > >> > > >> > >> artemis-native/src/main/c/org_apache_activemq_artemis_jlibaio_LibaioContext.h >> > > [INFO] 576 resources included (use -debug for more details) >> > > >> > >> > >> > -- >> > Clebert Suconic >> > >>
