[GitHub] activemq-artemis issue #782: ARTEMIS-738 Improving TX support on AMQP

2016-09-19 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/782
  
Please, don't merge this yet...  there's an issue with connections dropping 
and rolling back TXs.

The Transactions should be at the connection and should be rolled back when 
the connection failed. I will ammend this tomorrow. It's a small refactoring 
and I should finish it quickly.


But this serves as a review point already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #782: ARTEMIS-738 Improving TX support on AMQP

2016-09-19 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/782

ARTEMIS-738 Improving TX support on AMQP

https://issues.apache.org/jira/browse/ARTEMIS-738

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis tx

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #782


commit c98988219ec2b5b77d74ff435064359b741d03cf
Author: Clebert Suconic 
Date:   2016-09-15T19:28:07Z

ARTEMIS-738 Improving TX support on AMQP

https://issues.apache.org/jira/browse/ARTEMIS-738




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #781: ARTEMIS-715 messages could be sent to wr...

2016-09-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/781


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #781: ARTEMIS-715 messages could be sent to wr...

2016-09-19 Thread treblereel
GitHub user treblereel opened a pull request:

https://github.com/apache/activemq-artemis/pull/781

ARTEMIS-715 messages could be sent to wrong queue

In rare circumstances MessageProducer can send a message
to wrong queue

JIRA: https://issues.apache.org/jira/browse/ARTEMIS-715


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/treblereel/activemq-artemis-wildfly 
ARTEMIS-715_upstream

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/781.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #781


commit 379747981400f26cf6dd96ac89d843e840b32cff
Author: Dmitrii Tikhomirov 
Date:   2016-09-19T17:00:21Z

ARTEMIS-715 messages could be sent to wrong queue

In rare circumstances MessageProducer can send a message
to wrong queue




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---