date:20160921

[GitHub] activemq-artemis pull request #782: ARTEMIS-738 Improving TX support on AMQP

2016-09-21 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/782


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: AddressSize show a negative number. Why?

2016-09-21 Thread Clebert Suconic

would need a way to replicate the issue. or more information on how
you got into that.

On Wed, Sep 21, 2016 at 5:07 PM, Fabio Gomes dos Santos
 wrote:
> Does the anyone know why the AddressSize shows a negative number on jmx?
>
> The queue as no message, but return this:
>
>
> ```NameValue   TypeDisplay NameUpdate Interval Description
> AddressSize -3636362longAddressSize -1  N/A
> ```
>
> --
> Fábio Santos
> supergr...@gmail.com
> 



-- 
Clebert Suconic

[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
@hqstevenson  are you getting notifications for these questions? either 
here or dev-list


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...

2016-09-21 Thread johnament

Github user johnament commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
@clebertsuconic agreed.  This does look like an awesome idea though for end 
users trying to test with messaging systems.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
I guess this is intended for users to use on their tests?

What was the intention, to refactor Artemis' testsuite, or to provide rules 
for users running their own tests?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...

2016-09-21 Thread jbertram

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
I think it would also be good to have a clear explanation of why this 
approach is superior to the approach already adopted in the test-suite.

Additional questions:

1. What expectation is there to adopt this style of testing?  Should all 
new tests use this style?
2. Do you plan on converting all existing test-cases to this style?  If 
not, I'd be concerned with having 2 methods of doing the same thing introducing 
confusion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #787: ARTEMIS-743 Default the queue address to the qu...

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/787
  
just to let you guys know.. I ran the testsuite and only got a few known 
failures. looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
This looks a great idea...


however.. there's no docs on how to use this. it would warrant a chapter on 
the user-docs..

and maybe examples on how to run tests with it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #789: ARTEMIS-737 - added JUnit rules for Arte...

2016-09-21 Thread hqstevenson

GitHub user hqstevenson opened a pull request:

https://github.com/apache/activemq-artemis/pull/789

ARTEMIS-737 - added JUnit rules for Artemis servers and clients



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hqstevenson/activemq-artemis ARTEMIS-737

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/789.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #789


commit c79d00b78c23f55af88c94507c0a5ec8325cf893
Author: Quinn Stevenson 
Date:   2016-09-21T21:45:05Z

ARTEMIS-737 - added JUnit rules for Artemis servers and clients




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #784: ARTEMIS-740 Auto-reload diverts from bro...

2016-09-21 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/784


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

AddressSize show a negative number. Why?

2016-09-21 Thread Fabio Gomes dos Santos

Does the anyone know why the AddressSize shows a negative number on jmx?

The queue as no message, but return this:


```NameValue   TypeDisplay NameUpdate Interval Description
AddressSize -3636362longAddressSize -1  N/A
```

-- 
Fábio Santos
supergr...@gmail.com

[GitHub] activemq-artemis pull request #741: ARTEMIS-702 JMS 2 spec violation for rec...

2016-09-21 Thread jbertram

Github user jbertram closed the pull request at:

https://github.com/apache/activemq-artemis/pull/741


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #783: Rename misleading divertBindingNotExists...

2016-09-21 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/783


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #785: Add missing @Overrides, flag as error in...

2016-09-21 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/785


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #787: ARTEMIS-743 Default the queue address to the qu...

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/787
  
I am happy with this. +1 for merge...

Two small TODOS I would remove now.. but other than that good to merge...

Will let @mtaylor also to comment on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/787#discussion_r79924952
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueConfig.java
 ---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.server;
+
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.filter.Filter;
+import org.apache.activemq.artemis.core.filter.FilterUtils;
+import org.apache.activemq.artemis.core.paging.PagingManager;
+import org.apache.activemq.artemis.core.paging.cursor.PageSubscription;
+
+public final class QueueConfig {
+
+   private final long id;
+   private final SimpleString address;
+   private final SimpleString name;
+   private final Filter filter;
+   private final PageSubscription pageSubscription;
+   private final SimpleString user;
+   private final boolean durable;
+   private final boolean temporary;
+   private final boolean autoCreated;
+
+   public static final class Builder {
+
+  private final long id;
+  private final SimpleString address;
+  private final SimpleString name;
+  private Filter filter;
+  private PagingManager pagingManager;
+  private SimpleString user;
+  private boolean durable;
+  private boolean temporary;
+  private boolean autoCreated;
+
+  private Builder(final long id, final SimpleString name) {
+ this(id, name, name);
+  }
+
+  private Builder(final long id, final SimpleString name, final 
SimpleString address) {
+ //TODO Checks if what are valid default values and/or enforces 
not mandatory fields to be on Builder's constructor
+ this.id = id;
+ this.name = name;
+ this.address = address;
+ this.filter = null;
+ this.pagingManager = null;
+ this.user = null;
+ this.durable = true;
+ this.temporary = false;
+ this.autoCreated = true;
+ validateState();
+  }
+
+  //TODO maybe an SimpleString::isEmpty method would be welcome
--- End diff --

I would remove this TODO as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/787#discussion_r79924920
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueConfig.java
 ---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.server;
+
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.filter.Filter;
+import org.apache.activemq.artemis.core.filter.FilterUtils;
+import org.apache.activemq.artemis.core.paging.PagingManager;
+import org.apache.activemq.artemis.core.paging.cursor.PageSubscription;
+
+public final class QueueConfig {
+
+   private final long id;
+   private final SimpleString address;
+   private final SimpleString name;
+   private final Filter filter;
+   private final PageSubscription pageSubscription;
+   private final SimpleString user;
+   private final boolean durable;
+   private final boolean temporary;
+   private final boolean autoCreated;
+
+   public static final class Builder {
+
+  private final long id;
+  private final SimpleString address;
+  private final SimpleString name;
+  private Filter filter;
+  private PagingManager pagingManager;
+  private SimpleString user;
+  private boolean durable;
+  private boolean temporary;
+  private boolean autoCreated;
+
+  private Builder(final long id, final SimpleString name) {
+ this(id, name, name);
+  }
+
+  private Builder(final long id, final SimpleString name, final 
SimpleString address) {
+ //TODO Checks if what are valid default values and/or enforces 
not mandatory fields to be on Builder's constructor
--- End diff --

I would remove this TODO


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/788


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #782: ARTEMIS-738 Improving TX support on AMQP

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/782
  
@mtaylor / @gemmellr  This is now ready to merge... 

(tagging you guys since you both commented on this PR before)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/788#discussion_r79900443
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
 ---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
   LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
 fi
 
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+  LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+  LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+  LIBRARY_PATH=""
--- End diff --

Actually no, the ./artemis create will use the libaio to determine the 
journal type (if it can't load libaio, it won't use it).. and it will also 
perform a sync on the system to calculate the timed-buffer values.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/788#discussion_r79900532
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
 ---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
   LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
 fi
 
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+  LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+  LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+  LIBRARY_PATH=""
--- End diff --

if ./create can't find libaio, the configuration will be set to NIO and aio 
won't be used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread jbertram

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/788#discussion_r79899679
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
 ---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
   LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
 fi
 
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+  LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+  LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+  LIBRARY_PATH=""
--- End diff --

We only need to set the library path for the actual broker instance, right? 
 We don't need to set it for the other CLI commands.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread jbertram

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/788#discussion_r79899253
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
 ---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
   LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
 fi
 
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+  LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+  LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+  LIBRARY_PATH=""
--- End diff --

If the user is on a Linux system then I would expect `uname -a` to return 
`x86_64` or `i686`.  My thought here was to avoid setting the library path for 
systems where `uname -a` returned something other than what we support 
out-of-the-box.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/788#discussion_r79898185
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
 ---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
   LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
 fi
 
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+  LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+  LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+  LIBRARY_PATH=""
--- End diff --

There are two artemis I think.. one for the distribution, one for the 
instance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/788#discussion_r79898051
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
 ---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
   LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
 fi
 
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+  LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+  LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+  LIBRARY_PATH=""
--- End diff --

We need something here in case of else.

Say you are on a Linux for a new System, and the user compiled the library 
himself. on that case you need something on the LD_LIBRARY_PATH to work.

Maybe we could have the x86_64 here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib

2016-09-21 Thread jbertram

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/788

ARTEMIS-732 loading wrong arch lib



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-732

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/788.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #788


commit 1f4a768b1bf58c1e5fd1b9e1df85ac94ae533037
Author: jbertram 
Date:   2016-09-21T17:41:22Z

ARTEMIS-732 loading wrong arch lib




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: No formal RAR distribution for Artemis?

2016-09-21 Thread Clebert Suconic

We can make any required changes. I don't think it was really
intentional other than.. nobody extending it.. lets make it final ;)

Once you have a PR  / diff whatever I will take a look.. I want to
make sure wildfly works.. I think Artemis should have as many Servers
as possible integrated.


If we can make it with a single RA... even better. (I hope this won't
endup with multiple ResourceAdapters imlementations.. one for each
server).

On Wed, Sep 21, 2016 at 10:33 AM, John D. Ament  wrote:
> Yes, I believe we have a mostly working RA in TomEE now.  The main change
> was something identified a while ago, the Resource Adapter class has to
> have an interface and be non-final.  We were able to get that working for
> the most part in TomEE, where connection factories are injected from
> artemis.  We ran into an issue with the MDB listening, but suspect its an
> issue on the TomEE side.  Do you happen to know if the final declarations
> were intentional (and perhaps I'm forgetting something)?
>
> All in all, it worked pretty well.  I have a JIRA to create and Jon F has
> the code changes to go in.
>
> John
>
> On Wed, Sep 21, 2016 at 7:15 AM Clebert Suconic 
> wrote:
>
>> There's the artemis-ra where all the classes are.
>>
>> That artemis-ra is just for the packaging for the ra.xml
>>
>> Maybe we should move it somewhere else.
>>
>>
>>
>>
>> Did you guys get to any code changes required?
>>
>> On Tue, Sep 20, 2016 at 6:58 PM, John D. Ament 
>> wrote:
>> > Hey,
>> >
>> > Just wrapped up the hacking.  Its looking good so far.  Just curious, one
>> > of the issues that was encountered is that there's no default rar
>> generated
>> > for Artemis.  Should there be?  there's an example that ships, maybe it
>> > would make sense to include this in the main packages?
>> >
>> >
>> https://github.com/apache/activemq-artemis/tree/master/examples/features/sub-modules/artemis-ra-rar
>> >
>> > I'm also wondering how other containers may package this up.
>> >
>> > John
>>
>>
>>
>> --
>> Clebert Suconic
>>



-- 
Clebert Suconic

[GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...

2016-09-21 Thread franz1981

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/787#discussion_r79863944
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
 ---
@@ -1290,10 +1291,7 @@ protected ServerSessionImpl 
internalCreateSession(String name,
  SessionCallback 
callback,
  OperationContext 
context,
  boolean 
autoCreateJMSQueues) throws Exception {
-  return new ServerSessionImpl(name, username, password, 
validatedUser, minLargeMessageSize, autoCommitSends, autoCommitAcks, 
preAcknowledge, configuration.isPersistDeliveryCountBeforeDelivery(),
-   xa, connection, storageManager, 
postOffice, resourceManager, securityStore, managementService, this, 
configuration.getManagementAddress(),
-   defaultAddress == null ? null : new 
SimpleString(defaultAddress), callback, context, autoCreateJMSQueues ? 
jmsQueueCreator : null,
-   pagingManager);
+  return new ServerSessionImpl(name, username, password, 
validatedUser, minLargeMessageSize, autoCommitSends, autoCommitAcks, 
preAcknowledge, configuration.isPersistDeliveryCountBeforeDelivery(), xa, 
connection, storageManager, postOffice, resourceManager, securityStore, 
managementService, this, configuration.getManagementAddress(), defaultAddress 
== null ? null : new SimpleString(defaultAddress), callback, context, 
autoCreateJMSQueues ? jmsQueueCreator : null, pagingManager);
--- End diff --

Yes! 
And then i'll squash the commit!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/787#discussion_r79863285
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueConfig.java
 ---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.server;
+
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.filter.Filter;
+import org.apache.activemq.artemis.core.filter.FilterUtils;
+import org.apache.activemq.artemis.core.paging.PagingManager;
+import org.apache.activemq.artemis.core.paging.cursor.PageSubscription;
+
+public final class QueueConfig {
+
+   private final long id;
--- End diff --

ahhh... this is an internal class. I thought it was part of the interface 
now.

Never mind then


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/787#discussion_r79860213
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
 ---
@@ -1290,10 +1291,7 @@ protected ServerSessionImpl 
internalCreateSession(String name,
  SessionCallback 
callback,
  OperationContext 
context,
  boolean 
autoCreateJMSQueues) throws Exception {
-  return new ServerSessionImpl(name, username, password, 
validatedUser, minLargeMessageSize, autoCommitSends, autoCommitAcks, 
preAcknowledge, configuration.isPersistDeliveryCountBeforeDelivery(),
-   xa, connection, storageManager, 
postOffice, resourceManager, securityStore, managementService, this, 
configuration.getManagementAddress(),
-   defaultAddress == null ? null : new 
SimpleString(defaultAddress), callback, context, autoCreateJMSQueues ? 
jmsQueueCreator : null,
-   pagingManager);
+  return new ServerSessionImpl(name, username, password, 
validatedUser, minLargeMessageSize, autoCommitSends, autoCommitAcks, 
preAcknowledge, configuration.isPersistDeliveryCountBeforeDelivery(), xa, 
connection, storageManager, postOffice, resourceManager, securityStore, 
managementService, this, configuration.getManagementAddress(), defaultAddress 
== null ? null : new SimpleString(defaultAddress), callback, context, 
autoCreateJMSQueues ? jmsQueueCreator : null, pagingManager);
--- End diff --

this line gets too big.. can you break it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #787: ARTEMIS-743 Default the queue address to...

2016-09-21 Thread clebertsuconic

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/787#discussion_r79860068
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/QueueConfig.java
 ---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.server;
+
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.filter.Filter;
+import org.apache.activemq.artemis.core.filter.FilterUtils;
+import org.apache.activemq.artemis.core.paging.PagingManager;
+import org.apache.activemq.artemis.core.paging.cursor.PageSubscription;
+
+public final class QueueConfig {
+
+   private final long id;
--- End diff --

The id is assigned when the queue is persisted. Why this is part of the 
config options?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #786: ARTEMIS-742 = replication quorum broken

2016-09-21 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/786


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: No formal RAR distribution for Artemis?

2016-09-21 Thread John D. Ament

Yes, I believe we have a mostly working RA in TomEE now.  The main change
was something identified a while ago, the Resource Adapter class has to
have an interface and be non-final.  We were able to get that working for
the most part in TomEE, where connection factories are injected from
artemis.  We ran into an issue with the MDB listening, but suspect its an
issue on the TomEE side.  Do you happen to know if the final declarations
were intentional (and perhaps I'm forgetting something)?

All in all, it worked pretty well.  I have a JIRA to create and Jon F has
the code changes to go in.

John

On Wed, Sep 21, 2016 at 7:15 AM Clebert Suconic 
wrote:

> There's the artemis-ra where all the classes are.
>
> That artemis-ra is just for the packaging for the ra.xml
>
> Maybe we should move it somewhere else.
>
>
>
>
> Did you guys get to any code changes required?
>
> On Tue, Sep 20, 2016 at 6:58 PM, John D. Ament 
> wrote:
> > Hey,
> >
> > Just wrapped up the hacking.  Its looking good so far.  Just curious, one
> > of the issues that was encountered is that there's no default rar
> generated
> > for Artemis.  Should there be?  there's an example that ships, maybe it
> > would make sense to include this in the main packages?
> >
> >
> https://github.com/apache/activemq-artemis/tree/master/examples/features/sub-modules/artemis-ra-rar
> >
> > I'm also wondering how other containers may package this up.
> >
> > John
>
>
>
> --
> Clebert Suconic
>

Re: No formal RAR distribution for Artemis?

2016-09-21 Thread Clebert Suconic

There's the artemis-ra where all the classes are.

That artemis-ra is just for the packaging for the ra.xml

Maybe we should move it somewhere else.




Did you guys get to any code changes required?

On Tue, Sep 20, 2016 at 6:58 PM, John D. Ament  wrote:
> Hey,
>
> Just wrapped up the hacking.  Its looking good so far.  Just curious, one
> of the issues that was encountered is that there's no default rar generated
> for Artemis.  Should there be?  there's an example that ships, maybe it
> would make sense to include this in the main packages?
>
> https://github.com/apache/activemq-artemis/tree/master/examples/features/sub-modules/artemis-ra-rar
>
> I'm also wondering how other containers may package this up.
>
> John



-- 
Clebert Suconic

[GitHub] activemq-artemis pull request #787: ENTMQ-1844 Default the queue address to ...

2016-09-21 Thread franz1981

GitHub user franz1981 opened a pull request:

https://github.com/apache/activemq-artemis/pull/787

ENTMQ-1844 Default the queue address to the queue name

https://issues.jboss.org/browse/ENTMQ-1844

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/franz1981/activemq-artemis 
default_queue_address_to_name

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/787.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #787


commit 97ed77d8b577b638ad39e806101d1f3f1c2841ad
Author: Francesco Nigro 
Date:   2016-09-20T20:39:28Z

Created QueueConfig that replace and enable additional behaviours on 
QueueFactory.
Added Filter predicate.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #786: ARTEMIS-742 = replication quorum broken

2016-09-21 Thread andytaylor

GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/786

ARTEMIS-742 = replication quorum broken

https://issues.apache.org/jira/browse/ARTEMIS-742

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-artemis splitbrain

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/786.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #786


commit 680f84b5a28b8f1af85640a32c2c0b936a890d5a
Author: Andy Taylor 
Date:   2016-09-06T10:49:23Z

ARTEMIS-742 = replication quorum broken

https://issues.apache.org/jira/browse/ARTEMIS-742




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #785: Add missing @Overrides, flag as error in...

2016-09-21 Thread scop

GitHub user scop opened a pull request:

https://github.com/apache/activemq-artemis/pull/785

Add missing @Overrides, flag as error in IDEs



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scop/activemq-artemis overrides

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/785.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #785


commit a7820474c8b674a55a4136ea12fe6e8e8c303af8
Author: Ville SkyttÃ¤ 
Date:   2016-09-21T10:15:12Z

Add missing @Overrides

commit 723ed97c7ae047965a79ecd74fab757da14637ac
Author: Ville SkyttÃ¤ 
Date:   2016-09-21T10:30:52Z

Add IDEA inspection settings, flag missing @Override as error

commit 4d202f777ae7b94ada9b774184ef454974af018f
Author: Ville SkyttÃ¤ 
Date:   2016-09-21T10:45:42Z

Flag missing @Override as error in Eclipse




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #784: ARTEMIS-740 Auto-reload diverts from bro...

2016-09-21 Thread scop

GitHub user scop opened a pull request:

https://github.com/apache/activemq-artemis/pull/784

ARTEMIS-740 Auto-reload diverts from broker.xml



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scop/activemq-artemis divert-reload

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/784.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #784


commit 520422934bf4e3e18efc93210b0fd27d1c95c084
Author: Ville SkyttÃ¤ 
Date:   2016-09-21T09:13:31Z

ARTEMIS-740 Auto-reload diverts from broker.xml




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

38 matches

Mail list logo