Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Clebert Suconic
WOW... nice graphs It would be great to have those as part of the
codebase somehow. What you guys think?

On Fri, Oct 7, 2016 at 7:46 PM, Fabio Gomes dos Santos
 wrote:
> https://postimg.org/image/rd4wygyt7/
> https://postimg.org/image/tt6qcbgvv/
>
> 2016-10-07 20:36 GMT-03:00 Clebert Suconic :
>
>> I don't think the attachments com through dev list.
>> I don't see an attachment at least.
>>
>> Probably better to provide a link somewhere ?
>>
>>
>>
>> On Friday, October 7, 2016, Fabio Gomes dos Santos 
>> wrote:
>>
>> > TL;DR
>> >
>> > but i believe you will appreciate this screenshots
>> > i have used zabbix to collect metrics and generate alerts, and used
>> > grafana like a passive artemis dashboard.
>> >
>> > Basically grafana use zabbix like a data store via api.
>> >
>> > i have plan to write a article about how do that soon
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> > 2016-10-07 19:54 GMT-03:00 Clebert Suconic > > >:
>> >
>> >> a consolidated repo for AMQ and Artemis might be useful for other
>> >> stuff as well. not just the web console.
>> >>
>> >> On Fri, Oct 7, 2016 at 5:49 PM, John D. Ament > >> > wrote:
>> >> > I think I just saw two great ideas:
>> >> >
>> >> > - A consolidated web console that is usable by both ActiveMQ and
>> >> Artemis.
>> >> > - It should be an independent repository/utility.
>> >> >
>> >> > I think all of the discussions are happening on a ML, but
>> realistically
>> >> if
>> >> > we're ready to start writing down some code, we need some of those
>> >> > utilities in place.  Since PRs are mirrored to the MLs that would
>> work,
>> >> but
>> >> > I would hate to see it baked into one of the existing repos to make
>> that
>> >> > happen.
>> >> >
>> >> > John
>> >> >
>> >> > On Fri, Oct 7, 2016 at 5:41 PM Jim Gomes > >> > wrote:
>> >> >
>> >> >> I was under the impression that all Apache development discussions
>> >> occur on
>> >> >> the email list. This is for legal and policy reasons. Please correct
>> >> me if
>> >> >> I'm wrong.
>> >> >>
>> >> >> On Fri, Oct 7, 2016, 9:43 AM Clebert Suconic <
>> >> clebert.suco...@gmail.com
>> >> >
>> >> >> wrote:
>> >> >>
>> >> >> > I think this is pretty straightforward:
>> >> >> >
>> >> >> > i - it should relay on JMX or jolokia.. A common thing between both
>> >> >> > Artemis and ActiveMQ
>> >> >> >
>> >> >> > ii - it should manage at least a single broker.. with some
>> metrics...
>> >> >> >
>> >> >> >
>> >> >> > iii - anything beyond that will just be a collaboration over the
>> >> code.
>> >> >> >
>> >> >> >
>> >> >> > The best way to discuss this IMO would be through a Pull Request..
>> >> >> > someone send an initial draft.. we can have some **technical**
>> >> >> > discussion over of PR, and commit it as version 1... then
>> >> >> > collaboratively this could be increased just as with anything else.
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> > I think we are clear from the previous discussions... and that's a
>> >> >> > request I am making here, probably the third time... lets
>> >> CTRL-Alt-Del
>> >> >> > and start fresh... The issues we had are clear... and I see
>> everybody
>> >> >> > with a single goal here.. to have an integrated console that looks
>> >> >> > like an Apache project, pretty and neat.
>> >> >> >
>> >> >> >
>> >> >> > Once someone put a first version, we can only improve it from
>> there.
>> >> >> >
>> >> >> > On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea <
>> hzbar...@gmail.com
>> >> >
>> >> >> > wrote:
>> >> >> > > I would suggest discussing the goals for such a console first. Is
>> >> it
>> >> >> > > intended to monitory just one broker instance or a whole network
>> of
>> >> >> > brokers?
>> >> >> > > Should it manage just the brokers or other services? Should it
>> >> rely on
>> >> >> > JMX
>> >> >> > > or something else?
>> >> >> > >
>> >> >> > > Then one can think about reusing and/or improving something
>> that's
>> >> >> > available
>> >> >> > > or some other solution.
>> >> >> > >
>> >> >> > > The way this discuss goes, sounds to me like trying to push again
>> >> for
>> >> >> > > something that was rejected in the past and I suspect will not go
>> >> >> > anywhere.
>> >> >> > >
>> >> >> > > My $0.02,
>> >> >> > > Hadrian
>> >> >> > >
>> >> >> > >
>> >> >> > > On 10/07/2016 06:41 AM, Martyn Taylor wrote:
>> >> >> > >>
>> >> >> > >> +1 on improving/adding a console.  Providing a console out of
>> the
>> >> box
>> >> >> > is a
>> >> >> > >> massive win for user experience imo and something that I feel
>> >> Artemis
>> >> >> > >> would
>> >> >> > >> greatly benefit from.  Whether it's HawtIO or something else we
>> >> should
>> >> >> > >> make
>> >> >> > >> every effort to standardise across both 5.x and Artemis.
>> >> >> > >>
>> >> >> > >> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
>> >> >> > >> > >> >
>> >> >> > >> wrote:
>> >> >> > >>
>> >> >> > >>> On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament <
>> >> >> johndam...@apache.org
>> >> >
>> >> >> > >>> wrote:
>> >> >> > 
>> >> >> >  @

Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Jim Gomes
Got it. I haven't used pull requests before, but that sounds great to me if
others will find it a better workflow. Will those who don't use git be able
to participate through the mail list interface? Some systems gave that kind
of ability.


On Fri, Oct 7, 2016, 3:29 PM Clebert Suconic 
wrote:

> On Fri, Oct 7, 2016 at 5:40 PM, Jim Gomes  wrote:
> > I was under the impression that all Apache development discussions occur
> on
> > the email list.
>
> As Justin Bertram Said, all PR comments are sent to the dev-list.
>
> What I'm really proposing, it's to be practical... to have something
> concrete to talk about on top of the code.
>
>
>
>  Clebert Suconic 
> > wrote:
> >
> >> I think this is pretty straightforward:
> >>
> >> i - it should relay on JMX or jolokia.. A common thing between both
> >> Artemis and ActiveMQ
> >>
> >> ii - it should manage at least a single broker.. with some metrics...
> >>
> >>
> >> iii - anything beyond that will just be a collaboration over the code.
> >>
> >>
> >> The best way to discuss this IMO would be through a Pull Request..
> >> someone send an initial draft.. we can have some **technical**
> >> discussion over of PR, and commit it as version 1... then
> >> collaboratively this could be increased just as with anything else.
> >>
> >>
> >>
> >> I think we are clear from the previous discussions... and that's a
> >> request I am making here, probably the third time... lets CTRL-Alt-Del
> >> and start fresh... The issues we had are clear... and I see everybody
> >> with a single goal here.. to have an integrated console that looks
> >> like an Apache project, pretty and neat.
> >>
> >>
> >> Once someone put a first version, we can only improve it from there.
> >>
> >> On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea 
> >> wrote:
> >> > I would suggest discussing the goals for such a console first. Is it
> >> > intended to monitory just one broker instance or a whole network of
> >> brokers?
> >> > Should it manage just the brokers or other services? Should it rely on
> >> JMX
> >> > or something else?
> >> >
> >> > Then one can think about reusing and/or improving something that's
> >> available
> >> > or some other solution.
> >> >
> >> > The way this discuss goes, sounds to me like trying to push again for
> >> > something that was rejected in the past and I suspect will not go
> >> anywhere.
> >> >
> >> > My $0.02,
> >> > Hadrian
> >> >
> >> >
> >> > On 10/07/2016 06:41 AM, Martyn Taylor wrote:
> >> >>
> >> >> +1 on improving/adding a console.  Providing a console out of the box
> >> is a
> >> >> massive win for user experience imo and something that I feel Artemis
> >> >> would
> >> >> greatly benefit from.  Whether it's HawtIO or something else we
> should
> >> >> make
> >> >> every effort to standardise across both 5.x and Artemis.
> >> >>
> >> >> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
> >> >> 
> >> >> wrote:
> >> >>
> >> >>> On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament <
> johndam...@apache.org>
> >> >>> wrote:
> >> 
> >>  @Hiram
> >> 
> >>  The website branding says otherwise (take a look at the top right
> >> >>>
> >> >>> corner).
> >> >>>
> >> >>>
> >> >>> That symbol on the top is just a link to the following:
> >> >>>
> >> >>> "Like hawtio? It’s part of a community of Red Hat projects. Learn
> more
> >> >>> about Red Hat and our open source communities:"
> >> >>>
> >> >>>
> >> >>>
> >> >>>  No other implications from what I see.
> >> >>>
> >> >>
> >> >
> >>
> >>
> >>
> >> --
> >> Clebert Suconic
> >>
>
>
>
> --
> Clebert Suconic
>


Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Fabio Gomes dos Santos
https://postimg.org/image/rd4wygyt7/
https://postimg.org/image/tt6qcbgvv/

2016-10-07 20:36 GMT-03:00 Clebert Suconic :

> I don't think the attachments com through dev list.
> I don't see an attachment at least.
>
> Probably better to provide a link somewhere ?
>
>
>
> On Friday, October 7, 2016, Fabio Gomes dos Santos 
> wrote:
>
> > TL;DR
> >
> > but i believe you will appreciate this screenshots
> > i have used zabbix to collect metrics and generate alerts, and used
> > grafana like a passive artemis dashboard.
> >
> > Basically grafana use zabbix like a data store via api.
> >
> > i have plan to write a article about how do that soon
> >
> >
> >
> > ​
> >
> >
> >
> > 2016-10-07 19:54 GMT-03:00 Clebert Suconic  > >:
> >
> >> a consolidated repo for AMQ and Artemis might be useful for other
> >> stuff as well. not just the web console.
> >>
> >> On Fri, Oct 7, 2016 at 5:49 PM, John D. Ament  >> > wrote:
> >> > I think I just saw two great ideas:
> >> >
> >> > - A consolidated web console that is usable by both ActiveMQ and
> >> Artemis.
> >> > - It should be an independent repository/utility.
> >> >
> >> > I think all of the discussions are happening on a ML, but
> realistically
> >> if
> >> > we're ready to start writing down some code, we need some of those
> >> > utilities in place.  Since PRs are mirrored to the MLs that would
> work,
> >> but
> >> > I would hate to see it baked into one of the existing repos to make
> that
> >> > happen.
> >> >
> >> > John
> >> >
> >> > On Fri, Oct 7, 2016 at 5:41 PM Jim Gomes  >> > wrote:
> >> >
> >> >> I was under the impression that all Apache development discussions
> >> occur on
> >> >> the email list. This is for legal and policy reasons. Please correct
> >> me if
> >> >> I'm wrong.
> >> >>
> >> >> On Fri, Oct 7, 2016, 9:43 AM Clebert Suconic <
> >> clebert.suco...@gmail.com
> >> >
> >> >> wrote:
> >> >>
> >> >> > I think this is pretty straightforward:
> >> >> >
> >> >> > i - it should relay on JMX or jolokia.. A common thing between both
> >> >> > Artemis and ActiveMQ
> >> >> >
> >> >> > ii - it should manage at least a single broker.. with some
> metrics...
> >> >> >
> >> >> >
> >> >> > iii - anything beyond that will just be a collaboration over the
> >> code.
> >> >> >
> >> >> >
> >> >> > The best way to discuss this IMO would be through a Pull Request..
> >> >> > someone send an initial draft.. we can have some **technical**
> >> >> > discussion over of PR, and commit it as version 1... then
> >> >> > collaboratively this could be increased just as with anything else.
> >> >> >
> >> >> >
> >> >> >
> >> >> > I think we are clear from the previous discussions... and that's a
> >> >> > request I am making here, probably the third time... lets
> >> CTRL-Alt-Del
> >> >> > and start fresh... The issues we had are clear... and I see
> everybody
> >> >> > with a single goal here.. to have an integrated console that looks
> >> >> > like an Apache project, pretty and neat.
> >> >> >
> >> >> >
> >> >> > Once someone put a first version, we can only improve it from
> there.
> >> >> >
> >> >> > On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea <
> hzbar...@gmail.com
> >> >
> >> >> > wrote:
> >> >> > > I would suggest discussing the goals for such a console first. Is
> >> it
> >> >> > > intended to monitory just one broker instance or a whole network
> of
> >> >> > brokers?
> >> >> > > Should it manage just the brokers or other services? Should it
> >> rely on
> >> >> > JMX
> >> >> > > or something else?
> >> >> > >
> >> >> > > Then one can think about reusing and/or improving something
> that's
> >> >> > available
> >> >> > > or some other solution.
> >> >> > >
> >> >> > > The way this discuss goes, sounds to me like trying to push again
> >> for
> >> >> > > something that was rejected in the past and I suspect will not go
> >> >> > anywhere.
> >> >> > >
> >> >> > > My $0.02,
> >> >> > > Hadrian
> >> >> > >
> >> >> > >
> >> >> > > On 10/07/2016 06:41 AM, Martyn Taylor wrote:
> >> >> > >>
> >> >> > >> +1 on improving/adding a console.  Providing a console out of
> the
> >> box
> >> >> > is a
> >> >> > >> massive win for user experience imo and something that I feel
> >> Artemis
> >> >> > >> would
> >> >> > >> greatly benefit from.  Whether it's HawtIO or something else we
> >> should
> >> >> > >> make
> >> >> > >> every effort to standardise across both 5.x and Artemis.
> >> >> > >>
> >> >> > >> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
> >> >> > >>  >> >
> >> >> > >> wrote:
> >> >> > >>
> >> >> > >>> On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament <
> >> >> johndam...@apache.org
> >> >
> >> >> > >>> wrote:
> >> >> > 
> >> >> >  @Hiram
> >> >> > 
> >> >> >  The website branding says otherwise (take a look at the top
> >> right
> >> >> > >>>
> >> >> > >>> corner).
> >> >> > >>>
> >> >> > >>>
> >> >> > >>> That symbol on the top is just a link to the following:
> >> >> > >>>
> >> >> > >>> "Like hawtio? It’s part of a community of Red Hat projects.
>

Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Clebert Suconic
I don't think the attachments com through dev list.
I don't see an attachment at least.

Probably better to provide a link somewhere ?



On Friday, October 7, 2016, Fabio Gomes dos Santos 
wrote:

> TL;DR
>
> but i believe you will appreciate this screenshots
> i have used zabbix to collect metrics and generate alerts, and used
> grafana like a passive artemis dashboard.
>
> Basically grafana use zabbix like a data store via api.
>
> i have plan to write a article about how do that soon
>
>
>
> ​
>
>
>
> 2016-10-07 19:54 GMT-03:00 Clebert Suconic  >:
>
>> a consolidated repo for AMQ and Artemis might be useful for other
>> stuff as well. not just the web console.
>>
>> On Fri, Oct 7, 2016 at 5:49 PM, John D. Ament > > wrote:
>> > I think I just saw two great ideas:
>> >
>> > - A consolidated web console that is usable by both ActiveMQ and
>> Artemis.
>> > - It should be an independent repository/utility.
>> >
>> > I think all of the discussions are happening on a ML, but realistically
>> if
>> > we're ready to start writing down some code, we need some of those
>> > utilities in place.  Since PRs are mirrored to the MLs that would work,
>> but
>> > I would hate to see it baked into one of the existing repos to make that
>> > happen.
>> >
>> > John
>> >
>> > On Fri, Oct 7, 2016 at 5:41 PM Jim Gomes > > wrote:
>> >
>> >> I was under the impression that all Apache development discussions
>> occur on
>> >> the email list. This is for legal and policy reasons. Please correct
>> me if
>> >> I'm wrong.
>> >>
>> >> On Fri, Oct 7, 2016, 9:43 AM Clebert Suconic <
>> clebert.suco...@gmail.com
>> >
>> >> wrote:
>> >>
>> >> > I think this is pretty straightforward:
>> >> >
>> >> > i - it should relay on JMX or jolokia.. A common thing between both
>> >> > Artemis and ActiveMQ
>> >> >
>> >> > ii - it should manage at least a single broker.. with some metrics...
>> >> >
>> >> >
>> >> > iii - anything beyond that will just be a collaboration over the
>> code.
>> >> >
>> >> >
>> >> > The best way to discuss this IMO would be through a Pull Request..
>> >> > someone send an initial draft.. we can have some **technical**
>> >> > discussion over of PR, and commit it as version 1... then
>> >> > collaboratively this could be increased just as with anything else.
>> >> >
>> >> >
>> >> >
>> >> > I think we are clear from the previous discussions... and that's a
>> >> > request I am making here, probably the third time... lets
>> CTRL-Alt-Del
>> >> > and start fresh... The issues we had are clear... and I see everybody
>> >> > with a single goal here.. to have an integrated console that looks
>> >> > like an Apache project, pretty and neat.
>> >> >
>> >> >
>> >> > Once someone put a first version, we can only improve it from there.
>> >> >
>> >> > On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea > >
>> >> > wrote:
>> >> > > I would suggest discussing the goals for such a console first. Is
>> it
>> >> > > intended to monitory just one broker instance or a whole network of
>> >> > brokers?
>> >> > > Should it manage just the brokers or other services? Should it
>> rely on
>> >> > JMX
>> >> > > or something else?
>> >> > >
>> >> > > Then one can think about reusing and/or improving something that's
>> >> > available
>> >> > > or some other solution.
>> >> > >
>> >> > > The way this discuss goes, sounds to me like trying to push again
>> for
>> >> > > something that was rejected in the past and I suspect will not go
>> >> > anywhere.
>> >> > >
>> >> > > My $0.02,
>> >> > > Hadrian
>> >> > >
>> >> > >
>> >> > > On 10/07/2016 06:41 AM, Martyn Taylor wrote:
>> >> > >>
>> >> > >> +1 on improving/adding a console.  Providing a console out of the
>> box
>> >> > is a
>> >> > >> massive win for user experience imo and something that I feel
>> Artemis
>> >> > >> would
>> >> > >> greatly benefit from.  Whether it's HawtIO or something else we
>> should
>> >> > >> make
>> >> > >> every effort to standardise across both 5.x and Artemis.
>> >> > >>
>> >> > >> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
>> >> > >> > >
>> >> > >> wrote:
>> >> > >>
>> >> > >>> On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament <
>> >> johndam...@apache.org
>> >
>> >> > >>> wrote:
>> >> > 
>> >> >  @Hiram
>> >> > 
>> >> >  The website branding says otherwise (take a look at the top
>> right
>> >> > >>>
>> >> > >>> corner).
>> >> > >>>
>> >> > >>>
>> >> > >>> That symbol on the top is just a link to the following:
>> >> > >>>
>> >> > >>> "Like hawtio? It’s part of a community of Red Hat projects. Learn
>> >> more
>> >> > >>> about Red Hat and our open source communities:"
>> >> > >>>
>> >> > >>>
>> >> > >>>
>> >> > >>>  No other implications from what I see.
>> >> > >>>
>> >> > >>
>> >> > >
>> >> >
>> >> >
>> >> >
>> >> > --
>> >> > Clebert Suconic
>> >> >
>> >>
>>
>>
>>
>> --
>> Clebert Suconic
>>
>
>
>
> --
> Fábio Santos
> supergr...@gmail.com
> 
> 
>


-- 
Clebert Suconic


Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Fabio Gomes dos Santos
TL;DR

but i believe you will appreciate this screenshots
i have used zabbix to collect metrics and generate alerts, and used grafana
like a passive artemis dashboard.

Basically grafana use zabbix like a data store via api.

i have plan to write a article about how do that soon



​



2016-10-07 19:54 GMT-03:00 Clebert Suconic :

> a consolidated repo for AMQ and Artemis might be useful for other
> stuff as well. not just the web console.
>
> On Fri, Oct 7, 2016 at 5:49 PM, John D. Ament 
> wrote:
> > I think I just saw two great ideas:
> >
> > - A consolidated web console that is usable by both ActiveMQ and Artemis.
> > - It should be an independent repository/utility.
> >
> > I think all of the discussions are happening on a ML, but realistically
> if
> > we're ready to start writing down some code, we need some of those
> > utilities in place.  Since PRs are mirrored to the MLs that would work,
> but
> > I would hate to see it baked into one of the existing repos to make that
> > happen.
> >
> > John
> >
> > On Fri, Oct 7, 2016 at 5:41 PM Jim Gomes  wrote:
> >
> >> I was under the impression that all Apache development discussions
> occur on
> >> the email list. This is for legal and policy reasons. Please correct me
> if
> >> I'm wrong.
> >>
> >> On Fri, Oct 7, 2016, 9:43 AM Clebert Suconic  >
> >> wrote:
> >>
> >> > I think this is pretty straightforward:
> >> >
> >> > i - it should relay on JMX or jolokia.. A common thing between both
> >> > Artemis and ActiveMQ
> >> >
> >> > ii - it should manage at least a single broker.. with some metrics...
> >> >
> >> >
> >> > iii - anything beyond that will just be a collaboration over the code.
> >> >
> >> >
> >> > The best way to discuss this IMO would be through a Pull Request..
> >> > someone send an initial draft.. we can have some **technical**
> >> > discussion over of PR, and commit it as version 1... then
> >> > collaboratively this could be increased just as with anything else.
> >> >
> >> >
> >> >
> >> > I think we are clear from the previous discussions... and that's a
> >> > request I am making here, probably the third time... lets CTRL-Alt-Del
> >> > and start fresh... The issues we had are clear... and I see everybody
> >> > with a single goal here.. to have an integrated console that looks
> >> > like an Apache project, pretty and neat.
> >> >
> >> >
> >> > Once someone put a first version, we can only improve it from there.
> >> >
> >> > On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea 
> >> > wrote:
> >> > > I would suggest discussing the goals for such a console first. Is it
> >> > > intended to monitory just one broker instance or a whole network of
> >> > brokers?
> >> > > Should it manage just the brokers or other services? Should it rely
> on
> >> > JMX
> >> > > or something else?
> >> > >
> >> > > Then one can think about reusing and/or improving something that's
> >> > available
> >> > > or some other solution.
> >> > >
> >> > > The way this discuss goes, sounds to me like trying to push again
> for
> >> > > something that was rejected in the past and I suspect will not go
> >> > anywhere.
> >> > >
> >> > > My $0.02,
> >> > > Hadrian
> >> > >
> >> > >
> >> > > On 10/07/2016 06:41 AM, Martyn Taylor wrote:
> >> > >>
> >> > >> +1 on improving/adding a console.  Providing a console out of the
> box
> >> > is a
> >> > >> massive win for user experience imo and something that I feel
> Artemis
> >> > >> would
> >> > >> greatly benefit from.  Whether it's HawtIO or something else we
> should
> >> > >> make
> >> > >> every effort to standardise across both 5.x and Artemis.
> >> > >>
> >> > >> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
> >> > >> 
> >> > >> wrote:
> >> > >>
> >> > >>> On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament <
> >> johndam...@apache.org>
> >> > >>> wrote:
> >> > 
> >> >  @Hiram
> >> > 
> >> >  The website branding says otherwise (take a look at the top right
> >> > >>>
> >> > >>> corner).
> >> > >>>
> >> > >>>
> >> > >>> That symbol on the top is just a link to the following:
> >> > >>>
> >> > >>> "Like hawtio? It’s part of a community of Red Hat projects. Learn
> >> more
> >> > >>> about Red Hat and our open source communities:"
> >> > >>>
> >> > >>>
> >> > >>>
> >> > >>>  No other implications from what I see.
> >> > >>>
> >> > >>
> >> > >
> >> >
> >> >
> >> >
> >> > --
> >> > Clebert Suconic
> >> >
> >>
>
>
>
> --
> Clebert Suconic
>



-- 
Fábio Santos
supergr...@gmail.com



Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Clebert Suconic
a consolidated repo for AMQ and Artemis might be useful for other
stuff as well. not just the web console.

On Fri, Oct 7, 2016 at 5:49 PM, John D. Ament  wrote:
> I think I just saw two great ideas:
>
> - A consolidated web console that is usable by both ActiveMQ and Artemis.
> - It should be an independent repository/utility.
>
> I think all of the discussions are happening on a ML, but realistically if
> we're ready to start writing down some code, we need some of those
> utilities in place.  Since PRs are mirrored to the MLs that would work, but
> I would hate to see it baked into one of the existing repos to make that
> happen.
>
> John
>
> On Fri, Oct 7, 2016 at 5:41 PM Jim Gomes  wrote:
>
>> I was under the impression that all Apache development discussions occur on
>> the email list. This is for legal and policy reasons. Please correct me if
>> I'm wrong.
>>
>> On Fri, Oct 7, 2016, 9:43 AM Clebert Suconic 
>> wrote:
>>
>> > I think this is pretty straightforward:
>> >
>> > i - it should relay on JMX or jolokia.. A common thing between both
>> > Artemis and ActiveMQ
>> >
>> > ii - it should manage at least a single broker.. with some metrics...
>> >
>> >
>> > iii - anything beyond that will just be a collaboration over the code.
>> >
>> >
>> > The best way to discuss this IMO would be through a Pull Request..
>> > someone send an initial draft.. we can have some **technical**
>> > discussion over of PR, and commit it as version 1... then
>> > collaboratively this could be increased just as with anything else.
>> >
>> >
>> >
>> > I think we are clear from the previous discussions... and that's a
>> > request I am making here, probably the third time... lets CTRL-Alt-Del
>> > and start fresh... The issues we had are clear... and I see everybody
>> > with a single goal here.. to have an integrated console that looks
>> > like an Apache project, pretty and neat.
>> >
>> >
>> > Once someone put a first version, we can only improve it from there.
>> >
>> > On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea 
>> > wrote:
>> > > I would suggest discussing the goals for such a console first. Is it
>> > > intended to monitory just one broker instance or a whole network of
>> > brokers?
>> > > Should it manage just the brokers or other services? Should it rely on
>> > JMX
>> > > or something else?
>> > >
>> > > Then one can think about reusing and/or improving something that's
>> > available
>> > > or some other solution.
>> > >
>> > > The way this discuss goes, sounds to me like trying to push again for
>> > > something that was rejected in the past and I suspect will not go
>> > anywhere.
>> > >
>> > > My $0.02,
>> > > Hadrian
>> > >
>> > >
>> > > On 10/07/2016 06:41 AM, Martyn Taylor wrote:
>> > >>
>> > >> +1 on improving/adding a console.  Providing a console out of the box
>> > is a
>> > >> massive win for user experience imo and something that I feel Artemis
>> > >> would
>> > >> greatly benefit from.  Whether it's HawtIO or something else we should
>> > >> make
>> > >> every effort to standardise across both 5.x and Artemis.
>> > >>
>> > >> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
>> > >> 
>> > >> wrote:
>> > >>
>> > >>> On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament <
>> johndam...@apache.org>
>> > >>> wrote:
>> > 
>> >  @Hiram
>> > 
>> >  The website branding says otherwise (take a look at the top right
>> > >>>
>> > >>> corner).
>> > >>>
>> > >>>
>> > >>> That symbol on the top is just a link to the following:
>> > >>>
>> > >>> "Like hawtio? It’s part of a community of Red Hat projects. Learn
>> more
>> > >>> about Red Hat and our open source communities:"
>> > >>>
>> > >>>
>> > >>>
>> > >>>  No other implications from what I see.
>> > >>>
>> > >>
>> > >
>> >
>> >
>> >
>> > --
>> > Clebert Suconic
>> >
>>



-- 
Clebert Suconic


[GitHub] activemq-artemis pull request #826: ARTEMIS-761 fix possible dup journal rec...

2016-10-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/826


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #826: ARTEMIS-761 fix possible dup journal rec...

2016-10-07 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/826#discussion_r82482751
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/DuplicateRecordIdTest.java
 ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.integration.journal;
+
+import org.apache.activemq.artemis.api.core.SimpleString;
+import 
org.apache.activemq.artemis.api.core.management.ActiveMQServerControl;
+import org.apache.activemq.artemis.api.core.management.AddressSettingsInfo;
+import org.apache.activemq.artemis.cli.commands.tools.PrintData;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
+import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
+import org.junit.Before;
+import org.junit.Test;
+
+public class DuplicateRecordIdTest extends ActiveMQTestBase {
+
+   protected ActiveMQServer server;
+
+   @Override
+   @Before
+   public void setUp() throws Exception {
+  super.setUp();
+  server = createServer(false, 
createDefaultInVMConfig().addAddressesSetting("#", new 
AddressSettings().setDeadLetterAddress(new 
SimpleString("dlq")).setExpiryAddress(new SimpleString("dlq";
+  server.getConfiguration().setPersistenceEnabled(true);
+   }
+
+   @Test
+   public void testDuplicateRecordId() throws Exception {
+  for (int i = 0; i < 3; i++) {
+ server.start();
+ ActiveMQServerControl serverControl = 
server.getActiveMQServerControl();
+ serverControl.removeAddressSettings("q");
+ AddressSettingsInfo defaultSettings = 
AddressSettingsInfo.from(serverControl.getAddressSettingsAsJSON("#"));
+ serverControl.addAddressSettings("q", "dlq", 
defaultSettings.getExpiryAddress(), -1, false, 1, 
defaultSettings.getMaxSizeBytes(), defaultSettings.getPageSizeBytes(), 
defaultSettings.getPageCacheMaxSize(), defaultSettings.getRedeliveryDelay(), 
defaultSettings.getRedeliveryMultiplier(), 
defaultSettings.getMaxRedeliveryDelay(), 
defaultSettings.getRedistributionDelay(), 
defaultSettings.isSendToDLAOnNoRoute(), 
defaultSettings.getAddressFullMessagePolicy(), 
defaultSettings.getSlowConsumerThreshold(), 
defaultSettings.getSlowConsumerCheckPeriod(), 
defaultSettings.getSlowConsumerPolicy(), 
defaultSettings.isAutoCreateJmsQueues(), 
defaultSettings.isAutoDeleteJmsQueues(), 
defaultSettings.isAutoCreateJmsTopics(), 
defaultSettings.isAutoDeleteJmsTopics());
+ server.stop();
+ 
PrintData.printData(server.getConfiguration().getBindingsLocation().getAbsoluteFile(),
 server.getConfiguration().getJournalLocation().getAbsoluteFile(), 
server.getConfiguration().getPagingLocation().getAbsoluteFile());
--- End diff --

actually.. just leave it ... it doesn't bother :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #824: ARTEMIS-775 Tests for AMQP credit handli...

2016-10-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/824


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #828: ARTEMIS-777 Remove dependency on legacy ...

2016-10-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/828


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #827: ARTEMIS-776 Attach response should only ...

2016-10-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/827


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #824: ARTEMIS-775 Tests for AMQP credit handli...

2016-10-07 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/824#discussion_r82481427
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java
 ---
@@ -0,0 +1,557 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.amqp;
+
+import java.util.ArrayList;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.activemq.artemis.core.server.Queue;
+import 
org.apache.activemq.artemis.tests.integration.mqtt.imported.util.Wait;
+import org.apache.activemq.transport.amqp.client.AmqpClient;
+import org.apache.activemq.transport.amqp.client.AmqpConnection;
+import org.apache.activemq.transport.amqp.client.AmqpMessage;
+import org.apache.activemq.transport.amqp.client.AmqpReceiver;
+import org.apache.activemq.transport.amqp.client.AmqpSender;
+import org.apache.activemq.transport.amqp.client.AmqpSession;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Test basic send and receive scenarios using only AMQP sender and 
receiver links.
+ */
+public class AmqpSendReceiveTest extends AmqpClientTestSupport {
+
+   protected static final Logger LOG = 
LoggerFactory.getLogger(AmqpSendReceiveTest.class);
+
+   @Test(timeout = 6)
+   public void testSimpleSendOneReceiveOne() throws Exception {
+
+  AmqpClient client = createAmqpClient();
+  AmqpConnection connection = addConnection(client.connect());
+  AmqpSession session = connection.createSession();
+
+  AmqpSender sender = session.createSender(getTestName());
+
+  AmqpMessage message = new AmqpMessage();
+
+  message.setMessageId("msg" + 1);
+  message.setMessageAnnotation("serialNo", 1);
+  message.setText("Test-Message");
+
+  sender.send(message);
+  sender.close();
+
+  LOG.info("Attempting to read message with receiver");
+  AmqpReceiver receiver = session.createReceiver(getTestName());
+  receiver.flow(2);
+  AmqpMessage received = receiver.receive(10, TimeUnit.SECONDS);
+  assertNotNull("Should have read message", received);
+  assertEquals("msg1", received.getMessageId());
+  received.accept();
+
+  receiver.close();
+
+  connection.close();
--- End diff --

I didn't realize you had addConnection.. sorry about that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #826: ARTEMIS-761 fix possible dup journal rec...

2016-10-07 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/826#discussion_r82480956
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/journal/DuplicateRecordIdTest.java
 ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.integration.journal;
+
+import org.apache.activemq.artemis.api.core.SimpleString;
+import 
org.apache.activemq.artemis.api.core.management.ActiveMQServerControl;
+import org.apache.activemq.artemis.api.core.management.AddressSettingsInfo;
+import org.apache.activemq.artemis.cli.commands.tools.PrintData;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
+import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
+import org.junit.Before;
+import org.junit.Test;
+
+public class DuplicateRecordIdTest extends ActiveMQTestBase {
+
+   protected ActiveMQServer server;
+
+   @Override
+   @Before
+   public void setUp() throws Exception {
+  super.setUp();
+  server = createServer(false, 
createDefaultInVMConfig().addAddressesSetting("#", new 
AddressSettings().setDeadLetterAddress(new 
SimpleString("dlq")).setExpiryAddress(new SimpleString("dlq";
+  server.getConfiguration().setPersistenceEnabled(true);
+   }
+
+   @Test
+   public void testDuplicateRecordId() throws Exception {
+  for (int i = 0; i < 3; i++) {
+ server.start();
+ ActiveMQServerControl serverControl = 
server.getActiveMQServerControl();
+ serverControl.removeAddressSettings("q");
+ AddressSettingsInfo defaultSettings = 
AddressSettingsInfo.from(serverControl.getAddressSettingsAsJSON("#"));
+ serverControl.addAddressSettings("q", "dlq", 
defaultSettings.getExpiryAddress(), -1, false, 1, 
defaultSettings.getMaxSizeBytes(), defaultSettings.getPageSizeBytes(), 
defaultSettings.getPageCacheMaxSize(), defaultSettings.getRedeliveryDelay(), 
defaultSettings.getRedeliveryMultiplier(), 
defaultSettings.getMaxRedeliveryDelay(), 
defaultSettings.getRedistributionDelay(), 
defaultSettings.isSendToDLAOnNoRoute(), 
defaultSettings.getAddressFullMessagePolicy(), 
defaultSettings.getSlowConsumerThreshold(), 
defaultSettings.getSlowConsumerCheckPeriod(), 
defaultSettings.getSlowConsumerPolicy(), 
defaultSettings.isAutoCreateJmsQueues(), 
defaultSettings.isAutoDeleteJmsQueues(), 
defaultSettings.isAutoCreateJmsTopics(), 
defaultSettings.isAutoDeleteJmsTopics());
+ server.stop();
+ 
PrintData.printData(server.getConfiguration().getBindingsLocation().getAbsoluteFile(),
 server.getConfiguration().getJournalLocation().getAbsoluteFile(), 
server.getConfiguration().getPagingLocation().getAbsoluteFile());
--- End diff --

I would remove the PrintData here.. this is for debug purposes only.. and 
anyone can call print-data directly if needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Clebert Suconic
On Fri, Oct 7, 2016 at 5:40 PM, Jim Gomes  wrote:
> I was under the impression that all Apache development discussions occur on
> the email list.

As Justin Bertram Said, all PR comments are sent to the dev-list.

What I'm really proposing, it's to be practical... to have something
concrete to talk about on top of the code.



 Clebert Suconic 
> wrote:
>
>> I think this is pretty straightforward:
>>
>> i - it should relay on JMX or jolokia.. A common thing between both
>> Artemis and ActiveMQ
>>
>> ii - it should manage at least a single broker.. with some metrics...
>>
>>
>> iii - anything beyond that will just be a collaboration over the code.
>>
>>
>> The best way to discuss this IMO would be through a Pull Request..
>> someone send an initial draft.. we can have some **technical**
>> discussion over of PR, and commit it as version 1... then
>> collaboratively this could be increased just as with anything else.
>>
>>
>>
>> I think we are clear from the previous discussions... and that's a
>> request I am making here, probably the third time... lets CTRL-Alt-Del
>> and start fresh... The issues we had are clear... and I see everybody
>> with a single goal here.. to have an integrated console that looks
>> like an Apache project, pretty and neat.
>>
>>
>> Once someone put a first version, we can only improve it from there.
>>
>> On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea 
>> wrote:
>> > I would suggest discussing the goals for such a console first. Is it
>> > intended to monitory just one broker instance or a whole network of
>> brokers?
>> > Should it manage just the brokers or other services? Should it rely on
>> JMX
>> > or something else?
>> >
>> > Then one can think about reusing and/or improving something that's
>> available
>> > or some other solution.
>> >
>> > The way this discuss goes, sounds to me like trying to push again for
>> > something that was rejected in the past and I suspect will not go
>> anywhere.
>> >
>> > My $0.02,
>> > Hadrian
>> >
>> >
>> > On 10/07/2016 06:41 AM, Martyn Taylor wrote:
>> >>
>> >> +1 on improving/adding a console.  Providing a console out of the box
>> is a
>> >> massive win for user experience imo and something that I feel Artemis
>> >> would
>> >> greatly benefit from.  Whether it's HawtIO or something else we should
>> >> make
>> >> every effort to standardise across both 5.x and Artemis.
>> >>
>> >> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
>> >> 
>> >> wrote:
>> >>
>> >>> On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament 
>> >>> wrote:
>> 
>>  @Hiram
>> 
>>  The website branding says otherwise (take a look at the top right
>> >>>
>> >>> corner).
>> >>>
>> >>>
>> >>> That symbol on the top is just a link to the following:
>> >>>
>> >>> "Like hawtio? It’s part of a community of Red Hat projects. Learn more
>> >>> about Red Hat and our open source communities:"
>> >>>
>> >>>
>> >>>
>> >>>  No other implications from what I see.
>> >>>
>> >>
>> >
>>
>>
>>
>> --
>> Clebert Suconic
>>



-- 
Clebert Suconic


[GitHub] activemq-artemis pull request #828: ARTEMIS-777 Remove dependency on legacy ...

2016-10-07 Thread tabish121
GitHub user tabish121 opened a pull request:

https://github.com/apache/activemq-artemis/pull/828

ARTEMIS-777 Remove dependency on legacy Qpid AMQP 0.x JMS client

Remove the dependency on the qpid-client module which is an AMQP JMS
client for the 0.x AMQP protocols which Artemis does not support.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-777

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/828.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #828


commit 2f490cda90e1fb944c27033d7958f36090528882
Author: Timothy Bish 
Date:   2016-10-07T22:09:11Z

ARTEMIS-777 Remove dependency on legacy Qpid AMQP 0.x JMS client

Remove the dependency on the qpid-client module which is an AMQP JMS
client for the 0.x AMQP protocols which Artemis does not support.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread John D. Ament
+1

On Oct 7, 2016 18:05, "Daniel Kulp"  wrote:

>
> I guess the first question that needs to be determined is if this will be
> done in the Artemis git repo or if we should create a new repo for this (so
> it could be shared for both 5.x and Artemis).   If a new repo, then just
> get the repo created and start committing code.   Don’t bother with the
> pull request, just start working on it and continue discussing it here.
>
> From my standpoint, I’m quite OK with a separate repo.
>
> Dan
>
>
>
>
> > On Oct 7, 2016, at 6:43 PM, Clebert Suconic 
> wrote:
> >
> > I think this is pretty straightforward:
> >
> > i - it should relay on JMX or jolokia.. A common thing between both
> > Artemis and ActiveMQ
> >
> > ii - it should manage at least a single broker.. with some metrics...
> >
> >
> > iii - anything beyond that will just be a collaboration over the code.
> >
> >
> > The best way to discuss this IMO would be through a Pull Request..
> > someone send an initial draft.. we can have some **technical**
> > discussion over of PR, and commit it as version 1... then
> > collaboratively this could be increased just as with anything else.
> >
> >
> >
> > I think we are clear from the previous discussions... and that's a
> > request I am making here, probably the third time... lets CTRL-Alt-Del
> > and start fresh... The issues we had are clear... and I see everybody
> > with a single goal here.. to have an integrated console that looks
> > like an Apache project, pretty and neat.
> >
> >
> > Once someone put a first version, we can only improve it from there.
> >
> > On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea 
> wrote:
> >> I would suggest discussing the goals for such a console first. Is it
> >> intended to monitory just one broker instance or a whole network of
> brokers?
> >> Should it manage just the brokers or other services? Should it rely on
> JMX
> >> or something else?
> >>
> >> Then one can think about reusing and/or improving something that's
> available
> >> or some other solution.
> >>
> >> The way this discuss goes, sounds to me like trying to push again for
> >> something that was rejected in the past and I suspect will not go
> anywhere.
> >>
> >> My $0.02,
> >> Hadrian
> >>
> >>
> >> On 10/07/2016 06:41 AM, Martyn Taylor wrote:
> >>>
> >>> +1 on improving/adding a console.  Providing a console out of the box
> is a
> >>> massive win for user experience imo and something that I feel Artemis
> >>> would
> >>> greatly benefit from.  Whether it's HawtIO or something else we should
> >>> make
> >>> every effort to standardise across both 5.x and Artemis.
> >>>
> >>> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
> >>> 
> >>> wrote:
> >>>
>  On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament  >
>  wrote:
> >
> > @Hiram
> >
> > The website branding says otherwise (take a look at the top right
> 
>  corner).
> 
> 
>  That symbol on the top is just a link to the following:
> 
>  "Like hawtio? It’s part of a community of Red Hat projects. Learn more
>  about Red Hat and our open source communities:"
> 
> 
> 
>  No other implications from what I see.
> 
> >>>
> >>
> >
> >
> >
> > --
> > Clebert Suconic
>
> --
> Daniel Kulp
> dk...@apache.org - http://dankulp.com/blog
> Talend Community Coder - http://coders.talend.com
>
>


Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Daniel Kulp

I guess the first question that needs to be determined is if this will be done 
in the Artemis git repo or if we should create a new repo for this (so it could 
be shared for both 5.x and Artemis).   If a new repo, then just get the repo 
created and start committing code.   Don’t bother with the pull request, just 
start working on it and continue discussing it here.

From my standpoint, I’m quite OK with a separate repo.  

Dan




> On Oct 7, 2016, at 6:43 PM, Clebert Suconic  wrote:
> 
> I think this is pretty straightforward:
> 
> i - it should relay on JMX or jolokia.. A common thing between both
> Artemis and ActiveMQ
> 
> ii - it should manage at least a single broker.. with some metrics...
> 
> 
> iii - anything beyond that will just be a collaboration over the code.
> 
> 
> The best way to discuss this IMO would be through a Pull Request..
> someone send an initial draft.. we can have some **technical**
> discussion over of PR, and commit it as version 1... then
> collaboratively this could be increased just as with anything else.
> 
> 
> 
> I think we are clear from the previous discussions... and that's a
> request I am making here, probably the third time... lets CTRL-Alt-Del
> and start fresh... The issues we had are clear... and I see everybody
> with a single goal here.. to have an integrated console that looks
> like an Apache project, pretty and neat.
> 
> 
> Once someone put a first version, we can only improve it from there.
> 
> On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea  wrote:
>> I would suggest discussing the goals for such a console first. Is it
>> intended to monitory just one broker instance or a whole network of brokers?
>> Should it manage just the brokers or other services? Should it rely on JMX
>> or something else?
>> 
>> Then one can think about reusing and/or improving something that's available
>> or some other solution.
>> 
>> The way this discuss goes, sounds to me like trying to push again for
>> something that was rejected in the past and I suspect will not go anywhere.
>> 
>> My $0.02,
>> Hadrian
>> 
>> 
>> On 10/07/2016 06:41 AM, Martyn Taylor wrote:
>>> 
>>> +1 on improving/adding a console.  Providing a console out of the box is a
>>> massive win for user experience imo and something that I feel Artemis
>>> would
>>> greatly benefit from.  Whether it's HawtIO or something else we should
>>> make
>>> every effort to standardise across both 5.x and Artemis.
>>> 
>>> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
>>> 
>>> wrote:
>>> 
 On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament 
 wrote:
> 
> @Hiram
> 
> The website branding says otherwise (take a look at the top right
 
 corner).
 
 
 That symbol on the top is just a link to the following:
 
 "Like hawtio? It’s part of a community of Red Hat projects. Learn more
 about Red Hat and our open source communities:"
 
 
 
 No other implications from what I see.
 
>>> 
>> 
> 
> 
> 
> -- 
> Clebert Suconic

-- 
Daniel Kulp
dk...@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com



Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Justin Bertram
All comments on pull requests sent to 
https://github.com/apache/activemq-artemis are echoed on the mailing list.  A 
quick look at the Hadoop and Kafka GitHub repos shows that they also discuss 
pull requests directly.  I'm not sure if those are echoed on their mailing 
lists or not, though.


Justin

- Original Message -
From: "Jim Gomes" 
To: "ActiveMQ Dev" 
Sent: Friday, October 7, 2016 4:40:58 PM
Subject: Re: [DISCUSS] Removing the Web Console

I was under the impression that all Apache development discussions occur on
the email list. This is for legal and policy reasons. Please correct me if
I'm wrong.

On Fri, Oct 7, 2016, 9:43 AM Clebert Suconic 
wrote:

> I think this is pretty straightforward:
>
> i - it should relay on JMX or jolokia.. A common thing between both
> Artemis and ActiveMQ
>
> ii - it should manage at least a single broker.. with some metrics...
>
>
> iii - anything beyond that will just be a collaboration over the code.
>
>
> The best way to discuss this IMO would be through a Pull Request..
> someone send an initial draft.. we can have some **technical**
> discussion over of PR, and commit it as version 1... then
> collaboratively this could be increased just as with anything else.
>
>
>
> I think we are clear from the previous discussions... and that's a
> request I am making here, probably the third time... lets CTRL-Alt-Del
> and start fresh... The issues we had are clear... and I see everybody
> with a single goal here.. to have an integrated console that looks
> like an Apache project, pretty and neat.
>
>
> Once someone put a first version, we can only improve it from there.
>
> On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea 
> wrote:
> > I would suggest discussing the goals for such a console first. Is it
> > intended to monitory just one broker instance or a whole network of
> brokers?
> > Should it manage just the brokers or other services? Should it rely on
> JMX
> > or something else?
> >
> > Then one can think about reusing and/or improving something that's
> available
> > or some other solution.
> >
> > The way this discuss goes, sounds to me like trying to push again for
> > something that was rejected in the past and I suspect will not go
> anywhere.
> >
> > My $0.02,
> > Hadrian
> >
> >
> > On 10/07/2016 06:41 AM, Martyn Taylor wrote:
> >>
> >> +1 on improving/adding a console.  Providing a console out of the box
> is a
> >> massive win for user experience imo and something that I feel Artemis
> >> would
> >> greatly benefit from.  Whether it's HawtIO or something else we should
> >> make
> >> every effort to standardise across both 5.x and Artemis.
> >>
> >> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
> >> 
> >> wrote:
> >>
> >>> On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament 
> >>> wrote:
> 
>  @Hiram
> 
>  The website branding says otherwise (take a look at the top right
> >>>
> >>> corner).
> >>>
> >>>
> >>> That symbol on the top is just a link to the following:
> >>>
> >>> "Like hawtio? It’s part of a community of Red Hat projects. Learn more
> >>> about Red Hat and our open source communities:"
> >>>
> >>>
> >>>
> >>>  No other implications from what I see.
> >>>
> >>
> >
>
>
>
> --
> Clebert Suconic
>


Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread John D. Ament
I think I just saw two great ideas:

- A consolidated web console that is usable by both ActiveMQ and Artemis.
- It should be an independent repository/utility.

I think all of the discussions are happening on a ML, but realistically if
we're ready to start writing down some code, we need some of those
utilities in place.  Since PRs are mirrored to the MLs that would work, but
I would hate to see it baked into one of the existing repos to make that
happen.

John

On Fri, Oct 7, 2016 at 5:41 PM Jim Gomes  wrote:

> I was under the impression that all Apache development discussions occur on
> the email list. This is for legal and policy reasons. Please correct me if
> I'm wrong.
>
> On Fri, Oct 7, 2016, 9:43 AM Clebert Suconic 
> wrote:
>
> > I think this is pretty straightforward:
> >
> > i - it should relay on JMX or jolokia.. A common thing between both
> > Artemis and ActiveMQ
> >
> > ii - it should manage at least a single broker.. with some metrics...
> >
> >
> > iii - anything beyond that will just be a collaboration over the code.
> >
> >
> > The best way to discuss this IMO would be through a Pull Request..
> > someone send an initial draft.. we can have some **technical**
> > discussion over of PR, and commit it as version 1... then
> > collaboratively this could be increased just as with anything else.
> >
> >
> >
> > I think we are clear from the previous discussions... and that's a
> > request I am making here, probably the third time... lets CTRL-Alt-Del
> > and start fresh... The issues we had are clear... and I see everybody
> > with a single goal here.. to have an integrated console that looks
> > like an Apache project, pretty and neat.
> >
> >
> > Once someone put a first version, we can only improve it from there.
> >
> > On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea 
> > wrote:
> > > I would suggest discussing the goals for such a console first. Is it
> > > intended to monitory just one broker instance or a whole network of
> > brokers?
> > > Should it manage just the brokers or other services? Should it rely on
> > JMX
> > > or something else?
> > >
> > > Then one can think about reusing and/or improving something that's
> > available
> > > or some other solution.
> > >
> > > The way this discuss goes, sounds to me like trying to push again for
> > > something that was rejected in the past and I suspect will not go
> > anywhere.
> > >
> > > My $0.02,
> > > Hadrian
> > >
> > >
> > > On 10/07/2016 06:41 AM, Martyn Taylor wrote:
> > >>
> > >> +1 on improving/adding a console.  Providing a console out of the box
> > is a
> > >> massive win for user experience imo and something that I feel Artemis
> > >> would
> > >> greatly benefit from.  Whether it's HawtIO or something else we should
> > >> make
> > >> every effort to standardise across both 5.x and Artemis.
> > >>
> > >> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
> > >> 
> > >> wrote:
> > >>
> > >>> On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament <
> johndam...@apache.org>
> > >>> wrote:
> > 
> >  @Hiram
> > 
> >  The website branding says otherwise (take a look at the top right
> > >>>
> > >>> corner).
> > >>>
> > >>>
> > >>> That symbol on the top is just a link to the following:
> > >>>
> > >>> "Like hawtio? It’s part of a community of Red Hat projects. Learn
> more
> > >>> about Red Hat and our open source communities:"
> > >>>
> > >>>
> > >>>
> > >>>  No other implications from what I see.
> > >>>
> > >>
> > >
> >
> >
> >
> > --
> > Clebert Suconic
> >
>


Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Jim Gomes
I was under the impression that all Apache development discussions occur on
the email list. This is for legal and policy reasons. Please correct me if
I'm wrong.

On Fri, Oct 7, 2016, 9:43 AM Clebert Suconic 
wrote:

> I think this is pretty straightforward:
>
> i - it should relay on JMX or jolokia.. A common thing between both
> Artemis and ActiveMQ
>
> ii - it should manage at least a single broker.. with some metrics...
>
>
> iii - anything beyond that will just be a collaboration over the code.
>
>
> The best way to discuss this IMO would be through a Pull Request..
> someone send an initial draft.. we can have some **technical**
> discussion over of PR, and commit it as version 1... then
> collaboratively this could be increased just as with anything else.
>
>
>
> I think we are clear from the previous discussions... and that's a
> request I am making here, probably the third time... lets CTRL-Alt-Del
> and start fresh... The issues we had are clear... and I see everybody
> with a single goal here.. to have an integrated console that looks
> like an Apache project, pretty and neat.
>
>
> Once someone put a first version, we can only improve it from there.
>
> On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea 
> wrote:
> > I would suggest discussing the goals for such a console first. Is it
> > intended to monitory just one broker instance or a whole network of
> brokers?
> > Should it manage just the brokers or other services? Should it rely on
> JMX
> > or something else?
> >
> > Then one can think about reusing and/or improving something that's
> available
> > or some other solution.
> >
> > The way this discuss goes, sounds to me like trying to push again for
> > something that was rejected in the past and I suspect will not go
> anywhere.
> >
> > My $0.02,
> > Hadrian
> >
> >
> > On 10/07/2016 06:41 AM, Martyn Taylor wrote:
> >>
> >> +1 on improving/adding a console.  Providing a console out of the box
> is a
> >> massive win for user experience imo and something that I feel Artemis
> >> would
> >> greatly benefit from.  Whether it's HawtIO or something else we should
> >> make
> >> every effort to standardise across both 5.x and Artemis.
> >>
> >> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
> >> 
> >> wrote:
> >>
> >>> On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament 
> >>> wrote:
> 
>  @Hiram
> 
>  The website branding says otherwise (take a look at the top right
> >>>
> >>> corner).
> >>>
> >>>
> >>> That symbol on the top is just a link to the following:
> >>>
> >>> "Like hawtio? It’s part of a community of Red Hat projects. Learn more
> >>> about Red Hat and our open source communities:"
> >>>
> >>>
> >>>
> >>>  No other implications from what I see.
> >>>
> >>
> >
>
>
>
> --
> Clebert Suconic
>


RE: [GitHub] activemq-artemis pull request #827: ARTEMIS-776 Attach response should only ...

2016-10-07 Thread Dharmesh Joshi
How do I unsubscribe from this mailing list? I sent the unsubscribe email to
the email address john  mentioned but I am still getting emails.

Can someone please help me?

Thanks,
Dharmesh

-Original Message-
From: tabish121 [mailto:g...@git.apache.org] 
Sent: Friday, October 7, 2016 5:38 PM
To: dev@activemq.apache.org
Subject: [GitHub] activemq-artemis pull request #827: ARTEMIS-776 Attach
response should only ...

GitHub user tabish121 opened a pull request:

https://github.com/apache/activemq-artemis/pull/827

ARTEMIS-776 Attach response should only list supported filters

The broker needs to return only the filters that are supported on a
receiver attach otherwise the remote is not aware that the broker is not
able to honor the requested configuration of the receiver.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-776

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/827.patch

To close this pull request, make a commit to your master/trunk branch with
(at least) the following in the commit message:

This closes #827


commit 398da40f7dd17b97838f4a2b377d7b19b82c6c7a
Author: Timothy Bish 
Date:   2016-10-07T21:29:46Z

ARTEMIS-776 Attach response should only list supported filters

The broker needs to return only the filters that are supported on a
receiver attach otherwise the remote is not aware that the broker is not
able to honor the requested configuration of the receiver.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---



[GitHub] activemq-artemis pull request #827: ARTEMIS-776 Attach response should only ...

2016-10-07 Thread tabish121
GitHub user tabish121 opened a pull request:

https://github.com/apache/activemq-artemis/pull/827

ARTEMIS-776 Attach response should only list supported filters

The broker needs to return only the filters that are supported on a
receiver attach otherwise the remote is not aware that the broker is not
able to honor the requested configuration of the receiver.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-776

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/827.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #827


commit 398da40f7dd17b97838f4a2b377d7b19b82c6c7a
Author: Timothy Bish 
Date:   2016-10-07T21:29:46Z

ARTEMIS-776 Attach response should only list supported filters

The broker needs to return only the filters that are supported on a
receiver attach otherwise the remote is not aware that the broker is not
able to honor the requested configuration of the receiver.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #826: ARTEMIS-761 fix possible dup journal rec...

2016-10-07 Thread jbertram
GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/826

ARTEMIS-761 fix possible dup journal record ID



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-761

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/826.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #826


commit d24c960f9c08ce3d0082e4cc3084ae738ce5a6ed
Author: jbertram 
Date:   2016-10-04T15:34:00Z

ARTEMIS-761 fix possible dup journal record ID




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #824: ARTEMIS-775 Tests for AMQP credit handli...

2016-10-07 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/824#discussion_r82449383
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java
 ---
@@ -0,0 +1,557 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.amqp;
+
+import java.util.ArrayList;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.activemq.artemis.core.server.Queue;
+import 
org.apache.activemq.artemis.tests.integration.mqtt.imported.util.Wait;
+import org.apache.activemq.transport.amqp.client.AmqpClient;
+import org.apache.activemq.transport.amqp.client.AmqpConnection;
+import org.apache.activemq.transport.amqp.client.AmqpMessage;
+import org.apache.activemq.transport.amqp.client.AmqpReceiver;
+import org.apache.activemq.transport.amqp.client.AmqpSender;
+import org.apache.activemq.transport.amqp.client.AmqpSession;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Test basic send and receive scenarios using only AMQP sender and 
receiver links.
+ */
+public class AmqpSendReceiveTest extends AmqpClientTestSupport {
+
+   protected static final Logger LOG = 
LoggerFactory.getLogger(AmqpSendReceiveTest.class);
+
+   @Test(timeout = 6)
+   public void testSimpleSendOneReceiveOne() throws Exception {
+
+  AmqpClient client = createAmqpClient();
+  AmqpConnection connection = addConnection(client.connect());
+  AmqpSession session = connection.createSession();
+
+  AmqpSender sender = session.createSender(getTestName());
+
+  AmqpMessage message = new AmqpMessage();
+
+  message.setMessageId("msg" + 1);
+  message.setMessageAnnotation("serialNo", 1);
+  message.setText("Test-Message");
+
+  sender.send(message);
+  sender.close();
+
+  LOG.info("Attempting to read message with receiver");
+  AmqpReceiver receiver = session.createReceiver(getTestName());
+  receiver.flow(2);
+  AmqpMessage received = receiver.receive(10, TimeUnit.SECONDS);
+  assertNotNull("Should have read message", received);
+  assertEquals("msg1", received.getMessageId());
+  received.accept();
+
+  receiver.close();
+
+  connection.close();
--- End diff --

This is because we have the ThreadLeakCheckRule on most of our tests. Some 
times we had test failures from one test into the other. Making sure there are 
no leaks improves reliability of the testsuite.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #824: ARTEMIS-775 Tests for AMQP credit handli...

2016-10-07 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/824#discussion_r82449213
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java
 ---
@@ -0,0 +1,557 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.amqp;
+
+import java.util.ArrayList;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.activemq.artemis.core.server.Queue;
+import 
org.apache.activemq.artemis.tests.integration.mqtt.imported.util.Wait;
+import org.apache.activemq.transport.amqp.client.AmqpClient;
+import org.apache.activemq.transport.amqp.client.AmqpConnection;
+import org.apache.activemq.transport.amqp.client.AmqpMessage;
+import org.apache.activemq.transport.amqp.client.AmqpReceiver;
+import org.apache.activemq.transport.amqp.client.AmqpSender;
+import org.apache.activemq.transport.amqp.client.AmqpSession;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Test basic send and receive scenarios using only AMQP sender and 
receiver links.
+ */
+public class AmqpSendReceiveTest extends AmqpClientTestSupport {
+
+   protected static final Logger LOG = 
LoggerFactory.getLogger(AmqpSendReceiveTest.class);
+
+   @Test(timeout = 6)
+   public void testSimpleSendOneReceiveOne() throws Exception {
+
+  AmqpClient client = createAmqpClient();
+  AmqpConnection connection = addConnection(client.connect());
+  AmqpSession session = connection.createSession();
+
+  AmqpSender sender = session.createSender(getTestName());
+
+  AmqpMessage message = new AmqpMessage();
+
+  message.setMessageId("msg" + 1);
+  message.setMessageAnnotation("serialNo", 1);
+  message.setText("Test-Message");
+
+  sender.send(message);
+  sender.close();
+
+  LOG.info("Attempting to read message with receiver");
+  AmqpReceiver receiver = session.createReceiver(getTestName());
+  receiver.flow(2);
+  AmqpMessage received = receiver.receive(10, TimeUnit.SECONDS);
+  assertNotNull("Should have read message", received);
+  assertEquals("msg1", received.getMessageId());
+  received.accept();
+
+  receiver.close();
+
+  connection.close();
--- End diff --

The connection.close here will leak a thread if your test failed..

I changed some of these on your other commit, this connection.close() 
should be on a finally block. I think that should be the same on AMQ5 code as 
well.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #825: ARTEMIS-767 consumer with pre-ack flagge...

2016-10-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/825


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #825: ARTEMIS-767 consumer with pre-ack flagge...

2016-10-07 Thread jbertram
GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/825

ARTEMIS-767 consumer with pre-ack flagged as slow



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-767

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/825.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #825


commit afb15e41241555e2c770a5ffb6e0dc7ef413b876
Author: jbertram 
Date:   2016-10-07T16:43:19Z

ARTEMIS-767 consumer with pre-ack flagged as slow




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Clebert Suconic
I think this is pretty straightforward:

i - it should relay on JMX or jolokia.. A common thing between both
Artemis and ActiveMQ

ii - it should manage at least a single broker.. with some metrics...


iii - anything beyond that will just be a collaboration over the code.


The best way to discuss this IMO would be through a Pull Request..
someone send an initial draft.. we can have some **technical**
discussion over of PR, and commit it as version 1... then
collaboratively this could be increased just as with anything else.



I think we are clear from the previous discussions... and that's a
request I am making here, probably the third time... lets CTRL-Alt-Del
and start fresh... The issues we had are clear... and I see everybody
with a single goal here.. to have an integrated console that looks
like an Apache project, pretty and neat.


Once someone put a first version, we can only improve it from there.

On Fri, Oct 7, 2016 at 12:17 PM, Hadrian Zbarcea  wrote:
> I would suggest discussing the goals for such a console first. Is it
> intended to monitory just one broker instance or a whole network of brokers?
> Should it manage just the brokers or other services? Should it rely on JMX
> or something else?
>
> Then one can think about reusing and/or improving something that's available
> or some other solution.
>
> The way this discuss goes, sounds to me like trying to push again for
> something that was rejected in the past and I suspect will not go anywhere.
>
> My $0.02,
> Hadrian
>
>
> On 10/07/2016 06:41 AM, Martyn Taylor wrote:
>>
>> +1 on improving/adding a console.  Providing a console out of the box is a
>> massive win for user experience imo and something that I feel Artemis
>> would
>> greatly benefit from.  Whether it's HawtIO or something else we should
>> make
>> every effort to standardise across both 5.x and Artemis.
>>
>> On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic
>> 
>> wrote:
>>
>>> On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament 
>>> wrote:

 @Hiram

 The website branding says otherwise (take a look at the top right
>>>
>>> corner).
>>>
>>>
>>> That symbol on the top is just a link to the following:
>>>
>>> "Like hawtio? It’s part of a community of Red Hat projects. Learn more
>>> about Red Hat and our open source communities:"
>>>
>>>
>>>
>>>  No other implications from what I see.
>>>
>>
>



-- 
Clebert Suconic


Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Hadrian Zbarcea
I would suggest discussing the goals for such a console first. Is it 
intended to monitory just one broker instance or a whole network of 
brokers? Should it manage just the brokers or other services? Should it 
rely on JMX or something else?


Then one can think about reusing and/or improving something that's 
available or some other solution.


The way this discuss goes, sounds to me like trying to push again for 
something that was rejected in the past and I suspect will not go anywhere.


My $0.02,
Hadrian

On 10/07/2016 06:41 AM, Martyn Taylor wrote:

+1 on improving/adding a console.  Providing a console out of the box is a
massive win for user experience imo and something that I feel Artemis would
greatly benefit from.  Whether it's HawtIO or something else we should make
every effort to standardise across both 5.x and Artemis.

On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic 
wrote:


On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament 
wrote:

@Hiram

The website branding says otherwise (take a look at the top right

corner).


That symbol on the top is just a link to the following:

"Like hawtio? It’s part of a community of Red Hat projects. Learn more
about Red Hat and our open source communities:"



 No other implications from what I see.





[GitHub] activemq-artemis pull request #824: ARTEMIS-775 Tests for AMQP credit handli...

2016-10-07 Thread tabish121
GitHub user tabish121 opened a pull request:

https://github.com/apache/activemq-artemis/pull/824

ARTEMIS-775 Tests for AMQP credit handling

Some new tests that cover some AMQP credit handling scenarios.  Test
case 'testCloseBusyReceiver' currently fails due to being dispatched a
duplicate message.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-775

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/824.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #824


commit 3cb18ff9633b686b2f9cd81133491aa82538dbe0
Author: Timothy Bish 
Date:   2016-10-07T16:09:28Z

ARTEMIS-775 Tests for AMQP credit handling

Some new tests that cover some AMQP credit handling scenarios.  Test
case 'testCloseBusyReceiver' currently fails due to being dispatched a
duplicate message.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #821: ARTEMIS-773 Tests that show issue with T...

2016-10-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/821


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #823: ARTEMIS-774 Fixed format of JMeter bench...

2016-10-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/823


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #822: Eclipse fixes

2016-10-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/822


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #820: ARTEMIS-770 AMQP Message Transformer ref...

2016-10-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/820


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #814: ARTEMIS-762 Reflect management changes i...

2016-10-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/814


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #823: ARTEMIS-774 Fixed format of JMeter bench...

2016-10-07 Thread franz1981
GitHub user franz1981 opened a pull request:

https://github.com/apache/activemq-artemis/pull/823

ARTEMIS-774 Fixed format of JMeter benchmark

Moved the Apache Licence header after the XML Declaration.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/franz1981/activemq-artemis perf_jmeter_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/823.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #823


commit 255e308689626341a55450667eccdd8efc524373
Author: Francesco Nigro 
Date:   2016-10-07T14:24:19Z

ARTEMIS-774 Fixed format of JMeter benchmark

Moved the Apache Licence header after the XML Declaration.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis pull request #822: Eclipse fixes

2016-10-07 Thread cshannon
GitHub user cshannon opened a pull request:

https://github.com/apache/activemq-artemis/pull/822

Eclipse fixes

This PR includes one documentation fix and also excludes an old xml-apis 
test jar that is unnecessary so that it doesn't interfere with the classpath in 
eclipse and cause compilation errors

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cshannon/activemq-artemis eclipseFixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/822.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #822


commit 6db794be9ed260a4305650d6fe99e8b0bb94b2ea
Author: Christopher L. Shannon (cshannon) 
Date:   2016-10-07T14:07:56Z

NO-JIRA: Exclude xml-apis test dependency

This dependency is not needed as the api is part of the JDK and it is
causing issues when m2eclipse

commit a42ac1680fda153c66714a14c990e9d7522f1061
Author: Christopher L. Shannon (cshannon) 
Date:   2016-10-07T14:13:30Z

https://issues.apache.org/jira/browse/ARTEMIS-730

Adding instructions for adding the proper schemas to the Eclipse XML
Catalog




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


To all devs using Mac, who upgraded to Sierra...

2016-10-07 Thread Clebert Suconic
If you develop ActiveMQ using a Mac, either Artemis or ActiveMQ, you
may be affected by this if you upgraded Sierra:


After upgrading to Sierra, the following test takes a long time. I
have no idea why is that.

public class Deleteme {

   @Test
   public void test() throws Exception {
  System.out.println("hostname::" +
InetAddress.getLocalHost().getHostName());
   }
}



The IDGenerator on OpenWire will use that function, and because of
this testing anything on Sierra may be frustrating and slow.


to "fix" that, discover what is your hostname, and add that to
/etc/hosts on localhost:


e.g:

127.0.0.1   localhost ClebertMac.local




Just a tip that may be helpful for other devs using a Mac.


Re: [DISCUSS] Removing the Web Console

2016-10-07 Thread Martyn Taylor
+1 on improving/adding a console.  Providing a console out of the box is a
massive win for user experience imo and something that I feel Artemis would
greatly benefit from.  Whether it's HawtIO or something else we should make
every effort to standardise across both 5.x and Artemis.

On Tue, Oct 4, 2016 at 5:11 PM, Clebert Suconic 
wrote:

> On Tue, Oct 4, 2016 at 11:57 AM, John D. Ament 
> wrote:
> > @Hiram
> >
> > The website branding says otherwise (take a look at the top right
> corner).
>
>
> That symbol on the top is just a link to the following:
>
> "Like hawtio? It’s part of a community of Red Hat projects. Learn more
> about Red Hat and our open source communities:"
>
>
>
>  No other implications from what I see.
>


[GitHub] activemq-artemis issue #814: ARTEMIS-762 Reflect management changes in AMQP ...

2016-10-07 Thread mtaylor
Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/814
  
@clebertsuconic Yes this is ready to go.  Cheers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


java.io.EOFException when ActiveMQ starts

2016-10-07 Thread Deepak Shakya
I am trying to start the ActiveMQ 5.11 and I see a WARNING as below:

 WARN | Transport Connection to: tcp://127.0.0.1:40890 failed:
java.io.EOFException

Here is the entire console log for this.

Java Runtime: Oracle Corporation 1.7.0_05 /usr/java/jdk1.7.0_05/jre
  Heap sizes: current=1004928k  free=994439k  max=1004928k
JVM args: -Xmx1G -Dorg.apache.activemq.UseDedicatedTaskRunner=true
-Djava.util.logging.config.file=logging.properties
-Djava.security.auth.login.config=/home/dragon/activemq/conf/login.config
-Dcom.sun.management.jmxremote
-Djava.io.tmpdir=/home/dragon/activemq/tmp
-Dactivemq.classpath=/home/dragon/activemq/conf;
-Dactivemq.home=/home/dragon/activemq
-Dactivemq.base=/home/dragon/activemq
-Dactivemq.conf=/home/dragon/activemq/conf
-Dactivemq.data=/home/dragon/activemq/data
Extensions classpath:
  
[/home/dragon/activemq/lib,/home/dragon/activemq/lib/camel,/home/dragon/activemq/lib/optional,/home/dragon/activemq/lib/web,/home/dragon/activemq/lib/extra]
ACTIVEMQ_HOME: /home/dragon/activemq
ACTIVEMQ_BASE: /home/dragon/activemq
ACTIVEMQ_CONF: /home/dragon/activemq/conf
ACTIVEMQ_DATA: /home/dragon/activemq/data
Loading message broker from: xbean:activemq.xml
 INFO | Refreshing
org.apache.activemq.xbean.XBeanBrokerFactory$1@a842913: startup date
[Fri Oct 07 08:14:02 IST 2016]; root of context hierarchy
 INFO | PListStore:[/home/dragon/activemq/data/divinedragonbox/tmp_storage]
started
 INFO | Using Persistence Adapter:
KahaDBPersistenceAdapter[/home/dragon/jms_store]
 INFO | JMX consoles can connect to
service:jmx:rmi:///jndi/rmi://localhost:15526/jmxrmi
 INFO | KahaDB is version 5
 INFO | Recovering from the journal ...
 INFO | Recovery replayed 76 operations from the journal in 0.032 seconds.
 INFO | Apache ActiveMQ 5.11.1 (divinedragonbox,
ID:divinedragonbox-60914-1475824445361-0:1) is starting
 INFO | Listening for connections at: tcp://divinedragonbox:15511
 INFO | Connector openwire started
 INFO | Listening for connections at: stomp://divinedragonbox:15512
 INFO | Connector stomp started
 INFO | Listening for connections at: ssl://divinedragonbox:15571
 INFO | Connector ssl started
 INFO | Establishing network connection from
vm://divinedragonbox?async=false&network=true to ssl://localhost:15571
 INFO | Connector vm://divinedragonbox started
 INFO | Network Connector DiscoveryNetworkConnector:host1 and
host2:BrokerService[divinedragonbox] started
 INFO | Apache ActiveMQ 5.11.1 (divinedragonbox,
ID:divinedragonbox-60914-1475824445361-0:1) started
 INFO | For help or more information please see: http://activemq.apache.org
 INFO | divinedragonbox Shutting down
 INFO | Connector vm://divinedragonbox stopped
 INFO | divinedragonbox bridge to Unknown stopped
 WARN | Transport Connection to: tcp://127.0.0.1:40890 failed:
java.io.EOFException
 INFO | ActiveMQ WebConsole available at http://localhost:15521/
 INFO | Initializing Spring FrameworkServlet 'dispatcher'
 INFO | jolokia-agent: No access restrictor found at
classpath:/jolokia-access.xml, access to all MBeans is allowed

I enabled the TRACE for the messages and I got the following snippets of
exceptions in the log file.

2016-10-07 08:15:45,378 | TRACE | Execute[ActiveMQ ForwardingBridge
StopTask] runnable:
org.apache.activemq.network.DemandForwardingBridgeSupport$4@b3f451d |
org.apache.activemq.thread.TaskRunnerFactory | ActiveMQ
BrokerService[divinedragonbox] Task-4
2016-10-07 08:15:45,378 | TRACE | Created and running thread[ActiveMQ
ForwardingBridge StopTask-5]: Thread[ActiveMQ ForwardingBridge
StopTask-5,5,main] | org.apache.activemq.thread.TaskRunnerFactory |
ActiveMQ BrokerService[divinedragonbox] Task-4
2016-10-07 08:15:45,379 | DEBUG | Caught exception sending shutdown |
org.apache.activemq.network.DemandForwardingBridgeSupport | ActiveMQ
ForwardingBridge StopTask-5
org.apache.activemq.transport.TransportDisposedIOException: Transport disposed.
at 
org.apache.activemq.transport.vm.VMTransport.oneway(VMTransport.java:82)[activemq-broker-5.11.1.jar:5.11.1]
at 
org.apache.activemq.transport.MutexTransport.oneway(MutexTransport.java:68)[activemq-client-5.11.1.jar:5.11.1]
at 
org.apache.activemq.transport.ResponseCorrelator.oneway(ResponseCorrelator.java:60)[activemq-client-5.11.1.jar:5.11.1]
at 
org.apache.activemq.network.DemandForwardingBridgeSupport$4.run(DemandForwardingBridgeSupport.java:288)[activemq-broker-5.11.1.jar:5.11.1]
at java.lang.Thread.run(Thread.java:722)[:1.7.0_05]
2016-10-07 08:15:45,380 | DEBUG | Stopping transport
ssl://localhost/127.0.0.1:15571 |
org.apache.activemq.transport.tcp.TcpTransport | ActiveMQ
BrokerService[divinedragonbox] Task-4
2016-10-07 08:15:45,381 | DEBUG | Initialized
TaskRunnerFactory[ActiveMQ Task] using ExecutorService: null |
org.apache.activemq.thread.TaskRunnerFactory | ActiveMQ
BrokerService[divinedragonbox] Task-4
2016-10-07 08:15:45,381 | TRACE | Execute[ActiveMQ Task] runnable:
org.apache.activemq.transport.tcp.TcpTransport$1@a1848dc |
org.ap