[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1215
  
@clebertsuconic sure I'll take care of it. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1215
  
@gaohoward actually, the example managmeent is broken after this. Can you 
look please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1215
  
@mtaylor I will let you merge this.. but this PR is +1 from me.. 

nice job @gaohoward 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1209: ARTEMIS-1122 ActiveMQJAASSecurityManager class...

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1209
  
@jbertram Hi Justin can you review this pls?
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1216: ARTEMIS-1124 JDBC Network Timeout configuratio...

[mtaylor]

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1216
  
Merged now you can close this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1216: ARTEMIS-1124 JDBC Network Timeout confi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1216


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1218: Artemis 1125 - Implement JMS Bindings J...

[mtaylor]

GitHub user mtaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/1218

Artemis 1125 - Implement JMS Bindings JDBC Store



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1125

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1218


commit 87bde15f383f97371fd3932b34f540a250ae3d30
Author: Francesco Nigro 
Date:   2017-04-20T10:43:40Z

ARTEMIS-1124 JDBC Network Timeout configuration

(cherry picked from commit a639774b54d31fd06c906f8ae42b9733f96e569b)

commit 57b4a91061529d48843558a1f36122ffc6415e6c
Author: Martyn Taylor 
Date:   2017-04-20T18:43:53Z

This closes #1216

commit 3837a0102e9bbc59af0d0750aa10bf53df848011
Author: Martyn Taylor 
Date:   2017-04-20T17:31:24Z

ARTEMIS-1125 Persist JMS Bindings in Database on JDBC




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1217: ARTEMIS-1124 JDBC Network Timeout confi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1217


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1216: ARTEMIS-1124 JDBC Network Timeout configuratio...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1216
  
@graben Thanks! Fixed in the 2.x fix too! :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1217: ARTEMIS-1124 JDBC Network Timeout configuratio...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1217
  
@mtaylor I can change it now :) I've just arrived home :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1217: ARTEMIS-1124 JDBC Network Timeout configuratio...

[mtaylor]

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1217
  
yes please.  Thanks Franz


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1217: ARTEMIS-1124 JDBC Network Timeout configuratio...

[mtaylor]

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1217
  
@franz1981 two comments here.

1. The network time out should also be used on the page store.
2. The default timeout is 20seconds but the docs says 30s.

I'll merge this as it is as the doc is a minor fix and page can be added 
later.  Can you follow up with a patch for this.

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1215
  
There might be a problem with Jenkins machine, the failure relates to 
'memory allocation'. Not related to my PR.
@clebertsuconic I ran the whole test suite on my local machine, there are 
few test failures but none of them related to my PR. They failed both with and 
without my PR. (I'll investigate those failures further when I got time).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1216: ARTEMIS-1124 JDBC Network Timeout configuratio...

[graben]

Github user graben commented on the issue:

https://github.com/apache/activemq-artemis/pull/1216
  
Well, 20s in impl is different to 30s in doc. :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1217: ARTEMIS-1124 JDBC Network Timeout confi...

[franz1981]

GitHub user franz1981 opened a pull request:

https://github.com/apache/activemq-artemis/pull/1217

ARTEMIS-1124 JDBC Network Timeout configuration



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/franz1981/activemq-artemis 
hardcoded_network_timeout

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1217


commit 256773206b75e6040d15cf06722843a7a9107ca8
Author: Francesco Nigro 
Date:   2017-04-20T10:43:40Z

ARTEMIS-1124 JDBC Network Timeout configuration




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1216: ARTEMIS-1124 JDBC Network Timeout confi...

[franz1981]

GitHub user franz1981 opened a pull request:

https://github.com/apache/activemq-artemis/pull/1216

ARTEMIS-1124 JDBC Network Timeout configuration

(cherry picked from commit 256773206b75e6040d15cf06722843a7a9107ca8)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/franz1981/activemq-artemis 
1.x_jdbc_network_timeout

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1216


commit 514957b37b97baf155f947f91487f0abb76c4ec4
Author: Francesco Nigro 
Date:   2017-04-20T10:43:40Z

ARTEMIS-1124 JDBC Network Timeout configuration

(cherry picked from commit 256773206b75e6040d15cf06722843a7a9107ca8)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1215
  
Please.  While the whole testsuite ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1215
  
OK, I removed the garbage files and reverted AmqpSendReceiveTest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1215#discussion_r112476953
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java
 ---
@@ -53,38 +56,61 @@
 import org.apache.qpid.proton.engine.Sender;
 import org.jgroups.util.UUID;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 /**
  * Test basic send and receive scenarios using only AMQP sender and 
receiver links.
  */
+@RunWith(Parameterized.class)
--- End diff --

@tabish121 ok, I'll remove it to keep it simple. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

[tabish121]

Github user tabish121 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1215#discussion_r112475520
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java
 ---
@@ -53,38 +56,61 @@
 import org.apache.qpid.proton.engine.Sender;
 import org.jgroups.util.UUID;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 /**
  * Test basic send and receive scenarios using only AMQP sender and 
receiver links.
  */
+@RunWith(Parameterized.class)
--- End diff --

This seems like an unnecessary change to this test.  The intent here is to 
test basic AMQP protocol support not to test the FQQN support in the broker 
which it appears is already done in the ProtonFullQualifiedNameTest.  I'd 
prefer if we could keep tests targeted and not try and make them test the 
entirety of the broker features in one monolithic test case as that makes it 
harder to maintain.  If you changed this one why didn't you change every single 
AMQP test in the same fashion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1215
  
guys please hold on this commit, I found some garbage files need to remove.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1215
  
@clebertsuconic @mtaylor This is a resubmit of FQQN PR, with all tests 
fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

[gaohoward]

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/1215

ARTEMIS-1093 Full qualified queue name support

Broker should support full qualified queue names (FQQN)
as well as bare queue names. This means when clients access
to a queue they have two equivalent ways to do so. One way
is by queue names and the other is by FQQN (i.e. address::qname)
names. Currently only receiving is supported.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis master_more_fqqn

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1215






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---