[GitHub] activemq-artemis pull request #2348: ARTEMIS-2112 Remove JMX props from star...
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2348 ARTEMIS-2112 Remove JMX props from start scripts JMX configuration is now done via management.xml. Configuring JMX via the start scripts could result in unexpected behavior since the authorisation configuration from management.xml would be ignored. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2112 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2348.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2348 commit c049fffe4483fee1efb74d43fe7f4f34a3f5d0d2 Author: Justin Bertram Date: 2018-10-05T23:20:50Z ARTEMIS-2112 Remove JMX props from start scripts JMX configuration is now done via management.xml. Configuring JMX via the start scripts could result in unexpected behavior since the authorisation configuration from management.xml would be ignored. ---
[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 @franz1981, thanks for the suggestion, but I don't think this is *that* kind of leak. I came up with a way to test it and updated the PR. ---
[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak
Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 You can take a weak reference of the ManagementContext instance you want to test the leak, force a GC + run finalizer (we have a method in the test suite for that) and then verify that the instance is being GCed..TBH it doesn't worth the effort ^^ ---
[GitHub] activemq-artemis issue #2347: ARTEMIS-2111 ManagementContext can leak
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2347 I couldn't find a way to write a test for this so I tested manually using the `forceFailover()` management method on the `ActiveMQServerControl`. If anybody has any clever ideas I'd love to hear them. ---
[GitHub] activemq-artemis pull request #2347: ARTEMIS-2111 ManagementContext can leak
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2347 ARTEMIS-2111 ManagementContext can leak You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2111 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2347.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2347 commit cbc4acdbc94692b570ad5a592aecacf6ae24a52c Author: Justin Bertram Date: 2018-10-05T18:39:07Z ARTEMIS-2111 ManagementContext can leak ---
[GitHub] activemq pull request #302: [AMQ-7067] KahaDB Recovery can experience a dang...
GitHub user jgoodyear opened a pull request: https://github.com/apache/activemq/pull/302 [AMQ-7067] KahaDB Recovery can experience a dangling transaction when⦠[AMQ-7067] KahaDB Recovery can experience a dangling transaction when prepare and commit occur on different pagefiles. Test cases added for Commit and Rollback on XA and Non-XA transactions. Executed kahadb-store tests, activemq-unit-tests, and ran full build. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jgoodyear/activemq master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/302.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #302 commit 2dabd858240dc3dc4341cceb1d28a61e5f440d1a Author: jgoodyear Date: 2018-10-05T16:34:21Z [AMQ-7067] KahaDB Recovery can experience a dangling transaction when prepare and commit occur on different pagefiles. ---
[GitHub] activemq-artemis pull request #2346: ARTEMIS-2110 allow a lease renew withou...
Github user gtully closed the pull request at: https://github.com/apache/activemq-artemis/pull/2346 ---
[GitHub] activemq-artemis pull request #2346: ARTEMIS-2110 allow a lease renew withou...
GitHub user gtully reopened a pull request: https://github.com/apache/activemq-artemis/pull/2346 ARTEMIS-2110 allow a lease renew without update to the expiry timesta⦠â¦mp. Fix intermittent failure of org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock You can merge this pull request into a Git repository by running: $ git pull https://github.com/gtully/activemq-artemis ARTEMIS-2110 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2346 commit ddf0cac2d7531dc49484c283a7f4cbe44d8e278e Author: gtully Date: 2018-10-04T15:47:16Z ARTEMIS-2110 allow a lease renew without update to the expiry timestamp. Fix intermittent failure of org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock ---
[GitHub] activemq-artemis issue #2346: ARTEMIS-2110 allow a lease renew without updat...
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/2346 seems building the web site is the crux. it can be disabled with: mvn -Pfast-tests -Pextra-tests -B install -q -pl '!artemis-web' ---
[GitHub] activemq-artemis issue #2346: ARTEMIS-2110 allow a lease renew without updat...
Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/2346 The ci build failure seems may be related to the doc generation... there is no output for 10 mins and a termination after 42 mins: --- T E S T S --- Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m Running org.apache.activemq.cli.test.WebServerComponentTest SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. [main] 15:57:20,526 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at http://localhost:0 [main] 15:57:21,519 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at https://localhost:0 [main] 15:57:21,967 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at http://localhost:0 [main] 15:57:22,496 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at https://localhost:0 Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.288 sec - in org.apache.activemq.cli.test.WebServerComponentTest Results : Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received The build has been terminated -- on a local build that runs to completion I see: [ERROR] Error fetching link: but it does not block for any more than one minute. Something needs to be tweaked, any ideas? --- T E S T S --- Running org.apache.activemq.cli.test.WebServerComponentTest SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. [main] 14:35:40,755 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at http://localhost:0 [main] 14:35:41,098 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at https://localhost:0 [main] 14:35:41,264 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at http://localhost:0 [main] 14:35:41,524 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at https://localhost:0 Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.22 sec - in org.apache.activemq.cli.test.WebServerComponentTest Results : Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 [ERROR] Error fetching link: /Users/gtully/code/activemq-artemis-two/artemis-core-client/target/apidocs/package-list. Ignored it. [ERROR] Error fetching link: /Users/gtully/code/activemq-artemis-two/artemis-selector/target/apidocs/package-list. Ignored it. [ERROR] Error fetching link: /Users/gtully/code/activemq-artemis-two/artemis-jms-client/target/apidocs/package-list. Ignored it. [ERROR] Error fetching link: /Users/gtully/code/activemq-artemis-two/artemis-journal/target/apidocs/package-list. Ignored it. [ERROR] Error fetching link: /Users/gtully/code/activemq-artemis-two/artemis-server/target/apidocs/package-list. Ignored it. [ERROR] Error fetching link: /Users/gtully/code/activemq-artemis-two/artemis-jms-server/target/apidocs/package-list. Ignored it. Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. There may be some insight in that diff as to why the build fails. ---
